Merge branch 'topic/asoc' into for-linus
authorTakashi Iwai <tiwai@suse.de>
Thu, 20 May 2010 10:00:43 +0000 (12:00 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 20 May 2010 10:00:43 +0000 (12:00 +0200)
Conflicts:
sound/soc/codecs/ad1938.c

55 files changed:
1  2 
arch/arm/mach-davinci/board-dm365-evm.c
arch/arm/mach-omap2/mcbsp.c
arch/arm/plat-omap/include/plat/mcbsp.h
arch/arm/plat-omap/mcbsp.c
drivers/gpio/wm8994-gpio.c
drivers/mfd/wm8994-core.c
sound/soc/codecs/ad1836.c
sound/soc/codecs/ak4104.c
sound/soc/codecs/ak4535.c
sound/soc/codecs/ak4642.c
sound/soc/codecs/ak4671.c
sound/soc/codecs/cs4270.c
sound/soc/codecs/cx20442.c
sound/soc/codecs/da7210.c
sound/soc/codecs/ssm2602.c
sound/soc/codecs/stac9766.c
sound/soc/codecs/tlv320aic23.c
sound/soc/codecs/tlv320aic26.c
sound/soc/codecs/tlv320aic3x.c
sound/soc/codecs/tlv320dac33.c
sound/soc/codecs/tpa6130a2.c
sound/soc/codecs/twl4030.c
sound/soc/codecs/uda134x.c
sound/soc/codecs/wm8350.c
sound/soc/codecs/wm8400.c
sound/soc/codecs/wm8510.c
sound/soc/codecs/wm8523.c
sound/soc/codecs/wm8580.c
sound/soc/codecs/wm8711.c
sound/soc/codecs/wm8728.c
sound/soc/codecs/wm8731.c
sound/soc/codecs/wm8750.c
sound/soc/codecs/wm8753.c
sound/soc/codecs/wm8776.c
sound/soc/codecs/wm8900.c
sound/soc/codecs/wm8903.c
sound/soc/codecs/wm8904.c
sound/soc/codecs/wm8940.c
sound/soc/codecs/wm8955.c
sound/soc/codecs/wm8960.c
sound/soc/codecs/wm8961.c
sound/soc/codecs/wm8971.c
sound/soc/codecs/wm8974.c
sound/soc/codecs/wm8978.c
sound/soc/codecs/wm8988.c
sound/soc/codecs/wm8990.c
sound/soc/codecs/wm8993.c
sound/soc/codecs/wm8994.c
sound/soc/codecs/wm9081.c
sound/soc/codecs/wm9712.c
sound/soc/codecs/wm9713.c
sound/soc/omap/mcpdm.c
sound/soc/sh/fsi.c
sound/soc/soc-core.c
sound/soc/soc-dapm.c

@@@ -22,7 -22,6 +22,7 @@@
  #include <linux/leds.h>
  #include <linux/mtd/mtd.h>
  #include <linux/mtd/partitions.h>
 +#include <linux/slab.h>
  #include <linux/mtd/nand.h>
  #include <linux/input.h>
  #include <linux/spi/spi.h>
@@@ -605,7 -604,11 +605,11 @@@ static __init void dm365_evm_init(void
        /* maybe setup mmc1/etc ... _after_ mmc0 */
        evm_init_cpld();
  
+ #ifdef CONFIG_SND_DM365_AIC3X_CODEC
        dm365_init_asp(&dm365_evm_snd_data);
+ #elif defined(CONFIG_SND_DM365_VOICE_CODEC)
+       dm365_init_vc(&dm365_evm_snd_data);
+ #endif
        dm365_init_rtc();
        dm365_init_ks(&dm365evm_ks_data);
  
@@@ -16,7 -16,6 +16,7 @@@
  #include <linux/err.h>
  #include <linux/io.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  
  #include <mach/irqs.h>
  #include <plat/dma.h>
@@@ -187,32 -186,28 +187,28 @@@ static struct omap_mcbsp_platform_data 
                .phys_base      = OMAP44XX_MCBSP1_BASE,
                .dma_rx_sync    = OMAP44XX_DMA_MCBSP1_RX,
                .dma_tx_sync    = OMAP44XX_DMA_MCBSP1_TX,
-               .rx_irq         = INT_24XX_MCBSP1_IRQ_RX,
-               .tx_irq         = INT_24XX_MCBSP1_IRQ_TX,
+               .tx_irq         = OMAP44XX_IRQ_MCBSP1,
                .ops            = &omap2_mcbsp_ops,
        },
        {
                .phys_base      = OMAP44XX_MCBSP2_BASE,
                .dma_rx_sync    = OMAP44XX_DMA_MCBSP2_RX,
                .dma_tx_sync    = OMAP44XX_DMA_MCBSP2_TX,
-               .rx_irq         = INT_24XX_MCBSP2_IRQ_RX,
-               .tx_irq         = INT_24XX_MCBSP2_IRQ_TX,
+               .tx_irq         = OMAP44XX_IRQ_MCBSP2,
                .ops            = &omap2_mcbsp_ops,
        },
        {
                .phys_base      = OMAP44XX_MCBSP3_BASE,
                .dma_rx_sync    = OMAP44XX_DMA_MCBSP3_RX,
                .dma_tx_sync    = OMAP44XX_DMA_MCBSP3_TX,
-               .rx_irq         = INT_24XX_MCBSP3_IRQ_RX,
-               .tx_irq         = INT_24XX_MCBSP3_IRQ_TX,
+               .tx_irq         = OMAP44XX_IRQ_MCBSP3,
                .ops            = &omap2_mcbsp_ops,
        },
        {
                .phys_base      = OMAP44XX_MCBSP4_BASE,
                .dma_rx_sync    = OMAP44XX_DMA_MCBSP4_RX,
                .dma_tx_sync    = OMAP44XX_DMA_MCBSP4_TX,
-               .rx_irq         = INT_24XX_MCBSP4_IRQ_RX,
-               .tx_irq         = INT_24XX_MCBSP4_IRQ_TX,
+               .tx_irq         = OMAP44XX_IRQ_MCBSP4,
                .ops            = &omap2_mcbsp_ops,
        },
  };
@@@ -59,7 -59,7 +59,7 @@@
  #define OMAP44XX_MCBSP1_BASE  0x49022000
  #define OMAP44XX_MCBSP2_BASE  0x49024000
  #define OMAP44XX_MCBSP3_BASE  0x49026000
 -#define OMAP44XX_MCBSP4_BASE  0x48074000
 +#define OMAP44XX_MCBSP4_BASE  0x48096000
  
  #if defined(CONFIG_ARCH_OMAP15XX) || defined(CONFIG_ARCH_OMAP16XX) || defined(CONFIG_ARCH_OMAP730) || defined(CONFIG_ARCH_OMAP850)
  
  #define OMAP_MCBSP_REG_WAKEUPEN       0xA8
  #define OMAP_MCBSP_REG_XCCR   0xAC
  #define OMAP_MCBSP_REG_RCCR   0xB0
+ #define OMAP_MCBSP_REG_XBUFFSTAT      0xB4
+ #define OMAP_MCBSP_REG_RBUFFSTAT      0xB8
  #define OMAP_MCBSP_REG_SSELCR 0xBC
  
  #define OMAP_ST_REG_REV               0x00
@@@ -471,6 -473,8 +473,8 @@@ void omap_mcbsp_set_tx_threshold(unsign
  void omap_mcbsp_set_rx_threshold(unsigned int id, u16 threshold);
  u16 omap_mcbsp_get_max_tx_threshold(unsigned int id);
  u16 omap_mcbsp_get_max_rx_threshold(unsigned int id);
+ u16 omap_mcbsp_get_tx_delay(unsigned int id);
+ u16 omap_mcbsp_get_rx_delay(unsigned int id);
  int omap_mcbsp_get_dma_op_mode(unsigned int id);
  #else
  static inline void omap_mcbsp_set_tx_threshold(unsigned int id, u16 threshold)
@@@ -479,6 -483,8 +483,8 @@@ static inline void omap_mcbsp_set_rx_th
  { }
  static inline u16 omap_mcbsp_get_max_tx_threshold(unsigned int id) { return 0; }
  static inline u16 omap_mcbsp_get_max_rx_threshold(unsigned int id) { return 0; }
+ static inline u16 omap_mcbsp_get_tx_delay(unsigned int id) { return 0; }
+ static inline u16 omap_mcbsp_get_rx_delay(unsigned int id) { return 0; }
  static inline int omap_mcbsp_get_dma_op_mode(unsigned int id) { return 0; }
  #endif
  int omap_mcbsp_request(unsigned int id);
@@@ -23,7 -23,6 +23,7 @@@
  #include <linux/clk.h>
  #include <linux/delay.h>
  #include <linux/io.h>
 +#include <linux/slab.h>
  
  #include <plat/dma.h>
  #include <plat/mcbsp.h>
@@@ -489,7 -488,7 +489,7 @@@ void omap_mcbsp_set_tx_threshold(unsign
  {
        struct omap_mcbsp *mcbsp;
  
-       if (!cpu_is_omap34xx())
+       if (!cpu_is_omap34xx() && !cpu_is_omap44xx())
                return;
  
        if (!omap_mcbsp_check_valid_id(id)) {
@@@ -511,7 -510,7 +511,7 @@@ void omap_mcbsp_set_rx_threshold(unsign
  {
        struct omap_mcbsp *mcbsp;
  
-       if (!cpu_is_omap34xx())
+       if (!cpu_is_omap34xx() && !cpu_is_omap44xx())
                return;
  
        if (!omap_mcbsp_check_valid_id(id)) {
@@@ -560,6 -559,61 +560,61 @@@ u16 omap_mcbsp_get_max_rx_threshold(uns
  }
  EXPORT_SYMBOL(omap_mcbsp_get_max_rx_threshold);
  
+ #define MCBSP2_FIFO_SIZE      0x500 /* 1024 + 256 locations */
+ #define MCBSP1345_FIFO_SIZE   0x80  /* 128 locations */
+ /*
+  * omap_mcbsp_get_tx_delay returns the number of used slots in the McBSP FIFO
+  */
+ u16 omap_mcbsp_get_tx_delay(unsigned int id)
+ {
+       struct omap_mcbsp *mcbsp;
+       u16 buffstat;
+       if (!omap_mcbsp_check_valid_id(id)) {
+               printk(KERN_ERR "%s: Invalid id (%d)\n", __func__, id + 1);
+               return -ENODEV;
+       }
+       mcbsp = id_to_mcbsp_ptr(id);
+       /* Returns the number of free locations in the buffer */
+       buffstat = MCBSP_READ(mcbsp, XBUFFSTAT);
+       /* Number of slots are different in McBSP ports */
+       if (mcbsp->id == 2)
+               return MCBSP2_FIFO_SIZE - buffstat;
+       else
+               return MCBSP1345_FIFO_SIZE - buffstat;
+ }
+ EXPORT_SYMBOL(omap_mcbsp_get_tx_delay);
+ /*
+  * omap_mcbsp_get_rx_delay returns the number of free slots in the McBSP FIFO
+  * to reach the threshold value (when the DMA will be triggered to read it)
+  */
+ u16 omap_mcbsp_get_rx_delay(unsigned int id)
+ {
+       struct omap_mcbsp *mcbsp;
+       u16 buffstat, threshold;
+       if (!omap_mcbsp_check_valid_id(id)) {
+               printk(KERN_ERR "%s: Invalid id (%d)\n", __func__, id + 1);
+               return -ENODEV;
+       }
+       mcbsp = id_to_mcbsp_ptr(id);
+       /* Returns the number of used locations in the buffer */
+       buffstat = MCBSP_READ(mcbsp, RBUFFSTAT);
+       /* RX threshold */
+       threshold = MCBSP_READ(mcbsp, THRSH1);
+       /* Return the number of location till we reach the threshold limit */
+       if (threshold <= buffstat)
+               return 0;
+       else
+               return threshold - buffstat;
+ }
+ EXPORT_SYMBOL(omap_mcbsp_get_rx_delay);
  /*
   * omap_mcbsp_get_dma_op_mode just return the current configured
   * operating mode for the mcbsp channel
@@@ -587,7 -641,7 +642,7 @@@ static inline void omap34xx_mcbsp_reque
         * Enable wakup behavior, smart idle and all wakeups
         * REVISIT: some wakeups may be unnecessary
         */
-       if (cpu_is_omap34xx()) {
+       if (cpu_is_omap34xx() || cpu_is_omap44xx()) {
                u16 syscon;
  
                syscon = MCBSP_READ(mcbsp, SYSCON);
@@@ -610,7 -664,7 +665,7 @@@ static inline void omap34xx_mcbsp_free(
        /*
         * Disable wakup behavior, smart idle and all wakeups
         */
-       if (cpu_is_omap34xx()) {
+       if (cpu_is_omap34xx() || cpu_is_omap44xx()) {
                u16 syscon;
  
                syscon = MCBSP_READ(mcbsp, SYSCON);
@@@ -724,14 -778,17 +779,17 @@@ int omap_mcbsp_request(unsigned int id
                        goto err_clk_disable;
                }
  
-               init_completion(&mcbsp->rx_irq_completion);
-               err = request_irq(mcbsp->rx_irq, omap_mcbsp_rx_irq_handler,
+               if (mcbsp->rx_irq) {
+                       init_completion(&mcbsp->rx_irq_completion);
+                       err = request_irq(mcbsp->rx_irq,
+                                       omap_mcbsp_rx_irq_handler,
                                        0, "McBSP", (void *)mcbsp);
-               if (err != 0) {
-                       dev_err(mcbsp->dev, "Unable to request RX IRQ %d "
-                                       "for McBSP%d\n", mcbsp->rx_irq,
-                                       mcbsp->id);
-                       goto err_free_irq;
+                       if (err != 0) {
+                               dev_err(mcbsp->dev, "Unable to request RX IRQ %d "
+                                               "for McBSP%d\n", mcbsp->rx_irq,
+                                               mcbsp->id);
+                               goto err_free_irq;
+                       }
                }
        }
  
@@@ -781,7 -838,8 +839,8 @@@ void omap_mcbsp_free(unsigned int id
  
        if (mcbsp->io_type == OMAP_MCBSP_IRQ_IO) {
                /* Free IRQs */
-               free_irq(mcbsp->rx_irq, (void *)mcbsp);
+               if (mcbsp->rx_irq)
+                       free_irq(mcbsp->rx_irq, (void *)mcbsp);
                free_irq(mcbsp->tx_irq, (void *)mcbsp);
        }
  
@@@ -855,7 -913,7 +914,7 @@@ void omap_mcbsp_start(unsigned int id, 
                MCBSP_WRITE(mcbsp, SPCR2, w | (1 << 7));
        }
  
-       if (cpu_is_omap2430() || cpu_is_omap34xx()) {
+       if (cpu_is_omap2430() || cpu_is_omap34xx() || cpu_is_omap44xx()) {
                /* Release the transmitter and receiver */
                w = MCBSP_READ_CACHE(mcbsp, XCCR);
                w &= ~(tx ? XDISABLE : 0);
@@@ -885,7 -943,7 +944,7 @@@ void omap_mcbsp_stop(unsigned int id, i
  
        /* Reset transmitter */
        tx &= 1;
-       if (cpu_is_omap2430() || cpu_is_omap34xx()) {
+       if (cpu_is_omap2430() || cpu_is_omap34xx() || cpu_is_omap44xx()) {
                w = MCBSP_READ_CACHE(mcbsp, XCCR);
                w |= (tx ? XDISABLE : 0);
                MCBSP_WRITE(mcbsp, XCCR, w);
  
        /* Reset receiver */
        rx &= 1;
-       if (cpu_is_omap2430() || cpu_is_omap34xx()) {
+       if (cpu_is_omap2430() || cpu_is_omap34xx() || cpu_is_omap44xx()) {
                w = MCBSP_READ_CACHE(mcbsp, RCCR);
                w |= (rx ? RDISABLE : 0);
                MCBSP_WRITE(mcbsp, RCCR, w);
@@@ -13,7 -13,6 +13,7 @@@
   */
  
  #include <linux/kernel.h>
 +#include <linux/slab.h>
  #include <linux/module.h>
  #include <linux/gpio.h>
  #include <linux/mfd/core.h>
@@@ -81,6 -80,18 +81,18 @@@ static void wm8994_gpio_set(struct gpio
        wm8994_set_bits(wm8994, WM8994_GPIO_1 + offset, WM8994_GPN_LVL, value);
  }
  
+ static int wm8994_gpio_to_irq(struct gpio_chip *chip, unsigned offset)
+ {
+       struct wm8994_gpio *wm8994_gpio = to_wm8994_gpio(chip);
+       struct wm8994 *wm8994 = wm8994_gpio->wm8994;
+       if (!wm8994->irq_base)
+               return -EINVAL;
+       return wm8994->irq_base + offset;
+ }
  #ifdef CONFIG_DEBUG_FS
  static void wm8994_gpio_dbg_show(struct seq_file *s, struct gpio_chip *chip)
  {
@@@ -14,7 -14,6 +14,7 @@@
  
  #include <linux/kernel.h>
  #include <linux/module.h>
 +#include <linux/slab.h>
  #include <linux/i2c.h>
  #include <linux/delay.h>
  #include <linux/mfd/core.h>
@@@ -173,9 -172,34 +173,34 @@@ static struct mfd_cell wm8994_regulator
        { .name = "wm8994-ldo", .id = 2 },
  };
  
+ static struct resource wm8994_codec_resources[] = {
+       {
+               .start = WM8994_IRQ_TEMP_SHUT,
+               .end   = WM8994_IRQ_TEMP_WARN,
+               .flags = IORESOURCE_IRQ,
+       },
+ };
+ static struct resource wm8994_gpio_resources[] = {
+       {
+               .start = WM8994_IRQ_GPIO(1),
+               .end   = WM8994_IRQ_GPIO(11),
+               .flags = IORESOURCE_IRQ,
+       },
+ };
  static struct mfd_cell wm8994_devs[] = {
-       { .name = "wm8994-codec" },
-       { .name = "wm8994-gpio" },
+       {
+               .name = "wm8994-codec",
+               .num_resources = ARRAY_SIZE(wm8994_codec_resources),
+               .resources = wm8994_codec_resources,
+       },
+       {
+               .name = "wm8994-gpio",
+               .num_resources = ARRAY_SIZE(wm8994_gpio_resources),
+               .resources = wm8994_gpio_resources,
+       },
  };
  
  /*
@@@ -236,6 -260,11 +261,11 @@@ static int wm8994_device_resume(struct 
                return ret;
        }
  
+       ret = wm8994_write(wm8994, WM8994_INTERRUPT_STATUS_1_MASK,
+                          WM8994_NUM_IRQ_REGS * 2, &wm8994->irq_masks_cur);
+       if (ret < 0)
+               dev_err(dev, "Failed to restore interrupt masks: %d\n", ret);
        ret = wm8994_write(wm8994, WM8994_LDO_1, WM8994_NUM_LDO_REGS * 2,
                           &wm8994->ldo_regs);
        if (ret < 0)
@@@ -348,6 -377,7 +378,7 @@@ static int wm8994_device_init(struct wm
  
  
        if (pdata) {
+               wm8994->irq_base = pdata->irq_base;
                wm8994->gpio_base = pdata->gpio_base;
  
                /* GPIO configuration is only applied if it's non-zero */
                                        WM8994_LDO1_DISCH, 0);
        }
  
+       wm8994_irq_init(wm8994);
        ret = mfd_add_devices(wm8994->dev, -1,
                              wm8994_devs, ARRAY_SIZE(wm8994_devs),
                              NULL, 0);
        if (ret != 0) {
                dev_err(wm8994->dev, "Failed to add children: %d\n", ret);
-               goto err_enable;
+               goto err_irq;
        }
  
        return 0;
  
+ err_irq:
+       wm8994_irq_exit(wm8994);
  err_enable:
        regulator_bulk_disable(ARRAY_SIZE(wm8994_main_supplies),
                               wm8994->supplies);
@@@ -401,6 -435,7 +436,7 @@@ err
  static void wm8994_device_exit(struct wm8994 *wm8994)
  {
        mfd_remove_devices(wm8994->dev);
+       wm8994_irq_exit(wm8994);
        regulator_bulk_disable(ARRAY_SIZE(wm8994_main_supplies),
                               wm8994->supplies);
        regulator_bulk_free(ARRAY_SIZE(wm8994_main_supplies), wm8994->supplies);
@@@ -469,6 -504,7 +505,7 @@@ static int wm8994_i2c_probe(struct i2c_
        wm8994->control_data = i2c;
        wm8994->read_dev = wm8994_i2c_read_device;
        wm8994->write_dev = wm8994_i2c_write_device;
+       wm8994->irq = i2c->irq;
  
        return wm8994_device_init(wm8994, id->driver_data, i2c->irq);
  }
@@@ -17,7 -17,6 +17,7 @@@
   */
  
  #include <linux/init.h>
 +#include <linux/slab.h>
  #include <linux/module.h>
  #include <linux/kernel.h>
  #include <linux/device.h>
@@@ -278,7 -277,7 +278,7 @@@ static int ad1836_register(struct ad183
        mutex_init(&codec->mutex);
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
-       codec->private_data = ad1836;
+       snd_soc_codec_set_drvdata(codec, ad1836);
        codec->reg_cache = ad1836->reg_cache;
        codec->reg_cache_size = AD1836_NUM_REGS;
        codec->name = "AD1836";
@@@ -10,7 -10,6 +10,7 @@@
   */
  
  #include <linux/module.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/soc.h>
  #include <sound/initval.h>
@@@ -222,7 -221,7 +222,7 @@@ static int ak4104_spi_probe(struct spi_
        codec->owner = THIS_MODULE;
        codec->dai = &ak4104_dai;
        codec->num_dai = 1;
-       codec->private_data = ak4104;
+       snd_soc_codec_set_drvdata(codec, ak4104);
        codec->control_data = spi;
        codec->reg_cache = ak4104->reg_cache;
        codec->reg_cache_size = AK4104_NUM_REGS;
@@@ -19,7 -19,6 +19,7 @@@
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -302,7 -301,7 +302,7 @@@ static int ak4535_set_dai_sysclk(struc
        int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct ak4535_priv *ak4535 = codec->private_data;
+       struct ak4535_priv *ak4535 = snd_soc_codec_get_drvdata(codec);
  
        ak4535->sysclk = freq;
        return 0;
@@@ -315,7 -314,7 +315,7 @@@ static int ak4535_hw_params(struct snd_
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct ak4535_priv *ak4535 = codec->private_data;
+       struct ak4535_priv *ak4535 = snd_soc_codec_get_drvdata(codec);
        u8 mode2 = ak4535_read_reg_cache(codec, AK4535_MODE2) & ~(0x3 << 5);
        int rate = params_rate(params), fs = 256;
  
@@@ -446,7 -445,6 +446,6 @@@ static int ak4535_resume(struct platfor
        struct snd_soc_codec *codec = socdev->card->codec;
        ak4535_sync(codec);
        ak4535_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       ak4535_set_bias_level(codec, codec->suspend_bias_level);
        return 0;
  }
  
@@@ -600,7 -598,7 +599,7 @@@ static int ak4535_probe(struct platform
                return -ENOMEM;
        }
  
-       codec->private_data = ak4535;
+       snd_soc_codec_set_drvdata(codec, ak4535);
        socdev->card->codec = codec;
        mutex_init(&codec->mutex);
        INIT_LIST_HEAD(&codec->dapm_widgets);
  #endif
  
        if (ret != 0) {
-               kfree(codec->private_data);
+               kfree(snd_soc_codec_get_drvdata(codec));
                kfree(codec);
        }
        return ret;
@@@ -639,7 -637,7 +638,7 @@@ static int ak4535_remove(struct platfor
                i2c_unregister_device(codec->control_data);
        i2c_del_driver(&ak4535_i2c_driver);
  #endif
-       kfree(codec->private_data);
+       kfree(snd_soc_codec_get_drvdata(codec));
        kfree(codec);
  
        return 0;
@@@ -29,7 -29,6 +29,7 @@@
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
  
  #define AK4642_CACHEREGNUM    0x25
  
+ /* PW_MGMT2 */
+ #define HPMTN         (1 << 6)
+ #define PMHPL         (1 << 5)
+ #define PMHPR         (1 << 4)
+ #define MS            (1 << 3) /* master/slave select */
+ #define MCKO          (1 << 1)
+ #define PMPLL         (1 << 0)
+ #define PMHP_MASK     (PMHPL | PMHPR)
+ #define PMHP          PMHP_MASK
+ /* MD_CTL1 */
+ #define PLL3          (1 << 7)
+ #define PLL2          (1 << 6)
+ #define PLL1          (1 << 5)
+ #define PLL0          (1 << 4)
+ #define PLL_MASK      (PLL3 | PLL2 | PLL1 | PLL0)
+ #define BCKO_MASK     (1 << 3)
+ #define BCKO_64               BCKO_MASK
+ /* MD_CTL2 */
+ #define FS0           (1 << 0)
+ #define FS1           (1 << 1)
+ #define FS2           (1 << 2)
+ #define FS3           (1 << 5)
+ #define FS_MASK               (FS0 | FS1 | FS2 | FS3)
  struct snd_soc_codec_device soc_codec_dev_ak4642;
  
  /* codec private data */
  struct ak4642_priv {
        struct snd_soc_codec codec;
-       unsigned int sysclk;
  };
  
  static struct snd_soc_codec *ak4642_codec;
@@@ -177,17 -203,12 +204,12 @@@ static int ak4642_dai_startup(struct sn
                 *
                 * PLL, Master Mode
                 * Audio I/F Format :MSB justified (ADC & DAC)
-                * Sampling Frequency: 44.1kHz
-                * Digital Volume: âˆ’8dB
+                * Digital Volume: -8dB
                 * Bass Boost Level : Middle
                 *
                 * This operation came from example code of
                 * "ASAHI KASEI AK4642" (japanese) manual p97.
-                *
-                * Example code use 0x39, 0x79 value for 0x01 address,
-                * But we need MCKO (0x02) bit now
                 */
-               ak4642_write(codec, 0x05, 0x27);
                ak4642_write(codec, 0x0f, 0x09);
                ak4642_write(codec, 0x0e, 0x19);
                ak4642_write(codec, 0x09, 0x91);
                ak4642_write(codec, 0x0a, 0x28);
                ak4642_write(codec, 0x0d, 0x28);
                ak4642_write(codec, 0x00, 0x64);
-               ak4642_write(codec, 0x01, 0x3b); /* + MCKO bit */
-               ak4642_write(codec, 0x01, 0x7b); /* + MCKO bit */
+               snd_soc_update_bits(codec, PW_MGMT2, PMHP_MASK, PMHP);
+               snd_soc_update_bits(codec, PW_MGMT2, HPMTN,     HPMTN);
        } else {
                /*
                 * start stereo input
                 *
                 * PLL Master Mode
                 * Audio I/F Format:MSB justified (ADC & DAC)
-                * Sampling Frequency:44.1kHz
                 * Pre MIC AMP:+20dB
                 * MIC Power On
                 * ALC setting:Refer to Table 35
                 * This operation came from example code of
                 * "ASAHI KASEI AK4642" (japanese) manual p94.
                 */
-               ak4642_write(codec, 0x05, 0x27);
                ak4642_write(codec, 0x02, 0x05);
                ak4642_write(codec, 0x06, 0x3c);
                ak4642_write(codec, 0x08, 0xe1);
@@@ -233,8 -252,8 +253,8 @@@ static void ak4642_dai_shutdown(struct 
  
        if (is_play) {
                /* stop headphone output */
-               ak4642_write(codec, 0x01, 0x3b);
-               ak4642_write(codec, 0x01, 0x0b);
+               snd_soc_update_bits(codec, PW_MGMT2, HPMTN,     0);
+               snd_soc_update_bits(codec, PW_MGMT2, PMHP_MASK, 0);
                ak4642_write(codec, 0x00, 0x40);
                ak4642_write(codec, 0x0e, 0x11);
                ak4642_write(codec, 0x0f, 0x08);
@@@ -250,9 -269,111 +270,111 @@@ static int ak4642_dai_set_sysclk(struc
        int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct ak4642_priv *ak4642 = codec->private_data;
+       u8 pll;
+       switch (freq) {
+       case 11289600:
+               pll = PLL2;
+               break;
+       case 12288000:
+               pll = PLL2 | PLL0;
+               break;
+       case 12000000:
+               pll = PLL2 | PLL1;
+               break;
+       case 24000000:
+               pll = PLL2 | PLL1 | PLL0;
+               break;
+       case 13500000:
+               pll = PLL3 | PLL2;
+               break;
+       case 27000000:
+               pll = PLL3 | PLL2 | PLL0;
+               break;
+       default:
+               return -EINVAL;
+       }
+       snd_soc_update_bits(codec, MD_CTL1, PLL_MASK, pll);
+       return 0;
+ }
+ static int ak4642_dai_set_fmt(struct snd_soc_dai *dai, unsigned int fmt)
+ {
+       struct snd_soc_codec *codec = dai->codec;
+       u8 data;
+       u8 bcko;
+       data = MCKO | PMPLL; /* use MCKO */
+       bcko = 0;
+       /* set master/slave audio interface */
+       switch (fmt & SND_SOC_DAIFMT_MASTER_MASK) {
+       case SND_SOC_DAIFMT_CBM_CFM:
+               data |= MS;
+               bcko = BCKO_64;
+               break;
+       case SND_SOC_DAIFMT_CBS_CFS:
+               break;
+       default:
+               return -EINVAL;
+       }
+       snd_soc_update_bits(codec, PW_MGMT2, MS, data);
+       snd_soc_update_bits(codec, MD_CTL1, BCKO_MASK, bcko);
+       return 0;
+ }
+ static int ak4642_dai_hw_params(struct snd_pcm_substream *substream,
+                               struct snd_pcm_hw_params *params,
+                               struct snd_soc_dai *dai)
+ {
+       struct snd_soc_codec *codec = dai->codec;
+       u8 rate;
+       switch (params_rate(params)) {
+       case 7350:
+               rate = FS2;
+               break;
+       case 8000:
+               rate = 0;
+               break;
+       case 11025:
+               rate = FS2 | FS0;
+               break;
+       case 12000:
+               rate = FS0;
+               break;
+       case 14700:
+               rate = FS2 | FS1;
+               break;
+       case 16000:
+               rate = FS1;
+               break;
+       case 22050:
+               rate = FS2 | FS1 | FS0;
+               break;
+       case 24000:
+               rate = FS1 | FS0;
+               break;
+       case 29400:
+               rate = FS3 | FS2 | FS1;
+               break;
+       case 32000:
+               rate = FS3 | FS1;
+               break;
+       case 44100:
+               rate = FS3 | FS2 | FS1 | FS0;
+               break;
+       case 48000:
+               rate = FS3 | FS1 | FS0;
+               break;
+       default:
+               return -EINVAL;
+               break;
+       }
+       snd_soc_update_bits(codec, MD_CTL2, FS_MASK, rate);
  
-       ak4642->sysclk = freq;
        return 0;
  }
  
@@@ -260,6 -381,8 +382,8 @@@ static struct snd_soc_dai_ops ak4642_da
        .startup        = ak4642_dai_startup,
        .shutdown       = ak4642_dai_shutdown,
        .set_sysclk     = ak4642_dai_set_sysclk,
+       .set_fmt        = ak4642_dai_set_fmt,
+       .hw_params      = ak4642_dai_hw_params,
  };
  
  struct snd_soc_dai ak4642_dai = {
                .rates = SNDRV_PCM_RATE_8000_48000,
                .formats = SNDRV_PCM_FMTBIT_S16_LE },
        .ops = &ak4642_dai_ops,
+       .symmetric_rates = 1,
  };
  EXPORT_SYMBOL_GPL(ak4642_dai);
  
@@@ -307,7 -431,7 +432,7 @@@ static int ak4642_init(struct ak4642_pr
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data     = ak4642;
+       snd_soc_codec_set_drvdata(codec, ak4642);
        codec->name             = "AK4642";
        codec->owner            = THIS_MODULE;
        codec->read             = ak4642_read_reg_cache;
                goto reg_cache_err;
        }
  
-       /*
-        * clock setting
-        *
-        * Audio I/F Format: MSB justified (ADC & DAC)
-        * BICK frequency at Master Mode: 64fs
-        * Input Master Clock Select at PLL Mode: 11.2896MHz
-        * MCKO: Enable
-        * Sampling Frequency: 44.1kHz
-        *
-        * This operation came from example code of
-        * "ASAHI KASEI AK4642" (japanese) manual p89.
-        *
-        * please fix-me
-        */
-       ak4642_write(codec, 0x01, 0x08);
-       ak4642_write(codec, 0x04, 0x4a);
-       ak4642_write(codec, 0x05, 0x27);
-       ak4642_write(codec, 0x00, 0x40);
-       ak4642_write(codec, 0x01, 0x0b);
        return ret;
  
  reg_cache_err:
@@@ -15,7 -15,6 +15,7 @@@
  #include <linux/init.h>
  #include <linux/i2c.h>
  #include <linux/delay.h>
 +#include <linux/slab.h>
  #include <sound/soc.h>
  #include <sound/soc-dapm.h>
  #include <sound/initval.h>
@@@ -702,7 -701,7 +702,7 @@@ static int ak4671_register(struct ak467
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = ak4671;
+       snd_soc_codec_set_drvdata(codec,  ak4671);
        codec->name = "AK4671";
        codec->owner = THIS_MODULE;
        codec->bias_level = SND_SOC_BIAS_OFF;
@@@ -23,7 -23,6 +23,7 @@@
  
  #include <linux/module.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/soc.h>
  #include <sound/initval.h>
@@@ -211,7 -210,7 +211,7 @@@ static int cs4270_set_dai_sysclk(struc
                                 int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct cs4270_private *cs4270 = codec->private_data;
+       struct cs4270_private *cs4270 = snd_soc_codec_get_drvdata(codec);
        unsigned int rates = 0;
        unsigned int rate_min = -1;
        unsigned int rate_max = 0;
@@@ -270,7 -269,7 +270,7 @@@ static int cs4270_set_dai_fmt(struct sn
                              unsigned int format)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct cs4270_private *cs4270 = codec->private_data;
+       struct cs4270_private *cs4270 = snd_soc_codec_get_drvdata(codec);
        int ret = 0;
  
        /* set DAI format */
@@@ -412,7 -411,7 +412,7 @@@ static int cs4270_hw_params(struct snd_
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct cs4270_private *cs4270 = codec->private_data;
+       struct cs4270_private *cs4270 = snd_soc_codec_get_drvdata(codec);
        int ret;
        unsigned int i;
        unsigned int rate;
  static int cs4270_dai_mute(struct snd_soc_dai *dai, int mute)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct cs4270_private *cs4270 = codec->private_data;
+       struct cs4270_private *cs4270 = snd_soc_codec_get_drvdata(codec);
        int reg6;
  
        reg6 = snd_soc_read(codec, CS4270_MUTE);
@@@ -524,7 -523,7 +524,7 @@@ static int cs4270_soc_put_mute(struct s
                                struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct cs4270_private *cs4270 = codec->private_data;
+       struct cs4270_private *cs4270 = snd_soc_codec_get_drvdata(codec);
        int left = !ucontrol->value.integer.value[0];
        int right = !ucontrol->value.integer.value[1];
  
@@@ -600,7 -599,7 +600,7 @@@ static int cs4270_probe(struct platform
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = cs4270_codec;
-       struct cs4270_private *cs4270 = codec->private_data;
+       struct cs4270_private *cs4270 = snd_soc_codec_get_drvdata(codec);
        int i, ret;
  
        /* Connect the codec to the socdev.  snd_soc_new_pcms() needs this. */
@@@ -657,7 -656,7 +657,7 @@@ static int cs4270_remove(struct platfor
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = cs4270_codec;
-       struct cs4270_private *cs4270 = codec->private_data;
+       struct cs4270_private *cs4270 = snd_soc_codec_get_drvdata(codec);
  
        snd_soc_free_pcms(socdev);
        regulator_bulk_disable(ARRAY_SIZE(cs4270->supplies), cs4270->supplies);
@@@ -730,7 -729,7 +730,7 @@@ static int cs4270_i2c_probe(struct i2c_
        codec->owner = THIS_MODULE;
        codec->dai = &cs4270_dai;
        codec->num_dai = 1;
-       codec->private_data = cs4270;
+       snd_soc_codec_set_drvdata(codec, cs4270);
        codec->control_data = i2c_client;
        codec->read = cs4270_read_reg_cache;
        codec->write = cs4270_i2c_write;
@@@ -843,7 -842,7 +843,7 @@@ MODULE_DEVICE_TABLE(i2c, cs4270_id)
  static int cs4270_soc_suspend(struct platform_device *pdev, pm_message_t mesg)
  {
        struct snd_soc_codec *codec = cs4270_codec;
-       struct cs4270_private *cs4270 = codec->private_data;
+       struct cs4270_private *cs4270 = snd_soc_codec_get_drvdata(codec);
        int reg, ret;
  
        reg = snd_soc_read(codec, CS4270_PWRCTL) | CS4270_PWRCTL_PDN_ALL;
  static int cs4270_soc_resume(struct platform_device *pdev)
  {
        struct snd_soc_codec *codec = cs4270_codec;
-       struct cs4270_private *cs4270 = codec->private_data;
+       struct cs4270_private *cs4270 = snd_soc_codec_get_drvdata(codec);
        struct i2c_client *i2c_client = codec->control_data;
        int reg;
  
@@@ -14,7 -14,6 +14,7 @@@
   */
  
  #include <linux/tty.h>
 +#include <linux/slab.h>
  
  #include <sound/core.h>
  #include <sound/initval.h>
@@@ -387,7 -386,7 +387,7 @@@ static int cx20442_register(struct cx20
  
        codec->name = "CX20442";
        codec->owner = THIS_MODULE;
-       codec->private_data = cx20442;
+       snd_soc_codec_set_drvdata(codec, cx20442);
  
        codec->dai = &cx20442_dai;
        codec->num_dai = 1;
@@@ -23,7 -23,6 +23,7 @@@
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
  #define DA7210_DAI_SRC_SEL            0x25
  #define DA7210_DAI_CFG1                       0x26
  #define DA7210_DAI_CFG3                       0x28
+ #define DA7210_PLL_DIV1                       0x29
+ #define DA7210_PLL_DIV2                       0x2A
  #define DA7210_PLL_DIV3                       0x2B
  #define DA7210_PLL                    0x2C
+ #define DA7210_A_HID_UNLOCK           0x8A
+ #define DA7210_A_TEST_UNLOCK          0x8B
+ #define DA7210_A_PLL1                 0x90
+ #define DA7210_A_CP_MODE              0xA7
  
  /* STARTUP1 bit fields */
  #define DA7210_SC_MST_EN              (1 << 0)
  /* INMIX_R bit fields */
  #define DA7210_IN_R_EN                        (1 << 7)
  
- /* ADC_HPF bit fields */
- #define DA7210_ADC_VOICE_EN           (1 << 7)
  /* ADC bit fields */
  #define DA7210_ADC_L_EN                       (1 << 3)
  #define DA7210_ADC_R_EN                       (1 << 7)
  
- /* DAC_HPF fields */
- #define DA7210_DAC_VOICE_EN           (1 << 7)
+ /* DAC/ADC HPF fields */
+ #define DA7210_VOICE_F0_MASK          (0x7 << 4)
+ #define DA7210_VOICE_F0_25            (1 << 4)
+ #define DA7210_VOICE_EN                       (1 << 7)
  
  /* DAC_SEL bit fields */
  #define DA7210_DAC_L_SRC_DAI_L                (4 << 0)
  #define DA7210_PLL_BYP                        (1 << 6)
  
  /* PLL bit fields */
- #define DA7210_PLL_FS_48000           (11 << 0)
+ #define DA7210_PLL_FS_MASK            (0xF << 0)
+ #define DA7210_PLL_FS_8000            (0x1 << 0)
+ #define DA7210_PLL_FS_11025           (0x2 << 0)
+ #define DA7210_PLL_FS_12000           (0x3 << 0)
+ #define DA7210_PLL_FS_16000           (0x5 << 0)
+ #define DA7210_PLL_FS_22050           (0x6 << 0)
+ #define DA7210_PLL_FS_24000           (0x7 << 0)
+ #define DA7210_PLL_FS_32000           (0x9 << 0)
+ #define DA7210_PLL_FS_44100           (0xA << 0)
+ #define DA7210_PLL_FS_48000           (0xB << 0)
+ #define DA7210_PLL_FS_88200           (0xE << 0)
+ #define DA7210_PLL_FS_96000           (0xF << 0)
+ #define DA7210_PLL_EN                 (0x1 << 7)
  
  #define DA7210_VERSION "0.0.1"
  
@@@ -165,7 -181,7 +182,7 @@@ static const u8 da7210_reg[] = 
  static inline u32 da7210_read_reg_cache(struct snd_soc_codec *codec, u32 reg)
  {
        u8 *cache = codec->reg_cache;
-       BUG_ON(reg > ARRAY_SIZE(da7210_reg));
+       BUG_ON(reg >= ARRAY_SIZE(da7210_reg));
        return cache[reg];
  }
  
@@@ -242,7 -258,8 +259,8 @@@ static int da7210_hw_params(struct snd_
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
        u32 dai_cfg1;
-       u32 reg, mask;
+       u32 hpf_reg, hpf_mask, hpf_value;
+       u32 fs, bypass;
  
        /* set DAI source to Left and Right ADC */
        da7210_write(codec, DA7210_DAI_SRC_SEL,
  
        da7210_write(codec, DA7210_DAI_CFG1, dai_cfg1);
  
-       /* FIXME
-        *
-        * It support 48K only now
-        */
+       hpf_reg = (SNDRV_PCM_STREAM_PLAYBACK == substream->stream) ?
+               DA7210_DAC_HPF : DA7210_ADC_HPF;
        switch (params_rate(params)) {
+       case 8000:
+               fs              = DA7210_PLL_FS_8000;
+               hpf_mask        = DA7210_VOICE_F0_MASK  | DA7210_VOICE_EN;
+               hpf_value       = DA7210_VOICE_F0_25    | DA7210_VOICE_EN;
+               bypass          = DA7210_PLL_BYP;
+               break;
+       case 11025:
+               fs              = DA7210_PLL_FS_11025;
+               hpf_mask        = DA7210_VOICE_F0_MASK  | DA7210_VOICE_EN;
+               hpf_value       = DA7210_VOICE_F0_25    | DA7210_VOICE_EN;
+               bypass          = 0;
+               break;
+       case 12000:
+               fs              = DA7210_PLL_FS_12000;
+               hpf_mask        = DA7210_VOICE_F0_MASK  | DA7210_VOICE_EN;
+               hpf_value       = DA7210_VOICE_F0_25    | DA7210_VOICE_EN;
+               bypass          = DA7210_PLL_BYP;
+               break;
+       case 16000:
+               fs              = DA7210_PLL_FS_16000;
+               hpf_mask        = DA7210_VOICE_F0_MASK  | DA7210_VOICE_EN;
+               hpf_value       = DA7210_VOICE_F0_25    | DA7210_VOICE_EN;
+               bypass          = DA7210_PLL_BYP;
+               break;
+       case 22050:
+               fs              = DA7210_PLL_FS_22050;
+               hpf_mask        = DA7210_VOICE_EN;
+               hpf_value       = 0;
+               bypass          = 0;
+               break;
+       case 32000:
+               fs              = DA7210_PLL_FS_32000;
+               hpf_mask        = DA7210_VOICE_EN;
+               hpf_value       = 0;
+               bypass          = DA7210_PLL_BYP;
+               break;
+       case 44100:
+               fs              = DA7210_PLL_FS_44100;
+               hpf_mask        = DA7210_VOICE_EN;
+               hpf_value       = 0;
+               bypass          = 0;
+               break;
        case 48000:
-               if (SNDRV_PCM_STREAM_PLAYBACK == substream->stream) {
-                       reg  = DA7210_DAC_HPF;
-                       mask = DA7210_DAC_VOICE_EN;
-               } else {
-                       reg  = DA7210_ADC_HPF;
-                       mask = DA7210_ADC_VOICE_EN;
-               }
+               fs              = DA7210_PLL_FS_48000;
+               hpf_mask        = DA7210_VOICE_EN;
+               hpf_value       = 0;
+               bypass          = DA7210_PLL_BYP;
+               break;
+       case 88200:
+               fs              = DA7210_PLL_FS_88200;
+               hpf_mask        = DA7210_VOICE_EN;
+               hpf_value       = 0;
+               bypass          = 0;
+               break;
+       case 96000:
+               fs              = DA7210_PLL_FS_96000;
+               hpf_mask        = DA7210_VOICE_EN;
+               hpf_value       = 0;
+               bypass          = DA7210_PLL_BYP;
                break;
        default:
                return -EINVAL;
        }
  
-       snd_soc_update_bits(codec, reg, mask, 0);
+       /* Disable active mode */
+       snd_soc_update_bits(codec, DA7210_STARTUP1, DA7210_SC_MST_EN, 0);
+       snd_soc_update_bits(codec, hpf_reg, hpf_mask, hpf_value);
+       snd_soc_update_bits(codec, DA7210_PLL, DA7210_PLL_FS_MASK, fs);
+       snd_soc_update_bits(codec, DA7210_PLL_DIV3, DA7210_PLL_BYP, bypass);
+       /* Enable active mode */
+       snd_soc_update_bits(codec, DA7210_STARTUP1,
+                           DA7210_SC_MST_EN, DA7210_SC_MST_EN);
  
        return 0;
  }
@@@ -362,6 -438,7 +439,7 @@@ struct snd_soc_dai da7210_dai = 
                .formats = DA7210_FORMATS,
        },
        .ops = &da7210_dai_ops,
+       .symmetric_rates = 1,
  };
  EXPORT_SYMBOL_GPL(da7210_dai);
  
@@@ -383,7 -460,7 +461,7 @@@ static int da7210_init(struct da7210_pr
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data     = da7210;
+       snd_soc_codec_set_drvdata(codec, da7210);
        codec->name             = "DA7210";
        codec->owner            = THIS_MODULE;
        codec->read             = da7210_read;
        /* FIXME
         *
         * This driver use fixed value here
+        * And below settings expects MCLK = 12.288MHz
+        *
+        * When you select different MCLK, please check...
+        *      DA7210_PLL_DIV1 val
+        *      DA7210_PLL_DIV2 val
+        *      DA7210_PLL_DIV3 val
+        *      DA7210_PLL_DIV3 :: DA7210_MCLK_RANGExxx
         */
  
        /*
+        * make sure that DA7210 use bypass mode before start up
+        */
+       da7210_write(codec, DA7210_STARTUP1, 0);
+       da7210_write(codec, DA7210_PLL_DIV3,
+                    DA7210_MCLK_RANGE_10_20_MHZ | DA7210_PLL_BYP);
+       /*
         * ADC settings
         */
  
        /* Diable PLL and bypass it */
        da7210_write(codec, DA7210_PLL, DA7210_PLL_FS_48000);
  
-       /* Bypass PLL and set MCLK freq rang to 10-20MHz */
-       da7210_write(codec, DA7210_PLL_DIV3,
+       /*
+        * If 48kHz sound came, it use bypass mode,
+        * and when it is 44.1kHz, it use PLL.
+        *
+        * This time, this driver sets PLL always ON
+        * and controls bypass/PLL mode by switching
+        * DA7210_PLL_DIV3 :: DA7210_PLL_BYP bit.
+        *   see da7210_hw_params
+        */
+       da7210_write(codec, DA7210_PLL_DIV1, 0xE5); /* MCLK = 12.288MHz */
+       da7210_write(codec, DA7210_PLL_DIV2, 0x99);
+       da7210_write(codec, DA7210_PLL_DIV3, 0x0A |
                     DA7210_MCLK_RANGE_10_20_MHZ | DA7210_PLL_BYP);
+       snd_soc_update_bits(codec, DA7210_PLL, DA7210_PLL_EN, DA7210_PLL_EN);
+       /* As suggested by Dialog */
+       da7210_write(codec, DA7210_A_HID_UNLOCK,        0x8B); /* unlock */
+       da7210_write(codec, DA7210_A_TEST_UNLOCK,       0xB4);
+       da7210_write(codec, DA7210_A_PLL1,              0x01);
+       da7210_write(codec, DA7210_A_CP_MODE,           0x7C);
+       da7210_write(codec, DA7210_A_HID_UNLOCK,        0x00); /* re-lock */
+       da7210_write(codec, DA7210_A_TEST_UNLOCK,       0x00);
  
        /* Activate all enabled subsystem */
        da7210_write(codec, DA7210_STARTUP1, DA7210_SC_MST_EN);
@@@ -33,7 -33,6 +33,7 @@@
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -140,6 -139,7 +140,7 @@@ SOC_DOUBLE_R("Capture Volume", SSM2602_
  SOC_DOUBLE_R("Capture Switch", SSM2602_LINVOL, SSM2602_RINVOL, 7, 1, 1),
  
  SOC_SINGLE("Mic Boost (+20dB)", SSM2602_APANA, 0, 1, 0),
+ SOC_SINGLE("Mic Boost2 (+20dB)", SSM2602_APANA, 7, 1, 0),
  SOC_SINGLE("Mic Switch", SSM2602_APANA, 1, 1, 1),
  
  SOC_SINGLE("Sidetone Playback Volume", SSM2602_APANA, 6, 3, 1),
@@@ -277,7 -277,7 +278,7 @@@ static int ssm2602_hw_params(struct snd
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct ssm2602_priv *ssm2602 = codec->private_data;
+       struct ssm2602_priv *ssm2602 = snd_soc_codec_get_drvdata(codec);
        struct i2c_client *i2c = codec->control_data;
        u16 iface = ssm2602_read_reg_cache(codec, SSM2602_IFACE) & 0xfff3;
        int i = get_coeff(ssm2602->sysclk, params_rate(params));
@@@ -322,7 -322,7 +323,7 @@@ static int ssm2602_startup(struct snd_p
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct ssm2602_priv *ssm2602 = codec->private_data;
+       struct ssm2602_priv *ssm2602 = snd_soc_codec_get_drvdata(codec);
        struct i2c_client *i2c = codec->control_data;
        struct snd_pcm_runtime *master_runtime;
  
@@@ -373,7 -373,7 +374,7 @@@ static void ssm2602_shutdown(struct snd
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct ssm2602_priv *ssm2602 = codec->private_data;
+       struct ssm2602_priv *ssm2602 = snd_soc_codec_get_drvdata(codec);
  
        /* deactivate */
        if (!codec->active)
@@@ -401,7 -401,7 +402,7 @@@ static int ssm2602_set_dai_sysclk(struc
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct ssm2602_priv *ssm2602 = codec->private_data;
+       struct ssm2602_priv *ssm2602 = snd_soc_codec_get_drvdata(codec);
        switch (freq) {
        case 11289600:
        case 12000000:
@@@ -559,7 -559,6 +560,6 @@@ static int ssm2602_resume(struct platfo
                codec->hw_write(codec->control_data, data, 2);
        }
        ssm2602_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       ssm2602_set_bias_level(codec, codec->suspend_bias_level);
        return 0;
  }
  
@@@ -605,8 -604,7 +605,7 @@@ static int ssm2602_init(struct snd_soc_
        reg = ssm2602_read_reg_cache(codec, SSM2602_ROUT1V);
        ssm2602_write(codec, SSM2602_ROUT1V, reg | ROUT1V_RLHP_BOTH);
        /*select Line in as default input*/
-       ssm2602_write(codec, SSM2602_APANA,
-                       APANA_ENABLE_MIC_BOOST2 | APANA_SELECT_DAC |
+       ssm2602_write(codec, SSM2602_APANA, APANA_SELECT_DAC |
                        APANA_ENABLE_MIC_BOOST);
        ssm2602_write(codec, SSM2602_PWR, 0);
  
@@@ -727,7 -725,7 +726,7 @@@ static int ssm2602_probe(struct platfor
                return -ENOMEM;
        }
  
-       codec->private_data = ssm2602;
+       snd_soc_codec_set_drvdata(codec, ssm2602);
        socdev->card->codec = codec;
        mutex_init(&codec->mutex);
        INIT_LIST_HEAD(&codec->dapm_widgets);
@@@ -760,7 -758,7 +759,7 @@@ static int ssm2602_remove(struct platfo
        i2c_unregister_device(codec->control_data);
        i2c_del_driver(&ssm2602_i2c_driver);
  #endif
-       kfree(codec->private_data);
+       kfree(snd_soc_codec_get_drvdata(codec));
        kfree(codec);
  
        return 0;
@@@ -15,7 -15,6 +15,7 @@@
   */
  
  #include <linux/init.h>
 +#include <linux/slab.h>
  #include <linux/module.h>
  #include <linux/device.h>
  #include <sound/core.h>
@@@ -289,9 -288,6 +289,6 @@@ reset
        }
        stac9766_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
  
-       if (codec->suspend_bias_level == SND_SOC_BIAS_ON)
-               stac9766_set_bias_level(codec, SND_SOC_BIAS_ON);
        return 0;
  }
  
@@@ -410,7 -406,7 +407,7 @@@ reset_err
  pcm_err:
        snd_soc_free_ac97_codec(codec);
  codec_err:
-       kfree(codec->private_data);
+       kfree(snd_soc_codec_get_drvdata(codec));
  cache_err:
        kfree(socdev->card->codec);
        socdev->card->codec = NULL;
@@@ -25,7 -25,6 +25,7 @@@
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -634,7 -633,6 +634,6 @@@ static int tlv320aic23_resume(struct pl
        }
  
        tlv320aic23_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       tlv320aic23_set_bias_level(codec, codec->suspend_bias_level);
  
        return 0;
  }
@@@ -13,7 -13,6 +13,7 @@@
  #include <linux/device.h>
  #include <linux/sysfs.h>
  #include <linux/spi/spi.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -49,7 -48,7 +49,7 @@@ struct aic26 
  static unsigned int aic26_reg_read(struct snd_soc_codec *codec,
                                   unsigned int reg)
  {
-       struct aic26 *aic26 = codec->private_data;
+       struct aic26 *aic26 = snd_soc_codec_get_drvdata(codec);
        u16 *cache = codec->reg_cache;
        u16 cmd, value;
        u8 buffer[2];
@@@ -93,7 -92,7 +93,7 @@@ static unsigned int aic26_reg_read_cach
  static int aic26_reg_write(struct snd_soc_codec *codec, unsigned int reg,
                           unsigned int value)
  {
-       struct aic26 *aic26 = codec->private_data;
+       struct aic26 *aic26 = snd_soc_codec_get_drvdata(codec);
        u16 *cache = codec->reg_cache;
        u16 cmd;
        u8 buffer[4];
@@@ -132,7 -131,7 +132,7 @@@ static int aic26_hw_params(struct snd_p
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct aic26 *aic26 = codec->private_data;
+       struct aic26 *aic26 = snd_soc_codec_get_drvdata(codec);
        int fsref, divisor, wlen, pval, jval, dval, qval;
        u16 reg;
  
  static int aic26_mute(struct snd_soc_dai *dai, int mute)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct aic26 *aic26 = codec->private_data;
+       struct aic26 *aic26 = snd_soc_codec_get_drvdata(codec);
        u16 reg = aic26_reg_read_cache(codec, AIC26_REG_DAC_GAIN);
  
        dev_dbg(&aic26->spi->dev, "aic26_mute(dai=%p, mute=%i)\n",
@@@ -218,7 -217,7 +218,7 @@@ static int aic26_set_sysclk(struct snd_
                            int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct aic26 *aic26 = codec->private_data;
+       struct aic26 *aic26 = snd_soc_codec_get_drvdata(codec);
  
        dev_dbg(&aic26->spi->dev, "aic26_set_sysclk(dai=%p, clk_id==%i,"
                " freq=%i, dir=%i)\n",
  static int aic26_set_fmt(struct snd_soc_dai *codec_dai, unsigned int fmt)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct aic26 *aic26 = codec->private_data;
+       struct aic26 *aic26 = snd_soc_codec_get_drvdata(codec);
  
        dev_dbg(&aic26->spi->dev, "aic26_set_fmt(dai=%p, fmt==%i)\n",
                codec_dai, fmt);
@@@ -431,7 -430,7 +431,7 @@@ static int aic26_spi_probe(struct spi_d
        /* Setup what we can in the codec structure so that the register
         * access functions will work as expected.  More will be filled
         * out when it is probed by the SoC CODEC part of this driver */
-       aic26->codec.private_data = aic26;
+       snd_soc_codec_set_drvdata(&aic26->codec, aic26);
        aic26->codec.name = "aic26";
        aic26->codec.owner = THIS_MODULE;
        aic26->codec.dai = &aic26_dai;
  #include <linux/delay.h>
  #include <linux/pm.h>
  #include <linux/i2c.h>
+ #include <linux/gpio.h>
+ #include <linux/regulator/consumer.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
  #include <sound/soc-dapm.h>
  #include <sound/initval.h>
  #include <sound/tlv.h>
+ #include <sound/tlv320aic3x.h>
  
  #include "tlv320aic3x.h"
  
- #define AIC3X_VERSION "0.2"
+ #define AIC3X_NUM_SUPPLIES    4
+ static const char *aic3x_supply_names[AIC3X_NUM_SUPPLIES] = {
+       "IOVDD",        /* I/O Voltage */
+       "DVDD",         /* Digital Core Voltage */
+       "AVDD",         /* Analog DAC Voltage */
+       "DRVDD",        /* ADC Analog and Output Driver Voltage */
+ };
  
  /* codec private data */
  struct aic3x_priv {
        struct snd_soc_codec codec;
+       struct regulator_bulk_data supplies[AIC3X_NUM_SUPPLIES];
        unsigned int sysclk;
        int master;
+       int gpio_reset;
  };
  
  /*
@@@ -764,7 -774,7 +775,7 @@@ static int aic3x_hw_params(struct snd_p
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct aic3x_priv *aic3x = codec->private_data;
+       struct aic3x_priv *aic3x = snd_soc_codec_get_drvdata(codec);
        int codec_clk = 0, bypass_pll = 0, fsref, last_clk = 0;
        u8 data, j, r, p, pll_q, pll_p = 1, pll_r = 1, pll_j = 1;
        u16 d, pll_d = 1;
@@@ -931,7 -941,7 +942,7 @@@ static int aic3x_set_dai_sysclk(struct 
                                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct aic3x_priv *aic3x = codec->private_data;
+       struct aic3x_priv *aic3x = snd_soc_codec_get_drvdata(codec);
  
        aic3x->sysclk = freq;
        return 0;
@@@ -941,7 -951,7 +952,7 @@@ static int aic3x_set_dai_fmt(struct snd
                             unsigned int fmt)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct aic3x_priv *aic3x = codec->private_data;
+       struct aic3x_priv *aic3x = snd_soc_codec_get_drvdata(codec);
        u8 iface_areg, iface_breg;
        int delay = 0;
  
  static int aic3x_set_bias_level(struct snd_soc_codec *codec,
                                enum snd_soc_bias_level level)
  {
-       struct aic3x_priv *aic3x = codec->private_data;
+       struct aic3x_priv *aic3x = snd_soc_codec_get_drvdata(codec);
        u8 reg;
  
        switch (level) {
        case SND_SOC_BIAS_ON:
-               /* all power is driven by DAPM system */
+               break;
+       case SND_SOC_BIAS_PREPARE:
                if (aic3x->master) {
                        /* enable pll */
                        reg = aic3x_read_reg_cache(codec, AIC3X_PLL_PROGA_REG);
                                    reg | PLL_ENABLE);
                }
                break;
-       case SND_SOC_BIAS_PREPARE:
-               break;
        case SND_SOC_BIAS_STANDBY:
-               /*
-                * all power is driven by DAPM system,
-                * so output power is safe if bypass was set
-                */
-               if (aic3x->master) {
-                       /* disable pll */
-                       reg = aic3x_read_reg_cache(codec, AIC3X_PLL_PROGA_REG);
-                       aic3x_write(codec, AIC3X_PLL_PROGA_REG,
-                                   reg & ~PLL_ENABLE);
-               }
-               break;
+               /* fall through and disable pll */
        case SND_SOC_BIAS_OFF:
-               /* force all power off */
-               reg = aic3x_read_reg_cache(codec, LINE1L_2_LADC_CTRL);
-               aic3x_write(codec, LINE1L_2_LADC_CTRL, reg & ~LADC_PWR_ON);
-               reg = aic3x_read_reg_cache(codec, LINE1R_2_RADC_CTRL);
-               aic3x_write(codec, LINE1R_2_RADC_CTRL, reg & ~RADC_PWR_ON);
-               reg = aic3x_read_reg_cache(codec, DAC_PWR);
-               aic3x_write(codec, DAC_PWR, reg & ~(LDAC_PWR_ON | RDAC_PWR_ON));
-               reg = aic3x_read_reg_cache(codec, HPLOUT_CTRL);
-               aic3x_write(codec, HPLOUT_CTRL, reg & ~HPLOUT_PWR_ON);
-               reg = aic3x_read_reg_cache(codec, HPROUT_CTRL);
-               aic3x_write(codec, HPROUT_CTRL, reg & ~HPROUT_PWR_ON);
-               reg = aic3x_read_reg_cache(codec, HPLCOM_CTRL);
-               aic3x_write(codec, HPLCOM_CTRL, reg & ~HPLCOM_PWR_ON);
-               reg = aic3x_read_reg_cache(codec, HPRCOM_CTRL);
-               aic3x_write(codec, HPRCOM_CTRL, reg & ~HPRCOM_PWR_ON);
-               reg = aic3x_read_reg_cache(codec, MONOLOPM_CTRL);
-               aic3x_write(codec, MONOLOPM_CTRL, reg & ~MONOLOPM_PWR_ON);
-               reg = aic3x_read_reg_cache(codec, LLOPM_CTRL);
-               aic3x_write(codec, LLOPM_CTRL, reg & ~LLOPM_PWR_ON);
-               reg = aic3x_read_reg_cache(codec, RLOPM_CTRL);
-               aic3x_write(codec, RLOPM_CTRL, reg & ~RLOPM_PWR_ON);
                if (aic3x->master) {
                        /* disable pll */
                        reg = aic3x_read_reg_cache(codec, AIC3X_PLL_PROGA_REG);
@@@ -1171,7 -1143,7 +1144,7 @@@ static int aic3x_resume(struct platform
                codec->hw_write(codec->control_data, data, 2);
        }
  
-       aic3x_set_bias_level(codec, codec->suspend_bias_level);
+       aic3x_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
  
        return 0;
  }
@@@ -1309,6 -1281,13 +1282,13 @@@ static int aic3x_unregister(struct aic3
        snd_soc_unregister_dai(&aic3x_dai);
        snd_soc_unregister_codec(&aic3x->codec);
  
+       if (aic3x->gpio_reset >= 0) {
+               gpio_set_value(aic3x->gpio_reset, 0);
+               gpio_free(aic3x->gpio_reset);
+       }
+       regulator_bulk_disable(ARRAY_SIZE(aic3x->supplies), aic3x->supplies);
+       regulator_bulk_free(ARRAY_SIZE(aic3x->supplies), aic3x->supplies);
        kfree(aic3x);
        aic3x_codec = NULL;
  
@@@ -1330,6 -1309,8 +1310,8 @@@ static int aic3x_i2c_probe(struct i2c_c
  {
        struct snd_soc_codec *codec;
        struct aic3x_priv *aic3x;
+       struct aic3x_pdata *pdata = i2c->dev.platform_data;
+       int ret, i;
  
        aic3x = kzalloc(sizeof(struct aic3x_priv), GFP_KERNEL);
        if (aic3x == NULL) {
  
        codec = &aic3x->codec;
        codec->dev = &i2c->dev;
-       codec->private_data = aic3x;
+       snd_soc_codec_set_drvdata(codec, aic3x);
        codec->control_data = i2c;
        codec->hw_write = (hw_write_t) i2c_master_send;
  
        i2c_set_clientdata(i2c, aic3x);
  
+       aic3x->gpio_reset = -1;
+       if (pdata && pdata->gpio_reset >= 0) {
+               ret = gpio_request(pdata->gpio_reset, "tlv320aic3x reset");
+               if (ret != 0)
+                       goto err_gpio;
+               aic3x->gpio_reset = pdata->gpio_reset;
+               gpio_direction_output(aic3x->gpio_reset, 0);
+       }
+       for (i = 0; i < ARRAY_SIZE(aic3x->supplies); i++)
+               aic3x->supplies[i].supply = aic3x_supply_names[i];
+       ret = regulator_bulk_get(codec->dev, ARRAY_SIZE(aic3x->supplies),
+                                aic3x->supplies);
+       if (ret != 0) {
+               dev_err(codec->dev, "Failed to request supplies: %d\n", ret);
+               goto err_get;
+       }
+       ret = regulator_bulk_enable(ARRAY_SIZE(aic3x->supplies),
+                                   aic3x->supplies);
+       if (ret != 0) {
+               dev_err(codec->dev, "Failed to enable supplies: %d\n", ret);
+               goto err_enable;
+       }
+       if (aic3x->gpio_reset >= 0) {
+               udelay(1);
+               gpio_set_value(aic3x->gpio_reset, 1);
+       }
        return aic3x_register(codec);
+ err_enable:
+       regulator_bulk_free(ARRAY_SIZE(aic3x->supplies), aic3x->supplies);
+ err_get:
+       if (aic3x->gpio_reset >= 0)
+               gpio_free(aic3x->gpio_reset);
+ err_gpio:
+       kfree(aic3x);
+       return ret;
  }
  
  static int aic3x_i2c_remove(struct i2c_client *client)
@@@ -31,7 -31,6 +31,7 @@@
  #include <linux/interrupt.h>
  #include <linux/gpio.h>
  #include <linux/regulator/consumer.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
  
  #define LATENCY_TIME_MS               20
  
+ #define MODE7_LTHR            10
+ #define MODE7_UTHR            (DAC33_BUFFER_SIZE_SAMPLES - 10)
+ #define BURST_BASEFREQ_HZ     49152000
+ #define SAMPLES_TO_US(rate, samples) \
+       (1000000000 / ((rate * 1000) / samples))
+ #define US_TO_SAMPLES(rate, us) \
+       (rate / (1000000 / us))
+ static void dac33_calculate_times(struct snd_pcm_substream *substream);
+ static int dac33_prepare_chip(struct snd_pcm_substream *substream);
  static struct snd_soc_codec *tlv320dac33_codec;
  
  enum dac33_state {
@@@ -80,6 -93,7 +94,7 @@@ struct tlv320dac33_priv 
        struct work_struct work;
        struct snd_soc_codec codec;
        struct regulator_bulk_data supplies[DAC33_NUM_SUPPLIES];
+       struct snd_pcm_substream *substream;
        int power_gpio;
        int chip_power;
        int irq;
        enum dac33_fifo_modes fifo_mode;/* FIFO mode selection */
        unsigned int nsample;           /* burst read amount from host */
        u8 burst_bclkdiv;               /* BCLK divider value in burst mode */
+       unsigned int burst_rate;        /* Interface speed in Burst modes */
+       int keep_bclk;                  /* Keep the BCLK continuously running
+                                        * in FIFO modes */
+       spinlock_t lock;
+       unsigned long long t_stamp1;    /* Time stamp for FIFO modes to */
+       unsigned long long t_stamp2;    /* calculate the FIFO caused delay */
+       unsigned int mode1_us_burst;    /* Time to burst read n number of
+                                        * samples */
+       unsigned int mode7_us_to_lthr;  /* Time to reach lthr from uthr */
  
        enum dac33_state state;
  };
@@@ -166,7 -191,7 +192,7 @@@ static inline void dac33_write_reg_cach
  static int dac33_read(struct snd_soc_codec *codec, unsigned int reg,
                      u8 *value)
  {
-       struct tlv320dac33_priv *dac33 = codec->private_data;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
        int val;
  
        *value = reg & 0xff;
  static int dac33_write(struct snd_soc_codec *codec, unsigned int reg,
                       unsigned int value)
  {
-       struct tlv320dac33_priv *dac33 = codec->private_data;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
        u8 data[2];
        int ret = 0;
  
  static int dac33_write_locked(struct snd_soc_codec *codec, unsigned int reg,
                       unsigned int value)
  {
-       struct tlv320dac33_priv *dac33 = codec->private_data;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
        int ret;
  
        mutex_lock(&dac33->mutex);
  static int dac33_write16(struct snd_soc_codec *codec, unsigned int reg,
                       unsigned int value)
  {
-       struct tlv320dac33_priv *dac33 = codec->private_data;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
        u8 data[3];
        int ret = 0;
  
        return ret;
  }
  
- static void dac33_restore_regs(struct snd_soc_codec *codec)
+ static void dac33_init_chip(struct snd_soc_codec *codec)
  {
-       struct tlv320dac33_priv *dac33 = codec->private_data;
-       u8 *cache = codec->reg_cache;
-       u8 data[2];
-       int i, ret;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
  
-       if (!dac33->chip_power)
+       if (unlikely(!dac33->chip_power))
                return;
  
-       for (i = DAC33_PWR_CTRL; i <= DAC33_INTP_CTRL_B; i++) {
-               data[0] = i;
-               data[1] = cache[i];
-               /* Skip the read only registers */
-               if ((i >= DAC33_INT_OSC_STATUS &&
-                               i <= DAC33_INT_OSC_FREQ_RAT_READ_B) ||
-                   (i >= DAC33_FIFO_WPTR_MSB && i <= DAC33_FIFO_IRQ_FLAG) ||
-                   i == DAC33_DAC_STATUS_FLAGS ||
-                   i == DAC33_SRC_EST_REF_CLK_RATIO_A ||
-                   i == DAC33_SRC_EST_REF_CLK_RATIO_B)
-                       continue;
-               ret = codec->hw_write(codec->control_data, data, 2);
-               if (ret != 2)
-                       dev_err(codec->dev, "Write failed (%d)\n", ret);
-       }
-       for (i = DAC33_LDAC_PWR_CTRL; i <= DAC33_LINEL_TO_LLO_VOL; i++) {
-               data[0] = i;
-               data[1] = cache[i];
-               ret = codec->hw_write(codec->control_data, data, 2);
-               if (ret != 2)
-                       dev_err(codec->dev, "Write failed (%d)\n", ret);
-       }
-       for (i = DAC33_LINER_TO_RLO_VOL; i <= DAC33_OSC_TRIM; i++) {
-               data[0] = i;
-               data[1] = cache[i];
-               ret = codec->hw_write(codec->control_data, data, 2);
-               if (ret != 2)
-                       dev_err(codec->dev, "Write failed (%d)\n", ret);
-       }
+       /* 44-46: DAC Control Registers */
+       /* A : DAC sample rate Fsref/1.5 */
+       dac33_write(codec, DAC33_DAC_CTRL_A, DAC33_DACRATE(0));
+       /* B : DAC src=normal, not muted */
+       dac33_write(codec, DAC33_DAC_CTRL_B, DAC33_DACSRCR_RIGHT |
+                                            DAC33_DACSRCL_LEFT);
+       /* C : (defaults) */
+       dac33_write(codec, DAC33_DAC_CTRL_C, 0x00);
+       /* 73 : volume soft stepping control,
+        clock source = internal osc (?) */
+       dac33_write(codec, DAC33_ANA_VOL_SOFT_STEP_CTRL, DAC33_VOLCLKEN);
+       dac33_write(codec, DAC33_PWR_CTRL, DAC33_PDNALLB);
+       /* Restore only selected registers (gains mostly) */
+       dac33_write(codec, DAC33_LDAC_DIG_VOL_CTRL,
+                   dac33_read_reg_cache(codec, DAC33_LDAC_DIG_VOL_CTRL));
+       dac33_write(codec, DAC33_RDAC_DIG_VOL_CTRL,
+                   dac33_read_reg_cache(codec, DAC33_RDAC_DIG_VOL_CTRL));
+       dac33_write(codec, DAC33_LINEL_TO_LLO_VOL,
+                   dac33_read_reg_cache(codec, DAC33_LINEL_TO_LLO_VOL));
+       dac33_write(codec, DAC33_LINER_TO_RLO_VOL,
+                   dac33_read_reg_cache(codec, DAC33_LINER_TO_RLO_VOL));
+ }
+ static inline void dac33_read_id(struct snd_soc_codec *codec)
+ {
+       u8 reg;
+       dac33_read(codec, DAC33_DEVICE_ID_MSB, &reg);
+       dac33_read(codec, DAC33_DEVICE_ID_LSB, &reg);
+       dac33_read(codec, DAC33_DEVICE_REV_ID, &reg);
  }
  
  static inline void dac33_soft_power(struct snd_soc_codec *codec, int power)
        if (power)
                reg |= DAC33_PDNALLB;
        else
-               reg &= ~DAC33_PDNALLB;
+               reg &= ~(DAC33_PDNALLB | DAC33_OSCPDNB |
+                        DAC33_DACRPDNB | DAC33_DACLPDNB);
        dac33_write(codec, DAC33_PWR_CTRL, reg);
  }
  
  static int dac33_hard_power(struct snd_soc_codec *codec, int power)
  {
-       struct tlv320dac33_priv *dac33 = codec->private_data;
-       int ret;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
+       int ret = 0;
  
        mutex_lock(&dac33->mutex);
+       /* Safety check */
+       if (unlikely(power == dac33->chip_power)) {
+               dev_dbg(codec->dev, "Trying to set the same power state: %s\n",
+                       power ? "ON" : "OFF");
+               goto exit;
+       }
        if (power) {
                ret = regulator_bulk_enable(ARRAY_SIZE(dac33->supplies),
                                          dac33->supplies);
                        gpio_set_value(dac33->power_gpio, 1);
  
                dac33->chip_power = 1;
-               /* Restore registers */
-               dac33_restore_regs(codec);
-               dac33_soft_power(codec, 1);
        } else {
                dac33_soft_power(codec, 0);
                if (dac33->power_gpio >= 0)
@@@ -360,11 -391,27 +392,27 @@@ exit
        return ret;
  }
  
+ static int playback_event(struct snd_soc_dapm_widget *w,
+               struct snd_kcontrol *kcontrol, int event)
+ {
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(w->codec);
+       switch (event) {
+       case SND_SOC_DAPM_PRE_PMU:
+               if (likely(dac33->substream)) {
+                       dac33_calculate_times(dac33->substream);
+                       dac33_prepare_chip(dac33->substream);
+               }
+               break;
+       }
+       return 0;
+ }
  static int dac33_get_nsample(struct snd_kcontrol *kcontrol,
                         struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct tlv320dac33_priv *dac33 = codec->private_data;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
  
        ucontrol->value.integer.value[0] = dac33->nsample;
  
@@@ -375,17 -422,21 +423,21 @@@ static int dac33_set_nsample(struct snd
                         struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct tlv320dac33_priv *dac33 = codec->private_data;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
        int ret = 0;
  
        if (dac33->nsample == ucontrol->value.integer.value[0])
                return 0;
  
        if (ucontrol->value.integer.value[0] < dac33->nsample_min ||
-           ucontrol->value.integer.value[0] > dac33->nsample_max)
+           ucontrol->value.integer.value[0] > dac33->nsample_max) {
                ret = -EINVAL;
-       else
+       } else {
                dac33->nsample = ucontrol->value.integer.value[0];
+               /* Re calculate the burst time */
+               dac33->mode1_us_burst = SAMPLES_TO_US(dac33->burst_rate,
+                                                     dac33->nsample);
+       }
  
        return ret;
  }
@@@ -394,7 -445,7 +446,7 @@@ static int dac33_get_fifo_mode(struct s
                         struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct tlv320dac33_priv *dac33 = codec->private_data;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
  
        ucontrol->value.integer.value[0] = dac33->fifo_mode;
  
@@@ -405,7 -456,7 +457,7 @@@ static int dac33_set_fifo_mode(struct s
                         struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct tlv320dac33_priv *dac33 = codec->private_data;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
        int ret = 0;
  
        if (dac33->fifo_mode == ucontrol->value.integer.value[0])
@@@ -485,6 -536,8 +537,8 @@@ static const struct snd_soc_dapm_widge
                         DAC33_OUT_AMP_PWR_CTRL, 6, 3, 3, 0),
        SND_SOC_DAPM_REG(snd_soc_dapm_mixer, "Output Right Amp Power",
                         DAC33_OUT_AMP_PWR_CTRL, 4, 3, 3, 0),
+       SND_SOC_DAPM_PRE("Prepare Playback", playback_event),
  };
  
  static const struct snd_soc_dapm_route audio_map[] = {
@@@ -527,18 -580,21 +581,21 @@@ static int dac33_set_bias_level(struct 
                break;
        case SND_SOC_BIAS_STANDBY:
                if (codec->bias_level == SND_SOC_BIAS_OFF) {
+                       /* Coming from OFF, switch on the codec */
                        ret = dac33_hard_power(codec, 1);
                        if (ret != 0)
                                return ret;
-               }
  
-               dac33_soft_power(codec, 0);
+                       dac33_init_chip(codec);
+               }
                break;
        case SND_SOC_BIAS_OFF:
+               /* Do not power off, when the codec is already off */
+               if (codec->bias_level == SND_SOC_BIAS_OFF)
+                       return 0;
                ret = dac33_hard_power(codec, 0);
                if (ret != 0)
                        return ret;
                break;
        }
        codec->bias_level = level;
@@@ -555,13 -611,34 +612,34 @@@ static inline void dac33_prefill_handle
        switch (dac33->fifo_mode) {
        case DAC33_FIFO_MODE1:
                dac33_write16(codec, DAC33_NSAMPLE_MSB,
-                               DAC33_THRREG(dac33->nsample));
+                       DAC33_THRREG(dac33->nsample + dac33->alarm_threshold));
+               /* Take the timestamps */
+               spin_lock_irq(&dac33->lock);
+               dac33->t_stamp2 = ktime_to_us(ktime_get());
+               dac33->t_stamp1 = dac33->t_stamp2;
+               spin_unlock_irq(&dac33->lock);
                dac33_write16(codec, DAC33_PREFILL_MSB,
                                DAC33_THRREG(dac33->alarm_threshold));
+               /* Enable Alarm Threshold IRQ with a delay */
+               udelay(SAMPLES_TO_US(dac33->burst_rate,
+                                    dac33->alarm_threshold));
+               dac33_write(codec, DAC33_FIFO_IRQ_MASK, DAC33_MAT);
                break;
        case DAC33_FIFO_MODE7:
+               /* Take the timestamp */
+               spin_lock_irq(&dac33->lock);
+               dac33->t_stamp1 = ktime_to_us(ktime_get());
+               /* Move back the timestamp with drain time */
+               dac33->t_stamp1 -= dac33->mode7_us_to_lthr;
+               spin_unlock_irq(&dac33->lock);
                dac33_write16(codec, DAC33_PREFILL_MSB,
-                               DAC33_THRREG(10));
+                               DAC33_THRREG(MODE7_LTHR));
+               /* Enable Upper Threshold IRQ */
+               dac33_write(codec, DAC33_FIFO_IRQ_MASK, DAC33_MUT);
                break;
        default:
                dev_warn(codec->dev, "Unhandled FIFO mode: %d\n",
@@@ -578,6 -655,11 +656,11 @@@ static inline void dac33_playback_handl
  
        switch (dac33->fifo_mode) {
        case DAC33_FIFO_MODE1:
+               /* Take the timestamp */
+               spin_lock_irq(&dac33->lock);
+               dac33->t_stamp2 = ktime_to_us(ktime_get());
+               spin_unlock_irq(&dac33->lock);
                dac33_write16(codec, DAC33_NSAMPLE_MSB,
                                DAC33_THRREG(dac33->nsample));
                break;
@@@ -628,31 -710,17 +711,17 @@@ static void dac33_work(struct work_stru
  static irqreturn_t dac33_interrupt_handler(int irq, void *dev)
  {
        struct snd_soc_codec *codec = dev;
-       struct tlv320dac33_priv *dac33 = codec->private_data;
-       queue_work(dac33->dac33_wq, &dac33->work);
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
  
-       return IRQ_HANDLED;
- }
+       spin_lock(&dac33->lock);
+       dac33->t_stamp1 = ktime_to_us(ktime_get());
+       spin_unlock(&dac33->lock);
  
- static void dac33_shutdown(struct snd_pcm_substream *substream,
-                            struct snd_soc_dai *dai)
- {
-       struct snd_soc_pcm_runtime *rtd = substream->private_data;
-       struct snd_soc_device *socdev = rtd->socdev;
-       struct snd_soc_codec *codec = socdev->card->codec;
-       struct tlv320dac33_priv *dac33 = codec->private_data;
-       unsigned int pwr_ctrl;
+       /* Do not schedule the workqueue in Mode7 */
+       if (dac33->fifo_mode != DAC33_FIFO_MODE7)
+               queue_work(dac33->dac33_wq, &dac33->work);
  
-       /* Stop pending workqueue */
-       if (dac33->fifo_mode)
-               cancel_work_sync(&dac33->work);
-       mutex_lock(&dac33->mutex);
-       pwr_ctrl = dac33_read_reg_cache(codec, DAC33_PWR_CTRL);
-       pwr_ctrl &= ~(DAC33_OSCPDNB | DAC33_DACRPDNB | DAC33_DACLPDNB);
-       dac33_write(codec, DAC33_PWR_CTRL, pwr_ctrl);
-       mutex_unlock(&dac33->mutex);
+       return IRQ_HANDLED;
  }
  
  static void dac33_oscwait(struct snd_soc_codec *codec)
                        "internal oscillator calibration failed\n");
  }
  
+ static int dac33_startup(struct snd_pcm_substream *substream,
+                          struct snd_soc_dai *dai)
+ {
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_device *socdev = rtd->socdev;
+       struct snd_soc_codec *codec = socdev->card->codec;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
+       /* Stream started, save the substream pointer */
+       dac33->substream = substream;
+       return 0;
+ }
+ static void dac33_shutdown(struct snd_pcm_substream *substream,
+                            struct snd_soc_dai *dai)
+ {
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_device *socdev = rtd->socdev;
+       struct snd_soc_codec *codec = socdev->card->codec;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
+       dac33->substream = NULL;
+ }
  static int dac33_hw_params(struct snd_pcm_substream *substream,
                           struct snd_pcm_hw_params *params,
                           struct snd_soc_dai *dai)
@@@ -715,7 -808,7 +809,7 @@@ static int dac33_prepare_chip(struct sn
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct tlv320dac33_priv *dac33 = codec->private_data;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
        unsigned int oscset, ratioset, pwr_ctrl, reg_tmp;
        u8 aictrl_a, aictrl_b, fifoctrl_a;
  
        }
  
        mutex_lock(&dac33->mutex);
+       if (!dac33->chip_power) {
+               /*
+                * Chip is not powered yet.
+                * Do the init in the dac33_set_bias_level later.
+                */
+               mutex_unlock(&dac33->mutex);
+               return 0;
+       }
+       dac33_soft_power(codec, 0);
        dac33_soft_power(codec, 1);
  
        reg_tmp = dac33_read_reg_cache(codec, DAC33_INT_OSC_CTRL);
        case DAC33_FIFO_MODE1:
                dac33_write(codec, DAC33_FIFO_IRQ_MODE_B,
                            DAC33_ATM(DAC33_FIFO_IRQ_MODE_LEVEL));
-               dac33_write(codec, DAC33_FIFO_IRQ_MASK, DAC33_MAT);
                break;
        case DAC33_FIFO_MODE7:
-               /* Disable all interrupts */
-               dac33_write(codec, DAC33_FIFO_IRQ_MASK, 0);
+               dac33_write(codec, DAC33_FIFO_IRQ_MODE_A,
+                       DAC33_UTM(DAC33_FIFO_IRQ_MODE_LEVEL));
                break;
        default:
                /* in FIFO bypass mode, the interrupts are not used */
                 */
                fifoctrl_a &= ~DAC33_FBYPAS;
                fifoctrl_a &= ~DAC33_FAUTO;
-               aictrl_b &= ~DAC33_BCLKON;
+               if (dac33->keep_bclk)
+                       aictrl_b |= DAC33_BCLKON;
+               else
+                       aictrl_b &= ~DAC33_BCLKON;
                break;
        case DAC33_FIFO_MODE7:
                /*
                 */
                fifoctrl_a &= ~DAC33_FBYPAS;
                fifoctrl_a |= DAC33_FAUTO;
-               aictrl_b &= ~DAC33_BCLKON;
+               if (dac33->keep_bclk)
+                       aictrl_b |= DAC33_BCLKON;
+               else
+                       aictrl_b &= ~DAC33_BCLKON;
                break;
        default:
                /*
                 * Configure the threshold levels, and leave 10 sample space
                 * at the bottom, and also at the top of the FIFO
                 */
-               dac33_write16(codec, DAC33_UTHR_MSB,
-                       DAC33_THRREG(DAC33_BUFFER_SIZE_SAMPLES - 10));
-               dac33_write16(codec, DAC33_LTHR_MSB,
-                       DAC33_THRREG(10));
+               dac33_write16(codec, DAC33_UTHR_MSB, DAC33_THRREG(MODE7_UTHR));
+               dac33_write16(codec, DAC33_LTHR_MSB, DAC33_THRREG(MODE7_LTHR));
                break;
        default:
                break;
@@@ -894,9 -1001,13 +1002,13 @@@ static void dac33_calculate_times(struc
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct tlv320dac33_priv *dac33 = codec->private_data;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
        unsigned int nsample_limit;
  
+       /* In bypass mode we don't need to calculate */
+       if (!dac33->fifo_mode)
+               return;
        /* Number of samples (16bit, stereo) in one period */
        dac33->nsample_min = snd_pcm_lib_period_bytes(substream) / 4;
  
  
        if (dac33->nsample > dac33->nsample_max)
                dac33->nsample = dac33->nsample_max;
- }
  
- static int dac33_pcm_prepare(struct snd_pcm_substream *substream,
-                            struct snd_soc_dai *dai)
- {
-       dac33_calculate_times(substream);
-       dac33_prepare_chip(substream);
+       switch (dac33->fifo_mode) {
+       case DAC33_FIFO_MODE1:
+               dac33->mode1_us_burst = SAMPLES_TO_US(dac33->burst_rate,
+                                                     dac33->nsample);
+               dac33->t_stamp1 = 0;
+               dac33->t_stamp2 = 0;
+               break;
+       case DAC33_FIFO_MODE7:
+               dac33->mode7_us_to_lthr =
+                                       SAMPLES_TO_US(substream->runtime->rate,
+                                               MODE7_UTHR - MODE7_LTHR + 1);
+               dac33->t_stamp1 = 0;
+               break;
+       default:
+               break;
+       }
  
-       return 0;
  }
  
  static int dac33_pcm_trigger(struct snd_pcm_substream *substream, int cmd,
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct tlv320dac33_priv *dac33 = codec->private_data;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
        int ret = 0;
  
        switch (cmd) {
        return ret;
  }
  
+ static snd_pcm_sframes_t dac33_dai_delay(
+                       struct snd_pcm_substream *substream,
+                       struct snd_soc_dai *dai)
+ {
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_device *socdev = rtd->socdev;
+       struct snd_soc_codec *codec = socdev->card->codec;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
+       unsigned long long t0, t1, t_now;
+       unsigned int time_delta;
+       int samples_out, samples_in, samples;
+       snd_pcm_sframes_t delay = 0;
+       switch (dac33->fifo_mode) {
+       case DAC33_FIFO_BYPASS:
+               break;
+       case DAC33_FIFO_MODE1:
+               spin_lock(&dac33->lock);
+               t0 = dac33->t_stamp1;
+               t1 = dac33->t_stamp2;
+               spin_unlock(&dac33->lock);
+               t_now = ktime_to_us(ktime_get());
+               /* We have not started to fill the FIFO yet, delay is 0 */
+               if (!t1)
+                       goto out;
+               if (t0 > t1) {
+                       /*
+                        * Phase 1:
+                        * After Alarm threshold, and before nSample write
+                        */
+                       time_delta = t_now - t0;
+                       samples_out = time_delta ? US_TO_SAMPLES(
+                                               substream->runtime->rate,
+                                               time_delta) : 0;
+                       if (likely(dac33->alarm_threshold > samples_out))
+                               delay = dac33->alarm_threshold - samples_out;
+                       else
+                               delay = 0;
+               } else if ((t_now - t1) <= dac33->mode1_us_burst) {
+                       /*
+                        * Phase 2:
+                        * After nSample write (during burst operation)
+                        */
+                       time_delta = t_now - t0;
+                       samples_out = time_delta ? US_TO_SAMPLES(
+                                               substream->runtime->rate,
+                                               time_delta) : 0;
+                       time_delta = t_now - t1;
+                       samples_in = time_delta ? US_TO_SAMPLES(
+                                               dac33->burst_rate,
+                                               time_delta) : 0;
+                       samples = dac33->alarm_threshold;
+                       samples += (samples_in - samples_out);
+                       if (likely(samples > 0))
+                               delay = samples;
+                       else
+                               delay = 0;
+               } else {
+                       /*
+                        * Phase 3:
+                        * After burst operation, before next alarm threshold
+                        */
+                       time_delta = t_now - t0;
+                       samples_out = time_delta ? US_TO_SAMPLES(
+                                               substream->runtime->rate,
+                                               time_delta) : 0;
+                       samples_in = dac33->nsample;
+                       samples = dac33->alarm_threshold;
+                       samples += (samples_in - samples_out);
+                       if (likely(samples > 0))
+                               delay = samples > DAC33_BUFFER_SIZE_SAMPLES ?
+                                       DAC33_BUFFER_SIZE_SAMPLES : samples;
+                       else
+                               delay = 0;
+               }
+               break;
+       case DAC33_FIFO_MODE7:
+               spin_lock(&dac33->lock);
+               t0 = dac33->t_stamp1;
+               spin_unlock(&dac33->lock);
+               t_now = ktime_to_us(ktime_get());
+               /* We have not started to fill the FIFO yet, delay is 0 */
+               if (!t0)
+                       goto out;
+               if (t_now <= t0) {
+                       /*
+                        * Either the timestamps are messed or equal. Report
+                        * maximum delay
+                        */
+                       delay = MODE7_UTHR;
+                       goto out;
+               }
+               time_delta = t_now - t0;
+               if (time_delta <= dac33->mode7_us_to_lthr) {
+                       /*
+                       * Phase 1:
+                       * After burst (draining phase)
+                       */
+                       samples_out = US_TO_SAMPLES(
+                                       substream->runtime->rate,
+                                       time_delta);
+                       if (likely(MODE7_UTHR > samples_out))
+                               delay = MODE7_UTHR - samples_out;
+                       else
+                               delay = 0;
+               } else {
+                       /*
+                       * Phase 2:
+                       * During burst operation
+                       */
+                       time_delta = time_delta - dac33->mode7_us_to_lthr;
+                       samples_out = US_TO_SAMPLES(
+                                       substream->runtime->rate,
+                                       time_delta);
+                       samples_in = US_TO_SAMPLES(
+                                       dac33->burst_rate,
+                                       time_delta);
+                       delay = MODE7_LTHR + samples_in - samples_out;
+                       if (unlikely(delay > MODE7_UTHR))
+                               delay = MODE7_UTHR;
+               }
+               break;
+       default:
+               dev_warn(codec->dev, "Unhandled FIFO mode: %d\n",
+                                                       dac33->fifo_mode);
+               break;
+       }
+ out:
+       return delay;
+ }
  static int dac33_set_dai_sysclk(struct snd_soc_dai *codec_dai,
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct tlv320dac33_priv *dac33 = codec->private_data;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
        u8 ioc_reg, asrcb_reg;
  
        ioc_reg = dac33_read_reg_cache(codec, DAC33_INT_OSC_CTRL);
@@@ -1008,7 -1273,7 +1274,7 @@@ static int dac33_set_dai_fmt(struct snd
                             unsigned int fmt)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct tlv320dac33_priv *dac33 = codec->private_data;
+       struct tlv320dac33_priv *dac33 = snd_soc_codec_get_drvdata(codec);
        u8 aictrl_a, aictrl_b;
  
        aictrl_a = dac33_read_reg_cache(codec, DAC33_SER_AUDIOIF_CTRL_A);
        return 0;
  }
  
- static void dac33_init_chip(struct snd_soc_codec *codec)
- {
-       /* 44-46: DAC Control Registers */
-       /* A : DAC sample rate Fsref/1.5 */
-       dac33_write(codec, DAC33_DAC_CTRL_A, DAC33_DACRATE(0));
-       /* B : DAC src=normal, not muted */
-       dac33_write(codec, DAC33_DAC_CTRL_B, DAC33_DACSRCR_RIGHT |
-                                            DAC33_DACSRCL_LEFT);
-       /* C : (defaults) */
-       dac33_write(codec, DAC33_DAC_CTRL_C, 0x00);
-       /* 64-65 : L&R DAC power control
-        Line In -> OUT 1V/V Gain, DAC -> OUT 4V/V Gain*/
-       dac33_write(codec, DAC33_LDAC_PWR_CTRL, DAC33_LROUT_GAIN(2));
-       dac33_write(codec, DAC33_RDAC_PWR_CTRL, DAC33_LROUT_GAIN(2));
-       /* 73 : volume soft stepping control,
-        clock source = internal osc (?) */
-       dac33_write(codec, DAC33_ANA_VOL_SOFT_STEP_CTRL, DAC33_VOLCLKEN);
-       /* 66 : LOP/LOM Modes */
-       dac33_write(codec, DAC33_OUT_AMP_CM_CTRL, 0xff);
-       /* 68 : LOM inverted from LOP */
-       dac33_write(codec, DAC33_OUT_AMP_CTRL, (3<<2));
-       dac33_write(codec, DAC33_PWR_CTRL, DAC33_PDNALLB);
- }
  static int dac33_soc_probe(struct platform_device *pdev)
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
  
        codec = tlv320dac33_codec;
        socdev->card->codec = codec;
-       dac33 = codec->private_data;
-       /* Power up the codec */
-       dac33_hard_power(codec, 1);
-       /* Set default configuration */
-       dac33_init_chip(codec);
+       dac33 = snd_soc_codec_get_drvdata(codec);
  
        /* register pcms */
        ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
  
        dac33_add_widgets(codec);
  
-       /* power on device */
-       dac33_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       /* Bias level configuration has enabled regulator an extra time */
-       regulator_bulk_disable(ARRAY_SIZE(dac33->supplies), dac33->supplies);
        return 0;
  
  pcm_err:
@@@ -1164,7 -1389,6 +1390,6 @@@ static int dac33_soc_resume(struct plat
        struct snd_soc_codec *codec = socdev->card->codec;
  
        dac33_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       dac33_set_bias_level(codec, codec->suspend_bias_level);
  
        return 0;
  }
@@@ -1182,10 -1406,11 +1407,11 @@@ EXPORT_SYMBOL_GPL(soc_codec_dev_tlv320d
  #define DAC33_FORMATS SNDRV_PCM_FMTBIT_S16_LE
  
  static struct snd_soc_dai_ops dac33_dai_ops = {
+       .startup        = dac33_startup,
        .shutdown       = dac33_shutdown,
        .hw_params      = dac33_hw_params,
-       .prepare        = dac33_pcm_prepare,
        .trigger        = dac33_pcm_trigger,
+       .delay          = dac33_dai_delay,
        .set_sysclk     = dac33_set_dai_sysclk,
        .set_fmt        = dac33_set_dai_fmt,
  };
@@@ -1221,11 -1446,12 +1447,12 @@@ static int __devinit dac33_i2c_probe(st
                return -ENOMEM;
  
        codec = &dac33->codec;
-       codec->private_data = dac33;
+       snd_soc_codec_set_drvdata(codec, dac33);
        codec->control_data = client;
  
        mutex_init(&codec->mutex);
        mutex_init(&dac33->mutex);
+       spin_lock_init(&dac33->lock);
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
        codec->hw_write = (hw_write_t) i2c_master_send;
        codec->bias_level = SND_SOC_BIAS_OFF;
        codec->set_bias_level = dac33_set_bias_level;
+       codec->idle_bias_off = 1;
        codec->dai = &dac33_dai;
        codec->num_dai = 1;
        codec->reg_cache_size = ARRAY_SIZE(dac33_reg);
  
        dac33->power_gpio = pdata->power_gpio;
        dac33->burst_bclkdiv = pdata->burst_bclkdiv;
+       /* Pre calculate the burst rate */
+       dac33->burst_rate = BURST_BASEFREQ_HZ / dac33->burst_bclkdiv / 32;
+       dac33->keep_bclk = pdata->keep_bclk;
        dac33->irq = client->irq;
        dac33->nsample = NSAMPLE_MAX;
+       dac33->nsample_max = NSAMPLE_MAX;
        /* Disable FIFO use by default */
        dac33->fifo_mode = DAC33_FIFO_BYPASS;
  
                        goto error_gpio;
                }
                gpio_direction_output(dac33->power_gpio, 0);
-       } else {
-               dac33->chip_power = 1;
        }
  
        /* Check if the IRQ number is valid and request it */
                goto err_get;
        }
  
-       ret = regulator_bulk_enable(ARRAY_SIZE(dac33->supplies),
-                                   dac33->supplies);
+       /* Read the tlv320dac33 ID registers */
+       ret = dac33_hard_power(codec, 1);
        if (ret != 0) {
-               dev_err(codec->dev, "Failed to enable supplies: %d\n", ret);
-               goto err_enable;
+               dev_err(codec->dev, "Failed to power up codec: %d\n", ret);
+               goto error_codec;
        }
+       dac33_read_id(codec);
+       dac33_hard_power(codec, 0);
  
        ret = snd_soc_register_codec(codec);
        if (ret != 0) {
                goto error_codec;
        }
  
        return ret;
  
  error_codec:
-       regulator_bulk_disable(ARRAY_SIZE(dac33->supplies), dac33->supplies);
- err_enable:
        regulator_bulk_free(ARRAY_SIZE(dac33->supplies), dac33->supplies);
  err_get:
        if (dac33->irq >= 0) {
@@@ -1362,7 -1588,9 +1589,9 @@@ static int __devexit dac33_i2c_remove(s
        struct tlv320dac33_priv *dac33;
  
        dac33 = i2c_get_clientdata(client);
-       dac33_hard_power(&dac33->codec, 0);
+       if (unlikely(dac33->chip_power))
+               dac33_hard_power(&dac33->codec, 0);
  
        if (dac33->power_gpio >= 0)
                gpio_free(dac33->power_gpio);
@@@ -26,7 -26,6 +26,7 @@@
  #include <linux/i2c.h>
  #include <linux/gpio.h>
  #include <linux/regulator/consumer.h>
 +#include <linux/slab.h>
  #include <sound/tpa6130a2-plat.h>
  #include <sound/soc.h>
  #include <sound/soc-dapm.h>
  
  static struct i2c_client *tpa6130a2_client;
  
- #define TPA6130A2_NUM_SUPPLIES 2
- static const char *tpa6130a2_supply_names[TPA6130A2_NUM_SUPPLIES] = {
-       "CPVSS",
-       "Vdd",
- };
- static const char *tpa6140a2_supply_names[TPA6130A2_NUM_SUPPLIES] = {
-       "HPVdd",
-       "AVdd",
- };
  /* This struct is used to save the context */
  struct tpa6130a2_data {
        struct mutex mutex;
        unsigned char regs[TPA6130A2_CACHEREGNUM];
-       struct regulator_bulk_data supplies[TPA6130A2_NUM_SUPPLIES];
+       struct regulator *supply;
        int power_gpio;
        unsigned char power_state;
+       enum tpa_model id;
  };
  
  static int tpa6130a2_i2c_read(int reg)
@@@ -135,11 -124,10 +125,10 @@@ static int tpa6130a2_power(int power
                if (data->power_gpio >= 0)
                        gpio_set_value(data->power_gpio, 1);
  
-               ret = regulator_bulk_enable(ARRAY_SIZE(data->supplies),
-                                           data->supplies);
+               ret = regulator_enable(data->supply);
                if (ret != 0) {
                        dev_err(&tpa6130a2_client->dev,
-                               "Failed to enable supplies: %d\n", ret);
+                               "Failed to enable supply: %d\n", ret);
                        goto exit;
                }
  
                if (data->power_gpio >= 0)
                        gpio_set_value(data->power_gpio, 0);
  
-               ret = regulator_bulk_disable(ARRAY_SIZE(data->supplies),
-                                            data->supplies);
+               ret = regulator_disable(data->supply);
                if (ret != 0) {
                        dev_err(&tpa6130a2_client->dev,
-                               "Failed to disable supplies: %d\n", ret);
+                               "Failed to disable supply: %d\n", ret);
                        goto exit;
                }
  
@@@ -176,7 -163,7 +164,7 @@@ exit
        return ret;
  }
  
- static int tpa6130a2_get_reg(struct snd_kcontrol *kcontrol,
+ static int tpa6130a2_get_volsw(struct snd_kcontrol *kcontrol,
                struct snd_ctl_elem_value *ucontrol)
  {
        struct soc_mixer_control *mc =
        struct tpa6130a2_data *data;
        unsigned int reg = mc->reg;
        unsigned int shift = mc->shift;
-       unsigned int mask = mc->max;
+       int max = mc->max;
+       unsigned int mask = (1 << fls(max)) - 1;
        unsigned int invert = mc->invert;
  
        BUG_ON(tpa6130a2_client == NULL);
  
        if (invert)
                ucontrol->value.integer.value[0] =
-                       mask - ucontrol->value.integer.value[0];
+                       max - ucontrol->value.integer.value[0];
  
        mutex_unlock(&data->mutex);
        return 0;
  }
  
- static int tpa6130a2_set_reg(struct snd_kcontrol *kcontrol,
+ static int tpa6130a2_put_volsw(struct snd_kcontrol *kcontrol,
                struct snd_ctl_elem_value *ucontrol)
  {
        struct soc_mixer_control *mc =
        struct tpa6130a2_data *data;
        unsigned int reg = mc->reg;
        unsigned int shift = mc->shift;
-       unsigned int mask = mc->max;
+       int max = mc->max;
+       unsigned int mask = (1 << fls(max)) - 1;
        unsigned int invert = mc->invert;
        unsigned int val = (ucontrol->value.integer.value[0] & mask);
        unsigned int val_reg;
        data = i2c_get_clientdata(tpa6130a2_client);
  
        if (invert)
-               val = mask - val;
+               val = max - val;
  
        mutex_lock(&data->mutex);
  
@@@ -260,10 -249,24 +250,24 @@@ static const unsigned int tpa6130_tlv[
  static const struct snd_kcontrol_new tpa6130a2_controls[] = {
        SOC_SINGLE_EXT_TLV("TPA6130A2 Headphone Playback Volume",
                       TPA6130A2_REG_VOL_MUTE, 0, 0x3f, 0,
-                      tpa6130a2_get_reg, tpa6130a2_set_reg,
+                      tpa6130a2_get_volsw, tpa6130a2_put_volsw,
                       tpa6130_tlv),
  };
  
+ static const unsigned int tpa6140_tlv[] = {
+       TLV_DB_RANGE_HEAD(3),
+       0, 8, TLV_DB_SCALE_ITEM(-5900, 400, 0),
+       9, 16, TLV_DB_SCALE_ITEM(-2500, 200, 0),
+       17, 31, TLV_DB_SCALE_ITEM(-1000, 100, 0),
+ };
+ static const struct snd_kcontrol_new tpa6140a2_controls[] = {
+       SOC_SINGLE_EXT_TLV("TPA6140A2 Headphone Playback Volume",
+                      TPA6130A2_REG_VOL_MUTE, 1, 0x1f, 0,
+                      tpa6130a2_get_volsw, tpa6130a2_put_volsw,
+                      tpa6140_tlv),
+ };
  /*
   * Enable or disable channel (left or right)
   * The bit number for mute and amplifier are the same per channel:
@@@ -355,8 -358,8 +359,8 @@@ static const struct snd_soc_dapm_widge
                        0, 0, tpa6130a2_supply_event,
                        SND_SOC_DAPM_POST_PMU|SND_SOC_DAPM_POST_PMD),
        /* Outputs */
-       SND_SOC_DAPM_HP("TPA6130A2 Headphone Left", NULL),
-       SND_SOC_DAPM_HP("TPA6130A2 Headphone Right", NULL),
+       SND_SOC_DAPM_OUTPUT("TPA6130A2 Headphone Left"),
+       SND_SOC_DAPM_OUTPUT("TPA6130A2 Headphone Right"),
  };
  
  static const struct snd_soc_dapm_route audio_map[] = {
  
  int tpa6130a2_add_controls(struct snd_soc_codec *codec)
  {
+       struct  tpa6130a2_data *data;
+       BUG_ON(tpa6130a2_client == NULL);
+       data = i2c_get_clientdata(tpa6130a2_client);
        snd_soc_dapm_new_controls(codec, tpa6130a2_dapm_widgets,
                                ARRAY_SIZE(tpa6130a2_dapm_widgets));
  
        snd_soc_dapm_add_routes(codec, audio_map, ARRAY_SIZE(audio_map));
  
-       return snd_soc_add_controls(codec, tpa6130a2_controls,
-                               ARRAY_SIZE(tpa6130a2_controls));
+       if (data->id == TPA6140A2)
+               return snd_soc_add_controls(codec, tpa6140a2_controls,
+                                               ARRAY_SIZE(tpa6140a2_controls));
+       else
+               return snd_soc_add_controls(codec, tpa6130a2_controls,
+                                               ARRAY_SIZE(tpa6130a2_controls));
  
  }
  EXPORT_SYMBOL_GPL(tpa6130a2_add_controls);
@@@ -386,7 -398,8 +399,8 @@@ static int __devinit tpa6130a2_probe(st
        struct device *dev;
        struct tpa6130a2_data *data;
        struct tpa6130a2_platform_data *pdata;
-       int i, ret;
+       const char *regulator;
+       int ret;
  
        dev = &client->dev;
  
  
        pdata = client->dev.platform_data;
        data->power_gpio = pdata->power_gpio;
+       data->id = pdata->id;
  
        mutex_init(&data->mutex);
  
                gpio_direction_output(data->power_gpio, 0);
        }
  
-       switch (pdata->id) {
+       switch (data->id) {
+       default:
+               dev_warn(dev, "Unknown TPA model (%d). Assuming 6130A2\n",
+                        pdata->id);
        case TPA6130A2:
-               for (i = 0; i < ARRAY_SIZE(data->supplies); i++)
-                       data->supplies[i].supply = tpa6130a2_supply_names[i];
+               regulator = "Vdd";
                break;
        case TPA6140A2:
-               for (i = 0; i < ARRAY_SIZE(data->supplies); i++)
-                       data->supplies[i].supply = tpa6140a2_supply_names[i];;
+               regulator = "AVdd";
                break;
-       default:
-               dev_warn(dev, "Unknown TPA model (%d). Assuming 6130A2\n",
-                        pdata->id);
-               for (i = 0; i < ARRAY_SIZE(data->supplies); i++)
-                       data->supplies[i].supply = tpa6130a2_supply_names[i];
        }
  
-       ret = regulator_bulk_get(dev, ARRAY_SIZE(data->supplies),
-                                data->supplies);
-       if (ret != 0) {
-               dev_err(dev, "Failed to request supplies: %d\n", ret);
+       data->supply = regulator_get(dev, regulator);
+       if (IS_ERR(data->supply)) {
+               ret = PTR_ERR(data->supply);
+               dev_err(dev, "Failed to request supply: %d\n", ret);
                goto err_regulator;
        }
  
        return 0;
  
  err_power:
-       regulator_bulk_free(ARRAY_SIZE(data->supplies), data->supplies);
+       regulator_put(data->supply);
  err_regulator:
        if (data->power_gpio >= 0)
                gpio_free(data->power_gpio);
@@@ -489,7 -499,7 +500,7 @@@ static int __devexit tpa6130a2_remove(s
        if (data->power_gpio >= 0)
                gpio_free(data->power_gpio);
  
-       regulator_bulk_free(ARRAY_SIZE(data->supplies), data->supplies);
+       regulator_put(data->supply);
  
        kfree(data);
        tpa6130a2_client = NULL;
@@@ -27,7 -27,6 +27,7 @@@
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
  #include <linux/i2c/twl.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -124,6 -123,8 +124,8 @@@ struct twl4030_priv 
        struct snd_soc_codec codec;
  
        unsigned int codec_powered;
+       /* reference counts of AIF/APLL users */
        unsigned int apll_enabled;
  
        struct snd_pcm_substream *master_substream;
  
        unsigned int sysclk;
  
-       /* Headset output state handling */
-       unsigned int hsl_enabled;
-       unsigned int hsr_enabled;
+       /* Output (with associated amp) states */
+       u8 hsl_enabled, hsr_enabled;
+       u8 earpiece_enabled;
+       u8 predrivel_enabled, predriver_enabled;
+       u8 carkitl_enabled, carkitr_enabled;
  };
  
  /*
@@@ -174,17 -177,52 +178,52 @@@ static inline void twl4030_write_reg_ca
  static int twl4030_write(struct snd_soc_codec *codec,
                        unsigned int reg, unsigned int value)
  {
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(codec);
+       int write_to_reg = 0;
        twl4030_write_reg_cache(codec, reg, value);
-       if (likely(reg < TWL4030_REG_SW_SHADOW))
-               return twl_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE, value,
-                                           reg);
-       else
-               return 0;
+       if (likely(reg < TWL4030_REG_SW_SHADOW)) {
+               /* Decide if the given register can be written */
+               switch (reg) {
+               case TWL4030_REG_EAR_CTL:
+                       if (twl4030->earpiece_enabled)
+                               write_to_reg = 1;
+                       break;
+               case TWL4030_REG_PREDL_CTL:
+                       if (twl4030->predrivel_enabled)
+                               write_to_reg = 1;
+                       break;
+               case TWL4030_REG_PREDR_CTL:
+                       if (twl4030->predriver_enabled)
+                               write_to_reg = 1;
+                       break;
+               case TWL4030_REG_PRECKL_CTL:
+                       if (twl4030->carkitl_enabled)
+                               write_to_reg = 1;
+                       break;
+               case TWL4030_REG_PRECKR_CTL:
+                       if (twl4030->carkitr_enabled)
+                               write_to_reg = 1;
+                       break;
+               case TWL4030_REG_HS_GAIN_SET:
+                       if (twl4030->hsl_enabled || twl4030->hsr_enabled)
+                               write_to_reg = 1;
+                       break;
+               default:
+                       /* All other register can be written */
+                       write_to_reg = 1;
+                       break;
+               }
+               if (write_to_reg)
+                       return twl_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
+                                                   value, reg);
+       }
+       return 0;
  }
  
  static void twl4030_codec_enable(struct snd_soc_codec *codec, int enable)
  {
-       struct twl4030_priv *twl4030 = codec->private_data;
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(codec);
        int mode;
  
        if (enable == twl4030->codec_powered)
@@@ -222,28 -260,28 +261,28 @@@ static void twl4030_init_chip(struct sn
  
  static void twl4030_apll_enable(struct snd_soc_codec *codec, int enable)
  {
-       struct twl4030_priv *twl4030 = codec->private_data;
-       int status;
-       if (enable == twl4030->apll_enabled)
-               return;
-       if (enable)
-               /* Enable PLL */
-               status = twl4030_codec_enable_resource(TWL4030_CODEC_RES_APLL);
-       else
-               /* Disable PLL */
-               status = twl4030_codec_disable_resource(TWL4030_CODEC_RES_APLL);
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(codec);
+       int status = -1;
+       if (enable) {
+               twl4030->apll_enabled++;
+               if (twl4030->apll_enabled == 1)
+                       status = twl4030_codec_enable_resource(
+                                                       TWL4030_CODEC_RES_APLL);
+       } else {
+               twl4030->apll_enabled--;
+               if (!twl4030->apll_enabled)
+                       status = twl4030_codec_disable_resource(
+                                                       TWL4030_CODEC_RES_APLL);
+       }
  
        if (status >= 0)
                twl4030_write_reg_cache(codec, TWL4030_REG_APLL_CTL, status);
-       twl4030->apll_enabled = enable;
  }
  
  static void twl4030_power_up(struct snd_soc_codec *codec)
  {
-       struct twl4030_priv *twl4030 = codec->private_data;
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(codec);
        u8 anamicl, regmisc1, byte;
        int i = 0;
  
@@@ -526,26 -564,26 +565,26 @@@ static int micpath_event(struct snd_soc
   * Output PGA builder:
   * Handle the muting and unmuting of the given output (turning off the
   * amplifier associated with the output pin)
-  * On mute bypass the reg_cache and mute the volume
-  * On unmute: restore the register content
+  * On mute bypass the reg_cache and write 0 to the register
+  * On unmute: restore the register content from the reg_cache
   * Outputs handled in this way:  Earpiece, PreDrivL/R, CarkitL/R
   */
  #define TWL4030_OUTPUT_PGA(pin_name, reg, mask)                               \
  static int pin_name##pga_event(struct snd_soc_dapm_widget *w,         \
                struct snd_kcontrol *kcontrol, int event)               \
  {                                                                     \
-       u8 reg_val;                                                     \
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(w->codec); \
                                                                        \
        switch (event) {                                                \
        case SND_SOC_DAPM_POST_PMU:                                     \
+               twl4030->pin_name##_enabled = 1;                        \
                twl4030_write(w->codec, reg,                            \
                        twl4030_read_reg_cache(w->codec, reg));         \
                break;                                                  \
        case SND_SOC_DAPM_POST_PMD:                                     \
-               reg_val = twl4030_read_reg_cache(w->codec, reg);        \
-               twl_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,    \
-                                       reg_val & (~mask),              \
-                                       reg);                           \
+               twl4030->pin_name##_enabled = 0;                        \
+               twl_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,            \
+                                       0, reg);                        \
                break;                                                  \
        }                                                               \
        return 0;                                                       \
@@@ -636,13 -674,38 +675,38 @@@ static int apll_event(struct snd_soc_da
        return 0;
  }
  
+ static int aif_event(struct snd_soc_dapm_widget *w,
+               struct snd_kcontrol *kcontrol, int event)
+ {
+       u8 audio_if;
+       audio_if = twl4030_read_reg_cache(w->codec, TWL4030_REG_AUDIO_IF);
+       switch (event) {
+       case SND_SOC_DAPM_PRE_PMU:
+               /* Enable AIF */
+               /* enable the PLL before we use it to clock the DAI */
+               twl4030_apll_enable(w->codec, 1);
+               twl4030_write(w->codec, TWL4030_REG_AUDIO_IF,
+                                               audio_if | TWL4030_AIF_EN);
+               break;
+       case SND_SOC_DAPM_POST_PMD:
+               /* disable the DAI before we stop it's source PLL */
+               twl4030_write(w->codec, TWL4030_REG_AUDIO_IF,
+                                               audio_if &  ~TWL4030_AIF_EN);
+               twl4030_apll_enable(w->codec, 0);
+               break;
+       }
+       return 0;
+ }
  static void headset_ramp(struct snd_soc_codec *codec, int ramp)
  {
        struct snd_soc_device *socdev = codec->socdev;
        struct twl4030_setup_data *setup = socdev->codec_data;
  
        unsigned char hs_gain, hs_pop;
-       struct twl4030_priv *twl4030 = codec->private_data;
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(codec);
        /* Base values for ramp delay calculation: 2^19 - 2^26 */
        unsigned int ramp_base[] = {524288, 1048576, 2097152, 4194304,
                                    8388608, 16777216, 33554432, 67108864};
                /* Headset ramp-up according to the TRM */
                hs_pop |= TWL4030_VMID_EN;
                twl4030_write(codec, TWL4030_REG_HS_POPN_SET, hs_pop);
-               twl4030_write(codec, TWL4030_REG_HS_GAIN_SET, hs_gain);
+               /* Actually write to the register */
+               twl_i2c_write_u8(TWL4030_MODULE_AUDIO_VOICE,
+                                       hs_gain,
+                                       TWL4030_REG_HS_GAIN_SET);
                hs_pop |= TWL4030_RAMP_EN;
                twl4030_write(codec, TWL4030_REG_HS_POPN_SET, hs_pop);
                /* Wait ramp delay time + 1, so the VMID can settle */
  static int headsetlpga_event(struct snd_soc_dapm_widget *w,
                struct snd_kcontrol *kcontrol, int event)
  {
-       struct twl4030_priv *twl4030 = w->codec->private_data;
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(w->codec);
  
        switch (event) {
        case SND_SOC_DAPM_POST_PMU:
  static int headsetrpga_event(struct snd_soc_dapm_widget *w,
                struct snd_kcontrol *kcontrol, int event)
  {
-       struct twl4030_priv *twl4030 = w->codec->private_data;
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(w->codec);
  
        switch (event) {
        case SND_SOC_DAPM_POST_PMU:
@@@ -918,7 -984,7 +985,7 @@@ static int snd_soc_put_twl4030_opmode_e
        struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct twl4030_priv *twl4030 = codec->private_data;
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(codec);
        struct soc_enum *e = (struct soc_enum *)kcontrol->private_value;
        unsigned short val;
        unsigned short mask, bitmask;
@@@ -1036,6 -1102,16 +1103,16 @@@ static const struct soc_enum twl4030_vi
                        ARRAY_SIZE(twl4030_vibradir_texts),
                        twl4030_vibradir_texts);
  
+ /* Digimic Left and right swapping */
+ static const char *twl4030_digimicswap_texts[] = {
+       "Not swapped", "Swapped",
+ };
+ static const struct soc_enum twl4030_digimicswap_enum =
+       SOC_ENUM_SINGLE(TWL4030_REG_MISC_SET_1, 0,
+                       ARRAY_SIZE(twl4030_digimicswap_texts),
+                       twl4030_digimicswap_texts);
  static const struct snd_kcontrol_new twl4030_snd_controls[] = {
        /* Codec operation mode control */
        SOC_ENUM_EXT("Codec Operation Mode", twl4030_op_modes_enum,
  
        SOC_ENUM("Vibra H-bridge mode", twl4030_vibradirmode_enum),
        SOC_ENUM("Vibra H-bridge direction", twl4030_vibradir_enum),
+       SOC_ENUM("Digimic LR Swap", twl4030_digimicswap_enum),
  };
  
  static const struct snd_soc_dapm_widget twl4030_dapm_widgets[] = {
        SND_SOC_DAPM_INPUT("DIGIMIC1"),
  
        /* Outputs */
-       SND_SOC_DAPM_OUTPUT("OUTL"),
-       SND_SOC_DAPM_OUTPUT("OUTR"),
        SND_SOC_DAPM_OUTPUT("EARPIECE"),
        SND_SOC_DAPM_OUTPUT("PREDRIVEL"),
        SND_SOC_DAPM_OUTPUT("PREDRIVER"),
        SND_SOC_DAPM_OUTPUT("HFR"),
        SND_SOC_DAPM_OUTPUT("VIBRA"),
  
+       /* AIF and APLL clocks for running DAIs (including loopback) */
+       SND_SOC_DAPM_OUTPUT("Virtual HiFi OUT"),
+       SND_SOC_DAPM_INPUT("Virtual HiFi IN"),
+       SND_SOC_DAPM_OUTPUT("Virtual Voice OUT"),
        /* DACs */
        SND_SOC_DAPM_DAC("DAC Right1", "Right Front HiFi Playback",
                        SND_SOC_NOPM, 0, 0),
        SND_SOC_DAPM_SUPPLY("APLL Enable", SND_SOC_NOPM, 0, 0, apll_event,
                            SND_SOC_DAPM_PRE_PMU|SND_SOC_DAPM_POST_PMD),
  
-       SND_SOC_DAPM_SUPPLY("AIF Enable", TWL4030_REG_AUDIO_IF, 0, 0, NULL, 0),
+       SND_SOC_DAPM_SUPPLY("AIF Enable", SND_SOC_NOPM, 0, 0, aif_event,
+                           SND_SOC_DAPM_PRE_PMU|SND_SOC_DAPM_POST_PMD),
  
        /* Output MIXER controls */
        /* Earpiece */
@@@ -1334,10 -1416,6 +1417,6 @@@ static const struct snd_soc_dapm_route 
        {"Digital Voice Playback Mixer", NULL, "DAC Voice"},
  
        /* Supply for the digital part (APLL) */
-       {"Digital R1 Playback Mixer", NULL, "APLL Enable"},
-       {"Digital L1 Playback Mixer", NULL, "APLL Enable"},
-       {"Digital R2 Playback Mixer", NULL, "APLL Enable"},
-       {"Digital L2 Playback Mixer", NULL, "APLL Enable"},
        {"Digital Voice Playback Mixer", NULL, "APLL Enable"},
  
        {"Digital R1 Playback Mixer", NULL, "AIF Enable"},
        {"Vibra Mux", "AudioR2", "DAC Right2"},
  
        /* outputs */
-       {"OUTL", NULL, "Analog L2 Playback Mixer"},
-       {"OUTR", NULL, "Analog R2 Playback Mixer"},
+       /* Must be always connected (for AIF and APLL) */
+       {"Virtual HiFi OUT", NULL, "Digital L1 Playback Mixer"},
+       {"Virtual HiFi OUT", NULL, "Digital R1 Playback Mixer"},
+       {"Virtual HiFi OUT", NULL, "Digital L2 Playback Mixer"},
+       {"Virtual HiFi OUT", NULL, "Digital R2 Playback Mixer"},
+       /* Must be always connected (for APLL) */
+       {"Virtual Voice OUT", NULL, "Digital Voice Playback Mixer"},
+       /* Physical outputs */
        {"EARPIECE", NULL, "Earpiece PGA"},
        {"PREDRIVEL", NULL, "PredriveL PGA"},
        {"PREDRIVER", NULL, "PredriveR PGA"},
        {"VIBRA", NULL, "Vibra Route"},
  
        /* Capture path */
+       /* Must be always connected (for AIF and APLL) */
+       {"ADC Virtual Left1", NULL, "Virtual HiFi IN"},
+       {"ADC Virtual Right1", NULL, "Virtual HiFi IN"},
+       {"ADC Virtual Left2", NULL, "Virtual HiFi IN"},
+       {"ADC Virtual Right2", NULL, "Virtual HiFi IN"},
+       /* Physical inputs */
        {"Analog Left", "Main Mic Capture Switch", "MAINMIC"},
        {"Analog Left", "Headset Mic Capture Switch", "HSMIC"},
        {"Analog Left", "AUXL Capture Switch", "AUXL"},
        {"ADC Virtual Left2", NULL, "TX2 Capture Route"},
        {"ADC Virtual Right2", NULL, "TX2 Capture Route"},
  
-       {"ADC Virtual Left1", NULL, "APLL Enable"},
-       {"ADC Virtual Right1", NULL, "APLL Enable"},
-       {"ADC Virtual Left2", NULL, "APLL Enable"},
-       {"ADC Virtual Right2", NULL, "APLL Enable"},
        {"ADC Virtual Left1", NULL, "AIF Enable"},
        {"ADC Virtual Right1", NULL, "AIF Enable"},
        {"ADC Virtual Left2", NULL, "AIF Enable"},
@@@ -1588,7 -1673,7 +1674,7 @@@ static int twl4030_startup(struct snd_p
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct twl4030_priv *twl4030 = codec->private_data;
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(codec);
  
        if (twl4030->master_substream) {
                twl4030->slave_substream = substream;
@@@ -1619,7 -1704,7 +1705,7 @@@ static void twl4030_shutdown(struct snd
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct twl4030_priv *twl4030 = codec->private_data;
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(codec);
  
        if (twl4030->master_substream == substream)
                twl4030->master_substream = twl4030->slave_substream;
@@@ -1645,7 -1730,7 +1731,7 @@@ static int twl4030_hw_params(struct snd
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct twl4030_priv *twl4030 = codec->private_data;
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(codec);
        u8 mode, old_mode, format, old_format;
  
         /* If the substream has 4 channel, do the necessary setup */
@@@ -1765,7 -1850,7 +1851,7 @@@ static int twl4030_set_dai_sysclk(struc
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct twl4030_priv *twl4030 = codec->private_data;
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(codec);
  
        switch (freq) {
        case 19200000:
@@@ -1880,7 -1965,7 +1966,7 @@@ static int twl4030_voice_startup(struc
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct twl4030_priv *twl4030 = codec->private_data;
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(codec);
        u8 mode;
  
        /* If the system master clock is not 26MHz, the voice PCM interface is
@@@ -1962,7 -2047,7 +2048,7 @@@ static int twl4030_voice_set_dai_sysclk
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct twl4030_priv *twl4030 = codec->private_data;
+       struct twl4030_priv *twl4030 = snd_soc_codec_get_drvdata(codec);
  
        if (freq != 26000000) {
                dev_err(codec->dev, "Unsupported APLL mclk: %u, the Voice"
@@@ -2108,7 -2193,6 +2194,6 @@@ static int twl4030_soc_resume(struct pl
        struct snd_soc_codec *codec = socdev->card->codec;
  
        twl4030_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       twl4030_set_bias_level(codec, codec->suspend_bias_level);
        return 0;
  }
  
@@@ -2125,7 -2209,7 +2210,7 @@@ static int twl4030_soc_probe(struct pla
        BUG_ON(!twl4030_codec);
  
        codec = twl4030_codec;
-       twl4030 = codec->private_data;
+       twl4030 = snd_soc_codec_get_drvdata(codec);
        socdev->card->codec = codec;
  
        /* Configuration for headset ramp delay from setup data */
@@@ -2188,7 -2272,7 +2273,7 @@@ static int __devinit twl4030_codec_prob
        }
  
        codec = &twl4030->codec;
-       codec->private_data = twl4030;
+       snd_soc_codec_set_drvdata(codec, twl4030);
        codec->dev = &pdev->dev;
        twl4030_dai[0].dev = &pdev->dev;
        twl4030_dai[1].dev = &pdev->dev;
@@@ -15,7 -15,6 +15,7 @@@
  
  #include <linux/module.h>
  #include <linux/delay.h>
 +#include <linux/slab.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
  #include <sound/soc.h>
@@@ -175,7 -174,7 +175,7 @@@ static int uda134x_startup(struct snd_p
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct uda134x_priv *uda134x = codec->private_data;
+       struct uda134x_priv *uda134x = snd_soc_codec_get_drvdata(codec);
        struct snd_pcm_runtime *master_runtime;
  
        if (uda134x->master_substream) {
@@@ -208,7 -207,7 +208,7 @@@ static void uda134x_shutdown(struct snd
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct uda134x_priv *uda134x = codec->private_data;
+       struct uda134x_priv *uda134x = snd_soc_codec_get_drvdata(codec);
  
        if (uda134x->master_substream == substream)
                uda134x->master_substream = uda134x->slave_substream;
@@@ -223,7 -222,7 +223,7 @@@ static int uda134x_hw_params(struct snd
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct uda134x_priv *uda134x = codec->private_data;
+       struct uda134x_priv *uda134x = snd_soc_codec_get_drvdata(codec);
        u8 hw_params;
  
        if (substream == uda134x->slave_substream) {
@@@ -295,7 -294,7 +295,7 @@@ static int uda134x_set_dai_sysclk(struc
                                  int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct uda134x_priv *uda134x = codec->private_data;
+       struct uda134x_priv *uda134x = snd_soc_codec_get_drvdata(codec);
  
        pr_debug("%s clk_id: %d, freq: %u, dir: %d\n", __func__,
                 clk_id, freq, dir);
@@@ -317,7 -316,7 +317,7 @@@ static int uda134x_set_dai_fmt(struct s
                               unsigned int fmt)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct uda134x_priv *uda134x = codec->private_data;
+       struct uda134x_priv *uda134x = snd_soc_codec_get_drvdata(codec);
  
        pr_debug("%s fmt: %08X\n", __func__, fmt);
  
@@@ -432,6 -431,14 +432,14 @@@ SOC_ENUM("PCM Playback De-emphasis", ud
  SOC_SINGLE("DC Filter Enable Switch", UDA134X_STATUS0, 0, 1, 0),
  };
  
+ static const struct snd_kcontrol_new uda1345_snd_controls[] = {
+ SOC_SINGLE("Master Playback Volume", UDA134X_DATA000, 0, 0x3F, 1),
+ SOC_ENUM("PCM Playback De-emphasis", uda134x_mixer_enum[1]),
+ SOC_SINGLE("DC Filter Enable Switch", UDA134X_STATUS0, 0, 1, 0),
+ };
  static struct snd_soc_dai_ops uda134x_dai_ops = {
        .startup        = uda134x_startup,
        .shutdown       = uda134x_shutdown,
@@@ -487,6 -494,7 +495,7 @@@ static int uda134x_soc_probe(struct pla
        case UDA134X_UDA1340:
        case UDA134X_UDA1341:
        case UDA134X_UDA1344:
+       case UDA134X_UDA1345:
                break;
        default:
                printk(KERN_ERR "UDA134X SoC codec: "
        uda134x = kzalloc(sizeof(struct uda134x_priv), GFP_KERNEL);
        if (uda134x == NULL)
                goto priv_err;
-       codec->private_data = uda134x;
+       snd_soc_codec_set_drvdata(codec, uda134x);
  
        codec->reg_cache = kmemdup(uda134x_reg, sizeof(uda134x_reg),
                                   GFP_KERNEL);
                ret = snd_soc_add_controls(codec, uda1341_snd_controls,
                                        ARRAY_SIZE(uda1341_snd_controls));
        break;
+       case UDA134X_UDA1345:
+               ret = snd_soc_add_controls(codec, uda1345_snd_controls,
+                                       ARRAY_SIZE(uda1345_snd_controls));
+       break;
        default:
                printk(KERN_ERR "%s unknown codec type: %d",
                        __func__, pd->model);
  pcm_err:
        kfree(codec->reg_cache);
  reg_err:
-       kfree(codec->private_data);
+       kfree(snd_soc_codec_get_drvdata(codec));
  priv_err:
        kfree(codec);
        return ret;
@@@ -586,7 -598,7 +599,7 @@@ static int uda134x_soc_remove(struct pl
        snd_soc_free_pcms(socdev);
        snd_soc_dapm_free(socdev);
  
-       kfree(codec->private_data);
+       kfree(snd_soc_codec_get_drvdata(codec));
        kfree(codec->reg_cache);
        kfree(codec);
  
@@@ -13,7 -13,6 +13,7 @@@
  #include <linux/module.h>
  #include <linux/moduleparam.h>
  #include <linux/init.h>
 +#include <linux/slab.h>
  #include <linux/delay.h>
  #include <linux/pm.h>
  #include <linux/platform_device.h>
@@@ -55,6 -54,7 +55,7 @@@ struct wm8350_output 
  struct wm8350_jack_data {
        struct snd_soc_jack *jack;
        int report;
+       int short_report;
  };
  
  struct wm8350_data {
@@@ -63,6 -63,7 +64,7 @@@
        struct wm8350_output out2;
        struct wm8350_jack_data hpl;
        struct wm8350_jack_data hpr;
+       struct wm8350_jack_data mic;
        struct regulator_bulk_data supplies[ARRAY_SIZE(supply_names)];
        int fll_freq_out;
        int fll_freq_in;
@@@ -94,7 -95,7 +96,7 @@@ static int wm8350_codec_write(struct sn
   */
  static inline int wm8350_out1_ramp_step(struct snd_soc_codec *codec)
  {
-       struct wm8350_data *wm8350_data = codec->private_data;
+       struct wm8350_data *wm8350_data = snd_soc_codec_get_drvdata(codec);
        struct wm8350_output *out1 = &wm8350_data->out1;
        struct wm8350 *wm8350 = codec->control_data;
        int left_complete = 0, right_complete = 0;
   */
  static inline int wm8350_out2_ramp_step(struct snd_soc_codec *codec)
  {
-       struct wm8350_data *wm8350_data = codec->private_data;
+       struct wm8350_data *wm8350_data = snd_soc_codec_get_drvdata(codec);
        struct wm8350_output *out2 = &wm8350_data->out2;
        struct wm8350 *wm8350 = codec->control_data;
        int left_complete = 0, right_complete = 0;
@@@ -230,7 -231,7 +232,7 @@@ static void wm8350_pga_work(struct work
  {
        struct snd_soc_codec *codec =
            container_of(work, struct snd_soc_codec, delayed_work.work);
-       struct wm8350_data *wm8350_data = codec->private_data;
+       struct wm8350_data *wm8350_data = snd_soc_codec_get_drvdata(codec);
        struct wm8350_output *out1 = &wm8350_data->out1,
            *out2 = &wm8350_data->out2;
        int i, out1_complete, out2_complete;
@@@ -277,7 -278,7 +279,7 @@@ static int pga_event(struct snd_soc_dap
                     struct snd_kcontrol *kcontrol, int event)
  {
        struct snd_soc_codec *codec = w->codec;
-       struct wm8350_data *wm8350_data = codec->private_data;
+       struct wm8350_data *wm8350_data = snd_soc_codec_get_drvdata(codec);
        struct wm8350_output *out;
  
        switch (w->shift) {
@@@ -322,7 -323,7 +324,7 @@@ static int wm8350_put_volsw_2r_vu(struc
                                  struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8350_data *wm8350_priv = codec->private_data;
+       struct wm8350_data *wm8350_priv = snd_soc_codec_get_drvdata(codec);
        struct wm8350_output *out = NULL;
        struct soc_mixer_control *mc =
                (struct soc_mixer_control *)kcontrol->private_value;
@@@ -365,7 -366,7 +367,7 @@@ static int wm8350_get_volsw_2r(struct s
                               struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8350_data *wm8350_priv = codec->private_data;
+       struct wm8350_data *wm8350_priv = snd_soc_codec_get_drvdata(codec);
        struct wm8350_output *out1 = &wm8350_priv->out1;
        struct wm8350_output *out2 = &wm8350_priv->out2;
        struct soc_mixer_control *mc =
@@@ -1107,7 -1108,7 +1109,7 @@@ static int wm8350_set_fll(struct snd_so
  {
        struct snd_soc_codec *codec = codec_dai->codec;
        struct wm8350 *wm8350 = codec->control_data;
-       struct wm8350_data *priv = codec->private_data;
+       struct wm8350_data *priv = snd_soc_codec_get_drvdata(codec);
        struct _fll_div fll_div;
        int ret = 0;
        u16 fll_1, fll_4;
@@@ -1159,7 -1160,7 +1161,7 @@@ static int wm8350_set_bias_level(struc
                                 enum snd_soc_bias_level level)
  {
        struct wm8350 *wm8350 = codec->control_data;
-       struct wm8350_data *priv = codec->private_data;
+       struct wm8350_data *priv = snd_soc_codec_get_drvdata(codec);
        struct wm8350_audio_platform_data *platform =
                wm8350->codec.platform_data;
        u16 pm1;
@@@ -1335,9 -1336,6 +1337,6 @@@ static int wm8350_resume(struct platfor
  
        wm8350_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
  
-       if (codec->suspend_bias_level == SND_SOC_BIAS_ON)
-               wm8350_set_bias_level(codec, SND_SOC_BIAS_ON);
        return 0;
  }
  
@@@ -1392,12 -1390,13 +1391,13 @@@ static irqreturn_t wm8350_hp_jack_handl
   * @jack:   jack to report detection events on
   * @report: value to report
   *
-  * Enables the headphone jack detection of the WM8350.
+  * Enables the headphone jack detection of the WM8350.  If no report
+  * is specified then detection is disabled.
   */
  int wm8350_hp_jack_detect(struct snd_soc_codec *codec, enum wm8350_jack which,
                          struct snd_soc_jack *jack, int report)
  {
-       struct wm8350_data *priv = codec->private_data;
+       struct wm8350_data *priv = snd_soc_codec_get_drvdata(codec);
        struct wm8350 *wm8350 = codec->control_data;
        int irq;
        int ena;
                return -EINVAL;
        }
  
-       wm8350_set_bits(wm8350, WM8350_POWER_MGMT_4, WM8350_TOCLK_ENA);
-       wm8350_set_bits(wm8350, WM8350_JACK_DETECT, ena);
+       if (report) {
+               wm8350_set_bits(wm8350, WM8350_POWER_MGMT_4, WM8350_TOCLK_ENA);
+               wm8350_set_bits(wm8350, WM8350_JACK_DETECT, ena);
+       } else {
+               wm8350_clear_bits(wm8350, WM8350_JACK_DETECT, ena);
+       }
  
        /* Sync status */
        wm8350_hp_jack_handler(irq + wm8350->irq_base, priv);
  }
  EXPORT_SYMBOL_GPL(wm8350_hp_jack_detect);
  
+ static irqreturn_t wm8350_mic_handler(int irq, void *data)
+ {
+       struct wm8350_data *priv = data;
+       struct wm8350 *wm8350 = priv->codec.control_data;
+       u16 reg;
+       int report = 0;
+       reg = wm8350_reg_read(wm8350, WM8350_JACK_PIN_STATUS);
+       if (reg & WM8350_JACK_MICSCD_LVL)
+               report |= priv->mic.short_report;
+       if (reg & WM8350_JACK_MICSD_LVL)
+               report |= priv->mic.report;
+       snd_soc_jack_report(priv->mic.jack, report,
+                           priv->mic.report | priv->mic.short_report);
+       return IRQ_HANDLED;
+ }
+ /**
+  * wm8350_mic_jack_detect - Enable microphone jack detection.
+  *
+  * @codec:         WM8350 codec
+  * @jack:          jack to report detection events on
+  * @detect_report: value to report when presence detected
+  * @short_report:  value to report when microphone short detected
+  *
+  * Enables the microphone jack detection of the WM8350.  If both reports
+  * are specified as zero then detection is disabled.
+  */
+ int wm8350_mic_jack_detect(struct snd_soc_codec *codec,
+                          struct snd_soc_jack *jack,
+                          int detect_report, int short_report)
+ {
+       struct wm8350_data *priv = snd_soc_codec_get_drvdata(codec);
+       struct wm8350 *wm8350 = codec->control_data;
+       priv->mic.jack = jack;
+       priv->mic.report = detect_report;
+       priv->mic.short_report = short_report;
+       if (detect_report || short_report) {
+               wm8350_set_bits(wm8350, WM8350_POWER_MGMT_4, WM8350_TOCLK_ENA);
+               wm8350_set_bits(wm8350, WM8350_POWER_MGMT_1,
+                               WM8350_MIC_DET_ENA);
+       } else {
+               wm8350_clear_bits(wm8350, WM8350_POWER_MGMT_1,
+                                 WM8350_MIC_DET_ENA);
+       }
+       return 0;
+ }
+ EXPORT_SYMBOL_GPL(wm8350_mic_jack_detect);
  static struct snd_soc_codec *wm8350_codec;
  
  static int wm8350_probe(struct platform_device *pdev)
        socdev->card->codec = wm8350_codec;
        codec = socdev->card->codec;
        wm8350 = codec->control_data;
-       priv = codec->private_data;
+       priv = snd_soc_codec_get_drvdata(codec);
  
        /* Enable the codec */
        wm8350_set_bits(wm8350, WM8350_POWER_MGMT_5, WM8350_CODEC_ENA);
        wm8350_register_irq(wm8350, WM8350_IRQ_CODEC_JCK_DET_R,
                            wm8350_hp_jack_handler, 0, "Right jack detect",
                            priv);
+       wm8350_register_irq(wm8350, WM8350_IRQ_CODEC_MICSCD,
+                           wm8350_mic_handler, 0, "Microphone short", priv);
+       wm8350_register_irq(wm8350, WM8350_IRQ_CODEC_MICD,
+                           wm8350_mic_handler, 0, "Microphone detect", priv);
  
        ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
        if (ret < 0) {
@@@ -1515,18 -1576,21 +1577,21 @@@ static int wm8350_remove(struct platfor
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
        struct wm8350 *wm8350 = codec->control_data;
-       struct wm8350_data *priv = codec->private_data;
+       struct wm8350_data *priv = snd_soc_codec_get_drvdata(codec);
        int ret;
  
        wm8350_clear_bits(wm8350, WM8350_JACK_DETECT,
                          WM8350_JDL_ENA | WM8350_JDR_ENA);
        wm8350_clear_bits(wm8350, WM8350_POWER_MGMT_4, WM8350_TOCLK_ENA);
  
+       wm8350_free_irq(wm8350, WM8350_IRQ_CODEC_MICD, priv);
+       wm8350_free_irq(wm8350, WM8350_IRQ_CODEC_MICSCD, priv);
        wm8350_free_irq(wm8350, WM8350_IRQ_CODEC_JCK_DET_L, priv);
        wm8350_free_irq(wm8350, WM8350_IRQ_CODEC_JCK_DET_R, priv);
  
        priv->hpl.jack = NULL;
        priv->hpr.jack = NULL;
+       priv->mic.jack = NULL;
  
        /* cancel any work waiting to be queued. */
        ret = cancel_delayed_work(&codec->delayed_work);
@@@ -1631,7 -1695,7 +1696,7 @@@ static __devinit int wm8350_codec_probe
        codec->dai = &wm8350_dai;
        codec->num_dai = 1;
        codec->reg_cache_size = WM8350_MAX_REGISTER;
-       codec->private_data = priv;
+       snd_soc_codec_set_drvdata(codec, priv);
        codec->control_data = wm8350;
  
        /* Put the codec into reset if it wasn't already */
@@@ -1663,7 -1727,7 +1728,7 @@@ static int __devexit wm8350_codec_remov
  {
        struct wm8350 *wm8350 = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = wm8350->codec.codec;
-       struct wm8350_data *priv = codec->private_data;
+       struct wm8350_data *priv = snd_soc_codec_get_drvdata(codec);
  
        snd_soc_unregister_dai(&wm8350_dai);
        snd_soc_unregister_codec(codec);
@@@ -14,7 -14,6 +14,7 @@@
  #include <linux/module.h>
  #include <linux/moduleparam.h>
  #include <linux/kernel.h>
 +#include <linux/slab.h>
  #include <linux/init.h>
  #include <linux/delay.h>
  #include <linux/pm.h>
@@@ -77,7 -76,7 +77,7 @@@ struct wm8400_priv 
  static inline unsigned int wm8400_read(struct snd_soc_codec *codec,
                                       unsigned int reg)
  {
-       struct wm8400_priv *wm8400 = codec->private_data;
+       struct wm8400_priv *wm8400 = snd_soc_codec_get_drvdata(codec);
  
        if (reg == WM8400_INTDRIVBITS)
                return wm8400->fake_register;
@@@ -91,7 -90,7 +91,7 @@@
  static int wm8400_write(struct snd_soc_codec *codec, unsigned int reg,
        unsigned int value)
  {
-       struct wm8400_priv *wm8400 = codec->private_data;
+       struct wm8400_priv *wm8400 = snd_soc_codec_get_drvdata(codec);
  
        if (reg == WM8400_INTDRIVBITS) {
                wm8400->fake_register = value;
  
  static void wm8400_codec_reset(struct snd_soc_codec *codec)
  {
-       struct wm8400_priv *wm8400 = codec->private_data;
+       struct wm8400_priv *wm8400 = snd_soc_codec_get_drvdata(codec);
  
        wm8400_reset_codec_reg_cache(wm8400->wm8400);
  }
@@@ -926,7 -925,7 +926,7 @@@ static int wm8400_set_dai_sysclk(struc
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8400_priv *wm8400 = codec->private_data;
+       struct wm8400_priv *wm8400 = snd_soc_codec_get_drvdata(codec);
  
        wm8400->sysclk = freq;
        return 0;
@@@ -1015,7 -1014,7 +1015,7 @@@ static int wm8400_set_dai_pll(struct sn
                              unsigned int freq_out)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8400_priv *wm8400 = codec->private_data;
+       struct wm8400_priv *wm8400 = snd_soc_codec_get_drvdata(codec);
        struct fll_factors factors;
        int ret;
        u16 reg;
@@@ -1204,7 -1203,7 +1204,7 @@@ static int wm8400_mute(struct snd_soc_d
  static int wm8400_set_bias_level(struct snd_soc_codec *codec,
                                 enum snd_soc_bias_level level)
  {
-       struct wm8400_priv *wm8400 = codec->private_data;
+       struct wm8400_priv *wm8400 = snd_soc_codec_get_drvdata(codec);
        u16 val;
        int ret;
  
@@@ -1467,7 -1466,7 +1467,7 @@@ static int wm8400_codec_probe(struct pl
                return -ENOMEM;
  
        codec = &priv->codec;
-       codec->private_data = priv;
+       snd_soc_codec_set_drvdata(codec, priv);
        codec->control_data = dev_get_drvdata(&dev->dev);
        priv->wm8400 = dev_get_drvdata(&dev->dev);
  
@@@ -1530,7 -1529,7 +1530,7 @@@ err
  
  static int __exit wm8400_codec_remove(struct platform_device *dev)
  {
-       struct wm8400_priv *priv = wm8400_codec->private_data;
+       struct wm8400_priv *priv = snd_soc_codec_get_drvdata(wm8400_codec);
        u16 reg;
  
        snd_soc_unregister_dai(&wm8400_dai);
@@@ -19,7 -19,6 +19,7 @@@
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
  #include <linux/spi/spi.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -557,7 -556,7 +557,7 @@@ static int wm8510_resume(struct platfor
                codec->hw_write(codec->control_data, data, 2);
        }
        wm8510_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       wm8510_set_bias_level(codec, codec->suspend_bias_level);
        return 0;
  }
  
@@@ -19,7 -19,6 +19,7 @@@
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
  #include <linux/regulator/consumer.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -138,7 -137,7 +138,7 @@@ static int wm8523_startup(struct snd_pc
                          struct snd_soc_dai *dai)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8523_priv *wm8523 = codec->private_data;
+       struct wm8523_priv *wm8523 = snd_soc_codec_get_drvdata(codec);
  
        /* The set of sample rates that can be supported depends on the
         * MCLK supplied to the CODEC - enforce this.
@@@ -164,7 -163,7 +164,7 @@@ static int wm8523_hw_params(struct snd_
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8523_priv *wm8523 = codec->private_data;
+       struct wm8523_priv *wm8523 = snd_soc_codec_get_drvdata(codec);
        int i;
        u16 aifctrl1 = snd_soc_read(codec, WM8523_AIF_CTRL1);
        u16 aifctrl2 = snd_soc_read(codec, WM8523_AIF_CTRL2);
@@@ -211,7 -210,7 +211,7 @@@ static int wm8523_set_dai_sysclk(struc
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8523_priv *wm8523 = codec->private_data;
+       struct wm8523_priv *wm8523 = snd_soc_codec_get_drvdata(codec);
        unsigned int val;
        int i;
  
@@@ -318,7 -317,7 +318,7 @@@ static int wm8523_set_dai_fmt(struct sn
  static int wm8523_set_bias_level(struct snd_soc_codec *codec,
                                 enum snd_soc_bias_level level)
  {
-       struct wm8523_priv *wm8523 = codec->private_data;
+       struct wm8523_priv *wm8523 = snd_soc_codec_get_drvdata(codec);
        int ret, i;
  
        switch (level) {
@@@ -489,7 -488,7 +489,7 @@@ static int wm8523_register(struct wm852
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8523;
+       snd_soc_codec_set_drvdata(codec, wm8523);
        codec->name = "WM8523";
        codec->owner = THIS_MODULE;
        codec->bias_level = SND_SOC_BIAS_OFF;
@@@ -25,7 -25,6 +25,7 @@@
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
  #include <linux/regulator/consumer.h>
 +#include <linux/slab.h>
  
  #include <sound/core.h>
  #include <sound/pcm.h>
@@@ -412,7 -411,7 +412,7 @@@ static int wm8580_set_dai_pll(struct sn
  {
        int offset;
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8580_priv *wm8580 = codec->private_data;
+       struct wm8580_priv *wm8580 = snd_soc_codec_get_drvdata(codec);
        struct pll_state *state;
        struct _pll_div pll_div;
        unsigned int reg;
@@@ -840,7 -839,7 +840,7 @@@ static int wm8580_register(struct wm858
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8580;
+       snd_soc_codec_set_drvdata(codec, wm8580);
        codec->name = "WM8580";
        codec->owner = THIS_MODULE;
        codec->bias_level = SND_SOC_BIAS_OFF;
@@@ -20,7 -20,6 +20,7 @@@
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
  #include <linux/spi/spi.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -163,7 -162,7 +163,7 @@@ static int wm8711_hw_params(struct snd_
        struct snd_soc_dai *dai)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8711_priv *wm8711 = codec->private_data;
+       struct wm8711_priv *wm8711 = snd_soc_codec_get_drvdata(codec);
        u16 iface = snd_soc_read(codec, WM8711_IFACE) & 0xfffc;
        int i = get_coeff(wm8711->sysclk, params_rate(params));
        u16 srate = (coeff_div[i].sr << 2) |
@@@ -227,7 -226,7 +227,7 @@@ static int wm8711_set_dai_sysclk(struc
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8711_priv *wm8711 = codec->private_data;
+       struct wm8711_priv *wm8711 = snd_soc_codec_get_drvdata(codec);
  
        switch (freq) {
        case 11289600:
@@@ -376,7 -375,7 +376,7 @@@ static int wm8711_resume(struct platfor
                codec->hw_write(codec->control_data, data, 2);
        }
        wm8711_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       wm8711_set_bias_level(codec, codec->suspend_bias_level);
        return 0;
  }
  
@@@ -446,7 -445,7 +446,7 @@@ static int wm8711_register(struct wm871
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8711;
+       snd_soc_codec_set_drvdata(codec, wm8711);
        codec->name = "WM8711";
        codec->owner = THIS_MODULE;
        codec->bias_level = SND_SOC_BIAS_OFF;
@@@ -18,7 -18,6 +18,7 @@@
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
  #include <linux/spi/spi.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -238,7 -237,7 +238,7 @@@ static int wm8728_resume(struct platfor
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
  
-       wm8728_set_bias_level(codec, codec->suspend_bias_level);
+       wm8728_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
  
        return 0;
  }
@@@ -18,7 -18,6 +18,7 @@@
  #include <linux/delay.h>
  #include <linux/pm.h>
  #include <linux/i2c.h>
 +#include <linux/slab.h>
  #include <linux/platform_device.h>
  #include <linux/regulator/consumer.h>
  #include <linux/spi/spi.h>
@@@ -225,7 -224,7 +225,7 @@@ static int wm8731_hw_params(struct snd_
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8731_priv *wm8731 = codec->private_data;
+       struct wm8731_priv *wm8731 = snd_soc_codec_get_drvdata(codec);
        u16 iface = snd_soc_read(codec, WM8731_IFACE) & 0xfff3;
        int i = get_coeff(wm8731->sysclk, params_rate(params));
        u16 srate = (coeff_div[i].sr << 2) |
@@@ -292,7 -291,7 +292,7 @@@ static int wm8731_set_dai_sysclk(struc
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8731_priv *wm8731 = codec->private_data;
+       struct wm8731_priv *wm8731 = snd_soc_codec_get_drvdata(codec);
  
        switch (freq) {
        case 11289600:
@@@ -369,6 -368,10 +369,10 @@@ static int wm8731_set_dai_fmt(struct sn
  static int wm8731_set_bias_level(struct snd_soc_codec *codec,
                                 enum snd_soc_bias_level level)
  {
+       struct wm8731_priv *wm8731 = snd_soc_codec_get_drvdata(codec);
+       int i, ret;
+       u8 data[2];
+       u16 *cache = codec->reg_cache;
        u16 reg;
  
        switch (level) {
        case SND_SOC_BIAS_PREPARE:
                break;
        case SND_SOC_BIAS_STANDBY:
+               if (codec->bias_level == SND_SOC_BIAS_OFF) {
+                       ret = regulator_bulk_enable(ARRAY_SIZE(wm8731->supplies),
+                                                   wm8731->supplies);
+                       if (ret != 0)
+                               return ret;
+                       /* Sync reg_cache with the hardware */
+                       for (i = 0; i < ARRAY_SIZE(wm8731_reg); i++) {
+                               if (cache[i] == wm8731_reg[i])
+                                       continue;
+                               data[0] = (i << 1) | ((cache[i] >> 8)
+                                                     & 0x0001);
+                               data[1] = cache[i] & 0x00ff;
+                               codec->hw_write(codec->control_data, data, 2);
+                       }
+               }
                /* Clear PWROFF, gate CLKOUT, everything else as-is */
                reg = snd_soc_read(codec, WM8731_PWR) & 0xff7f;
                snd_soc_write(codec, WM8731_PWR, reg | 0x0040);
        case SND_SOC_BIAS_OFF:
                snd_soc_write(codec, WM8731_ACTIVE, 0x0);
                snd_soc_write(codec, WM8731_PWR, 0xffff);
+               regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies),
+                                      wm8731->supplies);
                break;
        }
        codec->bias_level = level;
        return 0;
  }
  
- #define WM8731_RATES (SNDRV_PCM_RATE_8000 | SNDRV_PCM_RATE_11025 |\
-               SNDRV_PCM_RATE_16000 | SNDRV_PCM_RATE_22050 |\
-               SNDRV_PCM_RATE_32000 | SNDRV_PCM_RATE_44100 |\
-               SNDRV_PCM_RATE_48000 | SNDRV_PCM_RATE_88200 |\
-               SNDRV_PCM_RATE_96000)
+ #define WM8731_RATES SNDRV_PCM_RATE_8000_96000
  
  #define WM8731_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE |\
        SNDRV_PCM_FMTBIT_S24_LE)
@@@ -432,12 -451,9 +452,9 @@@ static int wm8731_suspend(struct platfo
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8731_priv *wm8731 = codec->private_data;
  
-       snd_soc_write(codec, WM8731_ACTIVE, 0x0);
        wm8731_set_bias_level(codec, SND_SOC_BIAS_OFF);
-       regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies),
-                              wm8731->supplies);
        return 0;
  }
  
@@@ -445,27 -461,8 +462,8 @@@ static int wm8731_resume(struct platfor
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8731_priv *wm8731 = codec->private_data;
-       int i, ret;
-       u8 data[2];
-       u16 *cache = codec->reg_cache;
  
-       ret = regulator_bulk_enable(ARRAY_SIZE(wm8731->supplies),
-                                   wm8731->supplies);
-       if (ret != 0)
-               return ret;
-       /* Sync reg_cache with the hardware */
-       for (i = 0; i < ARRAY_SIZE(wm8731_reg); i++) {
-               if (cache[i] == wm8731_reg[i])
-                       continue;
-               data[0] = (i << 1) | ((cache[i] >> 8) & 0x0001);
-               data[1] = cache[i] & 0x00ff;
-               codec->hw_write(codec->control_data, data, 2);
-       }
        wm8731_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       wm8731_set_bias_level(codec, codec->suspend_bias_level);
  
        return 0;
  }
@@@ -540,7 -537,7 +538,7 @@@ static int wm8731_register(struct wm873
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8731;
+       snd_soc_codec_set_drvdata(codec, wm8731);
        codec->name = "WM8731";
        codec->owner = THIS_MODULE;
        codec->bias_level = SND_SOC_BIAS_OFF;
                goto err_codec;
        }
  
+       /* Regulators will have been enabled by bias management */
+       regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);
        return 0;
  
  err_codec:
@@@ -627,7 -627,6 +628,6 @@@ static void wm8731_unregister(struct wm
        wm8731_set_bias_level(&wm8731->codec, SND_SOC_BIAS_OFF);
        snd_soc_unregister_dai(&wm8731_dai);
        snd_soc_unregister_codec(&wm8731->codec);
-       regulator_bulk_disable(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);
        regulator_bulk_free(ARRAY_SIZE(wm8731->supplies), wm8731->supplies);
        kfree(wm8731);
        wm8731_codec = NULL;
@@@ -708,7 -707,7 +708,7 @@@ MODULE_DEVICE_TABLE(i2c, wm8731_i2c_id)
  
  static struct i2c_driver wm8731_i2c_driver = {
        .driver = {
-               .name = "WM8731 I2C Codec",
+               .name = "wm8731",
                .owner = THIS_MODULE,
        },
        .probe =    wm8731_i2c_probe,
@@@ -20,7 -20,6 +20,7 @@@
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
  #include <linux/spi/spi.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
  
  #include "wm8750.h"
  
- #define WM8750_VERSION "0.12"
- /* codec private data */
- struct wm8750_priv {
-       unsigned int sysclk;
- };
  /*
   * wm8750 register cache
   * We can't read the WM8750 register space when we
@@@ -56,6 -48,13 +49,13 @@@ static const u16 wm8750_reg[] = 
        0x0079, 0x0079, 0x0079,          /* 40 */
  };
  
+ /* codec private data */
+ struct wm8750_priv {
+       unsigned int sysclk;
+       struct snd_soc_codec codec;
+       u16 reg_cache[ARRAY_SIZE(wm8750_reg)];
+ };
  #define wm8750_reset(c)       snd_soc_write(c, WM8750_RESET, 0)
  
  /*
@@@ -483,7 -482,7 +483,7 @@@ static int wm8750_set_dai_sysclk(struc
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8750_priv *wm8750 = codec->private_data;
+       struct wm8750_priv *wm8750 = snd_soc_codec_get_drvdata(codec);
  
        switch (freq) {
        case 11289600:
@@@ -562,7 -561,7 +562,7 @@@ static int wm8750_pcm_hw_params(struct 
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8750_priv *wm8750 = codec->private_data;
+       struct wm8750_priv *wm8750 = snd_soc_codec_get_drvdata(codec);
        u16 iface = snd_soc_read(codec, WM8750_IFACE) & 0x1f3;
        u16 srate = snd_soc_read(codec, WM8750_SRATE) & 0x1c0;
        int coeff = get_coeff(wm8750->sysclk, params_rate(params));
@@@ -614,10 -613,16 +614,16 @@@ static int wm8750_set_bias_level(struc
                snd_soc_write(codec, WM8750_PWR1, pwr_reg | 0x00c0);
                break;
        case SND_SOC_BIAS_PREPARE:
-               /* set vmid to 5k for quick power up */
-               snd_soc_write(codec, WM8750_PWR1, pwr_reg | 0x01c1);
                break;
        case SND_SOC_BIAS_STANDBY:
+               if (codec->bias_level == SND_SOC_BIAS_OFF) {
+                       /* Set VMID to 5k */
+                       snd_soc_write(codec, WM8750_PWR1, pwr_reg | 0x01c1);
+                       /* ...and ramp */
+                       msleep(1000);
+               }
                /* mute dac and set vmid to 500k, enable VREF */
                snd_soc_write(codec, WM8750_PWR1, pwr_reg | 0x0141);
                break;
@@@ -661,13 -666,6 +667,6 @@@ struct snd_soc_dai wm8750_dai = 
  };
  EXPORT_SYMBOL_GPL(wm8750_dai);
  
- static void wm8750_work(struct work_struct *work)
- {
-       struct snd_soc_codec *codec =
-               container_of(work, struct snd_soc_codec, delayed_work.work);
-       wm8750_set_bias_level(codec, codec->bias_level);
- }
  static int wm8750_suspend(struct platform_device *pdev, pm_message_t state)
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
@@@ -696,36 -694,92 +695,92 @@@ static int wm8750_resume(struct platfor
  
        wm8750_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
  
-       /* charge wm8750 caps */
-       if (codec->suspend_bias_level == SND_SOC_BIAS_ON) {
-               wm8750_set_bias_level(codec, SND_SOC_BIAS_PREPARE);
-               codec->bias_level = SND_SOC_BIAS_ON;
-               schedule_delayed_work(&codec->delayed_work,
-                                       msecs_to_jiffies(1000));
+       return 0;
+ }
+ static struct snd_soc_codec *wm8750_codec;
+ static int wm8750_probe(struct platform_device *pdev)
+ {
+       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
+       struct snd_soc_codec *codec;
+       int ret = 0;
+       if (!wm8750_codec) {
+               dev_err(&pdev->dev, "WM8750 codec not yet registered\n");
+               return -EINVAL;
+       }
+       socdev->card->codec = wm8750_codec;
+       codec = wm8750_codec;
+       /* register pcms */
+       ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
+       if (ret < 0) {
+               printk(KERN_ERR "wm8750: failed to create pcms\n");
+               goto err;
        }
  
+       snd_soc_add_controls(codec, wm8750_snd_controls,
+                               ARRAY_SIZE(wm8750_snd_controls));
+       wm8750_add_widgets(codec);
+       return 0;
+ err:
+       return ret;
+ }
+ /* power down chip */
+ static int wm8750_remove(struct platform_device *pdev)
+ {
+       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
+       snd_soc_free_pcms(socdev);
+       snd_soc_dapm_free(socdev);
        return 0;
  }
  
+ struct snd_soc_codec_device soc_codec_dev_wm8750 = {
+       .probe          = wm8750_probe,
+       .remove         = wm8750_remove,
+       .suspend        = wm8750_suspend,
+       .resume         = wm8750_resume,
+ };
+ EXPORT_SYMBOL_GPL(soc_codec_dev_wm8750);
  /*
   * initialise the WM8750 driver
   * register the mixer and dsp interfaces with the kernel
   */
- static int wm8750_init(struct snd_soc_device *socdev,
-                      enum snd_soc_control_type control)
+ static int wm8750_register(struct wm8750_priv *wm8750,
+                       enum snd_soc_control_type control)
  {
-       struct snd_soc_codec *codec = socdev->card->codec;
+       struct snd_soc_codec *codec = &wm8750->codec;
        int reg, ret = 0;
  
+       if (wm8750_codec) {
+               dev_err(codec->dev, "Multiple WM8750 devices not supported\n");
+               ret = -EINVAL;
+               goto err;
+       }
+       mutex_init(&codec->mutex);
+       INIT_LIST_HEAD(&codec->dapm_widgets);
+       INIT_LIST_HEAD(&codec->dapm_paths);
        codec->name = "WM8750";
        codec->owner = THIS_MODULE;
+       codec->bias_level = SND_SOC_BIAS_STANDBY;
        codec->set_bias_level = wm8750_set_bias_level;
        codec->dai = &wm8750_dai;
        codec->num_dai = 1;
-       codec->reg_cache_size = ARRAY_SIZE(wm8750_reg);
-       codec->reg_cache = kmemdup(wm8750_reg, sizeof(wm8750_reg), GFP_KERNEL);
-       if (codec->reg_cache == NULL)
-               return -ENOMEM;
+       codec->reg_cache_size = ARRAY_SIZE(wm8750->reg_cache) + 1;
+       codec->reg_cache = &wm8750->reg_cache;
+       snd_soc_codec_set_drvdata(codec, wm8750);
+       memcpy(codec->reg_cache, wm8750_reg, sizeof(wm8750->reg_cache));
  
        ret = snd_soc_codec_set_cache_io(codec, 7, 9, control);
        if (ret < 0) {
                goto err;
        }
  
-       /* register pcms */
-       ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
-       if (ret < 0) {
-               printk(KERN_ERR "wm8750: failed to create pcms\n");
-               goto err;
-       }
        /* charge output caps */
-       wm8750_set_bias_level(codec, SND_SOC_BIAS_PREPARE);
-       codec->bias_level = SND_SOC_BIAS_STANDBY;
-       schedule_delayed_work(&codec->delayed_work, msecs_to_jiffies(1000));
+       wm8750_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
  
        /* set the update bits */
        reg = snd_soc_read(codec, WM8750_LDAC);
        reg = snd_soc_read(codec, WM8750_RINVOL);
        snd_soc_write(codec, WM8750_RINVOL, reg | 0x0100);
  
-       snd_soc_add_controls(codec, wm8750_snd_controls,
-                               ARRAY_SIZE(wm8750_snd_controls));
-       wm8750_add_widgets(codec);
-       return ret;
+       wm8750_codec = codec;
  
+       ret = snd_soc_register_codec(codec);
+       if (ret != 0) {
+               dev_err(codec->dev, "Failed to register codec: %d\n", ret);
+               goto err;
+       }
+       ret = snd_soc_register_dais(&wm8750_dai, 1);
+       if (ret != 0) {
+               dev_err(codec->dev, "Failed to register DAIs: %d\n", ret);
+               goto err_codec;
+       }
+       return 0;
+ err_codec:
+       snd_soc_unregister_codec(codec);
  err:
-       kfree(codec->reg_cache);
+       kfree(wm8750);
        return ret;
  }
  
- /* If the i2c layer weren't so broken, we could pass this kind of data
-    around */
- static struct snd_soc_device *wm8750_socdev;
+ static void wm8750_unregister(struct wm8750_priv *wm8750)
+ {
+       wm8750_set_bias_level(&wm8750->codec, SND_SOC_BIAS_OFF);
+       snd_soc_unregister_dais(&wm8750_dai, 1);
+       snd_soc_unregister_codec(&wm8750->codec);
+       kfree(wm8750);
+       wm8750_codec = NULL;
+ }
  
  #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
  
  static int wm8750_i2c_probe(struct i2c_client *i2c,
                            const struct i2c_device_id *id)
  {
-       struct snd_soc_device *socdev = wm8750_socdev;
-       struct snd_soc_codec *codec = socdev->card->codec;
-       int ret;
+       struct snd_soc_codec *codec;
+       struct wm8750_priv *wm8750;
+       wm8750 = kzalloc(sizeof(struct wm8750_priv), GFP_KERNEL);
+       if (wm8750 == NULL)
+               return -ENOMEM;
  
-       i2c_set_clientdata(i2c, codec);
+       codec = &wm8750->codec;
        codec->control_data = i2c;
+       i2c_set_clientdata(i2c, wm8750);
  
-       ret = wm8750_init(socdev, SND_SOC_I2C);
-       if (ret < 0)
-               pr_err("failed to initialise WM8750\n");
+       codec->dev = &i2c->dev;
  
-       return ret;
+       return wm8750_register(wm8750, SND_SOC_I2C);
  }
  
  static int wm8750_i2c_remove(struct i2c_client *client)
  {
-       struct snd_soc_codec *codec = i2c_get_clientdata(client);
-       kfree(codec->reg_cache);
+       struct wm8750_priv *wm8750 = i2c_get_clientdata(client);
+       wm8750_unregister(wm8750);
        return 0;
  }
  
@@@ -831,66 -896,31 +897,31 @@@ static struct i2c_driver wm8750_i2c_dri
        .remove =   wm8750_i2c_remove,
        .id_table = wm8750_i2c_id,
  };
- static int wm8750_add_i2c_device(struct platform_device *pdev,
-                                const struct wm8750_setup_data *setup)
- {
-       struct i2c_board_info info;
-       struct i2c_adapter *adapter;
-       struct i2c_client *client;
-       int ret;
-       ret = i2c_add_driver(&wm8750_i2c_driver);
-       if (ret != 0) {
-               dev_err(&pdev->dev, "can't add i2c driver\n");
-               return ret;
-       }
-       memset(&info, 0, sizeof(struct i2c_board_info));
-       info.addr = setup->i2c_address;
-       strlcpy(info.type, "wm8750", I2C_NAME_SIZE);
-       adapter = i2c_get_adapter(setup->i2c_bus);
-       if (!adapter) {
-               dev_err(&pdev->dev, "can't get i2c adapter %d\n",
-                       setup->i2c_bus);
-               goto err_driver;
-       }
-       client = i2c_new_device(adapter, &info);
-       i2c_put_adapter(adapter);
-       if (!client) {
-               dev_err(&pdev->dev, "can't add i2c device at 0x%x\n",
-                       (unsigned int)info.addr);
-               goto err_driver;
-       }
-       return 0;
- err_driver:
-       i2c_del_driver(&wm8750_i2c_driver);
-       return -ENODEV;
- }
  #endif
  
  #if defined(CONFIG_SPI_MASTER)
  static int __devinit wm8750_spi_probe(struct spi_device *spi)
  {
-       struct snd_soc_device *socdev = wm8750_socdev;
-       struct snd_soc_codec *codec = socdev->card->codec;
-       int ret;
+       struct snd_soc_codec *codec;
+       struct wm8750_priv *wm8750;
+       wm8750 = kzalloc(sizeof(struct wm8750_priv), GFP_KERNEL);
+       if (wm8750 == NULL)
+               return -ENOMEM;
  
+       codec = &wm8750->codec;
        codec->control_data = spi;
+       codec->dev = &spi->dev;
  
-       ret = wm8750_init(socdev, SND_SOC_SPI);
-       if (ret < 0)
-               dev_err(&spi->dev, "failed to initialise WM8750\n");
+       dev_set_drvdata(&spi->dev, wm8750);
  
-       return ret;
+       return wm8750_register(wm8750, SND_SOC_SPI);
  }
  
  static int __devexit wm8750_spi_remove(struct spi_device *spi)
  {
+       struct wm8750_priv *wm8750 = dev_get_drvdata(&spi->dev);
+       wm8750_unregister(wm8750);
        return 0;
  }
  
@@@ -905,115 -935,31 +936,31 @@@ static struct spi_driver wm8750_spi_dri
  };
  #endif
  
- static int wm8750_probe(struct platform_device *pdev)
+ static int __init wm8750_modinit(void)
  {
-       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-       struct wm8750_setup_data *setup = socdev->codec_data;
-       struct snd_soc_codec *codec;
-       struct wm8750_priv *wm8750;
        int ret;
-       pr_info("WM8750 Audio Codec %s", WM8750_VERSION);
-       codec = kzalloc(sizeof(struct snd_soc_codec), GFP_KERNEL);
-       if (codec == NULL)
-               return -ENOMEM;
-       wm8750 = kzalloc(sizeof(struct wm8750_priv), GFP_KERNEL);
-       if (wm8750 == NULL) {
-               kfree(codec);
-               return -ENOMEM;
-       }
-       codec->private_data = wm8750;
-       socdev->card->codec = codec;
-       mutex_init(&codec->mutex);
-       INIT_LIST_HEAD(&codec->dapm_widgets);
-       INIT_LIST_HEAD(&codec->dapm_paths);
-       wm8750_socdev = socdev;
-       INIT_DELAYED_WORK(&codec->delayed_work, wm8750_work);
-       ret = -ENODEV;
  #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
-       if (setup->i2c_address) {
-               ret = wm8750_add_i2c_device(pdev, setup);
-       }
+       ret = i2c_add_driver(&wm8750_i2c_driver);
+       if (ret != 0)
+               pr_err("Failed to register WM8750 I2C driver: %d\n", ret);
  #endif
  #if defined(CONFIG_SPI_MASTER)
-       if (setup->spi) {
-               ret = spi_register_driver(&wm8750_spi_driver);
-               if (ret != 0)
-                       printk(KERN_ERR "can't add spi driver");
-       }
+       ret = spi_register_driver(&wm8750_spi_driver);
+       if (ret != 0)
+               pr_err("Failed to register WM8750 SPI driver: %d\n", ret);
  #endif
-       if (ret != 0) {
-               kfree(codec->private_data);
-               kfree(codec);
-       }
-       return ret;
- }
- /*
-  * This function forces any delayed work to be queued and run.
-  */
- static int run_delayed_work(struct delayed_work *dwork)
- {
-       int ret;
-       /* cancel any work waiting to be queued. */
-       ret = cancel_delayed_work(dwork);
-       /* if there was any work waiting then we run it now and
-        * wait for it's completion */
-       if (ret) {
-               schedule_delayed_work(dwork, 0);
-               flush_scheduled_work();
-       }
-       return ret;
+       return 0;
  }
+ module_init(wm8750_modinit);
  
- /* power down chip */
- static int wm8750_remove(struct platform_device *pdev)
+ static void __exit wm8750_exit(void)
  {
-       struct snd_soc_device *socdev = platform_get_drvdata(pdev);
-       struct snd_soc_codec *codec = socdev->card->codec;
-       if (codec->control_data)
-               wm8750_set_bias_level(codec, SND_SOC_BIAS_OFF);
-       run_delayed_work(&codec->delayed_work);
-       snd_soc_free_pcms(socdev);
-       snd_soc_dapm_free(socdev);
  #if defined(CONFIG_I2C) || defined(CONFIG_I2C_MODULE)
-       i2c_unregister_device(codec->control_data);
        i2c_del_driver(&wm8750_i2c_driver);
  #endif
  #if defined(CONFIG_SPI_MASTER)
        spi_unregister_driver(&wm8750_spi_driver);
  #endif
-       kfree(codec->private_data);
-       kfree(codec);
-       return 0;
- }
- struct snd_soc_codec_device soc_codec_dev_wm8750 = {
-       .probe =        wm8750_probe,
-       .remove =       wm8750_remove,
-       .suspend =      wm8750_suspend,
-       .resume =       wm8750_resume,
- };
- EXPORT_SYMBOL_GPL(soc_codec_dev_wm8750);
- static int __init wm8750_modinit(void)
- {
-       return snd_soc_register_dai(&wm8750_dai);
- }
- module_init(wm8750_modinit);
- static void __exit wm8750_exit(void)
- {
-       snd_soc_unregister_dai(&wm8750_dai);
  }
  module_exit(wm8750_exit);
  
@@@ -40,7 -40,6 +40,7 @@@
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
  #include <linux/spi/spi.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -851,7 -850,7 +851,7 @@@ static int wm8753_set_dai_sysclk(struc
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8753_priv *wm8753 = codec->private_data;
+       struct wm8753_priv *wm8753 = snd_soc_codec_get_drvdata(codec);
  
        switch (freq) {
        case 11289600:
@@@ -914,7 -913,7 +914,7 @@@ static int wm8753_pcm_hw_params(struct 
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8753_priv *wm8753 = codec->private_data;
+       struct wm8753_priv *wm8753 = snd_soc_codec_get_drvdata(codec);
        u16 voice = wm8753_read_reg_cache(codec, WM8753_PCM) & 0x01f3;
        u16 srate = wm8753_read_reg_cache(codec, WM8753_SRATE1) & 0x017f;
  
@@@ -1148,7 -1147,7 +1148,7 @@@ static int wm8753_i2s_hw_params(struct 
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8753_priv *wm8753 = codec->private_data;
+       struct wm8753_priv *wm8753 = snd_soc_codec_get_drvdata(codec);
        u16 srate = wm8753_read_reg_cache(codec, WM8753_SRATE1) & 0x01c0;
        u16 hifi = wm8753_read_reg_cache(codec, WM8753_HIFI) & 0x01f3;
        int coeff;
@@@ -1646,7 -1645,7 +1646,7 @@@ static int wm8753_register(struct wm875
        codec->num_dai = 2;
        codec->reg_cache_size = ARRAY_SIZE(wm8753->reg_cache) + 1;
        codec->reg_cache = &wm8753->reg_cache;
-       codec->private_data = wm8753;
+       snd_soc_codec_set_drvdata(codec, wm8753);
  
        memcpy(codec->reg_cache, wm8753_reg, sizeof(wm8753->reg_cache));
        INIT_DELAYED_WORK(&codec->delayed_work, wm8753_work);
@@@ -20,7 -20,6 +20,7 @@@
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
  #include <linux/spi/spi.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -227,7 -226,7 +227,7 @@@ static int wm8776_hw_params(struct snd_
                            struct snd_soc_dai *dai)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8776_priv *wm8776 = codec->private_data;
+       struct wm8776_priv *wm8776 = snd_soc_codec_get_drvdata(codec);
        int iface_reg, iface;
        int ratio_shift, master;
        int i;
@@@ -304,7 -303,7 +304,7 @@@ static int wm8776_set_sysclk(struct snd
                             int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8776_priv *wm8776 = codec->private_data;
+       struct wm8776_priv *wm8776 = snd_soc_codec_get_drvdata(codec);
  
        BUG_ON(dai->id >= ARRAY_SIZE(wm8776->sysclk));
  
@@@ -491,7 -490,7 +491,7 @@@ static int wm8776_register(struct wm877
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8776;
+       snd_soc_codec_set_drvdata(codec, wm8776);
        codec->name = "WM8776";
        codec->owner = THIS_MODULE;
        codec->bias_level = SND_SOC_BIAS_OFF;
@@@ -24,7 -24,6 +24,7 @@@
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -745,7 -744,7 +745,7 @@@ static int fll_factors(struct _fll_div 
  static int wm8900_set_fll(struct snd_soc_codec *codec,
        int fll_id, unsigned int freq_in, unsigned int freq_out)
  {
-       struct wm8900_priv *wm8900 = codec->private_data;
+       struct wm8900_priv *wm8900 = snd_soc_codec_get_drvdata(codec);
        struct _fll_div fll_div;
        unsigned int reg;
  
@@@ -1132,7 -1131,7 +1132,7 @@@ static int wm8900_suspend(struct platfo
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8900_priv *wm8900 = codec->private_data;
+       struct wm8900_priv *wm8900 = snd_soc_codec_get_drvdata(codec);
        int fll_out = wm8900->fll_out;
        int fll_in  = wm8900->fll_in;
        int ret;
@@@ -1156,7 -1155,7 +1156,7 @@@ static int wm8900_resume(struct platfor
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8900_priv *wm8900 = codec->private_data;
+       struct wm8900_priv *wm8900 = snd_soc_codec_get_drvdata(codec);
        u16 *cache;
        int i, ret;
  
@@@ -1206,7 -1205,7 +1206,7 @@@ static __devinit int wm8900_i2c_probe(s
                return -ENOMEM;
  
        codec = &wm8900->codec;
-       codec->private_data = wm8900;
+       snd_soc_codec_set_drvdata(codec, wm8900);
        codec->reg_cache = &wm8900->reg_cache[0];
        codec->reg_cache_size = WM8900_MAXREG;
  
@@@ -1305,7 -1304,7 +1305,7 @@@ static __devexit int wm8900_i2c_remove(
        wm8900_set_bias_level(wm8900_codec, SND_SOC_BIAS_OFF);
  
        wm8900_dai.dev = NULL;
-       kfree(wm8900_codec->private_data);
+       kfree(snd_soc_codec_get_drvdata(wm8900_codec));
        wm8900_codec = NULL;
  
        return 0;
   *
   * TODO:
   *  - TDM mode configuration.
-  *  - Mic detect.
   *  - Digital microphone support.
-  *  - Interrupt support (mic detect and sequencer).
   */
  
  #include <linux/module.h>
  #include <linux/moduleparam.h>
  #include <linux/init.h>
+ #include <linux/completion.h>
  #include <linux/delay.h>
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
+ #include <sound/jack.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
  #include <sound/tlv.h>
  #include <sound/soc.h>
  #include <sound/soc-dapm.h>
  #include <sound/initval.h>
+ #include <sound/wm8903.h>
  
  #include "wm8903.h"
  
@@@ -222,6 -222,14 +223,14 @@@ struct wm8903_priv 
        int playback_active;
        int capture_active;
  
+       struct completion wseq;
+       struct snd_soc_jack *mic_jack;
+       int mic_det;
+       int mic_short;
+       int mic_last_report;
+       int mic_delay;
        struct snd_pcm_substream *master_substream;
        struct snd_pcm_substream *slave_substream;
  };
@@@ -244,13 -252,14 +253,14 @@@ static int wm8903_run_sequence(struct s
  {
        u16 reg[5];
        struct i2c_client *i2c = codec->control_data;
+       struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
  
        BUG_ON(start > 48);
  
-       /* Enable the sequencer */
+       /* Enable the sequencer if it's not already on */
        reg[0] = snd_soc_read(codec, WM8903_WRITE_SEQUENCER_0);
-       reg[0] |= WM8903_WSEQ_ENA;
-       snd_soc_write(codec, WM8903_WRITE_SEQUENCER_0, reg[0]);
+       snd_soc_write(codec, WM8903_WRITE_SEQUENCER_0,
+                     reg[0] | WM8903_WSEQ_ENA);
  
        dev_dbg(&i2c->dev, "Starting sequence at %d\n", start);
  
                     start | WM8903_WSEQ_START);
  
        /* Wait for it to complete.  If we have the interrupt wired up then
-        * we could block waiting for an interrupt, though polling may still
-        * be desirable for diagnostic purposes.
+        * that will break us out of the poll early.
         */
        do {
-               msleep(10);
+               wait_for_completion_timeout(&wm8903->wseq,
+                                           msecs_to_jiffies(10));
  
                reg[4] = snd_soc_read(codec, WM8903_WRITE_SEQUENCER_4);
        } while (reg[4] & WM8903_WSEQ_BUSY);
  
        dev_dbg(&i2c->dev, "Sequence complete\n");
  
-       /* Disable the sequencer again */
-       snd_soc_write(codec, WM8903_WRITE_SEQUENCER_0,
-                    reg[0] & ~WM8903_WSEQ_ENA);
+       /* Disable the sequencer again if we enabled it */
+       snd_soc_write(codec, WM8903_WRITE_SEQUENCER_0, reg[0]);
  
        return 0;
  }
@@@ -412,7 -420,7 +421,7 @@@ static int wm8903_class_w_put(struct sn
  {
        struct snd_soc_dapm_widget *widget = snd_kcontrol_chip(kcontrol);
        struct snd_soc_codec *codec = widget->codec;
-       struct wm8903_priv *wm8903 = codec->private_data;
+       struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
        struct i2c_client *i2c = codec->control_data;
        u16 reg;
        int ret;
@@@ -993,7 -1001,7 +1002,7 @@@ static int wm8903_set_dai_sysclk(struc
                                 int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8903_priv *wm8903 = codec->private_data;
+       struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
  
        wm8903->sysclk = freq;
  
@@@ -1221,7 -1229,7 +1230,7 @@@ static int wm8903_startup(struct snd_pc
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8903_priv *wm8903 = codec->private_data;
+       struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
        struct i2c_client *i2c = codec->control_data;
        struct snd_pcm_runtime *master_runtime;
  
@@@ -1257,7 -1265,7 +1266,7 @@@ static void wm8903_shutdown(struct snd_
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8903_priv *wm8903 = codec->private_data;
+       struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
  
        if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
                wm8903->playback_active--;
@@@ -1277,7 -1285,7 +1286,7 @@@ static int wm8903_hw_params(struct snd_
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8903_priv *wm8903 = codec->private_data;
+       struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
        struct i2c_client *i2c = codec->control_data;
        int fs = params_rate(params);
        int bclk;
        return 0;
  }
  
+ /**
+  * wm8903_mic_detect - Enable microphone detection via the WM8903 IRQ
+  *
+  * @codec:  WM8903 codec
+  * @jack:   jack to report detection events on
+  * @det:    value to report for presence detection
+  * @shrt:   value to report for short detection
+  *
+  * Enable microphone detection via IRQ on the WM8903.  If GPIOs are
+  * being used to bring out signals to the processor then only platform
+  * data configuration is needed for WM8903 and processor GPIOs should
+  * be configured using snd_soc_jack_add_gpios() instead.
+  *
+  * The current threasholds for detection should be configured using
+  * micdet_cfg in the platform data.  Using this function will force on
+  * the microphone bias for the device.
+  */
+ int wm8903_mic_detect(struct snd_soc_codec *codec, struct snd_soc_jack *jack,
+                     int det, int shrt)
+ {
+       struct wm8903_priv *wm8903 = snd_soc_codec_get_drvdata(codec);
+       int irq_mask = WM8903_MICDET_EINT | WM8903_MICSHRT_EINT;
+       dev_dbg(codec->dev, "Enabling microphone detection: %x %x\n",
+               det, shrt);
+       /* Store the configuration */
+       wm8903->mic_jack = jack;
+       wm8903->mic_det = det;
+       wm8903->mic_short = shrt;
+       /* Enable interrupts we've got a report configured for */
+       if (det)
+               irq_mask &= ~WM8903_MICDET_EINT;
+       if (shrt)
+               irq_mask &= ~WM8903_MICSHRT_EINT;
+       snd_soc_update_bits(codec, WM8903_INTERRUPT_STATUS_1_MASK,
+                           WM8903_MICDET_EINT | WM8903_MICSHRT_EINT,
+                           irq_mask);
+       if (det && shrt) {
+               /* Enable mic detection, this may not have been set through
+                * platform data (eg, if the defaults are OK). */
+               snd_soc_update_bits(codec, WM8903_WRITE_SEQUENCER_0,
+                                   WM8903_WSEQ_ENA, WM8903_WSEQ_ENA);
+               snd_soc_update_bits(codec, WM8903_MIC_BIAS_CONTROL_0,
+                                   WM8903_MICDET_ENA, WM8903_MICDET_ENA);
+       } else {
+               snd_soc_update_bits(codec, WM8903_MIC_BIAS_CONTROL_0,
+                                   WM8903_MICDET_ENA, 0);
+       }
+       return 0;
+ }
+ EXPORT_SYMBOL_GPL(wm8903_mic_detect);
+ static irqreturn_t wm8903_irq(int irq, void *data)
+ {
+       struct wm8903_priv *wm8903 = data;
+       struct snd_soc_codec *codec = &wm8903->codec;
+       int mic_report;
+       int int_pol;
+       int int_val = 0;
+       int mask = ~snd_soc_read(codec, WM8903_INTERRUPT_STATUS_1_MASK);
+       int_val = snd_soc_read(codec, WM8903_INTERRUPT_STATUS_1) & mask;
+       if (int_val & WM8903_WSEQ_BUSY_EINT) {
+               dev_dbg(codec->dev, "Write sequencer done\n");
+               complete(&wm8903->wseq);
+       }
+       /*
+        * The rest is microphone jack detection.  We need to manually
+        * invert the polarity of the interrupt after each event - to
+        * simplify the code keep track of the last state we reported
+        * and just invert the relevant bits in both the report and
+        * the polarity register.
+        */
+       mic_report = wm8903->mic_last_report;
+       int_pol = snd_soc_read(codec, WM8903_INTERRUPT_POLARITY_1);
+       if (int_val & WM8903_MICSHRT_EINT) {
+               dev_dbg(codec->dev, "Microphone short (pol=%x)\n", int_pol);
+               mic_report ^= wm8903->mic_short;
+               int_pol ^= WM8903_MICSHRT_INV;
+       }
+       if (int_val & WM8903_MICDET_EINT) {
+               dev_dbg(codec->dev, "Microphone detect (pol=%x)\n", int_pol);
+               mic_report ^= wm8903->mic_det;
+               int_pol ^= WM8903_MICDET_INV;
+               msleep(wm8903->mic_delay);
+       }
+       snd_soc_update_bits(codec, WM8903_INTERRUPT_POLARITY_1,
+                           WM8903_MICSHRT_INV | WM8903_MICDET_INV, int_pol);
+       snd_soc_jack_report(wm8903->mic_jack, mic_report,
+                           wm8903->mic_short | wm8903->mic_det);
+       wm8903->mic_last_report = mic_report;
+       return IRQ_HANDLED;
+ }
  #define WM8903_PLAYBACK_RATES (SNDRV_PCM_RATE_8000 |\
                               SNDRV_PCM_RATE_11025 |   \
                               SNDRV_PCM_RATE_16000 |   \
@@@ -1510,7 -1628,6 +1629,6 @@@ static int wm8903_resume(struct platfor
  
        /* Bring the codec back up to standby first to minimise pop/clicks */
        wm8903_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       wm8903_set_bias_level(codec, codec->suspend_bias_level);
  
        /* Sync back everything else */
        if (tmp_cache) {
@@@ -1530,9 -1647,11 +1648,11 @@@ static struct snd_soc_codec *wm8903_cod
  static __devinit int wm8903_i2c_probe(struct i2c_client *i2c,
                                      const struct i2c_device_id *id)
  {
+       struct wm8903_platform_data *pdata = dev_get_platdata(&i2c->dev);
        struct wm8903_priv *wm8903;
        struct snd_soc_codec *codec;
-       int ret;
+       int ret, i;
+       int trigger, irq_pol;
        u16 val;
  
        wm8903 = kzalloc(sizeof(struct wm8903_priv), GFP_KERNEL);
        codec->num_dai = 1;
        codec->reg_cache_size = ARRAY_SIZE(wm8903->reg_cache);
        codec->reg_cache = &wm8903->reg_cache[0];
-       codec->private_data = wm8903;
+       snd_soc_codec_set_drvdata(codec, wm8903);
        codec->volatile_register = wm8903_volatile_register;
+       init_completion(&wm8903->wseq);
  
        i2c_set_clientdata(i2c, codec);
        codec->control_data = i2c;
  
        wm8903_reset(codec);
  
+       /* Set up GPIOs and microphone detection */
+       if (pdata) {
+               for (i = 0; i < ARRAY_SIZE(pdata->gpio_cfg); i++) {
+                       if (!pdata->gpio_cfg[i])
+                               continue;
+                       snd_soc_write(codec, WM8903_GPIO_CONTROL_1 + i,
+                                     pdata->gpio_cfg[i] & 0xffff);
+               }
+               snd_soc_write(codec, WM8903_MIC_BIAS_CONTROL_0,
+                             pdata->micdet_cfg);
+               /* Microphone detection needs the WSEQ clock */
+               if (pdata->micdet_cfg)
+                       snd_soc_update_bits(codec, WM8903_WRITE_SEQUENCER_0,
+                                           WM8903_WSEQ_ENA, WM8903_WSEQ_ENA);
+               wm8903->mic_delay = pdata->micdet_delay;
+       }
+       
+       if (i2c->irq) {
+               if (pdata && pdata->irq_active_low) {
+                       trigger = IRQF_TRIGGER_LOW;
+                       irq_pol = WM8903_IRQ_POL;
+               } else {
+                       trigger = IRQF_TRIGGER_HIGH;
+                       irq_pol = 0;
+               }
+               snd_soc_update_bits(codec, WM8903_INTERRUPT_CONTROL,
+                                   WM8903_IRQ_POL, irq_pol);
+               
+               ret = request_threaded_irq(i2c->irq, NULL, wm8903_irq,
+                                          trigger | IRQF_ONESHOT,
+                                          "wm8903", wm8903);
+               if (ret != 0) {
+                       dev_err(&i2c->dev, "Failed to request IRQ: %d\n",
+                               ret);
+                       goto err;
+               }
+               /* Enable write sequencer interrupts */
+               snd_soc_update_bits(codec, WM8903_INTERRUPT_STATUS_1_MASK,
+                                   WM8903_IM_WSEQ_BUSY_EINT, 0);
+       }
        /* power on device */
        wm8903_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
  
        ret = snd_soc_register_codec(codec);
        if (ret != 0) {
                dev_err(&i2c->dev, "Failed to register codec: %d\n", ret);
-               goto err;
+               goto err_irq;
        }
  
        ret = snd_soc_register_dai(&wm8903_dai);
  
  err_codec:
        snd_soc_unregister_codec(codec);
+ err_irq:
+       if (i2c->irq)
+               free_irq(i2c->irq, wm8903);
  err:
        wm8903_codec = NULL;
        kfree(wm8903);
  static __devexit int wm8903_i2c_remove(struct i2c_client *client)
  {
        struct snd_soc_codec *codec = i2c_get_clientdata(client);
+       struct wm8903_priv *priv = snd_soc_codec_get_drvdata(codec);
  
        snd_soc_unregister_dai(&wm8903_dai);
        snd_soc_unregister_codec(codec);
  
        wm8903_set_bias_level(codec, SND_SOC_BIAS_OFF);
  
-       kfree(codec->private_data);
+       if (client->irq)
+               free_irq(client->irq, priv);
+       kfree(priv);
  
        wm8903_codec = NULL;
        wm8903_dai.dev = NULL;
@@@ -19,7 -19,6 +19,7 @@@
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
  #include <linux/regulator/consumer.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -613,7 -612,7 +613,7 @@@ static int wm8904_reset(struct snd_soc_
  
  static int wm8904_configure_clocking(struct snd_soc_codec *codec)
  {
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
        unsigned int clock0, clock2, rate;
  
        /* Gate the clock while we're updating to avoid misclocking */
  
  static void wm8904_set_drc(struct snd_soc_codec *codec)
  {
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
        struct wm8904_pdata *pdata = wm8904->pdata;
        int save, i;
  
@@@ -689,7 -688,7 +689,7 @@@ static int wm8904_put_drc_enum(struct s
                               struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8904_priv *wm8904 = codec->private_data;       
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);  
        struct wm8904_pdata *pdata = wm8904->pdata;
        int value = ucontrol->value.integer.value[0];
  
@@@ -707,7 -706,7 +707,7 @@@ static int wm8904_get_drc_enum(struct s
                               struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
  
        ucontrol->value.enumerated.item[0] = wm8904->drc_cfg;
  
  
  static void wm8904_set_retune_mobile(struct snd_soc_codec *codec)
  {
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
        struct wm8904_pdata *pdata = wm8904->pdata;
        int best, best_val, save, i, cfg;
  
@@@ -760,7 -759,7 +760,7 @@@ static int wm8904_put_retune_mobile_enu
                                         struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8904_priv *wm8904 = codec->private_data;       
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);  
        struct wm8904_pdata *pdata = wm8904->pdata;
        int value = ucontrol->value.integer.value[0];
  
@@@ -778,7 -777,7 +778,7 @@@ static int wm8904_get_retune_mobile_enu
                                         struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
  
        ucontrol->value.enumerated.item[0] = wm8904->retune_mobile_cfg;
  
@@@ -789,7 -788,7 +789,7 @@@ static int deemph_settings[] = { 0, 320
  
  static int wm8904_set_deemph(struct snd_soc_codec *codec)
  {
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
        int val, i, best;
  
        /* If we're using deemphasis select the nearest available sample 
@@@ -818,7 -817,7 +818,7 @@@ static int wm8904_get_deemph(struct snd
                             struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
  
        return wm8904->deemph;
  }
@@@ -827,7 -826,7 +827,7 @@@ static int wm8904_put_deemph(struct snd
                              struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
        int deemph = ucontrol->value.enumerated.item[0];
  
        if (deemph > 1)
@@@ -943,7 -942,7 +943,7 @@@ static int sysclk_event(struct snd_soc_
                         struct snd_kcontrol *kcontrol, int event)
  {
        struct snd_soc_codec *codec = w->codec;
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
  
        switch (event) {
        case SND_SOC_DAPM_PRE_PMU:
@@@ -981,7 -980,7 +981,7 @@@ static int out_pga_event(struct snd_soc
                         struct snd_kcontrol *kcontrol, int event)
  {
        struct snd_soc_codec *codec = w->codec;
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
        int reg, val;
        int dcs_mask;
        int dcs_l, dcs_r;
@@@ -1429,7 -1428,7 +1429,7 @@@ static const struct snd_soc_dapm_route 
  
  static int wm8904_add_widgets(struct snd_soc_codec *codec)
  {
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
  
        snd_soc_dapm_new_controls(codec, wm8904_core_dapm_widgets,
                                  ARRAY_SIZE(wm8904_core_dapm_widgets));
@@@ -1543,7 -1542,7 +1543,7 @@@ static int wm8904_hw_params(struct snd_
                            struct snd_soc_dai *dai)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
        int ret, i, best, best_val, cur_val;
        unsigned int aif1 = 0;
        unsigned int aif2 = 0;
@@@ -1670,7 -1669,7 +1670,7 @@@ static int wm8904_set_sysclk(struct snd
                             unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8904_priv *priv = codec->private_data;
+       struct wm8904_priv *priv = snd_soc_codec_get_drvdata(codec);
  
        switch (clk_id) {
        case WM8904_CLK_MCLK:
@@@ -1786,7 -1785,7 +1786,7 @@@ static int wm8904_set_tdm_slot(struct s
                               unsigned int rx_mask, int slots, int slot_width)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
        int aif1 = 0;
  
        /* Don't need to validate anything if we're turning off TDM */
@@@ -1943,7 -1942,7 +1943,7 @@@ static int wm8904_set_fll(struct snd_so
                          unsigned int Fref, unsigned int Fout)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
        struct _fll_div fll_div;
        int ret, val;
        int clock2, fll1;
@@@ -2095,7 -2094,7 +2095,7 @@@ static int wm8904_digital_mute(struct s
  
  static void wm8904_sync_cache(struct snd_soc_codec *codec)
  {
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
        int i;
  
        if (!codec->cache_sync)
  static int wm8904_set_bias_level(struct snd_soc_codec *codec,
                                 enum snd_soc_bias_level level)
  {
-       struct wm8904_priv *wm8904 = codec->private_data;
+       struct wm8904_priv *wm8904 = snd_soc_codec_get_drvdata(codec);
        int ret;
  
        switch (level) {
@@@ -2395,7 -2394,7 +2395,7 @@@ static int wm8904_probe(struct platform
                goto pcm_err;
        }
  
-       wm8904_handle_pdata(codec->private_data);
+       wm8904_handle_pdata(snd_soc_codec_get_drvdata(codec));
  
        wm8904_add_widgets(codec);
  
@@@ -2426,6 -2425,7 +2426,7 @@@ EXPORT_SYMBOL_GPL(soc_codec_dev_wm8904)
  static int wm8904_register(struct wm8904_priv *wm8904,
                           enum snd_soc_control_type control)
  {
+       struct wm8904_pdata *pdata = wm8904->pdata;
        int ret;
        struct snd_soc_codec *codec = &wm8904->codec;
        int i;
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8904;
+       snd_soc_codec_set_drvdata(codec, wm8904);
        codec->name = "WM8904";
        codec->owner = THIS_MODULE;
        codec->bias_level = SND_SOC_BIAS_OFF;
                WM8904_LINEOUTRZC;
        wm8904->reg_cache[WM8904_CLOCK_RATES_0] &= ~WM8904_SR_MODE;
  
+       /* Apply configuration from the platform data. */
+       if (wm8904->pdata) {
+               for (i = 0; i < WM8904_GPIO_REGS; i++) {
+                       if (!pdata->gpio_cfg[i])
+                               continue;
+                       wm8904->reg_cache[WM8904_GPIO_CONTROL_1 + i]
+                               = pdata->gpio_cfg[i] & 0xffff;
+               }
+               /* Zero is the default value for these anyway */
+               for (i = 0; i < WM8904_MIC_REGS; i++)
+                       wm8904->reg_cache[WM8904_MIC_BIAS_CONTROL_0 + i]
+                               = pdata->mic_cfg[i];
+       }
        /* Set Class W by default - this will be managed by the Class
         * G widget at runtime where bypass paths are available.
         */
@@@ -30,7 -30,6 +30,7 @@@
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
  #include <linux/spi/spi.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -581,7 -580,7 +581,7 @@@ static int wm8940_set_dai_sysclk(struc
                                 int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8940_priv *wm8940 = codec->private_data;
+       struct wm8940_priv *wm8940 = snd_soc_codec_get_drvdata(codec);
  
        switch (freq) {
        case 11289600:
@@@ -692,7 -691,6 +692,6 @@@ static int wm8940_resume(struct platfor
        ret = wm8940_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
        if (ret)
                goto error_ret;
-       ret = wm8940_set_bias_level(codec, codec->suspend_bias_level);
  
  error_ret:
        return ret;
@@@ -773,7 -771,7 +772,7 @@@ static int wm8940_register(struct wm894
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8940;
+       snd_soc_codec_set_drvdata(codec, wm8940);
        codec->name = "WM8940";
        codec->owner = THIS_MODULE;
        codec->bias_level = SND_SOC_BIAS_OFF;
@@@ -18,7 -18,6 +18,7 @@@
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
  #include <linux/regulator/consumer.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -235,7 -234,7 +235,7 @@@ static struct 
  
  static int wm8955_configure_clocking(struct snd_soc_codec *codec)
  {
-       struct wm8955_priv *wm8955 = codec->private_data;
+       struct wm8955_priv *wm8955 = snd_soc_codec_get_drvdata(codec);
        int i, ret, val;
        int clocking = 0;
        int srate = 0;
@@@ -353,7 -352,7 +353,7 @@@ static int deemph_settings[] = { 0, 320
  
  static int wm8955_set_deemph(struct snd_soc_codec *codec)
  {
-       struct wm8955_priv *wm8955 = codec->private_data;
+       struct wm8955_priv *wm8955 = snd_soc_codec_get_drvdata(codec);
        int val, i, best;
  
        /* If we're using deemphasis select the nearest available sample
@@@ -382,7 -381,7 +382,7 @@@ static int wm8955_get_deemph(struct snd
                             struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8955_priv *wm8955 = codec->private_data;
+       struct wm8955_priv *wm8955 = snd_soc_codec_get_drvdata(codec);
  
        return wm8955->deemph;
  }
@@@ -391,7 -390,7 +391,7 @@@ static int wm8955_put_deemph(struct snd
                             struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8955_priv *wm8955 = codec->private_data;
+       struct wm8955_priv *wm8955 = snd_soc_codec_get_drvdata(codec);
        int deemph = ucontrol->value.enumerated.item[0];
  
        if (deemph > 1)
@@@ -598,7 -597,7 +598,7 @@@ static int wm8955_hw_params(struct snd_
                            struct snd_soc_dai *dai)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8955_priv *wm8955 = codec->private_data;
+       struct wm8955_priv *wm8955 = snd_soc_codec_get_drvdata(codec);
        int ret;
        int wl;
  
@@@ -647,7 -646,7 +647,7 @@@ static int wm8955_set_sysclk(struct snd
                             unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8955_priv *priv = codec->private_data;
+       struct wm8955_priv *priv = snd_soc_codec_get_drvdata(codec);
        int div;
  
        switch (clk_id) {
@@@ -770,7 -769,7 +770,7 @@@ static int wm8955_digital_mute(struct s
  static int wm8955_set_bias_level(struct snd_soc_codec *codec,
                                 enum snd_soc_bias_level level)
  {
-       struct wm8955_priv *wm8955 = codec->private_data;
+       struct wm8955_priv *wm8955 = snd_soc_codec_get_drvdata(codec);
        int ret, i;
  
        switch (level) {
@@@ -971,7 -970,7 +971,7 @@@ static int wm8955_register(struct wm895
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8955;
+       snd_soc_codec_set_drvdata(codec, wm8955);
        codec->name = "WM8955";
        codec->owner = THIS_MODULE;
        codec->bias_level = SND_SOC_BIAS_OFF;
@@@ -15,7 -15,6 +15,7 @@@
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -23,6 -22,7 +23,7 @@@
  #include <sound/soc-dapm.h>
  #include <sound/initval.h>
  #include <sound/tlv.h>
+ #include <sound/wm8960.h>
  
  #include "wm8960.h"
  
  struct snd_soc_codec_device soc_codec_dev_wm8960;
  
  /* R25 - Power 1 */
+ #define WM8960_VMID_MASK 0x180
  #define WM8960_VREF      0x40
  
+ /* R26 - Power 2 */
+ #define WM8960_PWR2_LOUT1     0x40
+ #define WM8960_PWR2_ROUT1     0x20
+ #define WM8960_PWR2_OUT3      0x02
  /* R28 - Anti-pop 1 */
  #define WM8960_POBCTRL   0x80
  #define WM8960_BUFDCOPEN 0x10
@@@ -42,6 -48,7 +49,7 @@@
  
  /* R29 - Anti-pop 2 */
  #define WM8960_DISOP     0x40
+ #define WM8960_DRES_MASK 0x30
  
  /*
   * wm8960 register cache
@@@ -68,6 -75,9 +76,9 @@@ static const u16 wm8960_reg[WM8960_CACH
  struct wm8960_priv {
        u16 reg_cache[WM8960_CACHEREGNUM];
        struct snd_soc_codec codec;
+       struct snd_soc_dapm_widget *lout1;
+       struct snd_soc_dapm_widget *rout1;
+       struct snd_soc_dapm_widget *out3;
  };
  
  #define wm8960_reset(c)       snd_soc_write(c, WM8960_RESET, 0)
@@@ -226,10 -236,6 +237,6 @@@ SND_SOC_DAPM_MIXER("Right Output Mixer"
        &wm8960_routput_mixer[0],
        ARRAY_SIZE(wm8960_routput_mixer)),
  
- SND_SOC_DAPM_MIXER("Mono Output Mixer", WM8960_POWER2, 1, 0,
-       &wm8960_mono_out[0],
-       ARRAY_SIZE(wm8960_mono_out)),
  SND_SOC_DAPM_PGA("LOUT1 PGA", WM8960_POWER2, 6, 0, NULL, 0),
  SND_SOC_DAPM_PGA("ROUT1 PGA", WM8960_POWER2, 5, 0, NULL, 0),
  
@@@ -248,6 -254,17 +255,17 @@@ SND_SOC_DAPM_OUTPUT("SPK_RN")
  SND_SOC_DAPM_OUTPUT("OUT3"),
  };
  
+ static const struct snd_soc_dapm_widget wm8960_dapm_widgets_out3[] = {
+ SND_SOC_DAPM_MIXER("Mono Output Mixer", WM8960_POWER2, 1, 0,
+       &wm8960_mono_out[0],
+       ARRAY_SIZE(wm8960_mono_out)),
+ };
+ /* Represent OUT3 as a PGA so that it gets turned on with LOUT1/ROUT1 */
+ static const struct snd_soc_dapm_widget wm8960_dapm_widgets_capless[] = {
+ SND_SOC_DAPM_PGA("OUT3 VMID", WM8960_POWER2, 1, 0, NULL, 0),
+ };
  static const struct snd_soc_dapm_route audio_paths[] = {
        { "Left Boost Mixer", "LINPUT1 Switch", "LINPUT1" },
        { "Left Boost Mixer", "LINPUT2 Switch", "LINPUT2" },
        { "Right Output Mixer", "Boost Bypass Switch", "Right Boost Mixer" } ,
        { "Right Output Mixer", "PCM Playback Switch", "Right DAC" },
  
-       { "Mono Output Mixer", "Left Switch", "Left Output Mixer" },
-       { "Mono Output Mixer", "Right Switch", "Right Output Mixer" },
        { "LOUT1 PGA", NULL, "Left Output Mixer" },
        { "ROUT1 PGA", NULL, "Right Output Mixer" },
  
        { "SPK_LP", NULL, "Left Speaker Output" },
        { "SPK_RN", NULL, "Right Speaker Output" },
        { "SPK_RP", NULL, "Right Speaker Output" },
+ };
+ static const struct snd_soc_dapm_route audio_paths_out3[] = {
+       { "Mono Output Mixer", "Left Switch", "Left Output Mixer" },
+       { "Mono Output Mixer", "Right Switch", "Right Output Mixer" },
  
        { "OUT3", NULL, "Mono Output Mixer", }
  };
  
+ static const struct snd_soc_dapm_route audio_paths_capless[] = {
+       { "HP_L", NULL, "OUT3 VMID" },
+       { "HP_R", NULL, "OUT3 VMID" },
+       { "OUT3 VMID", NULL, "Left Output Mixer" },
+       { "OUT3 VMID", NULL, "Right Output Mixer" },
+ };
  static int wm8960_add_widgets(struct snd_soc_codec *codec)
  {
+       struct wm8960_data *pdata = codec->dev->platform_data;
+       struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
+       struct snd_soc_dapm_widget *w;
        snd_soc_dapm_new_controls(codec, wm8960_dapm_widgets,
                                  ARRAY_SIZE(wm8960_dapm_widgets));
  
        snd_soc_dapm_add_routes(codec, audio_paths, ARRAY_SIZE(audio_paths));
  
+       /* In capless mode OUT3 is used to provide VMID for the
+        * headphone outputs, otherwise it is used as a mono mixer.
+        */
+       if (pdata && pdata->capless) {
+               snd_soc_dapm_new_controls(codec, wm8960_dapm_widgets_capless,
+                                         ARRAY_SIZE(wm8960_dapm_widgets_capless));
+               snd_soc_dapm_add_routes(codec, audio_paths_capless,
+                                       ARRAY_SIZE(audio_paths_capless));
+       } else {
+               snd_soc_dapm_new_controls(codec, wm8960_dapm_widgets_out3,
+                                         ARRAY_SIZE(wm8960_dapm_widgets_out3));
+               snd_soc_dapm_add_routes(codec, audio_paths_out3,
+                                       ARRAY_SIZE(audio_paths_out3));
+       }
+       /* We need to power up the headphone output stage out of
+        * sequence for capless mode.  To save scanning the widget
+        * list each time to find the desired power state do so now
+        * and save the result.
+        */
+       list_for_each_entry(w, &codec->dapm_widgets, list) {
+               if (strcmp(w->name, "LOUT1 PGA") == 0)
+                       wm8960->lout1 = w;
+               if (strcmp(w->name, "ROUT1 PGA") == 0)
+                       wm8960->rout1 = w;
+               if (strcmp(w->name, "OUT3 VMID") == 0)
+                       wm8960->out3 = w;
+       }
+       
        return 0;
  }
  
@@@ -408,10 -470,9 +471,9 @@@ static int wm8960_mute(struct snd_soc_d
        return 0;
  }
  
- static int wm8960_set_bias_level(struct snd_soc_codec *codec,
-                                enum snd_soc_bias_level level)
+ static int wm8960_set_bias_level_out3(struct snd_soc_codec *codec,
+                                     enum snd_soc_bias_level level)
  {
-       struct wm8960_data *pdata = codec->dev->platform_data;
        u16 reg;
  
        switch (level) {
                if (codec->bias_level == SND_SOC_BIAS_OFF) {
                        /* Enable anti-pop features */
                        snd_soc_write(codec, WM8960_APOP1,
-                                    WM8960_POBCTRL | WM8960_SOFT_ST |
-                                    WM8960_BUFDCOPEN | WM8960_BUFIOEN);
-                       /* Discharge HP output */
-                       reg = WM8960_DISOP;
-                       if (pdata)
-                               reg |= pdata->dres << 4;
-                       snd_soc_write(codec, WM8960_APOP2, reg);
-                       msleep(400);
-                       snd_soc_write(codec, WM8960_APOP2, 0);
+                                     WM8960_POBCTRL | WM8960_SOFT_ST |
+                                     WM8960_BUFDCOPEN | WM8960_BUFIOEN);
  
                        /* Enable & ramp VMID at 2x50k */
                        reg = snd_soc_read(codec, WM8960_POWER1);
                /* Disable VMID and VREF, let them discharge */
                snd_soc_write(codec, WM8960_POWER1, 0);
                msleep(600);
+               break;
+       }
+       codec->bias_level = level;
+       return 0;
+ }
+ static int wm8960_set_bias_level_capless(struct snd_soc_codec *codec,
+                                        enum snd_soc_bias_level level)
+ {
+       struct wm8960_priv *wm8960 = snd_soc_codec_get_drvdata(codec);
+       int reg;
+       switch (level) {
+       case SND_SOC_BIAS_ON:
+               break;
+       case SND_SOC_BIAS_PREPARE:
+               switch (codec->bias_level) {
+               case SND_SOC_BIAS_STANDBY:
+                       /* Enable anti pop mode */
+                       snd_soc_update_bits(codec, WM8960_APOP1,
+                                           WM8960_POBCTRL | WM8960_SOFT_ST |
+                                           WM8960_BUFDCOPEN,
+                                           WM8960_POBCTRL | WM8960_SOFT_ST |
+                                           WM8960_BUFDCOPEN);
+                       /* Enable LOUT1, ROUT1 and OUT3 if they're enabled */
+                       reg = 0;
+                       if (wm8960->lout1 && wm8960->lout1->power)
+                               reg |= WM8960_PWR2_LOUT1;
+                       if (wm8960->rout1 && wm8960->rout1->power)
+                               reg |= WM8960_PWR2_ROUT1;
+                       if (wm8960->out3 && wm8960->out3->power)
+                               reg |= WM8960_PWR2_OUT3;
+                       snd_soc_update_bits(codec, WM8960_POWER2,
+                                           WM8960_PWR2_LOUT1 |
+                                           WM8960_PWR2_ROUT1 |
+                                           WM8960_PWR2_OUT3, reg);
+                       /* Enable VMID at 2*50k */
+                       snd_soc_update_bits(codec, WM8960_POWER1,
+                                           WM8960_VMID_MASK, 0x80);
+                       /* Ramp */
+                       msleep(100);
+                       /* Enable VREF */
+                       snd_soc_update_bits(codec, WM8960_POWER1,
+                                           WM8960_VREF, WM8960_VREF);
+                       msleep(100);
+                       break;
+               case SND_SOC_BIAS_ON:
+                       /* Enable anti-pop mode */
+                       snd_soc_update_bits(codec, WM8960_APOP1,
+                                           WM8960_POBCTRL | WM8960_SOFT_ST |
+                                           WM8960_BUFDCOPEN,
+                                           WM8960_POBCTRL | WM8960_SOFT_ST |
+                                           WM8960_BUFDCOPEN);
+                       /* Disable VMID and VREF */
+                       snd_soc_update_bits(codec, WM8960_POWER1,
+                                           WM8960_VREF | WM8960_VMID_MASK, 0);
+                       break;
+               default:
+                       break;
+               }
+               break;
  
-               snd_soc_write(codec, WM8960_APOP1, 0);
+       case SND_SOC_BIAS_STANDBY:
+               switch (codec->bias_level) {
+               case SND_SOC_BIAS_PREPARE:
+                       /* Disable HP discharge */
+                       snd_soc_update_bits(codec, WM8960_APOP2,
+                                           WM8960_DISOP | WM8960_DRES_MASK,
+                                           0);
+                       /* Disable anti-pop features */
+                       snd_soc_update_bits(codec, WM8960_APOP1,
+                                           WM8960_POBCTRL | WM8960_SOFT_ST |
+                                           WM8960_BUFDCOPEN,
+                                           WM8960_POBCTRL | WM8960_SOFT_ST |
+                                           WM8960_BUFDCOPEN);
+                       break;
+               default:
+                       break;
+               }
+               break;
+       case SND_SOC_BIAS_OFF:
                break;
        }
  
@@@ -594,10 -738,6 +739,6 @@@ static int wm8960_set_dai_clkdiv(struc
        u16 reg;
  
        switch (div_id) {
-       case WM8960_SYSCLKSEL:
-               reg = snd_soc_read(codec, WM8960_CLOCK1) & 0x1fe;
-               snd_soc_write(codec, WM8960_CLOCK1, reg | div);
-               break;
        case WM8960_SYSCLKDIV:
                reg = snd_soc_read(codec, WM8960_CLOCK1) & 0x1f9;
                snd_soc_write(codec, WM8960_CLOCK1, reg | div);
@@@ -663,7 -803,7 +804,7 @@@ static int wm8960_suspend(struct platfo
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
  
-       wm8960_set_bias_level(codec, SND_SOC_BIAS_OFF);
+       codec->set_bias_level(codec, SND_SOC_BIAS_OFF);
        return 0;
  }
  
@@@ -682,8 -822,8 +823,8 @@@ static int wm8960_resume(struct platfor
                codec->hw_write(codec->control_data, data, 2);
        }
  
-       wm8960_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       wm8960_set_bias_level(codec, codec->suspend_bias_level);
+       codec->set_bias_level(codec, SND_SOC_BIAS_STANDBY);
        return 0;
  }
  
@@@ -753,6 -893,8 +894,8 @@@ static int wm8960_register(struct wm896
                goto err;
        }
  
+       codec->set_bias_level = wm8960_set_bias_level_out3;
        if (!pdata) {
                dev_warn(codec->dev, "No platform data supplied\n");
        } else {
                        dev_err(codec->dev, "Invalid DRES: %d\n", pdata->dres);
                        pdata->dres = 0;
                }
+               if (pdata->capless)
+                       codec->set_bias_level = wm8960_set_bias_level_capless;
        }
  
        mutex_init(&codec->mutex);
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8960;
+       snd_soc_codec_set_drvdata(codec, wm8960);
        codec->name = "WM8960";
        codec->owner = THIS_MODULE;
        codec->bias_level = SND_SOC_BIAS_OFF;
-       codec->set_bias_level = wm8960_set_bias_level;
        codec->dai = &wm8960_dai;
        codec->num_dai = 1;
        codec->reg_cache_size = WM8960_CACHEREGNUM;
  
        wm8960_dai.dev = codec->dev;
  
-       wm8960_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
+       codec->set_bias_level(codec, SND_SOC_BIAS_STANDBY);
  
        /* Latch the update bits */
        reg = snd_soc_read(codec, WM8960_LINVOL);
@@@ -841,7 -985,7 +986,7 @@@ err
  
  static void wm8960_unregister(struct wm8960_priv *wm8960)
  {
-       wm8960_set_bias_level(&wm8960->codec, SND_SOC_BIAS_OFF);
+       wm8960->codec.set_bias_level(&wm8960->codec, SND_SOC_BIAS_OFF);
        snd_soc_unregister_dai(&wm8960_dai);
        snd_soc_unregister_codec(&wm8960->codec);
        kfree(wm8960);
@@@ -883,7 -1027,7 +1028,7 @@@ MODULE_DEVICE_TABLE(i2c, wm8960_i2c_id)
  
  static struct i2c_driver wm8960_i2c_driver = {
        .driver = {
-               .name = "WM8960 I2C Codec",
+               .name = "wm8960",
                .owner = THIS_MODULE,
        },
        .probe =    wm8960_i2c_probe,
@@@ -18,7 -18,6 +18,7 @@@
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -631,7 -630,7 +631,7 @@@ static int wm8961_hw_params(struct snd_
                            struct snd_soc_dai *dai)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8961_priv *wm8961 = codec->private_data;
+       struct wm8961_priv *wm8961 = snd_soc_codec_get_drvdata(codec);
        int i, best, target, fs;
        u16 reg;
  
@@@ -722,7 -721,7 +722,7 @@@ static int wm8961_set_sysclk(struct snd
                             int dir)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8961_priv *wm8961 = codec->private_data;
+       struct wm8961_priv *wm8961 = snd_soc_codec_get_drvdata(codec);
        u16 reg = snd_soc_read(codec, WM8961_CLOCKING1);
  
        if (freq > 33000000) {
@@@ -1065,7 -1064,7 +1065,7 @@@ static int wm8961_register(struct wm896
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8961;
+       snd_soc_codec_set_drvdata(codec, wm8961);
        codec->name = "WM8961";
        codec->owner = THIS_MODULE;
        codec->dai = &wm8961_dai;
@@@ -20,7 -20,6 +20,7 @@@
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -415,7 -414,7 +415,7 @@@ static int wm8971_set_dai_sysclk(struc
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8971_priv *wm8971 = codec->private_data;
+       struct wm8971_priv *wm8971 = snd_soc_codec_get_drvdata(codec);
  
        switch (freq) {
        case 11289600:
@@@ -494,7 -493,7 +494,7 @@@ static int wm8971_pcm_hw_params(struct 
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8971_priv *wm8971 = codec->private_data;
+       struct wm8971_priv *wm8971 = snd_soc_codec_get_drvdata(codec);
        u16 iface = snd_soc_read(codec, WM8971_IFACE) & 0x1f3;
        u16 srate = snd_soc_read(codec, WM8971_SRATE) & 0x1c0;
        int coeff = get_coeff(wm8971->sysclk, params_rate(params));
@@@ -820,7 -819,7 +820,7 @@@ static int wm8971_probe(struct platform
                return -ENOMEM;
        }
  
-       codec->private_data = wm8971;
+       snd_soc_codec_set_drvdata(codec, wm8971);
        socdev->card->codec = codec;
        mutex_init(&codec->mutex);
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_DELAYED_WORK(&codec->delayed_work, wm8971_work);
        wm8971_workq = create_workqueue("wm8971");
        if (wm8971_workq == NULL) {
-               kfree(codec->private_data);
+               kfree(snd_soc_codec_get_drvdata(codec));
                kfree(codec);
                return -ENOMEM;
        }
  
        if (ret != 0) {
                destroy_workqueue(wm8971_workq);
-               kfree(codec->private_data);
+               kfree(snd_soc_codec_get_drvdata(codec));
                kfree(codec);
        }
  
@@@ -867,7 -866,7 +867,7 @@@ static int wm8971_remove(struct platfor
        i2c_unregister_device(codec->control_data);
        i2c_del_driver(&wm8971_i2c_driver);
  #endif
-       kfree(codec->private_data);
+       kfree(snd_soc_codec_get_drvdata(codec));
        kfree(codec);
  
        return 0;
@@@ -18,7 -18,6 +18,7 @@@
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -181,7 -180,7 +181,7 @@@ SOC_SINGLE("ADC 128x Oversampling Switc
  static const struct snd_kcontrol_new wm8974_speaker_mixer_controls[] = {
  SOC_DAPM_SINGLE("Line Bypass Switch", WM8974_SPKMIX, 1, 1, 0),
  SOC_DAPM_SINGLE("Aux Playback Switch", WM8974_SPKMIX, 5, 1, 0),
- SOC_DAPM_SINGLE("PCM Playback Switch", WM8974_SPKMIX, 0, 1, 1),
+ SOC_DAPM_SINGLE("PCM Playback Switch", WM8974_SPKMIX, 0, 1, 0),
  };
  
  /* Mono Output Mixer */
@@@ -609,7 -608,7 +609,7 @@@ static int wm8974_resume(struct platfor
                codec->hw_write(codec->control_data, data, 2);
        }
        wm8974_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
-       wm8974_set_bias_level(codec, codec->suspend_bias_level);
        return 0;
  }
  
@@@ -677,7 -676,7 +677,7 @@@ static __devinit int wm8974_register(st
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8974;
+       snd_soc_codec_set_drvdata(codec, wm8974);
        codec->name = "WM8974";
        codec->owner = THIS_MODULE;
        codec->bias_level = SND_SOC_BIAS_OFF;
@@@ -19,7 -19,6 +19,7 @@@
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -439,7 -438,7 +439,7 @@@ static int wm8978_enum_mclk(unsigned in
   */
  static int wm8978_configure_pll(struct snd_soc_codec *codec)
  {
-       struct wm8978_priv *wm8978 = codec->private_data;
+       struct wm8978_priv *wm8978 = snd_soc_codec_get_drvdata(codec);
        struct wm8978_pll_div pll_div;
        unsigned int f_opclk = wm8978->f_opclk, f_mclk = wm8978->f_mclk,
                f_256fs = wm8978->f_256fs;
@@@ -535,7 -534,7 +535,7 @@@ static int wm8978_set_dai_clkdiv(struc
                                 int div_id, int div)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8978_priv *wm8978 = codec->private_data;
+       struct wm8978_priv *wm8978 = snd_soc_codec_get_drvdata(codec);
        int ret = 0;
  
        switch (div_id) {
@@@ -580,7 -579,7 +580,7 @@@ static int wm8978_set_dai_sysclk(struc
                                 unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8978_priv *wm8978 = codec->private_data;
+       struct wm8978_priv *wm8978 = snd_soc_codec_get_drvdata(codec);
        int ret = 0;
  
        dev_dbg(codec->dev, "%s: ID %d, freq %u\n", __func__, clk_id, freq);
@@@ -692,7 -691,7 +692,7 @@@ static int wm8978_hw_params(struct snd_
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8978_priv *wm8978 = codec->private_data;
+       struct wm8978_priv *wm8978 = snd_soc_codec_get_drvdata(codec);
        /* Word length mask = 0x60 */
        u16 iface_ctl = snd_soc_read(codec, WM8978_AUDIO_INTERFACE) & ~0x60;
        /* Sampling rate mask = 0xe (for filters) */
@@@ -912,7 -911,7 +912,7 @@@ static int wm8978_resume(struct platfor
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8978_priv *wm8978 = codec->private_data;
+       struct wm8978_priv *wm8978 = snd_soc_codec_get_drvdata(codec);
        int i;
        u16 *cache = codec->reg_cache;
  
@@@ -1020,7 -1019,7 +1020,7 @@@ static __devinit int wm8978_register(st
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8978;
+       snd_soc_codec_set_drvdata(codec, wm8978);
        codec->name = "WM8978";
        codec->owner = THIS_MODULE;
        codec->bias_level = SND_SOC_BIAS_OFF;
@@@ -19,7 -19,6 +19,7 @@@
  #include <linux/i2c.h>
  #include <linux/spi/spi.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -495,7 -494,7 +495,7 @@@ static int wm8988_set_dai_sysclk(struc
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8988_priv *wm8988 = codec->private_data;
+       struct wm8988_priv *wm8988 = snd_soc_codec_get_drvdata(codec);
  
        switch (freq) {
        case 11289600:
@@@ -585,7 -584,7 +585,7 @@@ static int wm8988_pcm_startup(struct sn
                              struct snd_soc_dai *dai)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8988_priv *wm8988 = codec->private_data;
+       struct wm8988_priv *wm8988 = snd_soc_codec_get_drvdata(codec);
  
        /* The set of sample rates that can be supported depends on the
         * MCLK supplied to the CODEC - enforce this.
@@@ -610,7 -609,7 +610,7 @@@ static int wm8988_pcm_hw_params(struct 
        struct snd_soc_pcm_runtime *rtd = substream->private_data;
        struct snd_soc_device *socdev = rtd->socdev;
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8988_priv *wm8988 = codec->private_data;
+       struct wm8988_priv *wm8988 = snd_soc_codec_get_drvdata(codec);
        u16 iface = snd_soc_read(codec, WM8988_IFACE) & 0x1f3;
        u16 srate = snd_soc_read(codec, WM8988_SRATE) & 0x180;
        int coeff;
@@@ -833,7 -832,7 +833,7 @@@ static int wm8988_register(struct wm898
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8988;
+       snd_soc_codec_set_drvdata(codec, wm8988);
        codec->name = "WM8988";
        codec->owner = THIS_MODULE;
        codec->dai = &wm8988_dai;
@@@ -18,7 -18,6 +18,7 @@@
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -1012,7 -1011,7 +1012,7 @@@ static int wm8990_set_dai_sysclk(struc
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8990_priv *wm8990 = codec->private_data;
+       struct wm8990_priv *wm8990 = snd_soc_codec_get_drvdata(codec);
  
        wm8990->sysclk = freq;
        return 0;
@@@ -1524,7 -1523,7 +1524,7 @@@ static int wm8990_probe(struct platform
                return -ENOMEM;
        }
  
-       codec->private_data = wm8990;
+       snd_soc_codec_set_drvdata(codec, wm8990);
        socdev->card->codec = codec;
        mutex_init(&codec->mutex);
        INIT_LIST_HEAD(&codec->dapm_widgets);
  #endif
  
        if (ret != 0) {
-               kfree(codec->private_data);
+               kfree(snd_soc_codec_get_drvdata(codec));
                kfree(codec);
        }
        return ret;
@@@ -1561,7 -1560,7 +1561,7 @@@ static int wm8990_remove(struct platfor
        i2c_unregister_device(codec->control_data);
        i2c_del_driver(&wm8990_i2c_driver);
  #endif
-       kfree(codec->private_data);
+       kfree(snd_soc_codec_get_drvdata(codec));
        kfree(codec);
  
        return 0;
@@@ -18,7 -18,6 +18,7 @@@
  #include <linux/i2c.h>
  #include <linux/regulator/consumer.h>
  #include <linux/spi/spi.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -371,7 -370,7 +371,7 @@@ static int wm8993_set_fll(struct snd_so
                          unsigned int Fref, unsigned int Fout)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8993_priv *wm8993 = codec->private_data;
+       struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec);
        u16 reg1, reg4, reg5;
        struct _fll_div fll_div;
        int ret;
  
  static int configure_clock(struct snd_soc_codec *codec)
  {
-       struct wm8993_priv *wm8993 = codec->private_data;
+       struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec);
        unsigned int reg;
  
        /* This should be done on init() for bypass paths */
@@@ -717,7 -716,7 +717,7 @@@ static int class_w_put(struct snd_kcont
  {
        struct snd_soc_dapm_widget *widget = snd_kcontrol_chip(kcontrol);
        struct snd_soc_codec *codec = widget->codec;
-       struct wm8993_priv *wm8993 = codec->private_data;
+       struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec);
        int ret;
  
        /* Turn it off if we're using the main output mixer */
@@@ -949,7 -948,7 +949,7 @@@ static void wm8993_cache_restore(struc
  static int wm8993_set_bias_level(struct snd_soc_codec *codec,
                                 enum snd_soc_bias_level level)
  {
-       struct wm8993_priv *wm8993 = codec->private_data;
+       struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec);
        int ret;
  
        switch (level) {
@@@ -1047,7 -1046,7 +1047,7 @@@ static int wm8993_set_sysclk(struct snd
                             int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm8993_priv *wm8993 = codec->private_data;
+       struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec);
  
        switch (clk_id) {
        case WM8993_SYSCLK_MCLK:
@@@ -1067,7 -1066,7 +1067,7 @@@ static int wm8993_set_dai_fmt(struct sn
                              unsigned int fmt)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8993_priv *wm8993 = codec->private_data;
+       struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec);
        unsigned int aif1 = snd_soc_read(codec, WM8993_AUDIO_INTERFACE_1);
        unsigned int aif4 = snd_soc_read(codec, WM8993_AUDIO_INTERFACE_4);
  
@@@ -1163,7 -1162,7 +1163,7 @@@ static int wm8993_hw_params(struct snd_
                            struct snd_soc_dai *dai)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8993_priv *wm8993 = codec->private_data;
+       struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec);
        int ret, i, best, best_val, cur_val;
        unsigned int clocking1, clocking3, aif1, aif4;
  
@@@ -1328,7 -1327,7 +1328,7 @@@ static int wm8993_set_tdm_slot(struct s
                               unsigned int rx_mask, int slots, int slot_width)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8993_priv *wm8993 = codec->private_data;
+       struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec);
        int aif1 = 0;
        int aif2 = 0;
  
@@@ -1431,7 -1430,7 +1431,7 @@@ static int wm8993_probe(struct platform
  
        socdev->card->codec = wm8993_codec;
        codec = wm8993_codec;
-       wm8993 = codec->private_data;
+       wm8993 = snd_soc_codec_get_drvdata(codec);
  
        ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
        if (ret < 0) {
@@@ -1478,7 -1477,7 +1478,7 @@@ static int wm8993_suspend(struct platfo
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8993_priv *wm8993 = codec->private_data;
+       struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec);
        int fll_fout = wm8993->fll_fout;
        int fll_fref  = wm8993->fll_fref;
        int ret;
@@@ -1502,7 -1501,7 +1502,7 @@@ static int wm8993_resume(struct platfor
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8993_priv *wm8993 = codec->private_data;
+       struct wm8993_priv *wm8993 = snd_soc_codec_get_drvdata(codec);
        int ret;
  
        wm8993_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
@@@ -1571,7 -1570,7 +1571,7 @@@ static int wm8993_i2c_probe(struct i2c_
        codec->set_bias_level = wm8993_set_bias_level;
        codec->dai = &wm8993_dai;
        codec->num_dai = 1;
-       codec->private_data = wm8993;
+       snd_soc_codec_set_drvdata(codec, wm8993);
  
        wm8993->hubs_data.hp_startup_mode = 1;
        wm8993->hubs_data.dcs_codes = -2;
@@@ -19,7 -19,6 +19,7 @@@
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
  #include <linux/regulator/consumer.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -62,6 -61,12 +62,12 @@@ static int wm8994_retune_mobile_base[] 
  
  #define WM8994_REG_CACHE_SIZE  0x621
  
+ struct wm8994_micdet {
+       struct snd_soc_jack *jack;
+       int det;
+       int shrt;
+ };
  /* codec private data */
  struct wm8994_priv {
        struct wm_hubs_data hubs;
@@@ -87,6 -92,8 +93,8 @@@
        int retune_mobile_cfg[WM8994_NUM_EQ];
        struct soc_enum retune_mobile_enum;
  
+       struct wm8994_micdet micdet[2];
        struct wm8994_pdata *pdata;
  };
  
@@@ -1696,13 -1703,15 +1704,15 @@@ static int wm8994_volatile(unsigned in
  static int wm8994_write(struct snd_soc_codec *codec, unsigned int reg,
        unsigned int value)
  {
-       struct wm8994_priv *wm8994 = codec->private_data;
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
  
        BUG_ON(reg > WM8994_MAX_REGISTER);
  
        if (!wm8994_volatile(reg))
                wm8994->reg_cache[reg] = value;
  
+       dev_dbg(codec->dev, "0x%x = 0x%x\n", reg, value);
        return wm8994_reg_write(codec->control_data, reg, value);
  }
  
@@@ -1721,7 -1730,7 +1731,7 @@@ static unsigned int wm8994_read(struct 
  
  static int configure_aif_clock(struct snd_soc_codec *codec, int aif)
  {
-       struct wm8994_priv *wm8994 = codec->private_data;
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
        int rate;
        int reg1 = 0;
        int offset;
                dev_dbg(codec->dev, "Dividing AIF%d clock to %dHz\n",
                        aif + 1, rate);
        }
+       if (rate && rate < 3000000)
+               dev_warn(codec->dev, "AIF%dCLK is %dHz, should be >=3MHz for optimal performance\n",
+                        aif + 1, rate);
        wm8994->aifclk[aif] = rate;
  
        snd_soc_update_bits(codec, WM8994_AIF1_CLOCKING_1 + offset,
  
  static int configure_clock(struct snd_soc_codec *codec)
  {
-       struct wm8994_priv *wm8994 = codec->private_data;
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
        int old, new;
  
        /* Bring up the AIF clocks first */
@@@ -1870,7 -1884,7 +1885,7 @@@ static int wm8994_put_drc_sw(struct snd
  
  static void wm8994_set_drc(struct snd_soc_codec *codec, int drc)
  {
-       struct wm8994_priv *wm8994 = codec->private_data;
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
        struct wm8994_pdata *pdata = wm8994->pdata;
        int base = wm8994_drc_base[drc];
        int cfg = wm8994->drc_cfg[drc];
@@@ -1906,7 -1920,7 +1921,7 @@@ static int wm8994_put_drc_enum(struct s
                               struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8994_priv *wm8994 = codec->private_data;       
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);  
        struct wm8994_pdata *pdata = wm8994->pdata;
        int drc = wm8994_get_drc(kcontrol->id.name);
        int value = ucontrol->value.integer.value[0];
@@@ -1928,7 -1942,7 +1943,7 @@@ static int wm8994_get_drc_enum(struct s
                               struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8994_priv *wm8994 = codec->private_data;
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
        int drc = wm8994_get_drc(kcontrol->id.name);
  
        ucontrol->value.enumerated.item[0] = wm8994->drc_cfg[drc];
  
  static void wm8994_set_retune_mobile(struct snd_soc_codec *codec, int block)
  {
-       struct wm8994_priv *wm8994 = codec->private_data;
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
        struct wm8994_pdata *pdata = wm8994->pdata;
        int base = wm8994_retune_mobile_base[block];
        int iface, best, best_val, save, i, cfg;
@@@ -2009,7 -2023,7 +2024,7 @@@ static int wm8994_put_retune_mobile_enu
                                         struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8994_priv *wm8994 = codec->private_data;       
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);  
        struct wm8994_pdata *pdata = wm8994->pdata;
        int block = wm8994_get_retune_mobile_block(kcontrol->id.name);
        int value = ucontrol->value.integer.value[0];
@@@ -2031,7 -2045,7 +2046,7 @@@ static int wm8994_get_retune_mobile_enu
                                         struct snd_ctl_elem_value *ucontrol)
  {
        struct snd_soc_codec *codec = snd_kcontrol_chip(kcontrol);
-       struct wm8994_priv *wm8994 = codec->private_data;
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
        int block = wm8994_get_retune_mobile_block(kcontrol->id.name);
  
        ucontrol->value.enumerated.item[0] = wm8994->retune_mobile_cfg[block];
@@@ -2182,13 -2196,13 +2197,13 @@@ static void wm8994_update_class_w(struc
        /* Only support direct DAC->headphone paths */
        reg = snd_soc_read(codec, WM8994_OUTPUT_MIXER_1);
        if (!(reg & WM8994_DAC1L_TO_HPOUT1L)) {
-               dev_dbg(codec->dev, "HPL connected to output mixer\n");
+               dev_vdbg(codec->dev, "HPL connected to output mixer\n");
                enable = 0;
        }
  
        reg = snd_soc_read(codec, WM8994_OUTPUT_MIXER_2);
        if (!(reg & WM8994_DAC1R_TO_HPOUT1R)) {
-               dev_dbg(codec->dev, "HPR connected to output mixer\n");
+               dev_vdbg(codec->dev, "HPR connected to output mixer\n");
                enable = 0;
        }
  
        reg = snd_soc_read(codec, WM8994_DAC1_LEFT_MIXER_ROUTING);
        switch (reg) {
        case WM8994_AIF2DACL_TO_DAC1L:
-               dev_dbg(codec->dev, "Class W source AIF2DAC\n");
+               dev_vdbg(codec->dev, "Class W source AIF2DAC\n");
                source = 2 << WM8994_CP_DYN_SRC_SEL_SHIFT;
                break;
        case WM8994_AIF1DAC2L_TO_DAC1L:
-               dev_dbg(codec->dev, "Class W source AIF1DAC2\n");
+               dev_vdbg(codec->dev, "Class W source AIF1DAC2\n");
                source = 1 << WM8994_CP_DYN_SRC_SEL_SHIFT;
                break;
        case WM8994_AIF1DAC1L_TO_DAC1L:
-               dev_dbg(codec->dev, "Class W source AIF1DAC1\n");
+               dev_vdbg(codec->dev, "Class W source AIF1DAC1\n");
                source = 0 << WM8994_CP_DYN_SRC_SEL_SHIFT;
                break;
        default:
-               dev_dbg(codec->dev, "DAC mixer setting: %x\n", reg);
+               dev_vdbg(codec->dev, "DAC mixer setting: %x\n", reg);
                enable = 0;
                break;
        }
  
        reg_r = snd_soc_read(codec, WM8994_DAC1_RIGHT_MIXER_ROUTING);
        if (reg_r != reg) {
-               dev_dbg(codec->dev, "Left and right DAC mixers different\n");
+               dev_vdbg(codec->dev, "Left and right DAC mixers different\n");
                enable = 0;
        }
  
@@@ -2777,9 -2791,18 +2792,18 @@@ static int wm8994_get_fll_config(struc
  
        if (freq_in > 1000000) {
                fll->fll_fratio = 0;
-       } else {
+       } else if (freq_in > 256000) {
+               fll->fll_fratio = 1;
+               freq_in *= 2;
+       } else if (freq_in > 128000) {
+               fll->fll_fratio = 2;
+               freq_in *= 4;
+       } else if (freq_in > 64000) {
                fll->fll_fratio = 3;
                freq_in *= 8;
+       } else {
+               fll->fll_fratio = 4;
+               freq_in *= 16;
        }
        pr_debug("FLL_FRATIO=%d, Fref=%dHz\n", fll->fll_fratio, freq_in);
  
@@@ -2812,7 -2835,7 +2836,7 @@@ static int wm8994_set_fll(struct snd_so
                          unsigned int freq_in, unsigned int freq_out)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8994_priv *wm8994 = codec->private_data;
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
        int reg_offset, ret;
        struct fll_div fll;
        u16 reg, aif1, aif2;
                return -EINVAL;
        }
  
+       switch (src) {
+       case 0:
+               /* Allow no source specification when stopping */
+               if (freq_out)
+                       return -EINVAL;
+               break;
+       case WM8994_FLL_SRC_MCLK1:
+       case WM8994_FLL_SRC_MCLK2:
+       case WM8994_FLL_SRC_LRCLK:
+       case WM8994_FLL_SRC_BCLK:
+               break;
+       default:
+               return -EINVAL;
+       }
        /* Are we changing anything? */
        if (wm8994->fll[id].src == src &&
            wm8994->fll[id].in == freq_in && wm8994->fll[id].out == freq_out)
                                    fll.n << WM8994_FLL1_N_SHIFT);
  
        snd_soc_update_bits(codec, WM8994_FLL1_CONTROL_5 + reg_offset,
-                           WM8994_FLL1_REFCLK_DIV_MASK,
-                           fll.clk_ref_div << WM8994_FLL1_REFCLK_DIV_SHIFT);
+                           WM8994_FLL1_REFCLK_DIV_MASK |
+                           WM8994_FLL1_REFCLK_SRC_MASK,
+                           (fll.clk_ref_div << WM8994_FLL1_REFCLK_DIV_SHIFT) |
+                           (src - 1));
  
        /* Enable (with fractional mode if required) */
        if (freq_out) {
  
        wm8994->fll[id].in = freq_in;
        wm8994->fll[id].out = freq_out;
+       wm8994->fll[id].src = src;
  
        /* Enable any gated AIF clocks */
        snd_soc_update_bits(codec, WM8994_AIF1_CLOCKING_1,
@@@ -2908,7 -2949,7 +2950,7 @@@ static int wm8994_set_dai_sysclk(struc
                int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8994_priv *wm8994 = codec->private_data;
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
  
        switch (dai->id) {
        case 1:
@@@ -3174,7 -3215,7 +3216,7 @@@ static int wm8994_hw_params(struct snd_
                            struct snd_soc_dai *dai)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm8994_priv *wm8994 = codec->private_data;
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
        int aif1_reg;
        int bclk_reg;
        int lrclk_reg;
@@@ -3338,6 -3379,36 +3380,36 @@@ static int wm8994_aif_mute(struct snd_s
        return 0;
  }
  
+ static int wm8994_set_tristate(struct snd_soc_dai *codec_dai, int tristate)
+ {
+       struct snd_soc_codec *codec = codec_dai->codec;
+       int reg, val, mask;
+       switch (codec_dai->id) {
+       case 1:
+               reg = WM8994_AIF1_MASTER_SLAVE;
+               mask = WM8994_AIF1_TRI;
+               break;
+       case 2:
+               reg = WM8994_AIF2_MASTER_SLAVE;
+               mask = WM8994_AIF2_TRI;
+               break;
+       case 3:
+               reg = WM8994_POWER_MANAGEMENT_6;
+               mask = WM8994_AIF3_TRI;
+               break;
+       default:
+               return -EINVAL;
+       }
+       if (tristate)
+               val = mask;
+       else
+               val = 0;
+       return snd_soc_update_bits(codec, reg, mask, reg);
+ }
  #define WM8994_RATES SNDRV_PCM_RATE_8000_96000
  
  #define WM8994_FORMATS (SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S20_3LE |\
@@@ -3349,6 -3420,7 +3421,7 @@@ static struct snd_soc_dai_ops wm8994_ai
        .hw_params      = wm8994_hw_params,
        .digital_mute   = wm8994_aif_mute,
        .set_pll        = wm8994_set_fll,
+       .set_tristate   = wm8994_set_tristate,
  };
  
  static struct snd_soc_dai_ops wm8994_aif2_dai_ops = {
        .hw_params      = wm8994_hw_params,
        .digital_mute   = wm8994_aif_mute,
        .set_pll        = wm8994_set_fll,
+       .set_tristate   = wm8994_set_tristate,
+ };
+ static struct snd_soc_dai_ops wm8994_aif3_dai_ops = {
+       .set_tristate   = wm8994_set_tristate,
  };
  
  struct snd_soc_dai wm8994_dai[] = {
        },
        {
                .name = "WM8994 AIF3",
+               .id = 3,
                .playback = {
                        .stream_name = "AIF3 Playback",
                        .channels_min = 2,
                        .rates = WM8994_RATES,
                        .formats = WM8994_FORMATS,
                },
+               .ops = &wm8994_aif3_dai_ops,
        }
  };
  EXPORT_SYMBOL_GPL(wm8994_dai);
@@@ -3423,7 -3502,7 +3503,7 @@@ static int wm8994_suspend(struct platfo
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8994_priv *wm8994 = codec->private_data;
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
        int i, ret;
  
        for (i = 0; i < ARRAY_SIZE(wm8994->fll); i++) {
@@@ -3444,7 -3523,7 +3524,7 @@@ static int wm8994_resume(struct platfor
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm8994_priv *wm8994 = codec->private_data;
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
        u16 *reg_cache = codec->reg_cache;
        int i, ret;
  
        wm8994_set_bias_level(codec, SND_SOC_BIAS_STANDBY);
  
        for (i = 0; i < ARRAY_SIZE(wm8994->fll); i++) {
+               if (!wm8994->fll_suspend[i].out)
+                       continue;
                ret = wm8994_set_fll(&codec->dai[0], i + 1,
                                     wm8994->fll_suspend[i].src,
                                     wm8994->fll_suspend[i].in,
@@@ -3639,7 -3721,7 +3722,7 @@@ static int wm8994_probe(struct platform
                return ret;
        }
  
-       wm8994_handle_pdata(codec->private_data);
+       wm8994_handle_pdata(snd_soc_codec_get_drvdata(codec));
  
        wm_hubs_add_analogue_controls(codec);
        snd_soc_add_controls(codec, wm8994_snd_controls,
@@@ -3670,6 -3752,96 +3753,96 @@@ struct snd_soc_codec_device soc_codec_d
  };
  EXPORT_SYMBOL_GPL(soc_codec_dev_wm8994);
  
+ /**
+  * wm8994_mic_detect - Enable microphone detection via the WM8994 IRQ
+  *
+  * @codec:   WM8994 codec
+  * @jack:    jack to report detection events on
+  * @micbias: microphone bias to detect on
+  * @det:     value to report for presence detection
+  * @shrt:    value to report for short detection
+  *
+  * Enable microphone detection via IRQ on the WM8994.  If GPIOs are
+  * being used to bring out signals to the processor then only platform
+  * data configuration is needed for WM8903 and processor GPIOs should
+  * be configured using snd_soc_jack_add_gpios() instead.
+  *
+  * Configuration of detection levels is available via the micbias1_lvl
+  * and micbias2_lvl platform data members.
+  */
+ int wm8994_mic_detect(struct snd_soc_codec *codec, struct snd_soc_jack *jack,
+                     int micbias, int det, int shrt)
+ {
+       struct wm8994_priv *wm8994 = snd_soc_codec_get_drvdata(codec);
+       struct wm8994_micdet *micdet;
+       int reg;
+       switch (micbias) {
+       case 1:
+               micdet = &wm8994->micdet[0];
+               break;
+       case 2:
+               micdet = &wm8994->micdet[1];
+               break;
+       default:
+               return -EINVAL;
+       }       
+       dev_dbg(codec->dev, "Configuring microphone detection on %d: %x %x\n",
+               micbias, det, shrt);
+       /* Store the configuration */
+       micdet->jack = jack;
+       micdet->det = det;
+       micdet->shrt = shrt;
+       /* If either of the jacks is set up then enable detection */
+       if (wm8994->micdet[0].jack || wm8994->micdet[1].jack)
+               reg = WM8994_MICD_ENA;
+       else 
+               reg = 0;
+       snd_soc_update_bits(codec, WM8994_MICBIAS, WM8994_MICD_ENA, reg);
+       return 0;
+ }
+ EXPORT_SYMBOL_GPL(wm8994_mic_detect);
+ static irqreturn_t wm8994_mic_irq(int irq, void *data)
+ {
+       struct wm8994_priv *priv = data;
+       struct snd_soc_codec *codec = &priv->codec;
+       int reg;
+       int report;
+       reg = snd_soc_read(codec, WM8994_INTERRUPT_RAW_STATUS_2);
+       if (reg < 0) {
+               dev_err(codec->dev, "Failed to read microphone status: %d\n",
+                       reg);
+               return IRQ_HANDLED;
+       }
+       dev_dbg(codec->dev, "Microphone status: %x\n", reg);
+       report = 0;
+       if (reg & WM8994_MIC1_DET_STS)
+               report |= priv->micdet[0].det;
+       if (reg & WM8994_MIC1_SHRT_STS)
+               report |= priv->micdet[0].shrt;
+       snd_soc_jack_report(priv->micdet[0].jack, report,
+                           priv->micdet[0].det | priv->micdet[0].shrt);
+       report = 0;
+       if (reg & WM8994_MIC2_DET_STS)
+               report |= priv->micdet[1].det;
+       if (reg & WM8994_MIC2_SHRT_STS)
+               report |= priv->micdet[1].shrt;
+       snd_soc_jack_report(priv->micdet[1].jack, report,
+                           priv->micdet[1].det | priv->micdet[1].shrt);
+       return IRQ_HANDLED;
+ }
  static int wm8994_codec_probe(struct platform_device *pdev)
  {
        int ret;
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm8994;
+       snd_soc_codec_set_drvdata(codec, wm8994);
        codec->control_data = dev_get_drvdata(pdev->dev.parent);
        codec->name = "WM8994";
        codec->owner = THIS_MODULE;
                break;
        }
  
+       ret = wm8994_request_irq(codec->control_data, WM8994_IRQ_MIC1_DET,
+                                wm8994_mic_irq, "Mic 1 detect", wm8994);
+       if (ret != 0)
+               dev_warn(&pdev->dev,
+                        "Failed to request Mic1 detect IRQ: %d\n", ret);
+       ret = wm8994_request_irq(codec->control_data, WM8994_IRQ_MIC1_SHRT,
+                                wm8994_mic_irq, "Mic 1 short", wm8994);
+       if (ret != 0)
+               dev_warn(&pdev->dev,
+                        "Failed to request Mic1 short IRQ: %d\n", ret);
+       ret = wm8994_request_irq(codec->control_data, WM8994_IRQ_MIC2_DET,
+                                wm8994_mic_irq, "Mic 2 detect", wm8994);
+       if (ret != 0)
+               dev_warn(&pdev->dev,
+                        "Failed to request Mic2 detect IRQ: %d\n", ret);
+       ret = wm8994_request_irq(codec->control_data, WM8994_IRQ_MIC2_SHRT,
+                                wm8994_mic_irq, "Mic 2 short", wm8994);
+       if (ret != 0)
+               dev_warn(&pdev->dev,
+                        "Failed to request Mic2 short IRQ: %d\n", ret);
        /* Remember if AIFnLRCLK is configured as a GPIO.  This should be
         * configured on init - if a system wants to do this dynamically
         * at runtime we can deal with that then.
        ret = wm8994_reg_read(codec->control_data, WM8994_GPIO_1);
        if (ret < 0) {
                dev_err(codec->dev, "Failed to read GPIO1 state: %d\n", ret);
-               goto err;
+               goto err_irq;
        }
        if ((ret & WM8994_GPN_FN_MASK) != WM8994_GP_FN_PIN_SPECIFIC) {
                wm8994->lrclk_shared[0] = 1;
        ret = wm8994_reg_read(codec->control_data, WM8994_GPIO_6);
        if (ret < 0) {
                dev_err(codec->dev, "Failed to read GPIO6 state: %d\n", ret);
-               goto err;
+               goto err_irq;
        }
        if ((ret & WM8994_GPN_FN_MASK) != WM8994_GP_FN_PIN_SPECIFIC) {
                wm8994->lrclk_shared[1] = 1;
        ret = snd_soc_register_codec(codec);
        if (ret != 0) {
                dev_err(codec->dev, "Failed to register codec: %d\n", ret);
-               goto err;
+               goto err_irq;
        }
  
        ret = snd_soc_register_dais(wm8994_dai, ARRAY_SIZE(wm8994_dai));
  
  err_codec:
        snd_soc_unregister_codec(codec);
+ err_irq:
+       wm8994_free_irq(codec->control_data, WM8994_IRQ_MIC2_SHRT, wm8994);
+       wm8994_free_irq(codec->control_data, WM8994_IRQ_MIC2_DET, wm8994);
+       wm8994_free_irq(codec->control_data, WM8994_IRQ_MIC1_SHRT, wm8994);
+       wm8994_free_irq(codec->control_data, WM8994_IRQ_MIC1_DET, wm8994);
  err:
        kfree(wm8994);
        return ret;
@@@ -3840,6 -4041,10 +4042,10 @@@ static int __devexit wm8994_codec_remov
        wm8994_set_bias_level(codec, SND_SOC_BIAS_OFF);
        snd_soc_unregister_dais(wm8994_dai, ARRAY_SIZE(wm8994_dai));
        snd_soc_unregister_codec(&wm8994->codec);
+       wm8994_free_irq(codec->control_data, WM8994_IRQ_MIC2_SHRT, wm8994);
+       wm8994_free_irq(codec->control_data, WM8994_IRQ_MIC2_DET, wm8994);
+       wm8994_free_irq(codec->control_data, WM8994_IRQ_MIC1_SHRT, wm8994);
+       wm8994_free_irq(codec->control_data, WM8994_IRQ_MIC1_DET, wm8994);
        kfree(wm8994);
        wm8994_codec = NULL;
  
@@@ -18,7 -18,6 +18,7 @@@
  #include <linux/pm.h>
  #include <linux/i2c.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -521,7 -520,7 +521,7 @@@ static int fll_factors(struct _fll_div 
  static int wm9081_set_fll(struct snd_soc_codec *codec, int fll_id,
                          unsigned int Fref, unsigned int Fout)
  {
-       struct wm9081_priv *wm9081 = codec->private_data;
+       struct wm9081_priv *wm9081 = snd_soc_codec_get_drvdata(codec);
        u16 reg1, reg4, reg5;
        struct _fll_div fll_div;
        int ret;
  
  static int configure_clock(struct snd_soc_codec *codec)
  {
-       struct wm9081_priv *wm9081 = codec->private_data;
+       struct wm9081_priv *wm9081 = snd_soc_codec_get_drvdata(codec);
        int new_sysclk, i, target;
        unsigned int reg;
        int ret = 0;
@@@ -702,7 -701,7 +702,7 @@@ static int clk_sys_event(struct snd_soc
                         struct snd_kcontrol *kcontrol, int event)
  {
        struct snd_soc_codec *codec = w->codec;
-       struct wm9081_priv *wm9081 = codec->private_data;
+       struct wm9081_priv *wm9081 = snd_soc_codec_get_drvdata(codec);
  
        /* This should be done on init() for bypass paths */
        switch (wm9081->sysclk_source) {
@@@ -873,7 -872,7 +873,7 @@@ static int wm9081_set_dai_fmt(struct sn
                              unsigned int fmt)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm9081_priv *wm9081 = codec->private_data;
+       struct wm9081_priv *wm9081 = snd_soc_codec_get_drvdata(codec);
        unsigned int aif2 = snd_soc_read(codec, WM9081_AUDIO_INTERFACE_2);
  
        aif2 &= ~(WM9081_AIF_BCLK_INV | WM9081_AIF_LRCLK_INV |
@@@ -965,7 -964,7 +965,7 @@@ static int wm9081_hw_params(struct snd_
                            struct snd_soc_dai *dai)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm9081_priv *wm9081 = codec->private_data;
+       struct wm9081_priv *wm9081 = snd_soc_codec_get_drvdata(codec);
        int ret, i, best, best_val, cur_val;
        unsigned int clk_ctrl2, aif1, aif2, aif3, aif4;
  
@@@ -1139,7 -1138,7 +1139,7 @@@ static int wm9081_set_sysclk(struct snd
                             int clk_id, unsigned int freq, int dir)
  {
        struct snd_soc_codec *codec = codec_dai->codec;
-       struct wm9081_priv *wm9081 = codec->private_data;
+       struct wm9081_priv *wm9081 = snd_soc_codec_get_drvdata(codec);
  
        switch (clk_id) {
        case WM9081_SYSCLK_MCLK:
@@@ -1159,7 -1158,7 +1159,7 @@@ static int wm9081_set_tdm_slot(struct s
        unsigned int tx_mask, unsigned int rx_mask, int slots, int slot_width)
  {
        struct snd_soc_codec *codec = dai->codec;
-       struct wm9081_priv *wm9081 = codec->private_data;
+       struct wm9081_priv *wm9081 = snd_soc_codec_get_drvdata(codec);
        unsigned int aif1 = snd_soc_read(codec, WM9081_AUDIO_INTERFACE_1);
  
        aif1 &= ~(WM9081_AIFDAC_TDM_SLOT_MASK | WM9081_AIFDAC_TDM_MODE_MASK);
@@@ -1242,7 -1241,7 +1242,7 @@@ static int wm9081_probe(struct platform
  
        socdev->card->codec = wm9081_codec;
        codec = wm9081_codec;
-       wm9081 = codec->private_data;
+       wm9081 = snd_soc_codec_get_drvdata(codec);
  
        /* register pcms */
        ret = snd_soc_new_pcms(socdev, SNDRV_DEFAULT_IDX1, SNDRV_DEFAULT_STR1);
@@@ -1339,7 -1338,7 +1339,7 @@@ static int wm9081_register(struct wm908
        INIT_LIST_HEAD(&codec->dapm_widgets);
        INIT_LIST_HEAD(&codec->dapm_paths);
  
-       codec->private_data = wm9081;
+       snd_soc_codec_set_drvdata(codec, wm9081);
        codec->name = "WM9081";
        codec->owner = THIS_MODULE;
        codec->dai = &wm9081_dai;
@@@ -11,7 -11,6 +11,7 @@@
   */
  
  #include <linux/init.h>
 +#include <linux/slab.h>
  #include <linux/module.h>
  #include <linux/kernel.h>
  #include <linux/device.h>
@@@ -632,9 -631,6 +632,6 @@@ static int wm9712_soc_resume(struct pla
                }
        }
  
-       if (codec->suspend_bias_level == SND_SOC_BIAS_ON)
-               wm9712_set_bias_level(codec, SND_SOC_BIAS_ON);
        return ret;
  }
  
@@@ -16,7 -16,6 +16,7 @@@
   */
  
  #include <linux/init.h>
 +#include <linux/slab.h>
  #include <linux/module.h>
  #include <linux/device.h>
  #include <sound/core.h>
@@@ -764,7 -763,7 +764,7 @@@ static void pll_factors(struct _pll_di
  static int wm9713_set_pll(struct snd_soc_codec *codec,
        int pll_id, unsigned int freq_in, unsigned int freq_out)
  {
-       struct wm9713_priv *wm9713 = codec->private_data;
+       struct wm9713_priv *wm9713 = snd_soc_codec_get_drvdata(codec);
        u16 reg, reg2;
        struct _pll_div pll_div;
  
@@@ -1175,7 -1174,7 +1175,7 @@@ static int wm9713_soc_resume(struct pla
  {
        struct snd_soc_device *socdev = platform_get_drvdata(pdev);
        struct snd_soc_codec *codec = socdev->card->codec;
-       struct wm9713_priv *wm9713 = codec->private_data;
+       struct wm9713_priv *wm9713 = snd_soc_codec_get_drvdata(codec);
        int i, ret;
        u16 *cache = codec->reg_cache;
  
                }
        }
  
-       if (codec->suspend_bias_level == SND_SOC_BIAS_ON)
-               wm9713_set_bias_level(codec, SND_SOC_BIAS_ON);
        return ret;
  }
  
@@@ -1228,8 -1224,9 +1225,9 @@@ static int wm9713_soc_probe(struct plat
        codec->reg_cache_size = sizeof(wm9713_reg);
        codec->reg_cache_step = 2;
  
-       codec->private_data = kzalloc(sizeof(struct wm9713_priv), GFP_KERNEL);
-       if (codec->private_data == NULL) {
+       snd_soc_codec_set_drvdata(codec, kzalloc(sizeof(struct wm9713_priv),
+                                                GFP_KERNEL));
+       if (snd_soc_codec_get_drvdata(codec) == NULL) {
                ret = -ENOMEM;
                goto priv_err;
        }
@@@ -1280,7 -1277,7 +1278,7 @@@ pcm_err
        snd_soc_free_ac97_codec(codec);
  
  codec_err:
-       kfree(codec->private_data);
+       kfree(snd_soc_codec_get_drvdata(codec));
  
  priv_err:
        kfree(codec->reg_cache);
@@@ -1302,7 -1299,7 +1300,7 @@@ static int wm9713_soc_remove(struct pla
        snd_soc_dapm_free(socdev);
        snd_soc_free_pcms(socdev);
        snd_soc_free_ac97_codec(codec);
-       kfree(codec->private_data);
+       kfree(snd_soc_codec_get_drvdata(codec));
        kfree(codec->reg_cache);
        kfree(codec);
        return 0;
diff --combined sound/soc/omap/mcpdm.c
@@@ -1,5 -1,5 +1,5 @@@
  /*
-  * mcpdm.c  --  McPDM interface driver
+  * mcpdm.c  --        McPDM interface driver
   *
   * Author: Jorge Eduardo Candelaria <x0107209@ti.com>
   * Copyright (C) 2009 - Texas Instruments, Inc.
@@@ -25,7 -25,6 +25,7 @@@
  #include <linux/device.h>
  #include <linux/platform_device.h>
  #include <linux/wait.h>
 +#include <linux/slab.h>
  #include <linux/interrupt.h>
  #include <linux/err.h>
  #include <linux/clk.h>
@@@ -39,46 -38,46 +39,46 @@@ static struct omap_mcpdm *mcpdm
  
  static inline void omap_mcpdm_write(u16 reg, u32 val)
  {
-        __raw_writel(val, mcpdm->io_base + reg);
+       __raw_writel(val, mcpdm->io_base + reg);
  }
  
  static inline int omap_mcpdm_read(u16 reg)
  {
-        return __raw_readl(mcpdm->io_base + reg);
+       return __raw_readl(mcpdm->io_base + reg);
  }
  
  static void omap_mcpdm_reg_dump(void)
  {
-        dev_dbg(mcpdm->dev, "***********************\n");
-        dev_dbg(mcpdm->dev, "IRQSTATUS_RAW:  0x%04x\n",
-                        omap_mcpdm_read(MCPDM_IRQSTATUS_RAW));
-        dev_dbg(mcpdm->dev, "IRQSTATUS:  0x%04x\n",
-                        omap_mcpdm_read(MCPDM_IRQSTATUS));
-        dev_dbg(mcpdm->dev, "IRQENABLE_SET:  0x%04x\n",
-                        omap_mcpdm_read(MCPDM_IRQENABLE_SET));
-        dev_dbg(mcpdm->dev, "IRQENABLE_CLR:  0x%04x\n",
-                        omap_mcpdm_read(MCPDM_IRQENABLE_CLR));
-        dev_dbg(mcpdm->dev, "IRQWAKE_EN: 0x%04x\n",
-                        omap_mcpdm_read(MCPDM_IRQWAKE_EN));
-        dev_dbg(mcpdm->dev, "DMAENABLE_SET: 0x%04x\n",
-                        omap_mcpdm_read(MCPDM_DMAENABLE_SET));
-        dev_dbg(mcpdm->dev, "DMAENABLE_CLR:  0x%04x\n",
-                        omap_mcpdm_read(MCPDM_DMAENABLE_CLR));
-        dev_dbg(mcpdm->dev, "DMAWAKEEN:  0x%04x\n",
-                        omap_mcpdm_read(MCPDM_DMAWAKEEN));
-        dev_dbg(mcpdm->dev, "CTRL:  0x%04x\n",
-                        omap_mcpdm_read(MCPDM_CTRL));
-        dev_dbg(mcpdm->dev, "DN_DATA:  0x%04x\n",
-                        omap_mcpdm_read(MCPDM_DN_DATA));
-        dev_dbg(mcpdm->dev, "UP_DATA: 0x%04x\n",
-                        omap_mcpdm_read(MCPDM_UP_DATA));
-        dev_dbg(mcpdm->dev, "FIFO_CTRL_DN: 0x%04x\n",
-                        omap_mcpdm_read(MCPDM_FIFO_CTRL_DN));
-        dev_dbg(mcpdm->dev, "FIFO_CTRL_UP:  0x%04x\n",
-                        omap_mcpdm_read(MCPDM_FIFO_CTRL_UP));
-        dev_dbg(mcpdm->dev, "DN_OFFSET:  0x%04x\n",
-                        omap_mcpdm_read(MCPDM_DN_OFFSET));
-        dev_dbg(mcpdm->dev, "***********************\n");
+       dev_dbg(mcpdm->dev, "***********************\n");
+       dev_dbg(mcpdm->dev, "IRQSTATUS_RAW:  0x%04x\n",
+                       omap_mcpdm_read(MCPDM_IRQSTATUS_RAW));
+       dev_dbg(mcpdm->dev, "IRQSTATUS: 0x%04x\n",
+                       omap_mcpdm_read(MCPDM_IRQSTATUS));
+       dev_dbg(mcpdm->dev, "IRQENABLE_SET:  0x%04x\n",
+                       omap_mcpdm_read(MCPDM_IRQENABLE_SET));
+       dev_dbg(mcpdm->dev, "IRQENABLE_CLR:  0x%04x\n",
+                       omap_mcpdm_read(MCPDM_IRQENABLE_CLR));
+       dev_dbg(mcpdm->dev, "IRQWAKE_EN: 0x%04x\n",
+                       omap_mcpdm_read(MCPDM_IRQWAKE_EN));
+       dev_dbg(mcpdm->dev, "DMAENABLE_SET: 0x%04x\n",
+                       omap_mcpdm_read(MCPDM_DMAENABLE_SET));
+       dev_dbg(mcpdm->dev, "DMAENABLE_CLR:  0x%04x\n",
+                       omap_mcpdm_read(MCPDM_DMAENABLE_CLR));
+       dev_dbg(mcpdm->dev, "DMAWAKEEN: 0x%04x\n",
+                       omap_mcpdm_read(MCPDM_DMAWAKEEN));
+       dev_dbg(mcpdm->dev, "CTRL:      0x%04x\n",
+                       omap_mcpdm_read(MCPDM_CTRL));
+       dev_dbg(mcpdm->dev, "DN_DATA:  0x%04x\n",
+                       omap_mcpdm_read(MCPDM_DN_DATA));
+       dev_dbg(mcpdm->dev, "UP_DATA: 0x%04x\n",
+                       omap_mcpdm_read(MCPDM_UP_DATA));
+       dev_dbg(mcpdm->dev, "FIFO_CTRL_DN: 0x%04x\n",
+                       omap_mcpdm_read(MCPDM_FIFO_CTRL_DN));
+       dev_dbg(mcpdm->dev, "FIFO_CTRL_UP:  0x%04x\n",
+                       omap_mcpdm_read(MCPDM_FIFO_CTRL_UP));
+       dev_dbg(mcpdm->dev, "DN_OFFSET: 0x%04x\n",
+                       omap_mcpdm_read(MCPDM_DN_OFFSET));
+       dev_dbg(mcpdm->dev, "***********************\n");
  }
  
  /*
   */
  static void omap_mcpdm_reset_capture(int reset)
  {
-        int ctrl = omap_mcpdm_read(MCPDM_CTRL);
+       int ctrl = omap_mcpdm_read(MCPDM_CTRL);
  
-        if (reset)
-                ctrl |= SW_UP_RST;
-        else
-                ctrl &= ~SW_UP_RST;
+       if (reset)
+               ctrl |= SW_UP_RST;
+       else
+               ctrl &= ~SW_UP_RST;
  
-        omap_mcpdm_write(MCPDM_CTRL, ctrl);
+       omap_mcpdm_write(MCPDM_CTRL, ctrl);
  }
  
  static void omap_mcpdm_reset_playback(int reset)
  {
-        int ctrl = omap_mcpdm_read(MCPDM_CTRL);
+       int ctrl = omap_mcpdm_read(MCPDM_CTRL);
  
-        if (reset)
-                ctrl |= SW_DN_RST;
-        else
-                ctrl &= ~SW_DN_RST;
+       if (reset)
+               ctrl |= SW_DN_RST;
+       else
+               ctrl &= ~SW_DN_RST;
  
-        omap_mcpdm_write(MCPDM_CTRL, ctrl);
+       omap_mcpdm_write(MCPDM_CTRL, ctrl);
  }
  
  /*
   */
  void omap_mcpdm_start(int stream)
  {
-        int ctrl = omap_mcpdm_read(MCPDM_CTRL);
+       int ctrl = omap_mcpdm_read(MCPDM_CTRL);
  
-        if (stream)
-                ctrl |= mcpdm->up_channels;
-        else
-                ctrl |= mcpdm->dn_channels;
+       if (stream)
+               ctrl |= mcpdm->up_channels;
+       else
+               ctrl |= mcpdm->dn_channels;
  
-        omap_mcpdm_write(MCPDM_CTRL, ctrl);
+       omap_mcpdm_write(MCPDM_CTRL, ctrl);
  }
  
  /*
   */
  void omap_mcpdm_stop(int stream)
  {
-        int ctrl = omap_mcpdm_read(MCPDM_CTRL);
+       int ctrl = omap_mcpdm_read(MCPDM_CTRL);
  
-        if (stream)
-                ctrl &= ~mcpdm->up_channels;
-        else
-                ctrl &= ~mcpdm->dn_channels;
+       if (stream)
+               ctrl &= ~mcpdm->up_channels;
+       else
+               ctrl &= ~mcpdm->dn_channels;
  
-        omap_mcpdm_write(MCPDM_CTRL, ctrl);
+       omap_mcpdm_write(MCPDM_CTRL, ctrl);
  }
  
  /*
   */
  int omap_mcpdm_capture_open(struct omap_mcpdm_link *uplink)
  {
-        int irq_mask = 0;
-        int ctrl;
+       int irq_mask = 0;
+       int ctrl;
  
-        if (!uplink)
-                return -EINVAL;
+       if (!uplink)
+               return -EINVAL;
  
-        mcpdm->uplink = uplink;
+       mcpdm->uplink = uplink;
  
-        /* Enable irq request generation */
-        irq_mask |= uplink->irq_mask & MCPDM_UPLINK_IRQ_MASK;
-        omap_mcpdm_write(MCPDM_IRQENABLE_SET, irq_mask);
+       /* Enable irq request generation */
+       irq_mask |= uplink->irq_mask & MCPDM_UPLINK_IRQ_MASK;
+       omap_mcpdm_write(MCPDM_IRQENABLE_SET, irq_mask);
  
-        /* Configure uplink threshold */
-        if (uplink->threshold > UP_THRES_MAX)
-                uplink->threshold = UP_THRES_MAX;
+       /* Configure uplink threshold */
+       if (uplink->threshold > UP_THRES_MAX)
+               uplink->threshold = UP_THRES_MAX;
  
-        omap_mcpdm_write(MCPDM_FIFO_CTRL_UP, uplink->threshold);
+       omap_mcpdm_write(MCPDM_FIFO_CTRL_UP, uplink->threshold);
  
-        /* Configure DMA controller */
-        omap_mcpdm_write(MCPDM_DMAENABLE_SET, DMA_UP_ENABLE);
+       /* Configure DMA controller */
+       omap_mcpdm_write(MCPDM_DMAENABLE_SET, DMA_UP_ENABLE);
  
-        /* Set pdm out format */
-        ctrl = omap_mcpdm_read(MCPDM_CTRL);
-        ctrl &= ~PDMOUTFORMAT;
-        ctrl |= uplink->format & PDMOUTFORMAT;
+       /* Set pdm out format */
+       ctrl = omap_mcpdm_read(MCPDM_CTRL);
+       ctrl &= ~PDMOUTFORMAT;
+       ctrl |= uplink->format & PDMOUTFORMAT;
  
-        /* Uplink channels */
-        mcpdm->up_channels = uplink->channels & (PDM_UP_MASK | PDM_STATUS_MASK);
+       /* Uplink channels */
+       mcpdm->up_channels = uplink->channels & (PDM_UP_MASK | PDM_STATUS_MASK);
  
-        omap_mcpdm_write(MCPDM_CTRL, ctrl);
+       omap_mcpdm_write(MCPDM_CTRL, ctrl);
  
-        return 0;
+       return 0;
  }
  
  /*
   */
  int omap_mcpdm_playback_open(struct omap_mcpdm_link *downlink)
  {
-        int irq_mask = 0;
-        int ctrl;
+       int irq_mask = 0;
+       int ctrl;
  
-        if (!downlink)
-                return -EINVAL;
+       if (!downlink)
+               return -EINVAL;
  
-        mcpdm->downlink = downlink;
+       mcpdm->downlink = downlink;
  
-        /* Enable irq request generation */
-        irq_mask |= downlink->irq_mask & MCPDM_DOWNLINK_IRQ_MASK;
-        omap_mcpdm_write(MCPDM_IRQENABLE_SET, irq_mask);
+       /* Enable irq request generation */
+       irq_mask |= downlink->irq_mask & MCPDM_DOWNLINK_IRQ_MASK;
+       omap_mcpdm_write(MCPDM_IRQENABLE_SET, irq_mask);
  
-        /* Configure uplink threshold */
-        if (downlink->threshold > DN_THRES_MAX)
-                downlink->threshold = DN_THRES_MAX;
+       /* Configure uplink threshold */
+       if (downlink->threshold > DN_THRES_MAX)
+               downlink->threshold = DN_THRES_MAX;
  
-        omap_mcpdm_write(MCPDM_FIFO_CTRL_DN, downlink->threshold);
+       omap_mcpdm_write(MCPDM_FIFO_CTRL_DN, downlink->threshold);
  
-        /* Enable DMA request generation */
-        omap_mcpdm_write(MCPDM_DMAENABLE_SET, DMA_DN_ENABLE);
+       /* Enable DMA request generation */
+       omap_mcpdm_write(MCPDM_DMAENABLE_SET, DMA_DN_ENABLE);
  
-        /* Set pdm out format */
-        ctrl = omap_mcpdm_read(MCPDM_CTRL);
-        ctrl &= ~PDMOUTFORMAT;
-        ctrl |= downlink->format & PDMOUTFORMAT;
+       /* Set pdm out format */
+       ctrl = omap_mcpdm_read(MCPDM_CTRL);
+       ctrl &= ~PDMOUTFORMAT;
+       ctrl |= downlink->format & PDMOUTFORMAT;
  
-        /* Downlink channels */
-        mcpdm->dn_channels = downlink->channels & (PDM_DN_MASK | PDM_CMD_MASK);
+       /* Downlink channels */
+       mcpdm->dn_channels = downlink->channels & (PDM_DN_MASK | PDM_CMD_MASK);
  
-        omap_mcpdm_write(MCPDM_CTRL, ctrl);
+       omap_mcpdm_write(MCPDM_CTRL, ctrl);
  
-        return 0;
+       return 0;
  }
  
  /*
   */
  int omap_mcpdm_capture_close(struct omap_mcpdm_link *uplink)
  {
-        int irq_mask = 0;
+       int irq_mask = 0;
  
-        if (!uplink)
-                return -EINVAL;
+       if (!uplink)
+               return -EINVAL;
  
-        /* Disable irq request generation */
-        irq_mask |= uplink->irq_mask & MCPDM_UPLINK_IRQ_MASK;
-        omap_mcpdm_write(MCPDM_IRQENABLE_CLR, irq_mask);
+       /* Disable irq request generation */
+       irq_mask |= uplink->irq_mask & MCPDM_UPLINK_IRQ_MASK;
+       omap_mcpdm_write(MCPDM_IRQENABLE_CLR, irq_mask);
  
-        /* Disable DMA request generation */
-        omap_mcpdm_write(MCPDM_DMAENABLE_CLR, DMA_UP_ENABLE);
+       /* Disable DMA request generation */
+       omap_mcpdm_write(MCPDM_DMAENABLE_CLR, DMA_UP_ENABLE);
  
-        /* Clear Downlink channels */
-        mcpdm->up_channels = 0;
+       /* Clear Downlink channels */
+       mcpdm->up_channels = 0;
  
-        mcpdm->uplink = NULL;
+       mcpdm->uplink = NULL;
  
-        return 0;
+       return 0;
  }
  
  /*
   */
  int omap_mcpdm_playback_close(struct omap_mcpdm_link *downlink)
  {
-        int irq_mask = 0;
+       int irq_mask = 0;
  
-        if (!downlink)
-                return -EINVAL;
+       if (!downlink)
+               return -EINVAL;
  
-        /* Disable irq request generation */
-        irq_mask |= downlink->irq_mask & MCPDM_DOWNLINK_IRQ_MASK;
-        omap_mcpdm_write(MCPDM_IRQENABLE_CLR, irq_mask);
+       /* Disable irq request generation */
+       irq_mask |= downlink->irq_mask & MCPDM_DOWNLINK_IRQ_MASK;
+       omap_mcpdm_write(MCPDM_IRQENABLE_CLR, irq_mask);
  
-        /* Disable DMA request generation */
-        omap_mcpdm_write(MCPDM_DMAENABLE_CLR, DMA_DN_ENABLE);
+       /* Disable DMA request generation */
+       omap_mcpdm_write(MCPDM_DMAENABLE_CLR, DMA_DN_ENABLE);
  
-        /* clear Downlink channels */
-        mcpdm->dn_channels = 0;
+       /* clear Downlink channels */
+       mcpdm->dn_channels = 0;
  
-        mcpdm->downlink = NULL;
+       mcpdm->downlink = NULL;
  
-        return 0;
+       return 0;
  }
  
  static irqreturn_t omap_mcpdm_irq_handler(int irq, void *dev_id)
  {
-        struct omap_mcpdm *mcpdm_irq = dev_id;
-        int irq_status;
-        irq_status = omap_mcpdm_read(MCPDM_IRQSTATUS);
-        /* Acknowledge irq event */
-        omap_mcpdm_write(MCPDM_IRQSTATUS, irq_status);
-        if (irq & MCPDM_DN_IRQ_FULL) {
-                dev_err(mcpdm_irq->dev, "DN FIFO error %x\n", irq_status);
-                omap_mcpdm_reset_playback(1);
-                omap_mcpdm_playback_open(mcpdm_irq->downlink);
-                omap_mcpdm_reset_playback(0);
-        }
-        if (irq & MCPDM_DN_IRQ_EMPTY) {
-                dev_err(mcpdm_irq->dev, "DN FIFO error %x\n", irq_status);
-                omap_mcpdm_reset_playback(1);
-                omap_mcpdm_playback_open(mcpdm_irq->downlink);
-                omap_mcpdm_reset_playback(0);
-        }
-        if (irq & MCPDM_DN_IRQ) {
-                dev_dbg(mcpdm_irq->dev, "DN write request\n");
-        }
-        if (irq & MCPDM_UP_IRQ_FULL) {
-                dev_err(mcpdm_irq->dev, "UP FIFO error %x\n", irq_status);
-                omap_mcpdm_reset_capture(1);
-                omap_mcpdm_capture_open(mcpdm_irq->uplink);
-                omap_mcpdm_reset_capture(0);
-        }
-        if (irq & MCPDM_UP_IRQ_EMPTY) {
-                dev_err(mcpdm_irq->dev, "UP FIFO error %x\n", irq_status);
-                omap_mcpdm_reset_capture(1);
-                omap_mcpdm_capture_open(mcpdm_irq->uplink);
-                omap_mcpdm_reset_capture(0);
-        }
-        if (irq & MCPDM_UP_IRQ) {
-                dev_dbg(mcpdm_irq->dev, "UP write request\n");
-        }
-        return IRQ_HANDLED;
+       struct omap_mcpdm *mcpdm_irq = dev_id;
+       int irq_status;
+       irq_status = omap_mcpdm_read(MCPDM_IRQSTATUS);
+       /* Acknowledge irq event */
+       omap_mcpdm_write(MCPDM_IRQSTATUS, irq_status);
+       if (irq & MCPDM_DN_IRQ_FULL) {
+               dev_err(mcpdm_irq->dev, "DN FIFO error %x\n", irq_status);
+               omap_mcpdm_reset_playback(1);
+               omap_mcpdm_playback_open(mcpdm_irq->downlink);
+               omap_mcpdm_reset_playback(0);
+       }
+       if (irq & MCPDM_DN_IRQ_EMPTY) {
+               dev_err(mcpdm_irq->dev, "DN FIFO error %x\n", irq_status);
+               omap_mcpdm_reset_playback(1);
+               omap_mcpdm_playback_open(mcpdm_irq->downlink);
+               omap_mcpdm_reset_playback(0);
+       }
+       if (irq & MCPDM_DN_IRQ) {
+               dev_dbg(mcpdm_irq->dev, "DN write request\n");
+       }
+       if (irq & MCPDM_UP_IRQ_FULL) {
+               dev_err(mcpdm_irq->dev, "UP FIFO error %x\n", irq_status);
+               omap_mcpdm_reset_capture(1);
+               omap_mcpdm_capture_open(mcpdm_irq->uplink);
+               omap_mcpdm_reset_capture(0);
+       }
+       if (irq & MCPDM_UP_IRQ_EMPTY) {
+               dev_err(mcpdm_irq->dev, "UP FIFO error %x\n", irq_status);
+               omap_mcpdm_reset_capture(1);
+               omap_mcpdm_capture_open(mcpdm_irq->uplink);
+               omap_mcpdm_reset_capture(0);
+       }
+       if (irq & MCPDM_UP_IRQ) {
+               dev_dbg(mcpdm_irq->dev, "UP write request\n");
+       }
+       return IRQ_HANDLED;
  }
  
  int omap_mcpdm_request(void)
  {
-        int ret;
+       int ret;
  
-        clk_enable(mcpdm->clk);
+       clk_enable(mcpdm->clk);
  
-        spin_lock(&mcpdm->lock);
+       spin_lock(&mcpdm->lock);
  
-        if (!mcpdm->free) {
-                dev_err(mcpdm->dev, "McPDM interface is in use\n");
-                spin_unlock(&mcpdm->lock);
-                ret = -EBUSY;
-                goto err;
-        }
-        mcpdm->free = 0;
+       if (!mcpdm->free) {
+               dev_err(mcpdm->dev, "McPDM interface is in use\n");
+               spin_unlock(&mcpdm->lock);
+               ret = -EBUSY;
+               goto err;
+       }
+       mcpdm->free = 0;
  
-        spin_unlock(&mcpdm->lock);
+       spin_unlock(&mcpdm->lock);
  
-        /* Disable lines while request is ongoing */
-        omap_mcpdm_write(MCPDM_CTRL, 0x00);
+       /* Disable lines while request is ongoing */
+       omap_mcpdm_write(MCPDM_CTRL, 0x00);
  
-        ret = request_irq(mcpdm->irq, omap_mcpdm_irq_handler,
-                                0, "McPDM", (void *)mcpdm);
-        if (ret) {
-                dev_err(mcpdm->dev, "Request for McPDM IRQ failed\n");
-                goto err;
-        }
+       ret = request_irq(mcpdm->irq, omap_mcpdm_irq_handler,
+                               0, "McPDM", (void *)mcpdm);
+       if (ret) {
+               dev_err(mcpdm->dev, "Request for McPDM IRQ failed\n");
+               goto err;
+       }
  
-        return 0;
+       return 0;
  
  err:
-        clk_disable(mcpdm->clk);
-        return ret;
+       clk_disable(mcpdm->clk);
+       return ret;
  }
  
  void omap_mcpdm_free(void)
  {
-        spin_lock(&mcpdm->lock);
-        if (mcpdm->free) {
-                dev_err(mcpdm->dev, "McPDM interface is already free\n");
-                spin_unlock(&mcpdm->lock);
-                return;
-        }
-        mcpdm->free = 1;
-        spin_unlock(&mcpdm->lock);
-        clk_disable(mcpdm->clk);
-        free_irq(mcpdm->irq, (void *)mcpdm);
+       spin_lock(&mcpdm->lock);
+       if (mcpdm->free) {
+               dev_err(mcpdm->dev, "McPDM interface is already free\n");
+               spin_unlock(&mcpdm->lock);
+               return;
+       }
+       mcpdm->free = 1;
+       spin_unlock(&mcpdm->lock);
+       clk_disable(mcpdm->clk);
+       free_irq(mcpdm->irq, (void *)mcpdm);
  }
  
  /* Enable/disable DC offset cancelation for the analog
   */
  int omap_mcpdm_set_offset(int offset1, int offset2)
  {
-        int offset;
+       int offset;
  
-        if ((offset1 > DN_OFST_MAX) || (offset2 > DN_OFST_MAX))
-                return -EINVAL;
+       if ((offset1 > DN_OFST_MAX) || (offset2 > DN_OFST_MAX))
+               return -EINVAL;
  
-        offset = (offset1 << DN_OFST_RX1) | (offset2 << DN_OFST_RX2);
+       offset = (offset1 << DN_OFST_RX1) | (offset2 << DN_OFST_RX2);
  
-        /* offset cancellation for channel 1 */
-        if (offset1)
-                offset |= DN_OFST_RX1_EN;
-        else
-                offset &= ~DN_OFST_RX1_EN;
+       /* offset cancellation for channel 1 */
+       if (offset1)
+               offset |= DN_OFST_RX1_EN;
+       else
+               offset &= ~DN_OFST_RX1_EN;
  
-        /* offset cancellation for channel 2 */
-        if (offset2)
-                offset |= DN_OFST_RX2_EN;
-        else
-                offset &= ~DN_OFST_RX2_EN;
+       /* offset cancellation for channel 2 */
+       if (offset2)
+               offset |= DN_OFST_RX2_EN;
+       else
+               offset &= ~DN_OFST_RX2_EN;
  
-        omap_mcpdm_write(MCPDM_DN_OFFSET, offset);
+       omap_mcpdm_write(MCPDM_DN_OFFSET, offset);
  
-        return 0;
+       return 0;
  }
  
  static int __devinit omap_mcpdm_probe(struct platform_device *pdev)
  {
-        struct resource *res;
-        int ret = 0;
-        mcpdm = kzalloc(sizeof(struct omap_mcpdm), GFP_KERNEL);
-        if (!mcpdm) {
-                ret = -ENOMEM;
-                goto exit;
-        }
-        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-        if (res == NULL) {
-                dev_err(&pdev->dev, "no resource\n");
-                goto err_resource;
-        }
-        spin_lock_init(&mcpdm->lock);
-        mcpdm->free = 1;
-        mcpdm->io_base = ioremap(res->start, resource_size(res));
-        if (!mcpdm->io_base) {
-                ret = -ENOMEM;
-                goto err_resource;
-        }
-        mcpdm->irq = platform_get_irq(pdev, 0);
-        mcpdm->clk = clk_get(&pdev->dev, "pdm_ck");
-        if (IS_ERR(mcpdm->clk)) {
-                ret = PTR_ERR(mcpdm->clk);
-                dev_err(&pdev->dev, "unable to get pdm_ck: %d\n", ret);
-                goto err_clk;
-        }
-        mcpdm->dev = &pdev->dev;
-        platform_set_drvdata(pdev, mcpdm);
-        return 0;
+       struct resource *res;
+       int ret = 0;
+       mcpdm = kzalloc(sizeof(struct omap_mcpdm), GFP_KERNEL);
+       if (!mcpdm) {
+               ret = -ENOMEM;
+               goto exit;
+       }
+       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
+       if (res == NULL) {
+               dev_err(&pdev->dev, "no resource\n");
+               goto err_resource;
+       }
+       spin_lock_init(&mcpdm->lock);
+       mcpdm->free = 1;
+       mcpdm->io_base = ioremap(res->start, resource_size(res));
+       if (!mcpdm->io_base) {
+               ret = -ENOMEM;
+               goto err_resource;
+       }
+       mcpdm->irq = platform_get_irq(pdev, 0);
+       mcpdm->clk = clk_get(&pdev->dev, "pdm_ck");
+       if (IS_ERR(mcpdm->clk)) {
+               ret = PTR_ERR(mcpdm->clk);
+               dev_err(&pdev->dev, "unable to get pdm_ck: %d\n", ret);
+               goto err_clk;
+       }
+       mcpdm->dev = &pdev->dev;
+       platform_set_drvdata(pdev, mcpdm);
+       return 0;
  
  err_clk:
-        iounmap(mcpdm->io_base);
+       iounmap(mcpdm->io_base);
  err_resource:
-        kfree(mcpdm);
+       kfree(mcpdm);
  exit:
-        return ret;
+       return ret;
  }
  
  static int __devexit omap_mcpdm_remove(struct platform_device *pdev)
  {
-        struct omap_mcpdm *mcpdm_ptr = platform_get_drvdata(pdev);
+       struct omap_mcpdm *mcpdm_ptr = platform_get_drvdata(pdev);
  
-        platform_set_drvdata(pdev, NULL);
+       platform_set_drvdata(pdev, NULL);
  
-        clk_put(mcpdm_ptr->clk);
+       clk_put(mcpdm_ptr->clk);
  
-        iounmap(mcpdm_ptr->io_base);
+       iounmap(mcpdm_ptr->io_base);
  
-        mcpdm_ptr->clk = NULL;
-        mcpdm_ptr->free = 0;
-        mcpdm_ptr->dev = NULL;
+       mcpdm_ptr->clk = NULL;
+       mcpdm_ptr->free = 0;
+       mcpdm_ptr->dev = NULL;
  
-        kfree(mcpdm_ptr);
+       kfree(mcpdm_ptr);
  
-        return 0;
+       return 0;
  }
  
  static struct platform_driver omap_mcpdm_driver = {
-        .probe = omap_mcpdm_probe,
-        .remove = __devexit_p(omap_mcpdm_remove),
-        .driver = {
-                .name = "omap-mcpdm",
-        },
+       .probe = omap_mcpdm_probe,
+       .remove = __devexit_p(omap_mcpdm_remove),
+       .driver = {
+               .name = "omap-mcpdm",
+       },
  };
  
  static struct platform_device *omap_mcpdm_device;
  
  static int __init omap_mcpdm_init(void)
  {
-        return platform_driver_register(&omap_mcpdm_driver);
+       return platform_driver_register(&omap_mcpdm_driver);
  }
  arch_initcall(omap_mcpdm_init);
diff --combined sound/soc/sh/fsi.c
@@@ -19,7 -19,6 +19,7 @@@
  #include <linux/list.h>
  #include <linux/pm_runtime.h>
  #include <linux/io.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/initval.h>
  #define MUTE_ST               0x0028
  #define REG_END               MUTE_ST
  
+ #define CPU_INT_ST    0x01F4
+ #define CPU_IEMSK     0x01F8
+ #define CPU_IMSK      0x01FC
  #define INT_ST                0x0200
  #define IEMSK         0x0204
  #define IMSK          0x0208
  #define MUTE          0x020C
  #define CLK_RST               0x0210
  #define SOFT_RST      0x0214
- #define MREG_START    INT_ST
- #define MREG_END      SOFT_RST
+ #define FIFO_SZ               0x0218
+ #define MREG_START    CPU_INT_ST
+ #define MREG_END      FIFO_SZ
  
  /* DO_FMT */
  /* DI_FMT */
  #define INT_A_IN      (1 << 4)
  #define INT_A_OUT     (1 << 0)
  
+ /* SOFT_RST */
+ #define PBSR          (1 << 12) /* Port B Software Reset */
+ #define PASR          (1 <<  8) /* Port A Software Reset */
+ #define IR            (1 <<  4) /* Interrupt Reset */
+ #define FSISR         (1 <<  0) /* Software Reset */
+ /* FIFO_SZ */
+ #define OUT_SZ_MASK   0x7
+ #define BO_SZ_SHIFT   8
+ #define AO_SZ_SHIFT   0
  #define FSI_RATES SNDRV_PCM_RATE_8000_96000
  
  #define FSI_FMTS (SNDRV_PCM_FMTBIT_S24_LE | SNDRV_PCM_FMTBIT_S16_LE)
@@@ -105,11 -120,18 +121,18 @@@ struct fsi_priv 
        int periods;
  };
  
+ struct fsi_regs {
+       u32 int_st;
+       u32 iemsk;
+       u32 imsk;
+ };
  struct fsi_master {
        void __iomem *base;
        int irq;
        struct fsi_priv fsia;
        struct fsi_priv fsib;
+       struct fsi_regs *regs;
        struct sh_fsi_platform_info *info;
        spinlock_t lock;
  };
@@@ -317,7 -339,7 +340,7 @@@ static int fsi_get_fifo_residue(struct 
  /************************************************************************
  
  
-               ctrl function
+               irq function
  
  
  ************************************************************************/
@@@ -326,8 -348,8 +349,8 @@@ static void fsi_irq_enable(struct fsi_p
        u32 data = fsi_port_ab_io_bit(fsi, is_play);
        struct fsi_master *master = fsi_get_master(fsi);
  
-       fsi_master_mask_set(master, IMSK,  data, data);
-       fsi_master_mask_set(master, IEMSK, data, data);
+       fsi_master_mask_set(master, master->regs->imsk,  data, data);
+       fsi_master_mask_set(master, master->regs->iemsk, data, data);
  }
  
  static void fsi_irq_disable(struct fsi_priv *fsi, int is_play)
        u32 data = fsi_port_ab_io_bit(fsi, is_play);
        struct fsi_master *master = fsi_get_master(fsi);
  
-       fsi_master_mask_set(master, IMSK,  data, 0);
-       fsi_master_mask_set(master, IEMSK, data, 0);
+       fsi_master_mask_set(master, master->regs->imsk,  data, 0);
+       fsi_master_mask_set(master, master->regs->iemsk, data, 0);
+ }
+ static u32 fsi_irq_get_status(struct fsi_master *master)
+ {
+       return fsi_master_read(master, master->regs->int_st);
+ }
+ static void fsi_irq_clear_all_status(struct fsi_master *master)
+ {
+       fsi_master_write(master, master->regs->int_st, 0x0000000);
  }
  
+ static void fsi_irq_clear_status(struct fsi_priv *fsi)
+ {
+       u32 data = 0;
+       struct fsi_master *master = fsi_get_master(fsi);
+       data |= fsi_port_ab_io_bit(fsi, 0);
+       data |= fsi_port_ab_io_bit(fsi, 1);
+       /* clear interrupt factor */
+       fsi_master_mask_set(master, master->regs->int_st, data, 0);
+ }
+ /************************************************************************
+               ctrl function
+ ************************************************************************/
  static void fsi_clk_ctrl(struct fsi_priv *fsi, int enable)
  {
        u32 val = fsi_is_port_a(fsi) ? (1 << 0) : (1 << 4);
                fsi_master_mask_set(master, CLK_RST, val, 0);
  }
  
- static void fsi_irq_init(struct fsi_priv *fsi, int is_play)
+ static void fsi_fifo_init(struct fsi_priv *fsi,
+                         int is_play,
+                         struct snd_soc_dai *dai)
  {
-       u32 data;
-       u32 ctrl;
+       struct fsi_master *master = fsi_get_master(fsi);
+       u32 ctrl, shift, i;
  
-       data = fsi_port_ab_io_bit(fsi, is_play);
-       ctrl = is_play ? DOFF_CTL : DIFF_CTL;
+       /* get on-chip RAM capacity */
+       shift = fsi_master_read(master, FIFO_SZ);
+       shift >>= fsi_is_port_a(fsi) ? AO_SZ_SHIFT : BO_SZ_SHIFT;
+       shift &= OUT_SZ_MASK;
+       fsi->fifo_max = 256 << shift;
+       dev_dbg(dai->dev, "fifo = %d words\n", fsi->fifo_max);
  
-       /* set IMSK */
-       fsi_irq_disable(fsi, is_play);
+       /*
+        * The maximum number of sample data varies depending
+        * on the number of channels selected for the format.
+        *
+        * FIFOs are used in 4-channel units in 3-channel mode
+        * and in 8-channel units in 5- to 7-channel mode
+        * meaning that more FIFOs than the required size of DPRAM
+        * are used.
+        *
+        * ex) if 256 words of DP-RAM is connected
+        * 1 channel:  256 (256 x 1 = 256)
+        * 2 channels: 128 (128 x 2 = 256)
+        * 3 channels:  64 ( 64 x 3 = 192)
+        * 4 channels:  64 ( 64 x 4 = 256)
+        * 5 channels:  32 ( 32 x 5 = 160)
+        * 6 channels:  32 ( 32 x 6 = 192)
+        * 7 channels:  32 ( 32 x 7 = 224)
+        * 8 channels:  32 ( 32 x 8 = 256)
+        */
+       for (i = 1; i < fsi->chan; i <<= 1)
+               fsi->fifo_max >>= 1;
+       dev_dbg(dai->dev, "%d channel %d store\n", fsi->chan, fsi->fifo_max);
+       ctrl = is_play ? DOFF_CTL : DIFF_CTL;
  
        /* set interrupt generation factor */
        fsi_reg_write(fsi, ctrl, IRQ_HALF);
  
        /* clear FIFO */
        fsi_reg_mask_set(fsi, ctrl, FIFO_CLR, FIFO_CLR);
-       /* clear interrupt factor */
-       fsi_master_mask_set(fsi_get_master(fsi), INT_ST, data, 0);
  }
  
  static void fsi_soft_all_reset(struct fsi_master *master)
  {
-       u32 status = fsi_master_read(master, SOFT_RST);
        /* port AB reset */
-       status &= 0x000000ff;
-       fsi_master_write(master, SOFT_RST, status);
+       fsi_master_mask_set(master, SOFT_RST, PASR | PBSR, 0);
        mdelay(10);
  
        /* soft reset */
-       status &= 0x000000f0;
-       fsi_master_write(master, SOFT_RST, status);
-       status |= 0x00000001;
-       fsi_master_write(master, SOFT_RST, status);
+       fsi_master_mask_set(master, SOFT_RST, FSISR, 0);
+       fsi_master_mask_set(master, SOFT_RST, FSISR, FSISR);
        mdelay(10);
  }
  
@@@ -559,12 -630,11 +631,11 @@@ static int fsi_data_pop(struct fsi_pri
  static irqreturn_t fsi_interrupt(int irq, void *data)
  {
        struct fsi_master *master = data;
-       u32 status = fsi_master_read(master, SOFT_RST) & ~0x00000010;
-       u32 int_st = fsi_master_read(master, INT_ST);
+       u32 int_st = fsi_irq_get_status(master);
  
        /* clear irq status */
-       fsi_master_write(master, SOFT_RST, status);
-       fsi_master_write(master, SOFT_RST, status | 0x00000010);
+       fsi_master_mask_set(master, SOFT_RST, IR, 0);
+       fsi_master_mask_set(master, SOFT_RST, IR, IR);
  
        if (int_st & INT_A_OUT)
                fsi_data_push(&master->fsia, 0);
        if (int_st & INT_B_IN)
                fsi_data_pop(&master->fsib, 0);
  
-       fsi_master_write(master, INT_ST, 0x0000000);
+       fsi_irq_clear_all_status(master);
  
        return IRQ_HANDLED;
  }
@@@ -669,29 -739,6 +740,6 @@@ static int fsi_dai_startup(struct snd_p
                dev_err(dai->dev, "unknown format.\n");
                return -EINVAL;
        }
-       switch (fsi->chan) {
-       case 1:
-               fsi->fifo_max = 256;
-               break;
-       case 2:
-               fsi->fifo_max = 128;
-               break;
-       case 3:
-       case 4:
-               fsi->fifo_max = 64;
-               break;
-       case 5:
-       case 6:
-       case 7:
-       case 8:
-               fsi->fifo_max = 32;
-               break;
-       default:
-               dev_err(dai->dev, "channel size error.\n");
-               return -EINVAL;
-       }
        fsi_reg_write(fsi, reg, data);
  
        /*
        if (is_master)
                fsi_clk_ctrl(fsi, 1);
  
-       /* irq setting */
-       fsi_irq_init(fsi, is_play);
+       /* irq clear */
+       fsi_irq_disable(fsi, is_play);
+       fsi_irq_clear_status(fsi);
+       /* fifo init */
+       fsi_fifo_init(fsi, is_play, dai);
  
        return ret;
  }
@@@ -913,6 -964,7 +965,7 @@@ EXPORT_SYMBOL_GPL(fsi_soc_platform)
  static int fsi_probe(struct platform_device *pdev)
  {
        struct fsi_master *master;
+       const struct platform_device_id *id_entry;
        struct resource *res;
        unsigned int irq;
        int ret;
                return -ENODEV;
        }
  
+       id_entry = pdev->id_entry;
+       if (!id_entry) {
+               dev_err(&pdev->dev, "unknown fsi device\n");
+               return -ENODEV;
+       }
        res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        irq = platform_get_irq(pdev, 0);
        if (!res || (int)irq <= 0) {
        master->fsia.master     = master;
        master->fsib.base       = master->base + 0x40;
        master->fsib.master     = master;
+       master->regs            = (struct fsi_regs *)id_entry->driver_data;
        spin_lock_init(&master->lock);
  
        pm_runtime_enable(&pdev->dev);
  
        fsi_soft_all_reset(master);
  
-       ret = request_irq(irq, &fsi_interrupt, IRQF_DISABLED, "fsi", master);
+       ret = request_irq(irq, &fsi_interrupt, IRQF_DISABLED,
+                         id_entry->name, master);
        if (ret) {
                dev_err(&pdev->dev, "irq request err\n");
                goto exit_iounmap;
@@@ -1029,6 -1089,23 +1090,23 @@@ static struct dev_pm_ops fsi_pm_ops = 
        .runtime_resume         = fsi_runtime_nop,
  };
  
+ static struct fsi_regs fsi_regs = {
+       .int_st = INT_ST,
+       .iemsk  = IEMSK,
+       .imsk   = IMSK,
+ };
+ static struct fsi_regs fsi2_regs = {
+       .int_st = CPU_INT_ST,
+       .iemsk  = CPU_IEMSK,
+       .imsk   = CPU_IMSK,
+ };
+ static struct platform_device_id fsi_id_table[] = {
+       { "sh_fsi",     (kernel_ulong_t)&fsi_regs },
+       { "sh_fsi2",    (kernel_ulong_t)&fsi2_regs },
+ };
  static struct platform_driver fsi_driver = {
        .driver         = {
                .name   = "sh_fsi",
        },
        .probe          = fsi_probe,
        .remove         = fsi_remove,
+       .id_table       = fsi_id_table,
  };
  
  static int __init fsi_mobile_init(void)
diff --combined sound/soc/soc-core.c
@@@ -28,7 -28,6 +28,7 @@@
  #include <linux/bitops.h>
  #include <linux/debugfs.h>
  #include <linux/platform_device.h>
 +#include <linux/slab.h>
  #include <sound/ac97_codec.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
@@@ -316,7 -315,7 +316,7 @@@ static int soc_pcm_apply_symmetry(struc
  
        if (codec_dai->symmetric_rates || cpu_dai->symmetric_rates ||
            machine->symmetric_rates) {
-               dev_dbg(card->dev, "Symmetry forces %dHz rate\n", 
+               dev_dbg(card->dev, "Symmetry forces %dHz rate\n",
                        machine->rate);
  
                ret = snd_pcm_hw_constraint_minmax(substream->runtime,
@@@ -405,6 -404,12 +405,12 @@@ static int soc_pcm_open(struct snd_pcm_
                        codec_dai->playback.formats & cpu_dai->playback.formats;
                runtime->hw.rates =
                        codec_dai->playback.rates & cpu_dai->playback.rates;
+               if (codec_dai->playback.rates
+                          & (SNDRV_PCM_RATE_KNOT | SNDRV_PCM_RATE_CONTINUOUS))
+                       runtime->hw.rates |= cpu_dai->playback.rates;
+               if (cpu_dai->playback.rates
+                          & (SNDRV_PCM_RATE_KNOT | SNDRV_PCM_RATE_CONTINUOUS))
+                       runtime->hw.rates |= codec_dai->playback.rates;
        } else {
                runtime->hw.rate_min =
                        max(codec_dai->capture.rate_min,
                        codec_dai->capture.formats & cpu_dai->capture.formats;
                runtime->hw.rates =
                        codec_dai->capture.rates & cpu_dai->capture.rates;
+               if (codec_dai->capture.rates
+                          & (SNDRV_PCM_RATE_KNOT | SNDRV_PCM_RATE_CONTINUOUS))
+                       runtime->hw.rates |= cpu_dai->capture.rates;
+               if (cpu_dai->capture.rates
+                          & (SNDRV_PCM_RATE_KNOT | SNDRV_PCM_RATE_CONTINUOUS))
+                       runtime->hw.rates |= codec_dai->capture.rates;
        }
  
        snd_pcm_limit_hw_rates(runtime);
        pr_debug("asoc: min rate %d max rate %d\n", runtime->hw.rate_min,
                 runtime->hw.rate_max);
  
-       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
-               cpu_dai->playback.active = codec_dai->playback.active = 1;
-       else
-               cpu_dai->capture.active = codec_dai->capture.active = 1;
-       cpu_dai->active = codec_dai->active = 1;
-       cpu_dai->runtime = runtime;
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+               cpu_dai->playback.active++;
+               codec_dai->playback.active++;
+       } else {
+               cpu_dai->capture.active++;
+               codec_dai->capture.active++;
+       }
+       cpu_dai->active++;
+       codec_dai->active++;
        card->codec->active++;
        mutex_unlock(&pcm_mutex);
        return 0;
@@@ -536,15 -550,16 +551,16 @@@ static int soc_codec_close(struct snd_p
  
        mutex_lock(&pcm_mutex);
  
-       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK)
-               cpu_dai->playback.active = codec_dai->playback.active = 0;
-       else
-               cpu_dai->capture.active = codec_dai->capture.active = 0;
-       if (codec_dai->playback.active == 0 &&
-               codec_dai->capture.active == 0) {
-               cpu_dai->active = codec_dai->active = 0;
+       if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
+               cpu_dai->playback.active--;
+               codec_dai->playback.active--;
+       } else {
+               cpu_dai->capture.active--;
+               codec_dai->capture.active--;
        }
+       cpu_dai->active--;
+       codec_dai->active--;
        codec->active--;
  
        /* Muting the DAC suppresses artifacts caused during digital
  
        if (platform->pcm_ops->close)
                platform->pcm_ops->close(substream);
-       cpu_dai->runtime = NULL;
  
        if (substream->stream == SNDRV_PCM_STREAM_PLAYBACK) {
                /* start delayed pop wq here for playback streams */
@@@ -802,6 -816,41 +817,41 @@@ static int soc_pcm_trigger(struct snd_p
        return 0;
  }
  
+ /*
+  * soc level wrapper for pointer callback
+  * If cpu_dai, codec_dai, platform driver has the delay callback, than
+  * the runtime->delay will be updated accordingly.
+  */
+ static snd_pcm_uframes_t soc_pcm_pointer(struct snd_pcm_substream *substream)
+ {
+       struct snd_soc_pcm_runtime *rtd = substream->private_data;
+       struct snd_soc_device *socdev = rtd->socdev;
+       struct snd_soc_card *card = socdev->card;
+       struct snd_soc_platform *platform = card->platform;
+       struct snd_soc_dai_link *machine = rtd->dai;
+       struct snd_soc_dai *cpu_dai = machine->cpu_dai;
+       struct snd_soc_dai *codec_dai = machine->codec_dai;
+       struct snd_pcm_runtime *runtime = substream->runtime;
+       snd_pcm_uframes_t offset = 0;
+       snd_pcm_sframes_t delay = 0;
+       if (platform->pcm_ops->pointer)
+               offset = platform->pcm_ops->pointer(substream);
+       if (cpu_dai->ops->delay)
+               delay += cpu_dai->ops->delay(substream, cpu_dai);
+       if (codec_dai->ops->delay)
+               delay += codec_dai->ops->delay(substream, codec_dai);
+       if (platform->delay)
+               delay += platform->delay(substream, codec_dai);
+       runtime->delay = delay;
+       return offset;
+ }
  /* ASoC PCM operations */
  static struct snd_pcm_ops soc_pcm_ops = {
        .open           = soc_pcm_open,
        .hw_free        = soc_pcm_hw_free,
        .prepare        = soc_pcm_prepare,
        .trigger        = soc_pcm_trigger,
+       .pointer        = soc_pcm_pointer,
  };
  
  #ifdef CONFIG_PM
@@@ -843,23 -893,35 +894,35 @@@ static int soc_suspend(struct device *d
        /* mute any active DAC's */
        for (i = 0; i < card->num_links; i++) {
                struct snd_soc_dai *dai = card->dai_link[i].codec_dai;
+               if (card->dai_link[i].ignore_suspend)
+                       continue;
                if (dai->ops->digital_mute && dai->playback.active)
                        dai->ops->digital_mute(dai, 1);
        }
  
        /* suspend all pcms */
-       for (i = 0; i < card->num_links; i++)
+       for (i = 0; i < card->num_links; i++) {
+               if (card->dai_link[i].ignore_suspend)
+                       continue;
                snd_pcm_suspend_all(card->dai_link[i].pcm);
+       }
  
        if (card->suspend_pre)
                card->suspend_pre(pdev, PMSG_SUSPEND);
  
        for (i = 0; i < card->num_links; i++) {
                struct snd_soc_dai  *cpu_dai = card->dai_link[i].cpu_dai;
+               if (card->dai_link[i].ignore_suspend)
+                       continue;
                if (cpu_dai->suspend && !cpu_dai->ac97_control)
                        cpu_dai->suspend(cpu_dai);
                if (platform->suspend)
-                       platform->suspend(cpu_dai);
+                       platform->suspend(&card->dai_link[i]);
        }
  
        /* close any waiting streams and save state */
  
        for (i = 0; i < codec->num_dai; i++) {
                char *stream = codec->dai[i].playback.stream_name;
+               if (card->dai_link[i].ignore_suspend)
+                       continue;
                if (stream != NULL)
                        snd_soc_dapm_stream_event(codec, stream,
                                SND_SOC_DAPM_STREAM_SUSPEND);
                                SND_SOC_DAPM_STREAM_SUSPEND);
        }
  
-       if (codec_dev->suspend)
-               codec_dev->suspend(pdev, PMSG_SUSPEND);
+       /* If there are paths active then the CODEC will be held with
+        * bias _ON and should not be suspended. */
+       if (codec_dev->suspend) {
+               switch (codec->bias_level) {
+               case SND_SOC_BIAS_STANDBY:
+               case SND_SOC_BIAS_OFF:
+                       codec_dev->suspend(pdev, PMSG_SUSPEND);
+                       break;
+               default:
+                       dev_dbg(socdev->dev, "CODEC is on over suspend\n");
+                       break;
+               }
+       }
  
        for (i = 0; i < card->num_links; i++) {
                struct snd_soc_dai *cpu_dai = card->dai_link[i].cpu_dai;
+               if (card->dai_link[i].ignore_suspend)
+                       continue;
                if (cpu_dai->suspend && cpu_dai->ac97_control)
                        cpu_dai->suspend(cpu_dai);
        }
@@@ -913,20 -994,44 +995,44 @@@ static void soc_resume_deferred(struct 
  
        dev_dbg(socdev->dev, "starting resume work\n");
  
+       /* Bring us up into D2 so that DAPM starts enabling things */
+       snd_power_change_state(codec->card, SNDRV_CTL_POWER_D2);
        if (card->resume_pre)
                card->resume_pre(pdev);
  
        for (i = 0; i < card->num_links; i++) {
                struct snd_soc_dai *cpu_dai = card->dai_link[i].cpu_dai;
+               if (card->dai_link[i].ignore_suspend)
+                       continue;
                if (cpu_dai->resume && cpu_dai->ac97_control)
                        cpu_dai->resume(cpu_dai);
        }
  
-       if (codec_dev->resume)
-               codec_dev->resume(pdev);
+       /* If the CODEC was idle over suspend then it will have been
+        * left with bias OFF or STANDBY and suspended so we must now
+        * resume.  Otherwise the suspend was suppressed.
+        */
+       if (codec_dev->resume) {
+               switch (codec->bias_level) {
+               case SND_SOC_BIAS_STANDBY:
+               case SND_SOC_BIAS_OFF:
+                       codec_dev->resume(pdev);
+                       break;
+               default:
+                       dev_dbg(socdev->dev, "CODEC was on over suspend\n");
+                       break;
+               }
+       }
  
        for (i = 0; i < codec->num_dai; i++) {
                char *stream = codec->dai[i].playback.stream_name;
+               if (card->dai_link[i].ignore_suspend)
+                       continue;
                if (stream != NULL)
                        snd_soc_dapm_stream_event(codec, stream,
                                SND_SOC_DAPM_STREAM_RESUME);
        /* unmute any active DACs */
        for (i = 0; i < card->num_links; i++) {
                struct snd_soc_dai *dai = card->dai_link[i].codec_dai;
+               if (card->dai_link[i].ignore_suspend)
+                       continue;
                if (dai->ops->digital_mute && dai->playback.active)
                        dai->ops->digital_mute(dai, 0);
        }
  
        for (i = 0; i < card->num_links; i++) {
                struct snd_soc_dai *cpu_dai = card->dai_link[i].cpu_dai;
+               if (card->dai_link[i].ignore_suspend)
+                       continue;
                if (cpu_dai->resume && !cpu_dai->ac97_control)
                        cpu_dai->resume(cpu_dai);
                if (platform->resume)
-                       platform->resume(cpu_dai);
+                       platform->resume(&card->dai_link[i]);
        }
  
        if (card->resume_post)
@@@ -1233,26 -1346,25 +1347,25 @@@ static int soc_remove(struct platform_d
        struct snd_soc_platform *platform = card->platform;
        struct snd_soc_codec_device *codec_dev = socdev->codec_dev;
  
-       if (!card->instantiated)
-               return 0;
+       if (card->instantiated) {
+               run_delayed_work(&card->delayed_work);
  
-       run_delayed_work(&card->delayed_work);
+               if (platform->remove)
+                       platform->remove(pdev);
  
-       if (platform->remove)
-               platform->remove(pdev);
+               if (codec_dev->remove)
+                       codec_dev->remove(pdev);
  
-       if (codec_dev->remove)
-               codec_dev->remove(pdev);
+               for (i = 0; i < card->num_links; i++) {
+                       struct snd_soc_dai *cpu_dai = card->dai_link[i].cpu_dai;
+                       if (cpu_dai->remove)
+                               cpu_dai->remove(pdev, cpu_dai);
+               }
  
-       for (i = 0; i < card->num_links; i++) {
-               struct snd_soc_dai *cpu_dai = card->dai_link[i].cpu_dai;
-               if (cpu_dai->remove)
-                       cpu_dai->remove(pdev, cpu_dai);
+               if (card->remove)
+                       card->remove(pdev);
        }
  
-       if (card->remove)
-               card->remove(pdev);
        snd_soc_unregister_card(card);
  
        return 0;
@@@ -1336,7 -1448,6 +1449,6 @@@ static int soc_new_pcm(struct snd_soc_d
        dai_link->pcm = pcm;
        pcm->private_data = rtd;
        soc_pcm_ops.mmap = platform->pcm_ops->mmap;
-       soc_pcm_ops.pointer = platform->pcm_ops->pointer;
        soc_pcm_ops.ioctl = platform->pcm_ops->ioctl;
        soc_pcm_ops.copy = platform->pcm_ops->copy;
        soc_pcm_ops.silence = platform->pcm_ops->silence;
@@@ -1906,18 -2017,22 +2018,22 @@@ int snd_soc_info_volsw(struct snd_kcont
  {
        struct soc_mixer_control *mc =
                (struct soc_mixer_control *)kcontrol->private_value;
-       int max = mc->max;
+       int platform_max;
        unsigned int shift = mc->shift;
        unsigned int rshift = mc->rshift;
  
-       if (max == 1 && !strstr(kcontrol->id.name, " Volume"))
+       if (!mc->platform_max)
+               mc->platform_max = mc->max;
+       platform_max = mc->platform_max;
+       if (platform_max == 1 && !strstr(kcontrol->id.name, " Volume"))
                uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
        else
                uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
  
        uinfo->count = shift == rshift ? 1 : 2;
        uinfo->value.integer.min = 0;
-       uinfo->value.integer.max = max;
+       uinfo->value.integer.max = platform_max;
        return 0;
  }
  EXPORT_SYMBOL_GPL(snd_soc_info_volsw);
@@@ -2015,16 -2130,20 +2131,20 @@@ int snd_soc_info_volsw_2r(struct snd_kc
  {
        struct soc_mixer_control *mc =
                (struct soc_mixer_control *)kcontrol->private_value;
-       int max = mc->max;
+       int platform_max;
  
-       if (max == 1 && !strstr(kcontrol->id.name, " Volume"))
+       if (!mc->platform_max)
+               mc->platform_max = mc->max;
+       platform_max = mc->platform_max;
+       if (platform_max == 1 && !strstr(kcontrol->id.name, " Volume"))
                uinfo->type = SNDRV_CTL_ELEM_TYPE_BOOLEAN;
        else
                uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
  
        uinfo->count = 2;
        uinfo->value.integer.min = 0;
-       uinfo->value.integer.max = max;
+       uinfo->value.integer.max = platform_max;
        return 0;
  }
  EXPORT_SYMBOL_GPL(snd_soc_info_volsw_2r);
@@@ -2125,13 -2244,17 +2245,17 @@@ int snd_soc_info_volsw_s8(struct snd_kc
  {
        struct soc_mixer_control *mc =
                (struct soc_mixer_control *)kcontrol->private_value;
-       int max = mc->max;
+       int platform_max;
        int min = mc->min;
  
+       if (!mc->platform_max)
+               mc->platform_max = mc->max;
+       platform_max = mc->platform_max;
        uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
        uinfo->count = 2;
        uinfo->value.integer.min = 0;
-       uinfo->value.integer.max = max-min;
+       uinfo->value.integer.max = platform_max - min;
        return 0;
  }
  EXPORT_SYMBOL_GPL(snd_soc_info_volsw_s8);
@@@ -2190,6 -2313,45 +2314,45 @@@ int snd_soc_put_volsw_s8(struct snd_kco
  EXPORT_SYMBOL_GPL(snd_soc_put_volsw_s8);
  
  /**
+  * snd_soc_limit_volume - Set new limit to an existing volume control.
+  *
+  * @codec: where to look for the control
+  * @name: Name of the control
+  * @max: new maximum limit
+  *
+  * Return 0 for success, else error.
+  */
+ int snd_soc_limit_volume(struct snd_soc_codec *codec,
+       const char *name, int max)
+ {
+       struct snd_card *card = codec->card;
+       struct snd_kcontrol *kctl;
+       struct soc_mixer_control *mc;
+       int found = 0;
+       int ret = -EINVAL;
+       /* Sanity check for name and max */
+       if (unlikely(!name || max <= 0))
+               return -EINVAL;
+       list_for_each_entry(kctl, &card->controls, list) {
+               if (!strncmp(kctl->id.name, name, sizeof(kctl->id.name))) {
+                       found = 1;
+                       break;
+               }
+       }
+       if (found) {
+               mc = (struct soc_mixer_control *)kctl->private_value;
+               if (max <= mc->max) {
+                       mc->platform_max = max;
+                       ret = 0;
+               }
+       }
+       return ret;
+ }
+ EXPORT_SYMBOL_GPL(snd_soc_limit_volume);
+ /**
   * snd_soc_dai_set_sysclk - configure DAI system or master clock.
   * @dai: DAI
   * @clk_id: DAI specific clock ID
diff --combined sound/soc/soc-dapm.c
@@@ -38,7 -38,6 +38,7 @@@
  #include <linux/platform_device.h>
  #include <linux/jiffies.h>
  #include <linux/debugfs.h>
 +#include <linux/slab.h>
  #include <sound/core.h>
  #include <sound/pcm.h>
  #include <sound/pcm_params.h>
@@@ -98,7 -97,6 +98,6 @@@ static void pop_dbg(u32 pop_time, cons
  
        if (pop_time) {
                vprintk(fmt, args);
-               pop_wait(pop_time);
        }
  
        va_end(args);
@@@ -315,62 -313,14 +314,14 @@@ static int dapm_update_bits(struct snd_
                pop_dbg(codec->pop_time, "pop test %s : %s in %d ms\n",
                        widget->name, widget->power ? "on" : "off",
                        codec->pop_time);
-               snd_soc_write(codec, widget->reg, new);
                pop_wait(codec->pop_time);
+               snd_soc_write(codec, widget->reg, new);
        }
        pr_debug("reg %x old %x new %x change %d\n", widget->reg,
                 old, new, change);
        return change;
  }
  
- /* ramps the volume up or down to minimise pops before or after a
-  * DAPM power event */
- static int dapm_set_pga(struct snd_soc_dapm_widget *widget, int power)
- {
-       const struct snd_kcontrol_new *k = widget->kcontrols;
-       if (widget->muted && !power)
-               return 0;
-       if (!widget->muted && power)
-               return 0;
-       if (widget->num_kcontrols && k) {
-               struct soc_mixer_control *mc =
-                       (struct soc_mixer_control *)k->private_value;
-               unsigned int reg = mc->reg;
-               unsigned int shift = mc->shift;
-               int max = mc->max;
-               unsigned int mask = (1 << fls(max)) - 1;
-               unsigned int invert = mc->invert;
-               if (power) {
-                       int i;
-                       /* power up has happended, increase volume to last level */
-                       if (invert) {
-                               for (i = max; i > widget->saved_value; i--)
-                                       snd_soc_update_bits(widget->codec, reg, mask, i);
-                       } else {
-                               for (i = 0; i < widget->saved_value; i++)
-                                       snd_soc_update_bits(widget->codec, reg, mask, i);
-                       }
-                       widget->muted = 0;
-               } else {
-                       /* power down is about to occur, decrease volume to mute */
-                       int val = snd_soc_read(widget->codec, reg);
-                       int i = widget->saved_value = (val >> shift) & mask;
-                       if (invert) {
-                               for (; i < mask; i++)
-                                       snd_soc_update_bits(widget->codec, reg, mask, i);
-                       } else {
-                               for (; i > 0; i--)
-                                       snd_soc_update_bits(widget->codec, reg, mask, i);
-                       }
-                       widget->muted = 1;
-               }
-       }
-       return 0;
- }
  /* create new dapm mixer control */
  static int dapm_new_mixer(struct snd_soc_codec *codec,
        struct snd_soc_dapm_widget *w)
@@@ -465,20 -415,10 +416,10 @@@ err
  static int dapm_new_pga(struct snd_soc_codec *codec,
        struct snd_soc_dapm_widget *w)
  {
-       struct snd_kcontrol *kcontrol;
-       int ret = 0;
-       if (!w->num_kcontrols)
-               return -EINVAL;
+       if (w->num_kcontrols)
+               pr_err("asoc: PGA controls not supported: '%s'\n", w->name);
  
-       kcontrol = snd_soc_cnew(&w->kcontrols[0], w, w->name);
-       ret = snd_ctl_add(codec->card, kcontrol);
-       if (ret < 0) {
-               printk(KERN_ERR "asoc: failed to add kcontrol %s\n", w->name);
-               return ret;
-       }
-       return ret;
+       return 0;
  }
  
  /* reset 'walked' bit for each dapm path */
@@@ -490,6 -430,25 +431,25 @@@ static inline void dapm_clear_walk(stru
                p->walked = 0;
  }
  
+ /* We implement power down on suspend by checking the power state of
+  * the ALSA card - when we are suspending the ALSA state for the card
+  * is set to D3.
+  */
+ static int snd_soc_dapm_suspend_check(struct snd_soc_dapm_widget *widget)
+ {
+       struct snd_soc_codec *codec = widget->codec;
+       switch (snd_power_get_state(codec->card)) {
+       case SNDRV_CTL_POWER_D3hot:
+       case SNDRV_CTL_POWER_D3cold:
+               if (widget->ignore_suspend)
+                       pr_debug("%s ignoring suspend\n", widget->name);
+               return widget->ignore_suspend;
+       default:
+               return 1;
+       }
+ }
  /*
   * Recursively check for a completed path to an active or physically connected
   * output widget. Returns number of complete paths.
@@@ -506,7 -465,7 +466,7 @@@ static int is_connected_output_ep(struc
        case snd_soc_dapm_adc:
        case snd_soc_dapm_aif_out:
                if (widget->active)
-                       return 1;
+                       return snd_soc_dapm_suspend_check(widget);
        default:
                break;
        }
        if (widget->connected) {
                /* connected pin ? */
                if (widget->id == snd_soc_dapm_output && !widget->ext)
-                       return 1;
+                       return snd_soc_dapm_suspend_check(widget);
  
                /* connected jack or spk ? */
                if (widget->id == snd_soc_dapm_hp || widget->id == snd_soc_dapm_spk ||
                    (widget->id == snd_soc_dapm_line && !list_empty(&widget->sources)))
-                       return 1;
+                       return snd_soc_dapm_suspend_check(widget);
        }
  
        list_for_each_entry(path, &widget->sinks, list_source) {
@@@ -552,7 -511,7 +512,7 @@@ static int is_connected_input_ep(struc
        case snd_soc_dapm_dac:
        case snd_soc_dapm_aif_in:
                if (widget->active)
-                       return 1;
+                       return snd_soc_dapm_suspend_check(widget);
        default:
                break;
        }
        if (widget->connected) {
                /* connected pin ? */
                if (widget->id == snd_soc_dapm_input && !widget->ext)
-                       return 1;
+                       return snd_soc_dapm_suspend_check(widget);
  
                /* connected VMID/Bias for lower pops */
                if (widget->id == snd_soc_dapm_vmid)
-                       return 1;
+                       return snd_soc_dapm_suspend_check(widget);
  
                /* connected jack ? */
                if (widget->id == snd_soc_dapm_mic ||
                    (widget->id == snd_soc_dapm_line && !list_empty(&widget->sinks)))
-                       return 1;
+                       return snd_soc_dapm_suspend_check(widget);
        }
  
        list_for_each_entry(path, &widget->sources, list_sink) {
@@@ -634,16 -593,8 +594,8 @@@ static int dapm_generic_apply_power(str
                        return ret;
        }
  
-       /* Lower PGA volume to reduce pops */
-       if (w->id == snd_soc_dapm_pga && !w->power)
-               dapm_set_pga(w, w->power);
        dapm_update_bits(w);
  
-       /* Raise PGA volume to reduce pops */
-       if (w->id == snd_soc_dapm_pga && w->power)
-               dapm_set_pga(w, w->power);
        /* power up post event */
        if (w->power && w->event &&
            (w->event_flags & SND_SOC_DAPM_POST_PMU)) {
@@@ -810,10 -761,6 +762,6 @@@ static void dapm_seq_run_coalesced(stru
                                pr_err("%s: pre event failed: %d\n",
                                       w->name, ret);
                }
-               /* Lower PGA volume to reduce pops */
-               if (w->id == snd_soc_dapm_pga && !w->power)
-                       dapm_set_pga(w, w->power);
        }
  
        if (reg >= 0) {
        }
  
        list_for_each_entry(w, pending, power_list) {
-               /* Raise PGA volume to reduce pops */
-               if (w->id == snd_soc_dapm_pga && w->power)
-                       dapm_set_pga(w, w->power);
                /* power up post event */
                if (w->power && w->event &&
                    (w->event_flags & SND_SOC_DAPM_POST_PMU)) {
@@@ -973,19 -916,12 +917,12 @@@ static int dapm_power_widgets(struct sn
                        if (!w->power_check)
                                continue;
  
-                       /* If we're suspending then pull down all the 
-                        * power. */
-                       switch (event) {
-                       case SND_SOC_DAPM_STREAM_SUSPEND:
-                               power = 0;
-                               break;
-                       default:
+                       if (!w->force)
                                power = w->power_check(w);
-                               if (power)
-                                       sys_power = 1;
-                               break;
-                       }
+                       else
+                               power = 1;
+                       if (power)
+                               sys_power = 1;
  
                        if (w->power == power)
                                continue;
  
        pop_dbg(codec->pop_time, "DAPM sequencing finished, waiting %dms\n",
                codec->pop_time);
+       pop_wait(codec->pop_time);
  
        return 0;
  }
@@@ -1338,6 -1275,9 +1276,9 @@@ static int snd_soc_dapm_set_pin(struct 
                if (!strcmp(w->name, pin)) {
                        pr_debug("dapm: %s: pin %s\n", codec->name, pin);
                        w->connected = status;
+                       /* Allow disabling of forced pins */
+                       if (status == 0)
+                               w->force = 0;
                        return 0;
                }
        }
@@@ -1594,12 -1534,6 +1535,6 @@@ int snd_soc_dapm_get_volsw(struct snd_k
        unsigned int invert = mc->invert;
        unsigned int mask = (1 << fls(max)) - 1;
  
-       /* return the saved value if we are powered down */
-       if (widget->id == snd_soc_dapm_pga && !widget->power) {
-               ucontrol->value.integer.value[0] = widget->saved_value;
-               return 0;
-       }
        ucontrol->value.integer.value[0] =
                (snd_soc_read(widget->codec, reg) >> shift) & mask;
        if (shift != rshift)
@@@ -1659,13 -1593,6 +1594,6 @@@ int snd_soc_dapm_put_volsw(struct snd_k
        mutex_lock(&widget->codec->mutex);
        widget->value = val;
  
-       /* save volume value if the widget is powered down */
-       if (widget->id == snd_soc_dapm_pga && !widget->power) {
-               widget->saved_value = val;
-               mutex_unlock(&widget->codec->mutex);
-               return 1;
-       }
        if (snd_soc_test_bits(widget->codec, reg, val_mask, val)) {
                if (val)
                        /* new connection */
@@@ -2094,18 -2021,8 +2022,8 @@@ int snd_soc_dapm_stream_event(struct sn
                                w->active = 0;
                                break;
                        case SND_SOC_DAPM_STREAM_SUSPEND:
-                               if (w->active)
-                                       w->suspend = 1;
-                               w->active = 0;
-                               break;
                        case SND_SOC_DAPM_STREAM_RESUME:
-                               if (w->suspend) {
-                                       w->active = 1;
-                                       w->suspend = 0;
-                               }
-                               break;
                        case SND_SOC_DAPM_STREAM_PAUSE_PUSH:
-                               break;
                        case SND_SOC_DAPM_STREAM_PAUSE_RELEASE:
                                break;
                        }
@@@ -2135,6 -2052,36 +2053,36 @@@ int snd_soc_dapm_enable_pin(struct snd_
  EXPORT_SYMBOL_GPL(snd_soc_dapm_enable_pin);
  
  /**
+  * snd_soc_dapm_force_enable_pin - force a pin to be enabled
+  * @codec: SoC codec
+  * @pin: pin name
+  *
+  * Enables input/output pin regardless of any other state.  This is
+  * intended for use with microphone bias supplies used in microphone
+  * jack detection.
+  *
+  * NOTE: snd_soc_dapm_sync() needs to be called after this for DAPM to
+  * do any widget power switching.
+  */
+ int snd_soc_dapm_force_enable_pin(struct snd_soc_codec *codec, const char *pin)
+ {
+       struct snd_soc_dapm_widget *w;
+       list_for_each_entry(w, &codec->dapm_widgets, list) {
+               if (!strcmp(w->name, pin)) {
+                       pr_debug("dapm: %s: pin %s\n", codec->name, pin);
+                       w->connected = 1;
+                       w->force = 1;
+                       return 0;
+               }
+       }
+       pr_err("dapm: %s: configuring unknown pin %s\n", codec->name, pin);
+       return -EINVAL;
+ }
+ EXPORT_SYMBOL_GPL(snd_soc_dapm_force_enable_pin);
+ /**
   * snd_soc_dapm_disable_pin - disable pin.
   * @codec: SoC codec
   * @pin: pin name
@@@ -2192,6 -2139,33 +2140,33 @@@ int snd_soc_dapm_get_pin_status(struct 
  EXPORT_SYMBOL_GPL(snd_soc_dapm_get_pin_status);
  
  /**
+  * snd_soc_dapm_ignore_suspend - ignore suspend status for DAPM endpoint
+  * @codec: audio codec
+  * @pin: audio signal pin endpoint (or start point)
+  *
+  * Mark the given endpoint or pin as ignoring suspend.  When the
+  * system is disabled a path between two endpoints flagged as ignoring
+  * suspend will not be disabled.  The path must already be enabled via
+  * normal means at suspend time, it will not be turned on if it was not
+  * already enabled.
+  */
+ int snd_soc_dapm_ignore_suspend(struct snd_soc_codec *codec, const char *pin)
+ {
+       struct snd_soc_dapm_widget *w;
+       list_for_each_entry(w, &codec->dapm_widgets, list) {
+               if (!strcmp(w->name, pin)) {
+                       w->ignore_suspend = 1;
+                       return 0;
+               }
+       }
+       pr_err("Unknown DAPM pin: %s\n", pin);
+       return -EINVAL;
+ }
+ EXPORT_SYMBOL_GPL(snd_soc_dapm_ignore_suspend);
+ /**
   * snd_soc_dapm_free - free dapm resources
   * @socdev: SoC device
   *