Staging: comedi: cb_pcimdda.c: Checkpatch cleanup
authorAndrea Gelmini <andrea.gelmini@gelma.net>
Fri, 26 Feb 2010 09:15:03 +0000 (10:15 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Thu, 4 Mar 2010 00:43:06 +0000 (16:43 -0800)
WARNING: braces {} are not necessary for any arm of this statement
+ if (it->options[2]) {
[...]
+ } else {
[...]

WARNING: braces {} are not necessary for single statement blocks
+ if (devpriv->registers) {
+ comedi_pci_disable(devpriv->pci_dev);
+ }

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/comedi/drivers/cb_pcimdda.c

index 980fa0a..e32a317 100644 (file)
@@ -284,11 +284,10 @@ static int attach(struct comedi_device *dev, struct comedi_devconfig *it)
        s->n_chan = thisboard->ao_chans;
        s->maxdata = figure_out_maxdata(thisboard->ao_bits);
        /* this is hard-coded here */
-       if (it->options[2]) {
+       if (it->options[2])
                s->range_table = &range_bipolar10;
-       } else {
+       else
                s->range_table = &range_bipolar5;
-       }
        s->insn_write = &ao_winsn;
        s->insn_read = &ao_rinsn;
 
@@ -337,9 +336,8 @@ static int detach(struct comedi_device *dev)
                }
 
                if (devpriv->pci_dev) {
-                       if (devpriv->registers) {
+                       if (devpriv->registers)
                                comedi_pci_disable(devpriv->pci_dev);
-                       }
                        pci_dev_put(devpriv->pci_dev);
                }