[SCSI] scsi dh alua: fix group id masking
authorIlgu Hong <ilgu.hong@promise.com>
Fri, 30 Jan 2009 23:00:09 +0000 (17:00 -0600)
committerJames Bottomley <James.Bottomley@HansenPartnership.com>
Thu, 12 Mar 2009 17:58:11 +0000 (12:58 -0500)
The buf[i] is a byte but we are only asking 4 bits off the
group_id. This patch has us take off a byte.

Signed-off-by: Ilgu Hong <ilgu.hong@promise.com>
Signed-off-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
drivers/scsi/device_handler/scsi_dh_alua.c

index e356b43..5096b0b 100644 (file)
@@ -247,8 +247,8 @@ static unsigned submit_stpg(struct scsi_device *sdev, struct alua_dh_data *h)
        /* Prepare the data buffer */
        memset(h->buff, 0, stpg_len);
        h->buff[4] = TPGS_STATE_OPTIMIZED & 0x0f;
-       h->buff[6] = (h->group_id >> 8) & 0x0f;
-       h->buff[7] = h->group_id & 0x0f;
+       h->buff[6] = (h->group_id >> 8) & 0xff;
+       h->buff[7] = h->group_id & 0xff;
 
        rq = get_alua_req(sdev, h->buff, stpg_len, WRITE);
        if (!rq)