md: remove sparse warnings about lock context.
authorNeilBrown <neilb@suse.de>
Wed, 23 Sep 2009 08:06:44 +0000 (18:06 +1000)
committerNeilBrown <neilb@suse.de>
Wed, 23 Sep 2009 08:06:44 +0000 (18:06 +1000)
There was a real error here on a failure path where we
incorrectly call rcu_read_unlock.

Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/bitmap.c

index 3319c2f..6986b00 100644 (file)
@@ -108,6 +108,8 @@ static void bitmap_free_page(struct bitmap *bitmap, unsigned char *page)
  * allocated while we're using it
  */
 static int bitmap_checkpage(struct bitmap *bitmap, unsigned long page, int create)
+__releases(bitmap->lock)
+__acquires(bitmap->lock)
 {
        unsigned char *mappage;
 
@@ -325,7 +327,6 @@ static int write_sb_page(struct bitmap *bitmap, struct page *page, int wait)
        return 0;
 
  bad_alignment:
-       rcu_read_unlock();
        return -EINVAL;
 }
 
@@ -1207,6 +1208,8 @@ void bitmap_daemon_work(struct bitmap *bitmap)
 static bitmap_counter_t *bitmap_get_counter(struct bitmap *bitmap,
                                            sector_t offset, int *blocks,
                                            int create)
+__releases(bitmap->lock)
+__acquires(bitmap->lock)
 {
        /* If 'create', we might release the lock and reclaim it.
         * The lock must have been taken with interrupts enabled.