perf_counter: Move child perfcounter init to after scheduler init
authorIngo Molnar <mingo@elte.hu>
Tue, 19 May 2009 13:50:30 +0000 (15:50 +0200)
committerIngo Molnar <mingo@elte.hu>
Mon, 25 May 2009 11:05:06 +0000 (13:05 +0200)
Initialize a task's perfcounters (inherit from parent, etc.) after
the child task's scheduler fields have been initialized already.

[ Impact: cleanup ]

Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: John Kacur <jkacur@redhat.com>
Cc: Mike Galbraith <efault@gmx.de>
LKML-Reference: <new-submission>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
kernel/fork.c

index e72a09f..675e01e 100644 (file)
@@ -984,7 +984,6 @@ static struct task_struct *copy_process(unsigned long clone_flags,
                goto fork_out;
 
        rt_mutex_init_task(p);
-       perf_counter_init_task(p);
 
 #ifdef CONFIG_PROVE_LOCKING
        DEBUG_LOCKS_WARN_ON(!p->hardirqs_enabled);
@@ -1096,6 +1095,7 @@ static struct task_struct *copy_process(unsigned long clone_flags,
 
        /* Perform scheduler related setup. Assign this task to a CPU. */
        sched_fork(p, clone_flags);
+       perf_counter_init_task(p);
 
        if ((retval = audit_alloc(p)))
                goto bad_fork_cleanup_policy;