hrtimer: remove hrtimer_clock_base::get_softirq_time()
authorMark McLoughlin <markmc@redhat.com>
Fri, 19 Sep 2008 12:13:44 +0000 (13:13 +0100)
committerIngo Molnar <mingo@elte.hu>
Mon, 22 Sep 2008 11:52:42 +0000 (13:52 +0200)
Peter Zijlstra noticed this 8 months ago and I just noticed
it again.

hrtimer_clock_base::get_softirq_time() is currently unused
in the entire tree. In fact, looking at the logs, it appears
as if it was never used. Remove it.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
include/linux/hrtimer.h
kernel/hrtimer.c

index 6d93dce..1b079bd 100644 (file)
@@ -145,7 +145,6 @@ struct hrtimer_sleeper {
  * @first:             pointer to the timer node which expires first
  * @resolution:                the resolution of the clock, in nanoseconds
  * @get_time:          function to retrieve the current time of the clock
- * @get_softirq_time:  function to retrieve the current time from the softirq
  * @softirq_time:      the time when running the hrtimer queue in the softirq
  * @offset:            offset of this clock to the monotonic base
  * @reprogram:         function to reprogram the timer event
@@ -157,7 +156,6 @@ struct hrtimer_clock_base {
        struct rb_node          *first;
        ktime_t                 resolution;
        ktime_t                 (*get_time)(void);
-       ktime_t                 (*get_softirq_time)(void);
        ktime_t                 softirq_time;
 #ifdef CONFIG_HIGH_RES_TIMERS
        ktime_t                 offset;
index 03ea137..4d761d5 100644 (file)
@@ -1401,9 +1401,7 @@ void hrtimer_run_queues(void)
                if (!base->first)
                        continue;
 
-               if (base->get_softirq_time)
-                       base->softirq_time = base->get_softirq_time();
-               else if (gettime) {
+               if (gettime) {
                        hrtimer_get_softirq_time(cpu_base);
                        gettime = 0;
                }