md/raid1: fix confusing 'redirect sector' message.
authorNeilBrown <neilb@suse.de>
Wed, 7 Apr 2010 02:14:43 +0000 (12:14 +1000)
committerNeilBrown <neilb@suse.de>
Tue, 18 May 2010 05:27:56 +0000 (15:27 +1000)
This message seems to suggest the named device is the one on which a
read failed, however it is actually the device that the read will be
redirected to.
So make the message a little clearer.

Reported-by: Tim Burgess <ozburgess@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
drivers/md/raid1.c

index 5ff75c4..2e08e48 100644 (file)
@@ -1689,10 +1689,10 @@ static void raid1d(mddev_t *mddev)
                                r1_bio->bios[r1_bio->read_disk] = bio;
                                rdev = conf->mirrors[disk].rdev;
                                if (printk_ratelimit())
-                                       printk(KERN_ERR "raid1: %s: redirecting sector %llu to"
-                                              " another mirror\n",
-                                              bdevname(rdev->bdev,b),
-                                              (unsigned long long)r1_bio->sector);
+                                       printk(KERN_ERR "raid1: redirecting sector %llu to"
+                                              " other mirror: %s\n",
+                                              (unsigned long long)r1_bio->sector,
+                                              bdevname(rdev->bdev,b));
                                bio->bi_sector = r1_bio->sector + rdev->data_offset;
                                bio->bi_bdev = rdev->bdev;
                                bio->bi_end_io = raid1_end_read_request;