[GFS2] use an temp variable to reduce a spin_unlock
authorDenis Cheng <crquan@gmail.com>
Wed, 25 Jul 2007 09:53:58 +0000 (17:53 +0800)
committerSteven Whitehouse <swhiteho@redhat.com>
Wed, 10 Oct 2007 07:54:58 +0000 (08:54 +0100)
this is more clear.

Signed-off-by: Denis Cheng <crquan@gmail.com>
Signed-off-by: David Teigland <teigland@redhat.com>
Signed-off-by: Steven Whitehouse <swhiteho@redhat.com>
fs/gfs2/locking/dlm/plock.c

index fba1f1d..1f7b038 100644 (file)
@@ -346,15 +346,16 @@ static ssize_t dev_write(struct file *file, const char __user *u, size_t count,
 
 static unsigned int dev_poll(struct file *file, poll_table *wait)
 {
+       unsigned int mask = 0;
+
        poll_wait(file, &send_wq, wait);
 
        spin_lock(&ops_lock);
-       if (!list_empty(&send_list)) {
-               spin_unlock(&ops_lock);
-               return POLLIN | POLLRDNORM;
-       }
+       if (!list_empty(&send_list))
+               mask = POLLIN | POLLRDNORM;
        spin_unlock(&ops_lock);
-       return 0;
+
+       return mask;
 }
 
 static const struct file_operations dev_fops = {