CAPI: Drop special controller lookup from capi20_put_message
authorJan Kiszka <jan.kiszka@web.de>
Mon, 8 Feb 2010 10:12:43 +0000 (10:12 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 17 Feb 2010 00:01:35 +0000 (16:01 -0800)
This strange special rule to fall back to controller 1 cannot be derived
from the CAPI specs and looks a lot like it was once dedicated to some
out-of-tree driver, probably AVM's broken fcdsl2 (FRITZ!Card DSL v2.0).
I found no in-tree user that needs this check, and I'm now taking care
of the fcdsl2. So drop these bits from our stack.

Signed-off-by: Jan Kiszka <jan.kiszka@web.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/isdn/capi/kcapi.c

index 0b4c8a7..ce9b05b 100644 (file)
@@ -777,11 +777,8 @@ u16 capi20_put_message(struct capi20_appl *ap, struct sk_buff *skb)
         * synchronizes this service with capi20_release.
         */
        ctr = get_capi_ctr_by_nr(CAPIMSG_CONTROLLER(skb->data));
-       if (!ctr || ctr->state != CAPI_CTR_RUNNING) {
-               ctr = get_capi_ctr_by_nr(1); /* XXX why? */
-               if (!ctr || ctr->state != CAPI_CTR_RUNNING)
-                       return CAPI_REGNOTINSTALLED;
-       }
+       if (!ctr || ctr->state != CAPI_CTR_RUNNING)
+               return CAPI_REGNOTINSTALLED;
        if (ctr->blocked)
                return CAPI_SENDQUEUEFULL;