NLM: Clean up before introducing new debugging messages
authorChuck Lever <chuck.lever@oracle.com>
Wed, 27 Aug 2008 20:57:15 +0000 (16:57 -0400)
committerJ. Bruce Fields <bfields@citi.umich.edu>
Mon, 29 Sep 2008 22:13:38 +0000 (18:13 -0400)
We're about to introduce some extra debugging messages in nlm_lookup_host().
Bring the coding style up to date first so we can cleanly introduce the new
debugging messages.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
fs/lockd/host.c

index a17664c..cb26e3d 100644 (file)
@@ -103,16 +103,19 @@ static struct nlm_host *nlm_lookup_host(int server,
                nlm_get_host(host);
                goto out;
        }
-       if (nsm)
-               atomic_inc(&nsm->sm_count);
-
-       host = NULL;
 
-       /* Sadly, the host isn't in our hash table yet. See if
-        * we have an NSM handle for it. If not, create one.
+       /*
+        * The host wasn't in our hash table.  If we don't
+        * have an NSM handle for it yet, create one.
         */
-       if (!nsm && !(nsm = nsm_find(sin, hostname, hostname_len)))
-               goto out;
+       if (nsm)
+               atomic_inc(&nsm->sm_count);
+       else {
+               host = NULL;
+               nsm = nsm_find(sin, hostname, hostname_len);
+               if (!nsm)
+                       goto out;
+       }
 
        host = kzalloc(sizeof(*host), GFP_KERNEL);
        if (!host) {