[SCSI] scsi_dh_rdac: Fix for returning correct mode select cmd return info
authorMoger, Babu <Babu.Moger@lsi.com>
Fri, 28 Aug 2009 14:18:39 +0000 (08:18 -0600)
committerJames Bottomley <James.Bottomley@suse.de>
Fri, 2 Oct 2009 14:45:09 +0000 (09:45 -0500)
The function mode_select_handle_sense returns SCSI_DH_OK even when there is a sense code which is incorrect. Removing it so that it returns SCSI_DH_IO when there is sense that is not handled by this function.

Signed-off-by: Babu Moger <babu.moger@lsi.com>
Reviewed-by: Vijay Chauhan <vijay.chauhan@lsi.com>
Reviewed-by: Bob Stankey <Robert.stankey@lsi.com>
Reviewed-by: Chandra Seetharaman <sekharan@us.ibm.com>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/device_handler/scsi_dh_rdac.c

index 11c8931..268189d 100644 (file)
@@ -500,8 +500,6 @@ static int mode_select_handle_sense(struct scsi_device *sdev,
        if (!ret)
                goto done;
 
-       err = SCSI_DH_OK;
-
        switch (sense_hdr.sense_key) {
        case NO_SENSE:
        case ABORTED_COMMAND: