Staging et131x: kill refcount
authorAlan Cox <alan@linux.intel.com>
Thu, 27 Aug 2009 09:58:49 +0000 (10:58 +0100)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 15 Sep 2009 19:02:26 +0000 (12:02 -0700)
The RefCount field is accessed only by a macro and the only use of it in
the tree is to read it, so it can go

Signed-off-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/et131x/et1310_pm.c
drivers/staging/et131x/et1310_rx.c
drivers/staging/et131x/et131x_adapter.h

index a507411..848d6b0 100644 (file)
@@ -139,8 +139,6 @@ void EnablePhyComa(struct et131x_adapter *etdev)
        spin_unlock_irqrestore(&etdev->SendHWLock, flags);
 
        /* Wait for outstanding Receive packets */
-       while ((MP_GET_RCV_REF(etdev) != 0) && (LoopCounter-- > 0))
-               mdelay(2);
 
        /* Gate off JAGCore 3 clock domains */
        GlobalPmCSR.bits.pm_sysclk_gate = 0;
index b05b8c5..6423552 100644 (file)
@@ -1258,13 +1258,6 @@ void et131x_handle_recv_interrupt(struct et131x_adapter *etdev)
                         * Besides, we don't really need (at this point) the
                         * pending list anyway.
                         */
-                       /* spin_lock_irqsave( &etdev->RcvPendLock, flags );
-                        * list_add_tail( &pMpRfd->list_node, &etdev->RxRing.RecvPendingList );
-                        * spin_unlock_irqrestore( &etdev->RcvPendLock, flags );
-                        */
-
-                       /* Update the number of outstanding Recvs */
-                       /* MP_INC_RCV_REF( etdev ); */
                } else {
                        RFDFreeArray[PacketFreeCount] = pMpRfd;
                        PacketFreeCount++;
index 82686ea..04de4ff 100644 (file)
 #define MP_TEST_FLAGS(_M, _F)       (((_M)->Flags & (_F)) == (_F))
 #define MP_IS_FLAG_CLEAR(_M, _F)    (((_M)->Flags & (_F)) == 0)
 
-#define MP_GET_RCV_REF(_A)          atomic_read(&(_A)->RcvRefCount)
-
 /* Macros specific to the private adapter structure */
 #define MP_TCB_RESOURCES_AVAILABLE(_M) ((_M)->TxRing.nBusySend < NUM_TCB)
 #define MP_TCB_RESOURCES_NOT_AVAILABLE(_M) ((_M)->TxRing.nBusySend >= NUM_TCB)
@@ -311,8 +309,6 @@ struct et131x_adapter {
        MP_POWER_MGMT PoMgmt;
        INTERRUPT_t CachedMaskValue;
 
-       atomic_t RcvRefCount;   /* Num packets not yet returned */
-
        /* Xcvr status at last poll */
        MI_BMSR_t Bmsr;