V4L/DVB (11516): drivers/media/video/saa5246a.c: fix use-after-free
authorDan Carpenter <error27@gmail.com>
Tue, 14 Apr 2009 22:51:30 +0000 (19:51 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 29 Apr 2009 18:41:12 +0000 (15:41 -0300)
I lowered the kfree(t) down a couple lines and removed the superflous
"t->vdev = NULL;"

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/saa5246a.c

index da47b2f..155804b 100644 (file)
@@ -1092,9 +1092,8 @@ static int saa5246a_probe(struct i2c_client *client,
        /* Register it */
        err = video_register_device(t->vdev, VFL_TYPE_VTX, -1);
        if (err < 0) {
-               kfree(t);
                video_device_release(t->vdev);
-               t->vdev = NULL;
+               kfree(t);
                return err;
        }
        return 0;