locks: allow lockd to process blocked locks during grace period
authorJ. Bruce Fields <bfields@citi.umich.edu>
Thu, 24 Jan 2008 16:11:34 +0000 (11:11 -0500)
committerJ. Bruce Fields <bfields@citi.umich.edu>
Mon, 29 Sep 2008 21:56:59 +0000 (17:56 -0400)
The check here is currently harmless but unnecessary, since, as the
comment notes, there aren't any blocked-lock callbacks to process
during the grace period anyway.

And eventually we want to allow multiple grace periods that come and go
for different filesystems over the course of the lifetime of lockd, at
which point this check is just going to get in the way.

Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
fs/lockd/svc.c

index 1553fec..bdc607b 100644 (file)
@@ -158,15 +158,9 @@ lockd(void *vrqstp)
                        continue;
                }
 
-               /*
-                * Retry any blocked locks that have been notified by
-                * the VFS. Don't do this during grace period.
-                * (Theoretically, there shouldn't even be blocked locks
-                * during grace period).
-                */
-               if (!nlmsvc_grace_period) {
-                       timeout = nlmsvc_retry_blocked();
-               } else if (time_before(grace_period_expire, jiffies))
+               timeout = nlmsvc_retry_blocked();
+
+               if (time_before(grace_period_expire, jiffies))
                        clear_grace_period();
 
                /*