BUG_ON cleanups in arch/i386
authorEric Sesterhenn <snakebyte@gmx.de>
Tue, 3 Oct 2006 21:34:58 +0000 (23:34 +0200)
committerAdrian Bunk <bunk@stusta.de>
Tue, 3 Oct 2006 21:34:58 +0000 (23:34 +0200)
This changes a couple of if() BUG(); constructs to
BUG_ON(); so it can be safely optimized away.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Adrian Bunk <bunk@stusta.de>
arch/i386/kernel/cpu/common.c
arch/i386/kernel/efi.c
arch/i386/mm/discontig.c
arch/i386/mm/init.c

index b2f24d5..d9f3e3c 100644 (file)
@@ -669,8 +669,7 @@ old_gdt:
         */
        atomic_inc(&init_mm.mm_count);
        current->active_mm = &init_mm;
-       if (current->mm)
-               BUG();
+       BUG_ON(current->mm);
        enter_lazy_tlb(&init_mm, current);
 
        load_esp0(t, thread);
index f943698..8b40648 100644 (file)
@@ -498,8 +498,7 @@ void __init efi_enter_virtual_mode(void)
                check_range_for_systab(md);
        }
 
-       if (!efi.systab)
-               BUG();
+       BUG_ON(!efi.systab);
 
        status = phys_efi_set_virtual_address_map(
                        memmap.desc_size * memmap.nr_map,
index 51e3739..455597d 100644 (file)
@@ -153,8 +153,7 @@ static void __init find_max_pfn_node(int nid)
         */
        if (node_start_pfn[nid] > max_pfn)
                node_start_pfn[nid] = max_pfn;
-       if (node_start_pfn[nid] > node_end_pfn[nid])
-               BUG();
+       BUG_ON(node_start_pfn[nid] > node_end_pfn[nid]);
 }
 
 /* 
index 90089c1..1674161 100644 (file)
@@ -569,8 +569,7 @@ void __init mem_init(void)
        int bad_ppro;
 
 #ifdef CONFIG_FLATMEM
-       if (!mem_map)
-               BUG();
+       BUG_ON(!mem_map);
 #endif
        
        bad_ppro = ppro_with_ram_bug();