V4L/DVB: s2255drv: remove dead code
authorDan Carpenter <error27@gmail.com>
Wed, 5 May 2010 06:00:47 +0000 (03:00 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Wed, 19 May 2010 15:59:14 +0000 (12:59 -0300)
My concern initially was we dereference "dev" in the parameter list to
s2255_dev_err() but it turns out that code path is never used.
The s2255_stop_readpipe() is only called from one place and "dev" is
never null.  So this patch just removes the whole condition here.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: linux-dev@sensoray.com
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/video/s2255drv.c

index 1f9a49e..3c7a79f 100644 (file)
@@ -2528,10 +2528,7 @@ static int s2255_stop_acquire(struct s2255_dev *dev, unsigned long chn)
 static void s2255_stop_readpipe(struct s2255_dev *dev)
 {
        struct s2255_pipeinfo *pipe = &dev->pipe;
 static void s2255_stop_readpipe(struct s2255_dev *dev)
 {
        struct s2255_pipeinfo *pipe = &dev->pipe;
-       if (dev == NULL) {
-               s2255_dev_err(&dev->udev->dev, "invalid device\n");
-               return;
-       }
+
        pipe->state = 0;
        if (pipe->stream_urb) {
                /* cancel urb */
        pipe->state = 0;
        if (pipe->stream_urb) {
                /* cancel urb */