pnp: Failed to activate device 00:0a - Samsung P35 XVM 1600 III
authorShaohua Li <shaohua.li@intel.com>
Sun, 13 Jan 2008 00:37:49 +0000 (19:37 -0500)
committerLen Brown <len.brown@intel.com>
Sun, 13 Jan 2008 00:37:49 +0000 (19:37 -0500)
PNP_WRITE requires protocol supports .set. If ACPI doesn't support _SRS, .set ismeanless, so PNP_WRITE.

Signed-off-by: Shaohua Li <shaohua.li@intel.com>
Signed-off-by: Len Brown <len.brown@intel.com>
drivers/pnp/pnpacpi/core.c

index dada899..662b4c2 100644 (file)
@@ -183,7 +183,7 @@ static int __init pnpacpi_add_device(struct acpi_device *device)
        if (ACPI_SUCCESS(status))
                dev->capabilities |= PNP_CONFIGURABLE;
        dev->capabilities |= PNP_READ;
-       if (device->flags.dynamic_status)
+       if (device->flags.dynamic_status && (dev->capabilities & PNP_CONFIGURABLE))
                dev->capabilities |= PNP_WRITE;
        if (device->flags.removable)
                dev->capabilities |= PNP_REMOVABLE;