driver core: sysdev: do not send KOBJ_ADD uevent if kobject_init_and_add fails
authorXiaotian Feng <dfeng@redhat.com>
Fri, 24 Jul 2009 09:31:41 +0000 (17:31 +0800)
committerGreg Kroah-Hartman <gregkh@suse.de>
Tue, 28 Jul 2009 20:45:22 +0000 (13:45 -0700)
If kobject_init_and_add fails, sysdev_register should not send KOBJ_ADD
uevent to userspace.

Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/base/sys.c

index 79a9ae5..0d90390 100644 (file)
@@ -275,9 +275,9 @@ int sysdev_register(struct sys_device *sysdev)
                                drv->add(sysdev);
                }
                mutex_unlock(&sysdev_drivers_lock);
+               kobject_uevent(&sysdev->kobj, KOBJ_ADD);
        }
 
-       kobject_uevent(&sysdev->kobj, KOBJ_ADD);
        return error;
 }