[CPUFREQ] Fix sysfs_create_file return value handling

Commit 0a4b2ccc555fa2ca6873d60219047104e4805d45 in cpufreq.git
eliminates the build warnings but does not pass on the error code of
sysfs_create_file to the function calling cpufreq_add_dev. Instead some
previous value of ret would be returned.

Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Signed-off-by: Dave Jones <davej@redhat.com>

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 0521427..0db9e1b 100644 (file)
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -826,16 +826,19 @@ static int cpufreq_add_dev (struct sys_device * sys_dev)
        /* set up files for this cpu device */
        drv_attr = cpufreq_driver->attr;
        while ((drv_attr) && (*drv_attr)) {
-               if (sysfs_create_file(&policy->kobj, &((*drv_attr)->attr)))
+               ret = sysfs_create_file(&policy->kobj, &((*drv_attr)->attr));
+               if (ret)
                        goto err_out_driver_exit;
                drv_attr++;
        }
        if (cpufreq_driver->get){
-               if (sysfs_create_file(&policy->kobj, &cpuinfo_cur_freq.attr))
+               ret = sysfs_create_file(&policy->kobj, &cpuinfo_cur_freq.attr);
+               if (ret)
                        goto err_out_driver_exit;
        }
        if (cpufreq_driver->target){
-               if (sysfs_create_file(&policy->kobj, &scaling_cur_freq.attr))
+               ret = sysfs_create_file(&policy->kobj, &scaling_cur_freq.attr);
+               if (ret)
                        goto err_out_driver_exit;
        }