sky2: checksum offload plus vlan bug
authorStephen Hemminger <shemminger@linux-foundation.org>
Thu, 24 May 2007 22:22:44 +0000 (15:22 -0700)
committerJeff Garzik <jeff@garzik.org>
Wed, 30 May 2007 13:52:47 +0000 (09:52 -0400)
Driver was not correctly setting up transmit descriptor when doing
VLAN tag insertion with checksum offload.

Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
drivers/net/sky2.c

index d9bc98b..7d94eab 100644 (file)
@@ -1432,7 +1432,7 @@ static int sky2_xmit_frame(struct sk_buff *skb, struct net_device *dev)
                tcpsum = offset << 16;          /* sum start */
                tcpsum |= offset + skb->csum_offset;    /* sum write */
 
-               ctrl = CALSUM | WR_SUM | INIT_SUM | LOCK_SUM;
+               ctrl |= CALSUM | WR_SUM | INIT_SUM | LOCK_SUM;
                if (ip_hdr(skb)->protocol == IPPROTO_UDP)
                        ctrl |= UDPTCP;