nilfs2: fix incorrect KERN_CRIT messages in case of write failures
authorRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Thu, 18 Jun 2009 14:53:25 +0000 (23:53 +0900)
committerRyusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Sun, 5 Jul 2009 01:44:20 +0000 (10:44 +0900)
In case of write-failure retries, the following KERN_CRIT level
messages are mistakenly output by nilfs_dat_commit_start() function:

nilfs_dat_commit_start: vbn = 408463, start = 12506, end = 18446744073709551615, pbn = 530210
nilfs_dat_commit_start: vbn = 408515, start = 12506, end = 18446744073709551615, pbn = 530211
nilfs_dat_commit_start: vbn = 408464, start = 12506, end = 18446744073709551615, pbn = 530212
...

This suppresses these messages.

Signed-off-by: Ryusuke Konishi <konishi.ryusuke@lab.ntt.co.jp>
Cc: stable@kernel.org
fs/nilfs2/dat.c

index 0b2710e..8927ca2 100644 (file)
@@ -134,15 +134,6 @@ void nilfs_dat_commit_start(struct inode *dat, struct nilfs_palloc_req *req,
        entry = nilfs_palloc_block_get_entry(dat, req->pr_entry_nr,
                                             req->pr_entry_bh, kaddr);
        entry->de_start = cpu_to_le64(nilfs_mdt_cno(dat));
-       if (entry->de_blocknr != cpu_to_le64(0) ||
-           entry->de_end != cpu_to_le64(NILFS_CNO_MAX)) {
-               printk(KERN_CRIT
-                      "%s: vbn = %llu, start = %llu, end = %llu, pbn = %llu\n",
-                      __func__, (unsigned long long)req->pr_entry_nr,
-                      (unsigned long long)le64_to_cpu(entry->de_start),
-                      (unsigned long long)le64_to_cpu(entry->de_end),
-                      (unsigned long long)le64_to_cpu(entry->de_blocknr));
-       }
        entry->de_blocknr = cpu_to_le64(blocknr);
        kunmap_atomic(kaddr, KM_USER0);