[ARM] pxa/viper: convert to use plat_serial8250_port irqflags field
authorMarc Zyngier <maz@misterjones.org>
Sat, 14 Nov 2009 14:53:14 +0000 (15:53 +0100)
committerEric Miao <eric.y.miao@gmail.com>
Tue, 1 Dec 2009 01:03:04 +0000 (09:03 +0800)
Use .irqflags in the plat_serial8250_port structure to set IRQ
polarity, and get rid of the corresponding set_irq_type().

Signed-off-by: Marc Zyngier <maz@misterjones.org>
Signed-off-by: Eric Miao <eric.y.miao@gmail.com>
arch/arm/mach-pxa/viper.c

index 6c36bd9..cf0d71b 100644 (file)
@@ -301,15 +301,6 @@ static void __init viper_init_irq(void)
        set_irq_chained_handler(gpio_to_irq(VIPER_CPLD_GPIO),
                                viper_irq_handler);
        set_irq_type(gpio_to_irq(VIPER_CPLD_GPIO), IRQ_TYPE_EDGE_BOTH);
-
-#ifndef CONFIG_SERIAL_PXA
-       /*
-        * 8250 doesn't support IRQ_TYPE being passed as part
-        * of the plat_serial8250_port structure...
-        */
-       set_irq_type(gpio_to_irq(VIPER_UARTA_GPIO), IRQ_TYPE_EDGE_RISING);
-       set_irq_type(gpio_to_irq(VIPER_UARTB_GPIO), IRQ_TYPE_EDGE_RISING);
-#endif
 }
 
 /* Flat Panel */
@@ -539,6 +530,7 @@ static struct plat_serial8250_port serial_platform_data[] = {
        {
                .mapbase        = VIPER_UARTA_PHYS,
                .irq            = gpio_to_irq(VIPER_UARTA_GPIO),
+               .irqflags       = IRQF_TRIGGER_RISING,
                .uartclk        = 1843200,
                .regshift       = 1,
                .iotype         = UPIO_MEM,
@@ -548,6 +540,7 @@ static struct plat_serial8250_port serial_platform_data[] = {
        {
                .mapbase        = VIPER_UARTB_PHYS,
                .irq            = gpio_to_irq(VIPER_UARTB_GPIO),
+               .irqflags       = IRQF_TRIGGER_RISING,
                .uartclk        = 1843200,
                .regshift       = 1,
                .iotype         = UPIO_MEM,