lib: Fix atomic64_inc_not_zero test
authorLuca Barbieri <luca@luca-barbieri.com>
Mon, 1 Mar 2010 18:55:48 +0000 (19:55 +0100)
committerH. Peter Anvin <hpa@zytor.com>
Mon, 1 Mar 2010 19:39:02 +0000 (11:39 -0800)
atomic64_inc_not_zero must return 1 if it perfomed the add and 0 otherwise.
The test assumed the opposite convention.

Signed-off-by: Luca Barbieri <luca@luca-barbieri.com>
LKML-Reference: <1267469749-11878-5-git-send-email-luca@luca-barbieri.com>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
lib/atomic64_test.c

index ee8e6de..f7bb706 100644 (file)
@@ -130,16 +130,16 @@ static __init int test_atomic64(void)
 #endif
 
        INIT(onestwos);
-       BUG_ON(atomic64_inc_not_zero(&v));
+       BUG_ON(!atomic64_inc_not_zero(&v));
        r += one;
        BUG_ON(v.counter != r);
 
        INIT(0);
-       BUG_ON(!atomic64_inc_not_zero(&v));
+       BUG_ON(atomic64_inc_not_zero(&v));
        BUG_ON(v.counter != r);
 
        INIT(-one);
-       BUG_ON(atomic64_inc_not_zero(&v));
+       BUG_ON(!atomic64_inc_not_zero(&v));
        r += one;
        BUG_ON(v.counter != r);