PCI: use better error return values in aer_inject
authorAndrew Patterson <andrew.patterson@hp.com>
Mon, 12 Oct 2009 19:14:10 +0000 (13:14 -0600)
committerJesse Barnes <jbarnes@virtuousgeek.org>
Wed, 4 Nov 2009 21:06:38 +0000 (13:06 -0800)
Replaced some error return values in aer_inject. Use -ENODEV when we
can't find a device and -ENOTTY when the device does not support PCIe AER.

Acked-by: Huang Ying <ying.huang@intel.com>
Signed-off-by: Andrew Patterson <andrew.patterson@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
drivers/pci/pcie/aer/aer_inject.c

index ac0b5e7..da2ad6e 100644 (file)
@@ -326,23 +326,23 @@ static int aer_inject(struct aer_error_inj *einj)
 
        dev = pci_get_domain_bus_and_slot((int)einj->domain, einj->bus, devfn);
        if (!dev)
-               return -EINVAL;
+               return -ENODEV;
        rpdev = pcie_find_root_port(dev);
        if (!rpdev) {
-               ret = -EINVAL;
+               ret = -ENOTTY;
                goto out_put;
        }
 
        pos_cap_err = pci_find_ext_capability(dev, PCI_EXT_CAP_ID_ERR);
        if (!pos_cap_err) {
-               ret = -EIO;
+               ret = -ENOTTY;
                goto out_put;
        }
        pci_read_config_dword(dev, pos_cap_err + PCI_ERR_UNCOR_SEVER, &sever);
 
        rp_pos_cap_err = pci_find_ext_capability(rpdev, PCI_EXT_CAP_ID_ERR);
        if (!rp_pos_cap_err) {
-               ret = -EIO;
+               ret = -ENOTTY;
                goto out_put;
        }