V4L/DVB (9439): Bug! SFRL nibble got swapped
authorManu Abraham <abraham.manu@gmail.com>
Fri, 9 Nov 2007 20:33:26 +0000 (17:33 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Mon, 29 Dec 2008 19:53:20 +0000 (17:53 -0200)
The Bug was found by Arvo Jarve <arvo@softshark.ee>

It was a wonder how it worked in the case with this bug,
STM verified this that this nibble was in fact insignificant
and can be ignored.

But still we need to fix all inconsistencies.

Signed-off-by: Manu Abraham <manu@linuxtv.org>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/dvb/frontends/stb0899_algo.c

index 2256fc7..6913beb 100644 (file)
@@ -110,7 +110,7 @@ static u32 stb0899_set_srate(struct stb0899_state *state, u32 master_clk, u32 sr
 
        sfr[0] = (tmp >> 12) & 0xff;
        sfr[1] = (tmp >>  4) & 0xff;
-       sfr[2] =  tmp & 0x0f;
+       sfr[2] =  tmp & 0xf0;
 
 //     stb0899_write_regs(state, STB0899_SFRUPH, sfr_up, 3);
        stb0899_write_regs(state, STB0899_SFRH, sfr, 3);