x86: uaccess: return value of __{get|put}_user() can be int
authorHiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Tue, 9 Dec 2008 03:18:38 +0000 (19:18 -0800)
committerIngo Molnar <mingo@elte.hu>
Fri, 12 Dec 2008 10:54:43 +0000 (11:54 +0100)
Impact: cleanup

The type of return value of __{get|put}_user() can be int.
There is no user to refer the return value of __{get|put}_user() as long.
This reduces code size a bit on 64-bit.

 $ size vmlinux.*
     text    data     bss     dec     hex filename
  4509265  479988  673588 5662841  566879 vmlinux.new
  4511462  479988  673588 5665038  56710e vmlinux.old

Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
arch/x86/include/asm/uaccess.h

index 35c5492..580c3ee 100644 (file)
@@ -350,14 +350,14 @@ do {                                                                      \
 
 #define __put_user_nocheck(x, ptr, size)                       \
 ({                                                             \
-       long __pu_err;                                          \
+       int __pu_err;                                           \
        __put_user_size((x), (ptr), (size), __pu_err, -EFAULT); \
        __pu_err;                                               \
 })
 
 #define __get_user_nocheck(x, ptr, size)                               \
 ({                                                                     \
-       long __gu_err;                                                  \
+       int __gu_err;                                                   \
        unsigned long __gu_val;                                         \
        __get_user_size(__gu_val, (ptr), (size), __gu_err, -EFAULT);    \
        (x) = (__force __typeof__(*(ptr)))__gu_val;                     \