x86, mce: trivial clean up for mce.c
authorHidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Thu, 30 Apr 2009 07:04:51 +0000 (16:04 +0900)
committerH. Peter Anvin <hpa@zytor.com>
Thu, 28 May 2009 16:24:16 +0000 (09:24 -0700)
This fixs following checkpatch warnings:

WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
+#include <asm/uaccess.h>

WARNING: Use #include <linux/smp.h> instead of <asm/smp.h>
+#include <asm/smp.h>

WARNING: line over 80 characters
+                               set_bit(MCE_OVERFLOW, (unsigned long *)&mcelog.flags);

WARNING: braces {} are not necessary for any arm of this statement
+       if (mce_notify_user()) {
[...]
+       } else {
[...]

Signed-off-by: Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>
Cc: Andi Kleen <andi@firstfloor.org>
Signed-off-by: H. Peter Anvin <hpa@zytor.com>
arch/x86/kernel/cpu/mcheck/mce.c

index 4375ffb..1d0aa9c 100644 (file)
@@ -14,6 +14,7 @@
 #include <linux/kallsyms.h>
 #include <linux/rcupdate.h>
 #include <linux/kobject.h>
+#include <linux/uaccess.h>
 #include <linux/kdebug.h>
 #include <linux/kernel.h>
 #include <linux/percpu.h>
 #include <linux/kmod.h>
 #include <linux/poll.h>
 #include <linux/cpu.h>
+#include <linux/smp.h>
 #include <linux/fs.h>
 
 #include <asm/processor.h>
-#include <asm/uaccess.h>
 #include <asm/idle.h>
 #include <asm/mce.h>
 #include <asm/msr.h>
-#include <asm/smp.h>
 
 #include "mce.h"
 
@@ -125,7 +125,8 @@ void mce_log(struct mce *mce)
                         * interesting ones:
                         */
                        if (entry >= MCE_LOG_LEN) {
-                               set_bit(MCE_OVERFLOW, (unsigned long *)&mcelog.flags);
+                               set_bit(MCE_OVERFLOW,
+                                       (unsigned long *)&mcelog.flags);
                                return;
                        }
                        /* Old left over entry. Skip: */
@@ -556,11 +557,10 @@ static void mcheck_timer(unsigned long data)
         * polling interval, otherwise increase the polling interval.
         */
        n = &__get_cpu_var(next_interval);
-       if (mce_notify_user()) {
+       if (mce_notify_user())
                *n = max(*n/2, HZ/100);
-       } else {
+       else
                *n = min(*n*2, (int)round_jiffies_relative(check_interval*HZ));
-       }
 
        t->expires = jiffies + *n;
        add_timer(t);