NFS4: invalidate cached acl on setacl
authorJ. Bruce Fields <bfields@citi.umich.edu>
Tue, 1 May 2007 14:56:25 +0000 (10:56 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Wed, 2 May 2007 14:36:09 +0000 (07:36 -0700)
The ACL that the server sets may not be exactly the one we set--for
example, it may silently turn off bits that it does not support.  So we
should remove any cached ACL so that any subsequent request for the ACL
will go to the server.

Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/nfs4proc.c

index f52cf5c..3b5ca1b 100644 (file)
@@ -2647,8 +2647,7 @@ static int __nfs4_proc_set_acl(struct inode *inode, const void *buf, size_t bufl
        nfs_inode_return_delegation(inode);
        buf_to_pages(buf, buflen, arg.acl_pages, &arg.acl_pgbase);
        ret = rpc_call_sync(NFS_CLIENT(inode), &msg, 0);
-       if (ret == 0)
-               nfs4_write_cached_acl(inode, buf, buflen);
+       nfs_zap_caches(inode);
        return ret;
 }