From 0b82ac37b889ec881b645860da3775118effb3ca Mon Sep 17 00:00:00 2001 From: "Serge E. Hallyn" Date: Wed, 7 Jan 2009 18:07:46 -0800 Subject: [PATCH] devices cgroup: allow mkfifo The devcgroup_inode_permission() hook in the devices whitelist cgroup has always bypassed access checks on fifos. But the mknod hook did not. The devices whitelist is only about block and char devices, and fifos can't even be added to the whitelist, so fifos can't be created at all except by tasks which have 'a' in their whitelist (meaning they have access to all devices). Fix the behavior by bypassing access checks to mkfifo. Signed-off-by: Serge E. Hallyn Cc: Li Zefan Cc: Pavel Emelyanov Cc: Paul Menage Cc: Lai Jiangshan Cc: KOSAKI Motohiro Cc: James Morris Reported-by: Daniel Lezcano Cc: [2.6.27.x] Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- security/device_cgroup.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/security/device_cgroup.c b/security/device_cgroup.c index cd377b9..3aacd0f 100644 --- a/security/device_cgroup.c +++ b/security/device_cgroup.c @@ -513,6 +513,9 @@ int devcgroup_inode_mknod(int mode, dev_t dev) struct dev_cgroup *dev_cgroup; struct dev_whitelist_item *wh; + if (!S_ISBLK(mode) && !S_ISCHR(mode)) + return 0; + rcu_read_lock(); dev_cgroup = task_devcgroup(current); -- 1.8.2.3