safe/jmp/linux-2.6
13 years agoStaging: drop redundant memset
Julia Lawall [Tue, 9 Mar 2010 21:15:21 +0000 (22:15 +0100)]
Staging: drop redundant memset

The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,e3,e4;
@@

- memset(e1,e2,e3);
  memcpy(e1,e4,e3);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: rt2860: fixed coding-style issues in pci_main_dev.c
Henrik Hautakoski [Tue, 9 Mar 2010 20:51:24 +0000 (21:51 +0100)]
Staging: rt2860: fixed coding-style issues in pci_main_dev.c

fixed a bunch of coding-style issues generated from checkpatch.pl

Signed-off-by: Henrik Hautakoski <henrik.hautakoski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: otus: drop redundant memset
Julia Lawall [Tue, 9 Mar 2010 21:14:58 +0000 (22:14 +0100)]
Staging: otus: drop redundant memset

The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy.

The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
expression e1,e2,e3,e4;
@@

- memset(e1,e2,e3);
  memcpy(e1,e4,e3);
// </smpl>

Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: netwave: fixed trailing whitespace style issue in netwave_cs.c
Prashant P. Shah [Tue, 9 Mar 2010 14:46:44 +0000 (20:16 +0530)]
Staging: netwave: fixed trailing whitespace style issue in netwave_cs.c

This is a patch to the netwave_cs.c file that fixes up all the
trailing whitespace errors found by the checkpatch.pl tool.

Signed-off-by: Prashant P. Shah <pshah.mumbai@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: comedi: fix missing KERN_facility level in ni_labpc.c
Aseem Sethi [Tue, 9 Mar 2010 18:34:36 +0000 (00:04 +0530)]
Staging: comedi: fix missing KERN_facility level in ni_labpc.c

This is a patch to fix the "missing KERN_facility level" error found
when running the checkpatch.pl script

Signed-off-by: Aseem Sethi <aseemsethi@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: handle skb allocation failure
Stephen Hemminger [Wed, 10 Mar 2010 01:42:17 +0000 (17:42 -0800)]
Staging: hv: handle skb allocation failure

Some fixes to receive handling:
  * Dieing with assertion failure when running out of memory is not ok
  * Use newer alloc function to get aligned skb
  * Dropped statistic is supposed to be incremented only by
    driver it was responsible for the drop.

Compile tested only.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: hv: use network device stats
Stephen Hemminger [Wed, 10 Mar 2010 01:42:33 +0000 (17:42 -0800)]
Staging: hv: use network device stats

The network device structure has space already reserved for statistics.

Compile tested only.

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: Intel Restricted Access Region Handler
Ossama Othman [Mon, 15 Mar 2010 23:23:56 +0000 (16:23 -0700)]
staging: Intel Restricted Access Region Handler

The Intel Restricted Access Region Handler provides a buffer allocation
mechanism to RAR users.  Since the intended usage model is to lock out
CPU access to RAR (the CPU will not be able to access RAR memory), this
driver does not access RAR memory, and merely keeps track of what areas
of RAR memory are in use.  It has it's own simple allocator that does
not rely on existing kernel allocators (SLAB, etc) since those
allocators are too tightly coupled with the paging mechanism, which isn't
needed for the intended RAR use cases.

An mmap() implementation is provided for debugging purposes to simplify
RAR memory access from the user space.  However, it will effectively be
a no-op when RAR access control is enabled since the CPU will not be
able to access RAR.

This driver should not be confused with the rar_register driver.  That
driver exposes an interface to access RAR registers on the Moorestown
platform.  The RAR handler driver relies on the rar_register driver for
low level RAR register reads and writes.

This patch was generated and built against the latest linux-2.6 master
branch.

Signed-off-by: Ossama Othman <ossama.othman@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: frontier: switch semaphores to mutexes
Eli Lindsey [Tue, 9 Mar 2010 06:15:33 +0000 (00:15 -0600)]
staging: frontier: switch semaphores to mutexes

This patch changes the use of semaphores in alphatrack.c and tranzport.c to
mutexes at the suggestion of checkpatch.pl

Signed-off-by: Eli Lindsey <eli@siliconsprawl.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: frontier: switch to strict_strtoul in tranzport.c
Eli Lindsey [Tue, 9 Mar 2010 06:15:32 +0000 (00:15 -0600)]
staging: frontier: switch to strict_strtoul in tranzport.c

This is a patch to tranzport.c that changes a use of simple_strtoul to
strict_strtoul at the suggestion of checkpatch.pl

Signed-off-by: Eli Lindsey <eli@siliconsprawl.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: comedi: fix space before tabs coding style issue in adl_pci6208.c
Jaakko Niemelä [Mon, 8 Mar 2010 21:24:44 +0000 (23:24 +0200)]
Staging: comedi: fix space before tabs coding style issue in adl_pci6208.c

This is a patch to the adl_pci6208.c file that fixes up a space before
tabs warning found by checkpatch.pl tool.

Signed-off-by: Jaakko Niemelä <mato@kyborgi.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: wlan-ng: fix coding style in hfa834x_usb.c
Edgardo Hames [Tue, 9 Mar 2010 01:02:37 +0000 (17:02 -0800)]
Staging: wlan-ng: fix coding style in hfa834x_usb.c

This is a patch in hfa834x_usb.c to fix typedef declarations and long lines.

Signed-off-by: Edgardo Hames <ehames@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: wavelan: fix coding style of first 1000 lines in wavelan.c
Jason [Mon, 8 Mar 2010 10:36:21 +0000 (02:36 -0800)]
staging: wavelan: fix coding style of first 1000 lines in wavelan.c

Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: rt2860: off by one errors
Dan Carpenter [Mon, 8 Mar 2010 13:39:24 +0000 (16:39 +0300)]
staging: rt2860: off by one errors

The code is trying to say that if the offset is higher than the max it
should be set to the max, but there is an off by one bug and it sets it
one passed the end of the array.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: frontier: Fix coding style issues in 2 files.
Michael Tate [Sun, 7 Mar 2010 14:19:39 +0000 (18:19 +0400)]
staging: frontier: Fix coding style issues in 2 files.

This patch removes unecessary whitespace before quoted newlines
in two files.
One warning in each file remains unresolved.

Signed-off-by: Michael Tate <michael.tate@wanadoo.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: rtl8192su: cleanup of r819xU_cmdpkt.c, r819xU_cmdpkt.c
Florian Schilhabel [Sat, 6 Mar 2010 19:45:25 +0000 (20:45 +0100)]
staging: rtl8192su: cleanup of r819xU_cmdpkt.c, r819xU_cmdpkt.c

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: rtl8192su: remove extern keyword, remove static declaration
Florian Schilhabel [Sat, 6 Mar 2010 19:45:11 +0000 (20:45 +0100)]
staging: rtl8192su: remove extern keyword, remove static declaration

removed extern keyword from rtl819x_watchdog_wqcallback.
removed static declaration from variable check_reset_cnt.
changed NumRxOkInPeriod and NumTxOkInPeriod comparison
in function rtl819x_watchdog_wqcallback to 666; we're not on windows.
plus cosmetics.

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: rtl8192su: remove re-declaration of counter i
Florian Schilhabel [Sat, 6 Mar 2010 19:44:54 +0000 (20:44 +0100)]
staging: rtl8192su: remove re-declaration of counter i

variable i is declared integer in rtl8192SU_ConfigAdapterInfo8192SForAutoLoadFail.
a few lines down it is re-declared u8.
removed the re-declaration.
plus cosmetics

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: rtl8192su: move to EEPROM_93CX
Florian Schilhabel [Sat, 6 Mar 2010 19:44:33 +0000 (20:44 +0100)]
staging: rtl8192su: move to EEPROM_93CX

this is basically a port of Larry Fingers Patch for rtl8187se to rtl8192su.
also removed some dead code.
plus cosmetics.

Signed-off-by: Florian Schilhabel <florian.c.schilhabel@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: et131x: Fix brace coding style issues.
Michael Tate [Sat, 6 Mar 2010 11:03:57 +0000 (15:03 +0400)]
staging: et131x: Fix brace coding style issues.

This revised patch fixes 2 brace coding style issues reported by checkpatch.pl
One warning line > 80 chars not resolved on maintainers advice.

Signed-off-by: Michael Tate <michael.tate@wanadoo.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: arlan: fix errors reported by checkpatch.pl tool
John Sheehan [Thu, 4 Mar 2010 14:24:40 +0000 (14:24 +0000)]
staging: arlan: fix errors reported by checkpatch.pl tool

fix all but one of the errors reported by checkpatch.pl tool.
Errors included wayward braces, white space issues(trailing
and prohibited), C99 issues, and foo* issues

Signed-off-by: John Sheehan <john.d.sheehan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: IIO: Fix uses of spinlocks prior to init in ring implementations
Jonathan Cameron [Tue, 2 Mar 2010 13:35:35 +0000 (13:35 +0000)]
staging: IIO: Fix uses of spinlocks prior to init in ring implementations

Some confusion was caused by the ___iio_init_ring_buffer and equivalent
in ring_sw handling both init of spin locks etc and allocation and
of the actual buffer.  This resulted in ring->use_lock being held
before it was initialized and actually during the initialization.

Some of the recent cleanups in the spin lock code seem to have triggered
the bug actually causing traceable crashes.

The following patch should fix this but hasn't been extensively tested
as of yet and there may well be some side effects I haven't thought of.
Just wanted to get this out there before anyone else runs into it!

Signed-off-by: Jonathan Cameron <jic23@cam.ac.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: hv: Corrected all header comment formats kernel-doc format
Hank Janssen [Thu, 4 Mar 2010 22:11:00 +0000 (22:11 +0000)]
staging: hv: Corrected all header comment formats kernel-doc format

Removed kerneldoc /** from functions that should not have them.
Added proper kerneldoc headers to functions that should have them.

This includes fixes as pointed out by Randy Dunlap and Joe Perches.

Cc: Joe Perches <joe@perches.com>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: hv: Remove Ringbuffer from TODO line
Hank Janssen [Thu, 4 Mar 2010 17:46:28 +0000 (17:46 +0000)]
staging: hv: Remove Ringbuffer from TODO line

Remove Ringbuffer work line item from TODO file.

The ring buffer in the Hyper-V Linux drivers is used to communicate with
the parent partition running Windows Server 2008 Hyper-V. The ring
buffer functionality on the Hyper-V Linux drivers is written to be
functionally compatible with the ring buffer functionality on the
Hyper-V Server. Consequently, it is not possible to make any changes
that might break the compatibility with server side ring buffer
implementation.

Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: Remove staging/poch
Vijay Kumar [Sun, 7 Mar 2010 02:24:45 +0000 (07:54 +0530)]
Staging: Remove staging/poch

Remove staging/poch.

Reasons for removal are -- The driver has serious cache
issues, that I couldn't fix. The card vendor is working
on a better replacement for the driver. The driver has
been delayed a lot and development has come to a stand
still.

Signed-off-by: Vijay Kumar B. <vijaykumar@bravegnu.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: comedi: fix print(k) coding style issue in aio_aio12_8.c
Maurice Dawson [Thu, 8 Apr 2010 12:13:20 +0000 (13:13 +0100)]
Staging: comedi: fix print(k) coding style issue in aio_aio12_8.c

This is a patch to the aio_aio12_8.c that fixes up print(k) warnings found by the checkpatch.pl tool

Signed-off-by: Maurice Dawson <mauricedawson2699@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: comedi: fix brace, print(k) and over 80 character coding style issues in...
Maurice Dawson [Tue, 30 Mar 2010 11:24:14 +0000 (12:24 +0100)]
Staging: comedi: fix brace, print(k) and over 80 character coding style issues in adv_pci1723.c

This is a Patch to the adv_pci1723.c file that fixes up brace, print(k) and over 80 character warnings found by the checkpatch.pl tool

Signed-off-by: Maurice Dawson <mauricedawson2699@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: comedi: fix KERN_facility level coding style issue in adl_pci9118.c
Maurice Dawson [Fri, 19 Mar 2010 14:20:10 +0000 (14:20 +0000)]
Staging: comedi: fix KERN_facility level coding style issue in adl_pci9118.c

This is a patch to the adl_pci9118.c file that fixes WARNING: printk() should include KERN_facility level found by the checkpatch.pl tool

Signed-off-by: Maurice Dawson <mauricedawson2699@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: comedi: fix 80 character coding style issue in adl_pci9118.c
Maurice Dawson [Thu, 18 Mar 2010 14:46:37 +0000 (14:46 +0000)]
Staging: comedi: fix 80 character coding style issue in adl_pci9118.c

Fixes all over 80 character warnings in the adl_pci9118.c file found by the checkpatch.pl tool

Signed-off-by: Maurice Dawson <mauricedawson2699@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: comedi: fix indent coding style issue in adl_pci9118.c
Maurice Dawson [Wed, 17 Mar 2010 13:40:11 +0000 (13:40 +0000)]
Staging: comedi: fix indent coding style issue in adl_pci9118.c

Patch to the adl_pci9118.c that fixes, ERROR: code indent should use tabs where possible, found by the checkpatch.pl tool

Signed-off-by: Maurice Dawson <mauricedawson2699@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: Add driver to support wanPMC-CxT1E1 card.
Bob Beers [Thu, 4 Mar 2010 13:40:46 +0000 (08:40 -0500)]
staging: Add driver to support wanPMC-CxT1E1 card.

Obviously still needs serious attention, but it compiles.

Original author: Rick Dobbs

Add driver to support wanPMC-CxT1E1 card.

This card provides 1-4 ports of T1E1 in PMC form factor.

Note, Rick doesn't want his email showing up as the "From:" author, but
has given his blessing to have the code included in the kernel tree.

Signed-off-by: Bob Beers <bob.beers@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agostaging: comedi: Fix 80 characters limit and printk issues in skel.c
Ellwyn Cole [Mon, 1 Mar 2010 17:43:50 +0000 (17:43 +0000)]
staging: comedi: Fix 80 characters limit and printk issues in skel.c

This is a patch to the skel.c file that fixes the 80 characters limit and
printk warnings found by the checkpatch.pl tool

Signed-off-by: Ellwyn Cole <ellwync@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: otus: hpfwu_BA.c: Checkpatch cleanup
Andrea Gelmini [Sun, 28 Feb 2010 23:28:56 +0000 (00:28 +0100)]
Staging: otus: hpfwu_BA.c: Checkpatch cleanup

drivers/staging/otus/hal/hpfwu_BA.c:874: ERROR: spaces required around that '=' (ctx:VxV)

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: batman-adv: send.c: Checkpatch cleanup
Andrea Gelmini [Sun, 28 Feb 2010 23:28:55 +0000 (00:28 +0100)]
Staging: batman-adv: send.c: Checkpatch cleanup

drivers/staging/batman-adv/send.c:137: CHECK: multiple assignments should be avoided

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: otus: hpreg.c: Checkpatch cleanup
Andrea Gelmini [Sun, 28 Feb 2010 23:28:54 +0000 (00:28 +0100)]
Staging: otus: hpreg.c: Checkpatch cleanup

drivers/staging/otus/hal/hpreg.c:33: WARNING: space prohibited between function name and open parenthesis '('
drivers/staging/otus/hal/hpreg.c:33: WARNING: space prohibited between function name and open parenthesis '('
drivers/staging/otus/hal/hpreg.c:38: CHECK: if this code is redundant consider removing it
drivers/staging/otus/hal/hpreg.c:81: ERROR: need consistent spacing around '|' (ctx:VxW)
drivers/staging/otus/hal/hpreg.c:96: ERROR: Macros with multiple statements should be enclosed in a do - while loop
drivers/staging/otus/hal/hpreg.c:98: CHECK: if this code is redundant consider removing it
drivers/staging/otus/hal/hpreg.c:275: ERROR: need consistent spacing around '|' (ctx:WxV)
drivers/staging/otus/hal/hpreg.c:304: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:362: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:376: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:377: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:402: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:402: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:413: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:413: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:434: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:496: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:497: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:501: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:526: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:529: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:531: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:539: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:539: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:544: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:663: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1335: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1336: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1345: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1345: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1346: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1346: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1347: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1347: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1355: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1356: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1357: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1357: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1365: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1366: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1367: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1367: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1375: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1376: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1377: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1377: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1378: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1378: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1387: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1387: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1388: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1388: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1395: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1396: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1397: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1397: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1398: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1398: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1398: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1398: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1405: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1406: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1407: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1407: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1408: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1408: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1415: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1415: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1415: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1415: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1416: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1416: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1416: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1416: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1416: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1416: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1432: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1432: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1432: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1435: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1435: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1435: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1436: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1436: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1436: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1442: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1442: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1442: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1445: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1445: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1445: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1446: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1446: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1446: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1455: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1455: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1455: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1455: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1456: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1456: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1456: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1456: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1456: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1456: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1465: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1465: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1465: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1465: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1466: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1466: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1466: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1466: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1466: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1466: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1475: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1475: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1475: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1475: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1476: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1485: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1485: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1485: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1485: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1485: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1486: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1486: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1486: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1486: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1486: ERROR: space required before that '-' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1557: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1558: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1560: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1560: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1560: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1560: ERROR: spaces required around that '<' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1560: ERROR: spaces required around that '&&' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1562: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1568: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1574: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1579: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1590: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1590: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1590: ERROR: space required after that ';' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1590: ERROR: spaces required around that '<' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1592: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1594: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1613: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1613: ERROR: spaces required around that '<' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1635: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:1639: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1639: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1640: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:1643: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1647: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1647: WARNING: suspect code indent for conditional statements (8, 8)
drivers/staging/otus/hal/hpreg.c:1649: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1652: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1652: WARNING: suspect code indent for conditional statements (8, 8)
drivers/staging/otus/hal/hpreg.c:1654: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1657: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1659: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1660: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1662: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1662: ERROR: else should follow close brace '}'
drivers/staging/otus/hal/hpreg.c:1664: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1671: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1674: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1675: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1676: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1676: ERROR: space required after that ',' (ctx:VxO)
drivers/staging/otus/hal/hpreg.c:1676: ERROR: space required before that '*' (ctx:OxV)
drivers/staging/otus/hal/hpreg.c:1676: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1678: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1681: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1682: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1682: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1683: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1684: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1685: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1686: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1687: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1690: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1692: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1693: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1694: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1695: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1695: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1696: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1696: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1697: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1697: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1698: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1698: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1699: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1700: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1700: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1701: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1702: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1702: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1703: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1706: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1707: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1708: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1710: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1711: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1712: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1713: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1714: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1714: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1717: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1719: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1720: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1721: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1722: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1722: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1723: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1723: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1724: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1724: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1725: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1725: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1726: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1726: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1727: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1728: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1728: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1729: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1730: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1730: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1731: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1734: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1735: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1735: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1736: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1737: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1738: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1739: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1740: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1743: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1744: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1744: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1745: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1746: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1747: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1748: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1749: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1752: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1755: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1755: WARNING: suspect code indent for conditional statements (16, 20)
drivers/staging/otus/hal/hpreg.c:1757: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1759: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1760: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1760: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1761: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1762: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1762: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1763: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1764: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1766: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1766: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1767: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1767: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1767: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:1767: ERROR: space prohibited before that close parenthesis ')'
drivers/staging/otus/hal/hpreg.c:1768: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1769: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1770: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1772: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1772: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1772: ERROR: space required after that ';' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1772: ERROR: spaces required around that '<' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1774: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1774: ERROR: space required after that ',' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1778: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1779: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1780: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1781: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1781: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1786: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1786: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1787: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1787: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1787: ERROR: spaces required around that '==' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1788: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1789: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1789: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1789: ERROR: space prohibited after that open parenthesis '('
drivers/staging/otus/hal/hpreg.c:1789: ERROR: space prohibited before that close parenthesis ')'
drivers/staging/otus/hal/hpreg.c:1789: ERROR: space required before the open parenthesis '('
drivers/staging/otus/hal/hpreg.c:1790: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1791: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1792: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1793: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1794: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1795: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1796: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1797: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1798: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1799: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1799: WARNING: suspect code indent for conditional statements (40, 44)
drivers/staging/otus/hal/hpreg.c:1805: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1807: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1809: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1811: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1814: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1816: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1817: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1820: ERROR: space required before the open parenthesis '('
drivers/staging/otus/hal/hpreg.c:1821: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1826: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1837: CHECK: if this code is redundant consider removing it
drivers/staging/otus/hal/hpreg.c:1839: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1840: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1841: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1842: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1843: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1845: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1845: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1845: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:1845: ERROR: spaces required around that '=' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1845: ERROR: spaces required around that '<' (ctx:VxV)
drivers/staging/otus/hal/hpreg.c:1846: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1847: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1848: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1849: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1850: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1851: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1852: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1853: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1854: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1861: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:1863: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1871: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:1874: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1881: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1883: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1883: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1883: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:1884: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1885: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1887: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1887: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1888: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1888: ERROR: "(foo*)" should be "(foo *)"
drivers/staging/otus/hal/hpreg.c:1890: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1890: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1892: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1892: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1893: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1894: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1894: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1896: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1897: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1898: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1899: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1904: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:1908: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1909: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1915: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1916: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1917: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1917: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1919: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1920: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1922: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1922: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1923: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1923: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1923: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:1924: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1925: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1925: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1926: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1926: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1928: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1930: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1930: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1931: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1932: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1933: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1935: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1935: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1936: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1936: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1937: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1937: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1938: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1938: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1939: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1939: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1940: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1940: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1941: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1941: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1942: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1942: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1943: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1943: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1944: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1944: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1945: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1945: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1946: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1946: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1947: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1947: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1948: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1948: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1949: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1949: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1950: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1950: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1951: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1951: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1952: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1952: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1953: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1953: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1954: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1954: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1955: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1955: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1956: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1956: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1957: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1957: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1958: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1958: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1959: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1959: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1960: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1960: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1961: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1961: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1962: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1962: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1963: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1963: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1964: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1964: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1965: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1965: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1966: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1966: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1967: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1967: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1968: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1968: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1969: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1969: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1970: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1970: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1971: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1971: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1973: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1974: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1976: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:1980: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:1984: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1986: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1986: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:1986: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:1987: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1988: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1989: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:1995: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:2003: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2005: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2005: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2005: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:2006: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2007: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2008: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2009: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2032: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:2035: ERROR: space required after that close brace '}'
drivers/staging/otus/hal/hpreg.c:2039: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2041: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2041: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:2042: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2045: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2047: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2048: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2050: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2050: ERROR: else should follow close brace '}'
drivers/staging/otus/hal/hpreg.c:2052: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2055: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2057: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2057: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2057: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:2058: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2059: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2060: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2061: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2061: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2062: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2063: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2064: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2065: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2066: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2067: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2073: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:2079: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2081: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2081: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:2082: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2085: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2085: ERROR: space prohibited after that open parenthesis '('
drivers/staging/otus/hal/hpreg.c:2087: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2087: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2087: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:2088: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2089: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2090: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2091: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2093: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2093: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:2094: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2094: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:2096: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2098: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2098: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2098: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:2099: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2100: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2101: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2102: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2103: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2105: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2111: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:2117: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2119: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2119: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:2120: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2120: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2120: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:2121: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2122: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2123: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2124: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2127: ERROR: return is not a function, parentheses are not required
drivers/staging/otus/hal/hpreg.c:2130: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:2140: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2142: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2142: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:2143: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2143: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2143: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:2144: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2145: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2146: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2147: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2152: ERROR: return is not a function, parentheses are not required
drivers/staging/otus/hal/hpreg.c:2155: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:2160: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2162: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2162: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2162: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:2163: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2164: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2165: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2171: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:2181: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2183: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2183: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2183: WARNING: suspect code indent for conditional statements (8, 12)
drivers/staging/otus/hal/hpreg.c:2184: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2185: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2185: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2186: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2187: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2187: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2187: WARNING: suspect code indent for conditional statements (16, 20)
drivers/staging/otus/hal/hpreg.c:2188: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2189: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2190: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2191: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2192: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2193: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2193: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2193: ERROR: else should follow close brace '}'
drivers/staging/otus/hal/hpreg.c:2194: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2195: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2195: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2195: WARNING: suspect code indent for conditional statements (16, 20)
drivers/staging/otus/hal/hpreg.c:2196: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2197: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2198: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2199: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2200: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2201: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2212: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:2216: ERROR: that open brace { should be on the previous line
drivers/staging/otus/hal/hpreg.c:2218: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2219: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2220: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2221: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2222: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2223: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2224: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2225: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2226: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2227: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2228: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2229: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2230: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2231: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2232: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2233: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2234: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2235: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2235: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:2236: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2238: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2239: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2239: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:2240: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2242: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2243: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2244: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2245: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2246: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2247: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2248: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2249: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2250: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2251: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2252: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2253: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2254: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2255: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2256: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2257: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2258: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2259: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2260: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2260: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:2261: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2263: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2264: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2265: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2266: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2267: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2268: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2269: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2270: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2271: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2272: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2273: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2274: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2275: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2276: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2277: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2278: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2279: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2280: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2281: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2282: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2283: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2284: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2285: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2286: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2287: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2288: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2289: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2290: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2291: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2292: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2293: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2294: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2295: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2296: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2297: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2298: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2299: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2300: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2301: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2302: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2303: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2304: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2305: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2306: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2307: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2308: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2309: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2310: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2311: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2312: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2313: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2314: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2315: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2316: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2317: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2318: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2319: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2320: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2321: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2322: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2323: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2324: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2325: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2326: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2327: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2328: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2329: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2330: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2331: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2332: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2332: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:2333: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2335: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2336: ERROR: code indent should use tabs where possible
drivers/staging/otus/hal/hpreg.c:2338: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpreg.c:2343: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:2345: ERROR: "foo* bar" should be "foo *bar"
drivers/staging/otus/hal/hpreg.c:2348: ERROR: spaces required around that '=' (ctx:VxV)

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: otus: hpfw2.c: Checkpatch cleanup
Andrea Gelmini [Sun, 28 Feb 2010 23:28:53 +0000 (00:28 +0100)]
Staging: otus: hpfw2.c: Checkpatch cleanup

drivers/staging/otus/hal/hpfw2.c:1018: ERROR: spaces required around that '=' (ctx:VxV)

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: otus: hpfwu_OTUS_RC.c: Checkpatch cleanup
Andrea Gelmini [Sun, 28 Feb 2010 23:28:52 +0000 (00:28 +0100)]
Staging: otus: hpfwu_OTUS_RC.c: Checkpatch cleanup

drivers/staging/otus/hal/hpfwu_OTUS_RC.c:715: ERROR: spaces required around that '=' (ctx:VxV)

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: otus: hpani.h: Checkpatch cleanup
Andrea Gelmini [Sun, 28 Feb 2010 23:28:51 +0000 (00:28 +0100)]
Staging: otus: hpani.h: Checkpatch cleanup

drivers/staging/otus/hal/hpani.h:102: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpani.h:356: ERROR: do not use C99 // comments
drivers/staging/otus/hal/hpani.h:395: ERROR: do not use C99 // comments

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: otus: hpfwu_2k.c: Checkpatch cleanup
Andrea Gelmini [Sun, 28 Feb 2010 23:28:50 +0000 (00:28 +0100)]
Staging: otus: hpfwu_2k.c: Checkpatch cleanup

drivers/staging/otus/hal/hpfwu_2k.c:1016: ERROR: spaces required around that '=' (ctx:VxV)

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: otus: hpfwu.c: Checkpatch cleanup
Andrea Gelmini [Sun, 28 Feb 2010 23:28:49 +0000 (00:28 +0100)]
Staging: otus: hpfwu.c: Checkpatch cleanup

drivers/staging/otus/hal/hpfwu.c:1017: ERROR: spaces required around that '=' (ctx:VxV)

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: otus: hpfwuinit.c: Checkpatch cleanup
Andrea Gelmini [Sun, 28 Feb 2010 23:28:48 +0000 (00:28 +0100)]
Staging: otus: hpfwuinit.c: Checkpatch cleanup

drivers/staging/otus/hal/hpfwuinit.c:240: ERROR: spaces required around that '=' (ctx:VxV)

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: asus_oled: asus_oled.c: Checkpatch cleanup
Andrea Gelmini [Sun, 28 Feb 2010 23:28:47 +0000 (00:28 +0100)]
Staging: asus_oled: asus_oled.c: Checkpatch cleanup

drivers/staging/asus_oled/asus_oled.c:774: ERROR: code indent should use tabs where possible

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: rt2870:: rtusb_bulk.c: Checkpatch cleanup
Andrea Gelmini [Sun, 28 Feb 2010 23:28:46 +0000 (00:28 +0100)]
Staging: rt2870:: rtusb_bulk.c: Checkpatch cleanup

drivers/staging/rt2870/common/rtusb_bulk.c:45: ERROR: that open brace { should be on the previous line
drivers/staging/rt2870/common/rtusb_bulk.c:175: ERROR: space required before the open parenthesis '('
drivers/staging/rt2870/common/rtusb_bulk.c:179: ERROR: space required before the open parenthesis '('
drivers/staging/rt2870/common/rtusb_bulk.c:190: ERROR: "foo * bar" should be "foo *bar"
drivers/staging/rt2870/common/rtusb_bulk.c:276: ERROR: space prohibited after that '&' (ctx:VxW)
drivers/staging/rt2870/common/rtusb_bulk.c:278: ERROR: space prohibited after that '&' (ctx:WxW)
drivers/staging/rt2870/common/rtusb_bulk.c:313: ERROR: space prohibited before that close parenthesis ')'
drivers/staging/rt2870/common/rtusb_bulk.c:329: WARNING: __func__ should be used instead of gcc specific __FUNCTION__
drivers/staging/rt2870/common/rtusb_bulk.c:337: ERROR: space prohibited after that '&' (ctx:VxW)
drivers/staging/rt2870/common/rtusb_bulk.c:404: WARNING: braces {} are not necessary for single statement blocks
drivers/staging/rt2870/common/rtusb_bulk.c:952: WARNING: braces {} are not necessary for single statement blocks
drivers/staging/rt2870/common/rtusb_bulk.c:1017: WARNING: braces {} are not necessary for single statement blocks

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: rt2870: rtusb_io.c: Checkpatch cleanup
Andrea Gelmini [Sun, 28 Feb 2010 23:28:45 +0000 (00:28 +0100)]
Staging: rt2870: rtusb_io.c: Checkpatch cleanup

drivers/staging/rt2870/common/rtusb_io.c:27: ERROR: code indent should use tabs where possible
drivers/staging/rt2870/common/rtusb_io.c:404: ERROR: while should follow close brace '}'
drivers/staging/rt2870/common/rtusb_io.c:459: ERROR: while should follow close brace '}'
drivers/staging/rt2870/common/rtusb_io.c:655: ERROR: return is not a function, parentheses are not required
drivers/staging/rt2870/common/rtusb_io.c:659: ERROR: return is not a function, parentheses are not required
drivers/staging/rt2870/common/rtusb_io.c:669: ERROR: return is not a function, parentheses are not required
drivers/staging/rt2870/common/rtusb_io.c:701: ERROR: return is not a function, parentheses are not required
drivers/staging/rt2870/common/rtusb_io.c:729: ERROR: return is not a function, parentheses are not required
drivers/staging/rt2870/common/rtusb_io.c:739: ERROR: return is not a function, parentheses are not required
drivers/staging/rt2870/common/rtusb_io.c:770: ERROR: return is not a function, parentheses are not required
drivers/staging/rt2870/common/rtusb_io.c:1412: ERROR: that open brace { should be on the previous line
drivers/staging/rt2870/common/rtusb_io.c:1434: ERROR: that open brace { should be on the previous line

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: rt2870: rtusb_data.c: Checkpatch cleanup
Andrea Gelmini [Sun, 28 Feb 2010 23:28:44 +0000 (00:28 +0100)]
Staging: rt2870: rtusb_data.c: Checkpatch cleanup

drivers/staging/rt2870/common/rtusb_data.c:127: ERROR: return is not a function, parentheses are not required
drivers/staging/rt2870/common/rtusb_data.c:141: ERROR: return is not a function, parentheses are not required
drivers/staging/rt2870/common/rtusb_data.c:154: ERROR: space prohibited before that close parenthesis ')'
drivers/staging/rt2870/common/rtusb_data.c:204: ERROR: space prohibited after that '&' (ctx:VxW)

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: comedi: fix comments over 80 issue in usbduxfast.c
Stewart Robertson [Sat, 27 Feb 2010 17:05:38 +0000 (17:05 +0000)]
Staging: comedi: fix comments over 80 issue in usbduxfast.c

This is a patch to the usbduxfast.c file that fixes comments
over 80 warnings found by the checkpatch.pl tool

Signed-off-by: Stewart Robertson <stewart_r@aliencamel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: comedi: fix 80 character line issue in 8253.h
Graham M Howe [Sat, 27 Feb 2010 09:14:22 +0000 (09:14 +0000)]
Staging: comedi: fix 80 character line issue in 8253.h

This is a patch to the 8253.h file to fix 80 character line warning
found by checkpatch.pl tool

Signed-off-by: Graham M Howe <gman.1352@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
13 years agoStaging: vt6655: 80211hdr.h: Checkpatch cleanup
Andrea Gelmini [Sat, 27 Feb 2010 16:43:22 +0000 (17:43 +0100)]
Staging: vt6655: 80211hdr.h: Checkpatch cleanup

ERROR: do not use C99 // comments
+// bit type

ERROR: do not use C99 // comments
+// 802.11 frame related, defined as 802.11 spec

ERROR: do not use C99 // comments
+//#define WLAN_RATES_MAXLEN           255

ERROR: do not use C99 // comments
+//#define WLAN_WEPMAX_KEYLEN          29

ERROR: do not use C99 // comments
+// Frame Type

ERROR: do not use C99 // comments
+// Frame Subtypes

ERROR: do not use C99 // comments
+// Control

ERROR: do not use C99 // comments
+// Data

ERROR: do not use C99 // comments
+// GET & SET Frame Control bit

ERROR: do not use C99 // comments
+// Sequence Field bit

ERROR: do not use C99 // comments
+// Capability Field bit

ERROR: do not use C99 // comments
+// GET & SET Frame Control bit

ERROR: do not use C99 // comments
+// Sequence Field bit

ERROR: do not use C99 // comments
+// Capability Field bit

ERROR: do not use C99 // comments
+#endif //#ifdef __BIG_ENDIAN

ERROR: do not use C99 // comments
+// ERP Field bit

ERROR: do not use C99 // comments
+// Support & Basic Rates field

ERROR: do not use C99 // comments
+// TIM field

ERROR: do not use C99 // comments
+// 3-Addr & 4-Addr

ERROR: do not use C99 // comments
+// IEEE ADDR

ERROR: do not use C99 // comments
+// 802.11 Header Format

ERROR: space required after that close brace '}'
+}__attribute__ ((__packed__))

ERROR: space required after that close brace '}'
+}__attribute__ ((__packed__))

ERROR: space required after that close brace '}'
+}__attribute__ ((__packed__))

ERROR: do not use C99 // comments
+#endif // __80211HDR_H__

Signed-off-by: Andrea Gelmini <andrea.gelmini@gelma.net
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoLinux 2.6.34-rc6 v2.6.34-rc6
Linus Torvalds [Fri, 30 Apr 2010 03:02:05 +0000 (20:02 -0700)]
Linux 2.6.34-rc6

14 years agoMerge branch 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jwessel...
Linus Torvalds [Fri, 30 Apr 2010 03:01:42 +0000 (20:01 -0700)]
Merge branch 'for_linus' of git://git./linux/kernel/git/jwessel/linux-2.6-kgdb

* 'for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/linux-2.6-kgdb:
  kgdb: don't needlessly skip PAGE_USER test for Fsl booke

14 years agoMerge branch 'for-linus' of git://oss.sgi.com/xfs/xfs
Linus Torvalds [Fri, 30 Apr 2010 02:49:34 +0000 (19:49 -0700)]
Merge branch 'for-linus' of git://oss.sgi.com/xfs/xfs

* 'for-linus' of git://oss.sgi.com/xfs/xfs:
  xfs: add a shrinker to background inode reclaim

14 years agokgdb: don't needlessly skip PAGE_USER test for Fsl booke
Wufei [Wed, 28 Apr 2010 21:42:32 +0000 (17:42 -0400)]
kgdb: don't needlessly skip PAGE_USER test for Fsl booke

The bypassing of this test is a leftover from 2.4 vintage
kernels, and is no longer appropriate, or even used by KGDB.
Currently KGDB uses probe_kernel_write() for all access to
memory via the KGDB core, so it can simply be deleted.

This fixes CVE-2010-1446.

CC: Benjamin Herrenschmidt <benh@kernel.crashing.org>
CC: Paul Mackerras <paulus@samba.org>
CC: Kumar Gala <galak@kernel.crashing.org>
Signed-off-by: Wufei <fei.wu@windriver.com>
Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
14 years agoMerge branch 'for-linus' of git://git.kernel.dk/linux-2.6-block
Linus Torvalds [Fri, 30 Apr 2010 00:18:07 +0000 (17:18 -0700)]
Merge branch 'for-linus' of git://git.kernel.dk/linux-2.6-block

* 'for-linus' of git://git.kernel.dk/linux-2.6-block:
  exofs: Fix "add bdi backing to mount session" fall out
  fs: fs/super.c needs to include backing-dev.h for !CONFIG_BLOCK

14 years agoMerge master.kernel.org:/home/rmk/linux-2.6-arm
Linus Torvalds [Fri, 30 Apr 2010 00:17:35 +0000 (17:17 -0700)]
Merge master.kernel.org:/home/rmk/linux-2.6-arm

* master.kernel.org:/home/rmk/linux-2.6-arm:
  ARM: 6061/1: PL061 GPIO: Bug fix - setting gpio for HIGH_LEVEL interrupt is not working.
  ARM: 5957/1: ARM: RealView SD/MMC Card detection and write-protect using GPIOLIB
  ARM: 6030/1: KS8695: enable console
  ARM: 6060/1: PL061 GPIO: Setting gpio val after changing direction to OUT.
  ARM: 6059/1: PL061 GPIO: Changing *_irq_chip_data with *_irq_data for real irqs.
  ARM: 6023/1: update bcmring_defconfig to latest version and fix build error
  ARM: fix build error in arch/arm/kernel/process.c

14 years agoMerge branch 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc
Linus Torvalds [Fri, 30 Apr 2010 00:16:36 +0000 (17:16 -0700)]
Merge branch 'merge' of git://git./linux/kernel/git/benh/powerpc

* 'merge' of git://git.kernel.org/pub/scm/linux/kernel/git/benh/powerpc:
  powerpc/ps3: Update ps3_defconfig
  powerpc/ps3: Update platform maintainer
  powerpc/pseries: Flush lazy kernel mappings after unplug operations
  powerpc/numa: Add form 1 NUMA affinity
  powerpc/fsl-booke: Fix CONFIG_RELOCATABLE support on FSL Book-E ppc32
  powerpc: 2.6.34 update of defconfigs for embedded 6xx/7xxx, 8xx, 8xxx
  powerpc/mpc8xxx defconfigs - turn off SYSFS_DEPRECATED
  powerpc/83xx: configure SIL SATA driver in 83xx-wide defconfig
  powerpc/83xx: enable EPOLL syscall in defconfig
  powerpc/83xx: add RTC drivers in 83xx defconfig
  powerpc/fsl-cpm: Configure clock correctly for SCC
  powerpc/fsl_booke: Correct test for MMU_FTR_BIG_PHYS
  powerpc/85xx/86xx: Fix build w/ CONFIG_PCI=n

14 years agoARM: 6061/1: PL061 GPIO: Bug fix - setting gpio for HIGH_LEVEL interrupt is not working.
viresh kumar [Thu, 29 Apr 2010 11:22:52 +0000 (12:22 +0100)]
ARM: 6061/1: PL061 GPIO: Bug fix - setting gpio for HIGH_LEVEL interrupt is not working.

In current implementation of PL061, setting type of irq to HIGH_LEVEL is not
working. This patch fixes this bug.

Signed-off-by: Viresh Kumar <viresh.kumar@st.com>
Acked-by: Baruch Siach <baruch@tkos.co.il>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
14 years agoxfs: add a shrinker to background inode reclaim
Dave Chinner [Wed, 28 Apr 2010 23:55:50 +0000 (09:55 +1000)]
xfs: add a shrinker to background inode reclaim

On low memory boxes or those with highmem, kernel can OOM before the
background reclaims inodes via xfssyncd. Add a shrinker to run inode
reclaim so that it inode reclaim is expedited when memory is low.

This is more complex than it needs to be because the VM folk don't
want a context added to the shrinker infrastructure. Hence we need
to add a global list of XFS mount structures so the shrinker can
traverse them.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
14 years agoexofs: Fix "add bdi backing to mount session" fall out
Boaz Harrosh [Thu, 29 Apr 2010 18:35:29 +0000 (20:35 +0200)]
exofs: Fix "add bdi backing to mount session" fall out

The patch: add bdi backing to mount session
(b3d0ab7e60d1865bb6f6a79a77aaba22f2543236)

Has a bug in the placement of the bdi member at
struct exofs_sb_info. The layout member must be kept
last.

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
14 years agofs: fs/super.c needs to include backing-dev.h for !CONFIG_BLOCK
Jens Axboe [Thu, 29 Apr 2010 18:33:35 +0000 (20:33 +0200)]
fs: fs/super.c needs to include backing-dev.h for !CONFIG_BLOCK

When CONFIG_BLOCK is set, it ends up getting backing-dev.h included.
But for !CONFIG_BLOCK, it isn't so lucky. The proper thing to do is
include <linux/backing-dev.h> directly from the file it's used from,
so do that.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
14 years agoMerge branch 'bugfixes' of git://git.linux-nfs.org/projects/trondmy/nfs-2.6
Linus Torvalds [Thu, 29 Apr 2010 17:23:44 +0000 (10:23 -0700)]
Merge branch 'bugfixes' of git://git.linux-nfs.org/projects/trondmy/nfs-2.6

* 'bugfixes' of git://git.linux-nfs.org/projects/trondmy/nfs-2.6:
  nfs: fix memory leak in nfs_get_sb with CONFIG_NFS_V4
  nfs: fix some issues in nfs41_proc_reclaim_complete()
  NFS: Ensure that nfs_wb_page() waits for Pg_writeback to clear
  NFS: Fix an unstable write data integrity race
  nfs: testing for null instead of ERR_PTR()
  NFS: rsize and wsize settings ignored on v4 mounts
  NFSv4: Don't attempt an atomic open if the file is a mountpoint
  SUNRPC: Fix a bug in rpcauth_prune_expired

14 years agopktcdvd: improve BKL and compat_ioctl.c usage
Arnd Bergmann [Wed, 28 Apr 2010 12:36:41 +0000 (14:36 +0200)]
pktcdvd: improve BKL and compat_ioctl.c usage

The pktcdvd driver uses proper locking and does not need the BKL in the
ioctl and llseek functions of the character device, so kill both.

Moving the compat_ioctl handling from common code into the driver itself
fixes build problems when CONFIG_BLOCK is disabled.

Acked-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
14 years agoexofs: Fix "add bdi backing to mount session" fall out
Boaz Harrosh [Thu, 29 Apr 2010 10:38:00 +0000 (13:38 +0300)]
exofs: Fix "add bdi backing to mount session" fall out

Commit b3d0ab7e60d1865bb6f6a79a77aaba22f2543236 ("exofs: add bdi backing
to mount session") has a bug in the placement of the bdi member at
struct exofs_sb_info.  The layout member must be kept last.

Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
Acked-by: Jens Axboe <jens.axboe@oracle.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
14 years agoMerge branch 'x86-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git...
Linus Torvalds [Thu, 29 Apr 2010 03:41:55 +0000 (20:41 -0700)]
Merge branch 'x86-fixes-for-linus' of git://git./linux/kernel/git/x86/linux-2.6-tip

* 'x86-fixes-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-tip:
  x86: Disable large pages on CPUs with Atom erratum AAE44
  x86-64: Clear a 64-bit FS/GS base on fork if selector is nonzero
  x86, mrst: Conditionally register cpu hotplug notifier for apbt

14 years agoMerge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes...
Linus Torvalds [Thu, 29 Apr 2010 03:40:17 +0000 (20:40 -0700)]
Merge branch 'for-linus' of git://git./linux/kernel/git/jbarnes/pci-2.6

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6:
  x86/PCI: compute Address Space length rather than using _LEN
  x86/PCI: never allocate PCI MMIO resources below BIOS_END

14 years agonfs d_revalidate() is too trigger-happy with d_drop()
Al Viro [Thu, 29 Apr 2010 02:10:43 +0000 (03:10 +0100)]
nfs d_revalidate() is too trigger-happy with d_drop()

If dentry found stale happens to be a root of disconnected tree, we
can't d_drop() it; its d_hash is actually part of s_anon and d_drop()
would simply hide it from shrink_dcache_for_umount(), leading to
all sorts of fun, including busy inodes on umount and oopsen after
that.

Bug had been there since at least 2006 (commit c636eb already has it),
so it's definitely -stable fodder.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
14 years agoARM: 5957/1: ARM: RealView SD/MMC Card detection and write-protect using GPIOLIB
Colin Tuckley [Wed, 24 Feb 2010 14:23:10 +0000 (15:23 +0100)]
ARM: 5957/1: ARM: RealView SD/MMC Card detection and write-protect using GPIOLIB

The switch to using GPIOLIB broke the sd/mmc card detection on the
RealView development boards if GPIO_PL061 was not selected.
This patch selects GPIO_PL061 if GPIOLIB is selected.
The sense of the return value from mmc_status has also changed
and is corrected.

Signed-off-by: Colin Tuckley <colin.tuckley@arm.com>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
14 years agoMerge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/lrg/voltage-2.6
Linus Torvalds [Wed, 28 Apr 2010 20:37:31 +0000 (13:37 -0700)]
Merge branch 'for-linus' of git://git./linux/kernel/git/lrg/voltage-2.6

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/lrg/voltage-2.6:
  regulator: fix enabling regulator issue on max8925

14 years agoMerge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6
Linus Torvalds [Wed, 28 Apr 2010 20:37:06 +0000 (13:37 -0700)]
Merge git://git./linux/kernel/git/davem/net-2.6

* git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-2.6: (27 commits)
  sfc: Change falcon_probe_board() to fail for unsupported boards
  sfc: Always close net device at the end of a disabling reset
  sfc: Wait at most 10ms for the MC to finish reading out MAC statistics
  sctp: Fix oops when sending queued ASCONF chunks
  sctp: fix to calc the INIT/INIT-ACK chunk length correctly is set
  sctp: per_cpu variables should be in bh_disabled section
  sctp: fix potential reference of a freed pointer
  sctp: avoid irq lock inversion while call sk->sk_data_ready()
  Revert "tcp: bind() fix when many ports are bound"
  net/usb: add sierra_net.c driver
  cdc_ether: fix autosuspend for mbm devices
  bluetooth: handle l2cap_create_connless_pdu() errors
  gianfar: Wait for both RX and TX to stop
  ipheth: potential null dereferences on error path
  smc91c92_cs: spin_unlock_irqrestore before calling smc_interrupt()
  drivers/usb/net/kaweth.c: add device "Allied Telesyn AT-USB10 USB Ethernet Adapter"
  bnx2: Update version to 2.0.9.
  bnx2: Prevent "scheduling while atomic" warning with cnic, bonding and vlan.
  bnx2: Fix lost MSI-X problem on 5709 NICs.
  cxgb3: Wait longer for control packets on initialization
  ...

14 years agosfc: Change falcon_probe_board() to fail for unsupported boards
Ben Hutchings [Wed, 28 Apr 2010 09:01:50 +0000 (09:01 +0000)]
sfc: Change falcon_probe_board() to fail for unsupported boards

The driver needs specific PHY and board support code for each SFC4000
board; there is no point trying to continue if it is missing.
Currently unsupported boards can trigger an 'oops'.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Cc: stable@kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
14 years agosfc: Always close net device at the end of a disabling reset
Ben Hutchings [Wed, 28 Apr 2010 09:01:33 +0000 (09:01 +0000)]
sfc: Always close net device at the end of a disabling reset

This fixes a regression introduced by commit
eb9f6744cbfa97674c13263802259b5aa0034594 "sfc: Implement ethtool
reset operation".

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Cc: stable@kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
14 years agosfc: Wait at most 10ms for the MC to finish reading out MAC statistics
Ben Hutchings [Wed, 28 Apr 2010 09:00:35 +0000 (09:00 +0000)]
sfc: Wait at most 10ms for the MC to finish reading out MAC statistics

The original code would wait indefinitely if MAC stats DMA failed.

Signed-off-by: Ben Hutchings <bhutchings@solarflare.com>
Cc: stable@kernel.org
Signed-off-by: David S. Miller <davem@davemloft.net>
14 years agosctp: Fix oops when sending queued ASCONF chunks
Vlad Yasevich [Wed, 28 Apr 2010 08:47:22 +0000 (08:47 +0000)]
sctp: Fix oops when sending queued ASCONF chunks

When we finish processing ASCONF_ACK chunk, we try to send
the next queued ASCONF.  This action runs the sctp state
machine recursively and it's not prepared to do so.

kernel BUG at kernel/timer.c:790!
invalid opcode: 0000 [#1] SMP
last sysfs file: /sys/module/ipv6/initstate
Modules linked in: sha256_generic sctp libcrc32c ipv6 dm_multipath
uinput 8139too i2c_piix4 8139cp mii i2c_core pcspkr virtio_net joydev
floppy virtio_blk virtio_pci [last unloaded: scsi_wait_scan]

Pid: 0, comm: swapper Not tainted 2.6.34-rc4 #15 /Bochs
EIP: 0060:[<c044a2ef>] EFLAGS: 00010286 CPU: 0
EIP is at add_timer+0xd/0x1b
EAX: cecbab14 EBX: 000000f0 ECX: c0957b1c EDX: 03595cf4
ESI: cecba800 EDI: cf276f00 EBP: c0957aa0 ESP: c0957aa0
 DS: 007b ES: 007b FS: 00d8 GS: 00e0 SS: 0068
Process swapper (pid: 0, ti=c0956000 task=c0988ba0 task.ti=c0956000)
Stack:
 c0957ae0 d1851214 c0ab62e4 c0ab5f26 0500ffff 00000004 00000005 00000004
<0> 00000000 d18694fd 00000004 1666b892 cecba800 cecba800 c0957b14
00000004
<0> c0957b94 d1851b11 ceda8b00 cecba800 cf276f00 00000001 c0957b14
000000d0
Call Trace:
 [<d1851214>] ? sctp_side_effects+0x607/0xdfc [sctp]
 [<d1851b11>] ? sctp_do_sm+0x108/0x159 [sctp]
 [<d1863386>] ? sctp_pname+0x0/0x1d [sctp]
 [<d1861a56>] ? sctp_primitive_ASCONF+0x36/0x3b [sctp]
 [<d185657c>] ? sctp_process_asconf_ack+0x2a4/0x2d3 [sctp]
 [<d184e35c>] ? sctp_sf_do_asconf_ack+0x1dd/0x2b4 [sctp]
 [<d1851ac1>] ? sctp_do_sm+0xb8/0x159 [sctp]
 [<d1863334>] ? sctp_cname+0x0/0x52 [sctp]
 [<d1854377>] ? sctp_assoc_bh_rcv+0xac/0xe1 [sctp]
 [<d1858f0f>] ? sctp_inq_push+0x2d/0x30 [sctp]
 [<d186329d>] ? sctp_rcv+0x797/0x82e [sctp]

Tested-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Yuansong Qiao <ysqiao@research.ait.ie>
Signed-off-by: Shuaijun Zhang <szhang@research.ait.ie>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
14 years agosctp: fix to calc the INIT/INIT-ACK chunk length correctly is set
Wei Yongjun [Wed, 28 Apr 2010 08:47:21 +0000 (08:47 +0000)]
sctp: fix to calc the INIT/INIT-ACK chunk length correctly is set

When calculating the INIT/INIT-ACK chunk length, we should not
only account the length of parameters, but also the parameters
zero padding length, such as AUTH HMACS parameter and CHUNKS
parameter. Without the parameters zero padding length we may get
following oops.

skb_over_panic: text:ce2068d2 len:130 put:6 head:cac3fe00 data:cac3fe00 tail:0xcac3fe82 end:0xcac3fe80 dev:<NULL>
------------[ cut here ]------------
kernel BUG at net/core/skbuff.c:127!
invalid opcode: 0000 [#2] SMP
last sysfs file: /sys/module/aes_generic/initstate
Modules linked in: authenc ......

Pid: 4102, comm: sctp_darn Tainted: G      D    2.6.34-rc2 #6
EIP: 0060:[<c0607630>] EFLAGS: 00010282 CPU: 0
EIP is at skb_over_panic+0x37/0x3e
EAX: 00000078 EBX: c07c024b ECX: c07c02b9 EDX: cb607b78
ESI: 00000000 EDI: cac3fe7a EBP: 00000002 ESP: cb607b74
 DS: 007b ES: 007b FS: 00d8 GS: 0033 SS: 0068
Process sctp_darn (pid: 4102, ti=cb607000 task=cabdc990 task.ti=cb607000)
Stack:
 c07c02b9 ce2068d2 00000082 00000006 cac3fe00 cac3fe00 cac3fe82 cac3fe80
<0> c07c024b cac3fe7c cac3fe7a c0608dec ca986e80 ce2068d2 00000006 0000007a
<0> cb8120ca ca986e80 cb812000 00000003 cb8120c4 ce208a25 cb8120ca cadd9400
Call Trace:
 [<ce2068d2>] ? sctp_addto_chunk+0x45/0x85 [sctp]
 [<c0608dec>] ? skb_put+0x2e/0x32
 [<ce2068d2>] ? sctp_addto_chunk+0x45/0x85 [sctp]
 [<ce208a25>] ? sctp_make_init+0x279/0x28c [sctp]
 [<c0686a92>] ? apic_timer_interrupt+0x2a/0x30
 [<ce1fdc0b>] ? sctp_sf_do_prm_asoc+0x2b/0x7b [sctp]
 [<ce202823>] ? sctp_do_sm+0xa0/0x14a [sctp]
 [<ce2133b9>] ? sctp_pname+0x0/0x14 [sctp]
 [<ce211d72>] ? sctp_primitive_ASSOCIATE+0x2b/0x31 [sctp]
 [<ce20f3cf>] ? sctp_sendmsg+0x7a0/0x9eb [sctp]
 [<c064eb1e>] ? inet_sendmsg+0x3b/0x43
 [<c04244b7>] ? task_tick_fair+0x2d/0xd9
 [<c06031e1>] ? sock_sendmsg+0xa7/0xc1
 [<c0416afe>] ? smp_apic_timer_interrupt+0x6b/0x75
 [<c0425123>] ? dequeue_task_fair+0x34/0x19b
 [<c0446abb>] ? sched_clock_local+0x17/0x11e
 [<c052ea87>] ? _copy_from_user+0x2b/0x10c
 [<c060ab3a>] ? verify_iovec+0x3c/0x6a
 [<c06035ca>] ? sys_sendmsg+0x186/0x1e2
 [<c042176b>] ? __wake_up_common+0x34/0x5b
 [<c04240c2>] ? __wake_up+0x2c/0x3b
 [<c057e35c>] ? tty_wakeup+0x43/0x47
 [<c04430f2>] ? remove_wait_queue+0x16/0x24
 [<c0580c94>] ? n_tty_read+0x5b8/0x65e
 [<c042be02>] ? default_wake_function+0x0/0x8
 [<c0604e0e>] ? sys_socketcall+0x17f/0x1cd
 [<c040264c>] ? sysenter_do_call+0x12/0x22
Code: 0f 45 de 53 ff b0 98 00 00 00 ff b0 94 ......
EIP: [<c0607630>] skb_over_panic+0x37/0x3e SS:ESP 0068:cb607b74

To reproduce:

# modprobe sctp
# echo 1 > /proc/sys/net/sctp/addip_enable
# echo 1 > /proc/sys/net/sctp/auth_enable
# sctp_test -H 3ffe:501:ffff:100:20c:29ff:fe4d:f37e -P 800 -l
# sctp_darn -H 3ffe:501:ffff:100:20c:29ff:fe4d:f37e -P 900 -h 192.168.0.21 -p 800 -I -s -t
sctp_darn ready to send...
3ffe:501:ffff:100:20c:29ff:fe4d:f37e:900-192.168.0.21:800 Interactive mode> bindx-add=192.168.0.21
3ffe:501:ffff:100:20c:29ff:fe4d:f37e:900-192.168.0.21:800 Interactive mode> bindx-add=192.168.1.21
3ffe:501:ffff:100:20c:29ff:fe4d:f37e:900-192.168.0.21:800 Interactive mode> snd=10

------------------------------------------------------------------
eth0 has addresses: 3ffe:501:ffff:100:20c:29ff:fe4d:f37e and 192.168.0.21
eth1 has addresses: 192.168.1.21
------------------------------------------------------------------

Reported-by: George Cheimonidis <gchimon@gmail.com>
Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
14 years agosctp: per_cpu variables should be in bh_disabled section
Vlad Yasevich [Wed, 28 Apr 2010 08:47:20 +0000 (08:47 +0000)]
sctp: per_cpu variables should be in bh_disabled section

Since the change of the atomics to percpu variables, we now
have to disable BH in process context when touching percpu variables.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
14 years agosctp: fix potential reference of a freed pointer
Vlad Yasevich [Wed, 28 Apr 2010 08:47:19 +0000 (08:47 +0000)]
sctp: fix potential reference of a freed pointer

When sctp attempts to update an assocition, it removes any
addresses that were not in the updated INITs.  However, the loop
may attempt to refrence a transport with address after removing it.

Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
14 years agosctp: avoid irq lock inversion while call sk->sk_data_ready()
Wei Yongjun [Wed, 28 Apr 2010 08:47:18 +0000 (08:47 +0000)]
sctp: avoid irq lock inversion while call sk->sk_data_ready()

sk->sk_data_ready() of sctp socket can be called from both BH and non-BH
contexts, but the default sk->sk_data_ready(), sock_def_readable(), can
not be used in this case. Therefore, we have to make a new function
sctp_data_ready() to grab sk->sk_data_ready() with BH disabling.

=========================================================
[ INFO: possible irq lock inversion dependency detected ]
2.6.33-rc6 #129
---------------------------------------------------------
sctp_darn/1517 just changed the state of lock:
 (clock-AF_INET){++.?..}, at: [<c06aab60>] sock_def_readable+0x20/0x80
but this lock took another, SOFTIRQ-unsafe lock in the past:
 (slock-AF_INET){+.-...}

and interrupts could create inverse lock ordering between them.

other info that might help us debug this:
1 lock held by sctp_darn/1517:
 #0:  (sk_lock-AF_INET){+.+.+.}, at: [<cdfe363d>] sctp_sendmsg+0x23d/0xc00 [sctp]

Signed-off-by: Wei Yongjun <yjwei@cn.fujitsu.com>
Signed-off-by: Vlad Yasevich <vladislav.yasevich@hp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
14 years agoRevert "tcp: bind() fix when many ports are bound"
David S. Miller [Wed, 28 Apr 2010 18:25:59 +0000 (11:25 -0700)]
Revert "tcp: bind() fix when many ports are bound"

This reverts two commits:

fda48a0d7a8412cedacda46a9c0bf8ef9cd13559
tcp: bind() fix when many ports are bound

and a follow-on fix for it:

6443bb1fc2050ca2b6585a3fa77f7833b55329ed
ipv6: Fix inet6_csk_bind_conflict()

It causes problems with binding listening sockets when time-wait
sockets from a previous instance still are alive.

It's too late to keep fiddling with this so late in the -rc
series, and we'll deal with it in net-next-2.6 instead.

Signed-off-by: David S. Miller <davem@davemloft.net>
14 years agonfs: fix memory leak in nfs_get_sb with CONFIG_NFS_V4
Xiaotian Feng [Thu, 22 Apr 2010 10:56:17 +0000 (18:56 +0800)]
nfs: fix memory leak in nfs_get_sb with CONFIG_NFS_V4

With CONFIG_NFS_V4 and data version 4, nfs_get_sb will allocate memory for
export_path in nfs4_validate_text_mount_data, so we need to free it then.
This is addressed in following kmemleak report:

unreferenced object 0xffff88016bf48a50 (size 16):
  comm "mount.nfs", pid 22567, jiffies 4651574704 (age 175471.200s)
  hex dump (first 16 bytes):
    2f 6f 70 74 2f 77 6f 72 6b 00 6b 6b 6b 6b 6b a5  /opt/work.kkkkk.
  backtrace:
    [<ffffffff814b34f9>] kmemleak_alloc+0x60/0xa7
    [<ffffffff81102c76>] kmemleak_alloc_recursive.clone.5+0x1b/0x1d
    [<ffffffff811046b3>] __kmalloc_track_caller+0x18f/0x1b7
    [<ffffffff810e1b08>] kstrndup+0x37/0x54
    [<ffffffffa0336971>] nfs_parse_devname+0x152/0x204 [nfs]
    [<ffffffffa0336af3>] nfs4_validate_text_mount_data+0xd0/0xdc [nfs]
    [<ffffffffa0338deb>] nfs_get_sb+0x325/0x736 [nfs]
    [<ffffffff81113671>] vfs_kern_mount+0xbd/0x17c
    [<ffffffff81113798>] do_kern_mount+0x4d/0xed
    [<ffffffff81129a87>] do_mount+0x787/0x7fe
    [<ffffffff81129b86>] sys_mount+0x88/0xc2
    [<ffffffff81009b42>] system_call_fastpath+0x16/0x1b

Signed-off-by: Xiaotian Feng <dfeng@redhat.com>
Cc: Trond Myklebust <Trond.Myklebust@netapp.com>
Cc: Chuck Lever <chuck.lever@oracle.com>
Cc: Benny Halevy <bhalevy@panasas.com>
Cc: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Andy Adamson <andros@netapp.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
14 years agonfs: fix some issues in nfs41_proc_reclaim_complete()
Dan Carpenter [Thu, 22 Apr 2010 09:28:39 +0000 (11:28 +0200)]
nfs: fix some issues in nfs41_proc_reclaim_complete()

The original code passed an ERR_PTR() to rpc_put_task() and instead of
returning zero on success it returned -ENOMEM.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
14 years agox86/PCI: compute Address Space length rather than using _LEN
Bjorn Helgaas [Tue, 27 Apr 2010 20:45:43 +0000 (14:45 -0600)]
x86/PCI: compute Address Space length rather than using _LEN

ACPI _CRS Address Space Descriptors have _MIN, _MAX, and _LEN.  Linux has
been computing Address Spaces as [_MIN to _MIN + _LEN - 1].  Based on the
tests in the bug reports below, Windows apparently uses [_MIN to _MAX].

Per spec (ACPI 4.0, Table 6-40), for _CRS fixed-size, fixed location
descriptors, "_LEN must be (_MAX - _MIN + 1)", and when that's true, it
doesn't matter which way we compute the end.  But of course, there are
BIOSes that don't follow this rule, and we're better off if Linux handles
those exceptions the same way as Windows.

This patch makes Linux use [_MIN to _MAX], as Windows seems to do.  This
effectively reverts d558b483d5 and 03db42adfe and replaces them with
simpler code.

    https://bugzilla.kernel.org/show_bug.cgi?id=14337 (round)
    https://bugzilla.kernel.org/show_bug.cgi?id=15480 (truncate)

Signed-off-by: Bjorn Helgaas <bjorn.helgaas@hp.com>
Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
14 years agoMerge branch 'urgent' of git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6
Linus Torvalds [Wed, 28 Apr 2010 14:58:36 +0000 (07:58 -0700)]
Merge branch 'urgent' of git://git./linux/kernel/git/brodo/pcmcia-2.6

* 'urgent' of git://git.kernel.org/pub/scm/linux/kernel/git/brodo/pcmcia-2.6:
  pcmcia: fix matching rules for pseudo-multi-function cards
  pcmcia: pcmcia_dev_present bugfix

14 years agoMerge branch 'for-linus' of git://git.kernel.dk/linux-2.6-block
Linus Torvalds [Wed, 28 Apr 2010 14:56:05 +0000 (07:56 -0700)]
Merge branch 'for-linus' of git://git.kernel.dk/linux-2.6-block

* 'for-linus' of git://git.kernel.dk/linux-2.6-block:
  coda: move backing-dev.h kernel include inside __KERNEL__
  mtd: ensure that bdi entries are properly initialized and registered
  Move mtd_bdi_*mappable to mtdcore.c
  btrfs: convert to using bdi_setup_and_register()
  Catch filesystems lacking s_bdi
  drbd: Terminate a connection early if sending the protocol fails
  drbd: fix memory leak
  Fix JFFS2 sync silent failure
  smbfs: add bdi backing to mount session
  ncpfs: add bdi backing to mount session
  exofs: add bdi backing to mount session
  ecryptfs: add bdi backing to mount session
  coda: add bdi backing to mount session
  cifs: add bdi backing to mount session
  afs: add bdi backing to mount session.
  9p: add bdi backing to mount session
  bdi: add helper function for doing init and register of a bdi for a file system
  block: ensure jiffies wrap is handled correctly in blk_rq_timed_out_timer

14 years agoMerge git://git.kernel.org/pub/scm/linux/kernel/git/wim/linux-2.6-watchdog
Linus Torvalds [Wed, 28 Apr 2010 14:55:35 +0000 (07:55 -0700)]
Merge git://git./linux/kernel/git/wim/linux-2.6-watchdog

* git://git.kernel.org/pub/scm/linux/kernel/git/wim/linux-2.6-watchdog:
  watchdog: booke_wdt: fix build - unconstify watchdog_info
  watchdog: sbc_fitpc2_wdt: fixed "scheduling while atomic" bug.
  watchdog: sbc_fitpc2_wdt: fixed I/O operations order
  Watchdog: sb_wdog.c: Fix sibyte watchdog initialization

14 years agoregulator: fix enabling regulator issue on max8925
Haojian Zhuang [Tue, 6 Apr 2010 10:19:15 +0000 (06:19 -0400)]
regulator: fix enabling regulator issue on max8925

Fix regulator enabling issue that is caused by typo error in is_enabled().

Signed-off-by: Haojian Zhuang <haojian.zhuang@marvell.com>
Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
Signed-off-by: Liam Girdwood <lrg@slimlogic.co.uk>
14 years agocoda: move backing-dev.h kernel include inside __KERNEL__
Jens Axboe [Wed, 28 Apr 2010 07:20:33 +0000 (09:20 +0200)]
coda: move backing-dev.h kernel include inside __KERNEL__

Otherwise we must export backing-dev.h as well, which doesn't make
any sense.

Signed-off-by: Jens Axboe <jens.axboe@oracle.com>
14 years agopowerpc/ps3: Update ps3_defconfig
Geoff Levand [Thu, 15 Apr 2010 09:11:39 +0000 (09:11 +0000)]
powerpc/ps3: Update ps3_defconfig

Refresh ps3_defconfig to latest kernel sources and change
these kernel config options:

  o CONFIG_USB_ANNOUNCE_NEW_DEVICES: n -> y
  o CONFIG_USB_EHCI_TT_NEWSCHED: n -> y
  o CONFIG_CMDLINE_BOOL: n -> y
  o CONFIG_CMDLINE: n -> ""

Signed-off-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
14 years agopowerpc/ps3: Update platform maintainer
Geoff Levand [Thu, 15 Apr 2010 09:11:34 +0000 (09:11 +0000)]
powerpc/ps3: Update platform maintainer

Update the PS3 entries in the MAINTAINERS file.

Signed-off-by: Geoff Levand <geoff@infradead.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
14 years agopowerpc/pseries: Flush lazy kernel mappings after unplug operations
Benjamin Herrenschmidt [Tue, 6 Apr 2010 15:03:40 +0000 (15:03 +0000)]
powerpc/pseries: Flush lazy kernel mappings after unplug operations

This ensures that the translations for unmapped IO mappings or
unmapped memory are properly removed from the MMU hash table
before such an unplug. Without this, the hypervisor refuses the
unplug operations due to those resources still being mapped by
the partition.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
14 years agopowerpc/numa: Add form 1 NUMA affinity
Anton Blanchard [Wed, 7 Apr 2010 15:33:44 +0000 (15:33 +0000)]
powerpc/numa: Add form 1 NUMA affinity

Firmware changed the way it represents memory and cpu affinity on POWER7.
Unfortunately the old method now caps the topology to work around issues
with legacy operating systems. For Linux to get the correct topology we
need to use the new form 1 affinity information.

We set the form 1 field in the client architecture, and if we see "1" in the
ibm,associativity-form property firmware supports form 1 affinity and
we should look at the first field in the ibm,associativity-reference-points
array. If not we use the second field as we always have.

Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
14 years agonet/usb: add sierra_net.c driver
Elina Pasheva [Wed, 28 Apr 2010 01:06:41 +0000 (18:06 -0700)]
net/usb: add sierra_net.c driver

Re-submitted based on comments from netdev community.
Summary of the changes:
1. Improved error handling.
2. Added the missing timeout arguments to usb_control_msg().

The following is a new Linux driver which exposes certain models of Sierra
Wireless modems to the operating system as Network Interface Cards (NICs).

This driver requires a version of the sierra.c driver which supports
blacklisting to work properly. The blacklist in sierra.c rejects the interfaces
claimed by sierra_net.c. Likewise, the sierra_net.c driver only accepts
(i.e. whitelists) the interface(s) used for USB-to-WWAN traffic.
The version of sierra.c which supports blacklisting is
available from the sierra wireless knowledge base page for older kernels. It is
also available in Linux kernel starting from version 2.6.31.

This driver works with all Sierra Wireless devices configured with PID=68A3
like USB305, USB306 provided the corresponding firmware version is I2.0
(for USB305) or M3.0 (for USB306) and later.
This driver will not work with earlier firmware versions than the ones shown
above. In this case the driver will issue an error message indicating
incompatibility and will not serve the device's USB-to-WWAN interface.

Sierra_net.c sits atop a pre-existing Linux driver called usbnet.c.
A series of hook functions are provided in sierra_net.c which are called by
usbnet.c in response to a particular condition such as receipt or transmission
of a data packet. As such, usbnet.c does most of the work of making
a modem appear to the system as a network device and for properly exchanging
traffic between the USB subsystem and the Network card interface.
Sierra_net.c is concerned with managing the data exchanged between the
USB-to-WWAN interface and the upper layers of the operating system.

Signed-off-by: Elina Pasheva <epasheva@sierrawireless.com>
Signed-off-by: Rory Filer <rfiler@sierrawireless.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
14 years agocdc_ether: fix autosuspend for mbm devices
Torgny Johansson [Wed, 28 Apr 2010 00:07:40 +0000 (17:07 -0700)]
cdc_ether: fix autosuspend for mbm devices

Autosuspend works until you bring the wwan interface up, then the
device does not enter autosuspend anymore.

The following patch fixes the problem by setting the .manage_power
field in the mbm_info struct to the same as in the cdc_info struct
(cdc_manager_power).

Signed-off-by: Torgny Johansson <torgny.johansson@ericsson.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
14 years agobluetooth: handle l2cap_create_connless_pdu() errors
Dan Carpenter [Wed, 21 Apr 2010 23:52:01 +0000 (23:52 +0000)]
bluetooth: handle l2cap_create_connless_pdu() errors

l2cap_create_connless_pdu() can sometimes return ERR_PTR(-ENOMEM) or
ERR_PTR(-EFAULT).

Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
14 years agogianfar: Wait for both RX and TX to stop
Andy Fleming [Tue, 27 Apr 2010 23:43:31 +0000 (16:43 -0700)]
gianfar: Wait for both RX and TX to stop

When gracefully stopping the controller, the driver was continuing if
*either* RX or TX had stopped.  We need to wait for both, or the
controller could get into an invalid state.

Signed-off-by: Andy Fleming <afleming@freescale.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
14 years agoMerge branch 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris...
Linus Torvalds [Tue, 27 Apr 2010 23:26:46 +0000 (16:26 -0700)]
Merge branch 'for-linus' of git://git./linux/kernel/git/jmorris/security-testing-2.6

* 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6:
  keys: don't need to use RCU in keyring_read() as semaphore is held

14 years agoMerge branch 'for-2.6.34' of git://linux-nfs.org/~bfields/linux
Linus Torvalds [Tue, 27 Apr 2010 23:26:21 +0000 (16:26 -0700)]
Merge branch 'for-2.6.34' of git://linux-nfs.org/~bfields/linux

* 'for-2.6.34' of git://linux-nfs.org/~bfields/linux:
  nfsd4: bug in read_buf

14 years agokeys: the request_key() syscall should link an existing key to the dest keyring
David Howells [Tue, 27 Apr 2010 20:13:08 +0000 (13:13 -0700)]
keys: the request_key() syscall should link an existing key to the dest keyring

The request_key() system call and request_key_and_link() should make a
link from an existing key to the destination keyring (if supplied), not
just from a new key to the destination keyring.

This can be tested by:

ring=`keyctl newring fred @s`
keyctl request2 user debug:a a
keyctl request user debug:a $ring
keyctl list $ring

If it says:

keyring is empty

then it didn't work.  If it shows something like:

1 key in keyring:
1070462727: --alswrv     0     0 user: debug:a

then it did.

request_key() system call is meant to recursively search all your keyrings for
the key you desire, and, optionally, if it doesn't exist, call out to userspace
to create one for you.

If request_key() finds or creates a key, it should, optionally, create a link
to that key from the destination keyring specified.

Therefore, if, after a successful call to request_key() with a desination
keyring specified, you see the destination keyring empty, the code didn't work
correctly.

If you see the found key in the keyring, then it did - which is what the patch
is required for.

Signed-off-by: David Howells <dhowells@redhat.com>
Cc: James Morris <jmorris@namei.org>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
14 years agogpio: fix pca953x set_type 'scheduling while atomic' bug
Marc Zyngier [Tue, 27 Apr 2010 20:13:07 +0000 (13:13 -0700)]
gpio: fix pca953x set_type 'scheduling while atomic' bug

Bill Gatliff reported the following bug when using the irq_chip facility
of the pca953x driver on a PPC platform:

BUG: scheduling while atomic: insmod/1530/0x00000002

He traced it back to an i2c transaction in pca953x_irq_set_type(), which
can be called with interrupt disabled (from __setup_irq()).  As the i2c
controller can sleep while sending a message, this qualifies as a bad
idea.

This patch moves the i2c transaction to pca953x_irq_bus_sync_unlock(),
where it is actually safe to send an i2c message.

[akpm@linux-foundation.org: coding-style fixes]
Signed-off-by: Marc Zyngier <maz@misterjones.org>
Reported-by: Bill Gatliff <bgat@billgatliff.com>
Cc: Eric Miao <eric.y.miao@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
14 years agoprocfs: fix tid fdinfo
Jerome Marchand [Tue, 27 Apr 2010 20:13:06 +0000 (13:13 -0700)]
procfs: fix tid fdinfo

Correct the file_operations struct in fdinfo entry of tid_base_stuff[].

Presently /proc/*/task/*/fdinfo contains symlinks to opened files like
/proc/*/fd/.

Signed-off-by: Jerome Marchand <jmarchan@redhat.com>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Cc: Miklos Szeredi <mszeredi@suse.cz>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
14 years agoarch/avr32: fix build failure caused by wrong prototype
Peter Huewe [Tue, 27 Apr 2010 20:13:04 +0000 (13:13 -0700)]
arch/avr32: fix build failure caused by wrong prototype

This patch fixes a build failure introduced by 1d8393171 ("avr32: use
generic ptrace_resume code") which had the static keyword as a leftover.

  arch/avr32/kernel/ptrace.c:32: error: static declaration of `user_enable_single_step' follows non-static declaration
  include/linux/ptrace.h:268: error: previous declaration of `user_enable_single_step' was here

References:
[1]http://kisskb.ellerman.id.au/kisskb/buildresult/2448162/

Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Cc: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: Christoph Hellwig <hch@lst.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
14 years agokeys: don't need to use RCU in keyring_read() as semaphore is held
David Howells [Tue, 27 Apr 2010 21:05:11 +0000 (14:05 -0700)]
keys: don't need to use RCU in keyring_read() as semaphore is held

keyring_read() doesn't need to use rcu_dereference() to access the keyring
payload as the caller holds the key semaphore to prevent modifications
from happening whilst the data is read out.

This should solve the following warning:

===================================================
[ INFO: suspicious rcu_dereference_check() usage. ]
---------------------------------------------------
security/keys/keyring.c:204 invoked rcu_dereference_check() without protection!

other info that might help us debug this:

rcu_scheduler_active = 1, debug_locks = 0
1 lock held by keyctl/2144:
 #0:  (&key->sem){+++++.}, at: [<ffffffff81177f7c>] keyctl_read_key+0x9c/0xcf

stack backtrace:
Pid: 2144, comm: keyctl Not tainted 2.6.34-rc2-cachefs #113
Call Trace:
 [<ffffffff8105121f>] lockdep_rcu_dereference+0xaa/0xb2
 [<ffffffff811762d5>] keyring_read+0x4d/0xe7
 [<ffffffff81177f8c>] keyctl_read_key+0xac/0xcf
 [<ffffffff811788d4>] sys_keyctl+0x75/0xb9
 [<ffffffff81001eeb>] system_call_fastpath+0x16/0x1b

Signed-off-by: David Howells <dhowells@redhat.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: James Morris <jmorris@namei.org>