safe/jmp/linux-2.6
14 years agostaging: dt3155v4l syncronize with API changes
Marin Mitov [Fri, 7 May 2010 08:00:35 +0000 (11:00 +0300)]
staging: dt3155v4l syncronize with API changes

dt3155v4l driver, as in -rc6-next-20100506 compiles, but will
not run properly due to recent changes in the videobuf APIs.

This patch synchronizes some functions that have been copied
from drivers/media/video/videobuf-dma-contig.c (and modified)
with the recent (-rc6 -> -rc6-next-) changes in videobuf layer
especially drivers/media/video/videobuf-dma-contig.c

Signed-off-by: Marin Mitov <mitov@issp.bas.bg>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: vt6656: code cleanup, removed HANDLE definition in ttype.h
Andres More [Thu, 6 May 2010 23:34:29 +0000 (20:34 -0300)]
staging: vt6656: code cleanup, removed HANDLE definition in ttype.h

Checkpatch warnings about using externs in .c files were not resolved,
neither some long lines on deeply nested code.

Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: storvsc module descriptions
Stephen Hemminger [Fri, 7 May 2010 04:44:45 +0000 (21:44 -0700)]
Staging: hv: storvsc module descriptions

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: block_operations can be const
Stephen Hemminger [Fri, 7 May 2010 04:44:44 +0000 (21:44 -0700)]
Staging: hv: block_operations can be const

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: add module description to blkvsc
Stephen Hemminger [Fri, 7 May 2010 04:44:43 +0000 (21:44 -0700)]
Staging: hv: add module description to blkvsc

Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: ti-st: depends on RFKILL
Randy Dunlap [Thu, 6 May 2010 23:45:10 +0000 (16:45 -0700)]
staging: ti-st: depends on RFKILL

Fix build errors.  st_kim.c uses rfkill*() interfaces, so it
should depend on RFKILL.

st_kim.c:(.text+0x291b21): undefined reference to `rfkill_unregister'
st_kim.c:(.text+0x291b31): undefined reference to `rfkill_destroy'
st_kim.c:(.text+0x291d8a): undefined reference to `rfkill_alloc'
st_kim.c:(.text+0x291db9): undefined reference to `rfkill_init_sw_state'
st_kim.c:(.text+0x291dc9): undefined reference to `rfkill_register'
st_kim.c:(.text+0x291e07): undefined reference to `rfkill_unregister'
(.text+0x291e85): undefined reference to `rfkill_set_hw_state'
(.text+0x292072): undefined reference to `rfkill_set_hw_state'
(.text+0x2920e1): undefined reference to `rfkill_set_hw_state

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: cxt1e1: fix semaphore build breakage
Randy Dunlap [Thu, 6 May 2010 23:44:08 +0000 (16:44 -0700)]
staging: cxt1e1: fix semaphore build breakage

Fix build errors by including linux/semaphore.h:

drivers/staging/cxt1e1/pmcc4_private.h:144: error: field 'sr_sem_busy' has incomplete type
drivers/staging/cxt1e1/pmcc4_private.h:146: error: field 'sr_sem_wait' has incomplete type
drivers/staging/cxt1e1/pmcc4_private.h:189: error: field 'sem_wdbusy' has incomplete type
drivers/staging/cxt1e1/musycc.c:617: error: implicit declaration of function 'down'
drivers/staging/cxt1e1/musycc.c:641: error: implicit declaration of function 'up'

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: updating README
Andrew Lunn [Fri, 7 May 2010 19:47:31 +0000 (21:47 +0200)]
Staging: batman-adv: updating README

Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Reduce max characters on a line to 80
Sven Eckelmann [Fri, 7 May 2010 19:47:30 +0000 (21:47 +0200)]
Staging: batman-adv: Reduce max characters on a line to 80

Documentation/CodingStyle sets a strongly prefered limit of 80
characters per line in "Chapter 2: Breaking long lines and strings".

Strings must be broken into smaller parts and long statements must be
rewritten.

Reported-by: Mikal Sande <mikal.sande@gmail.com>
Reported-by: Mark Rankilor <reodge@gmail.com>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Fix whitespace problems criticized by checkpatch.pl
Sven Eckelmann [Fri, 7 May 2010 19:47:29 +0000 (21:47 +0200)]
Staging: batman-adv: Fix whitespace problems criticized by checkpatch.pl

Trailing spaces at the end of a line or before a tab are against
Documentation/CodingStyle "3.1: Spaces" and should be avoided. It is
also common style to add a single space after commas unless it is
followed either by a newline or a tab.

Reported-by: Mikal Sande <mikal.sande@gmail.com>
Reported-by: Luis de Bethencourt <luisbg@ubuntu.com>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Update TODO file to reflect current state.
Andrew Lunn [Fri, 7 May 2010 19:47:28 +0000 (21:47 +0200)]
Staging: batman-adv: Update TODO file to reflect current state.

Not much left to do on the TODO list :-)

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Update pointer to ethhdr after skb_copy
Sven Eckelmann [Fri, 7 May 2010 19:47:27 +0000 (21:47 +0200)]
Staging: batman-adv: Update pointer to ethhdr after skb_copy

We must ensure that all pointer to a socket buffer are updated when we
copy a socket buffer and free our reference to the old one.
Another part of the kernel could also free its reference which maybe
removes the buffer completely. In that situation we would would feed
wrong information to the routing algorithm after the memory area is
written again by someone else.

Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: kfree_skb() in interface_tx() in error case
Simon Wunderlich [Fri, 7 May 2010 19:47:26 +0000 (21:47 +0200)]
Staging: batman-adv: kfree_skb() in interface_tx() in error case

As we always return that the we consumed the skb, we should also free the skb
in the case of an error.

Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Limit queue lengths for batman and broadcast packets
Simon Wunderlich [Fri, 7 May 2010 19:47:25 +0000 (21:47 +0200)]
Staging: batman-adv: Limit queue lengths for batman and broadcast packets

This patch limits the queue lengths of batman and broadcast packets. BATMAN
packets are held back for aggregation and jittered to avoid interferences.
Broadcast packets are stored to be sent out multiple times to increase
the probability to be received by other nodes in lossy environments.

Especially in extreme cases like broadcast storms, the queues have been seen
to run full, eating up all the memory and triggering the infamous OOM killer.
With the queue length limits introduced in this patch, this problem is
avoided.

Each queue is limited to 256 entries for now, resulting in 1 MB of maximum
space available in total for typical setups (assuming one packet including
overhead does not require more than 2000 byte). This should also be reasonable
for smaller routers, otherwise the defines can be tweaked later.

This third version of the patch does not increase the local broadcast
sequence number when the queue is already full.

Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Reorganize sequence number handling
Simon Wunderlich [Fri, 7 May 2010 19:47:24 +0000 (21:47 +0200)]
Staging: batman-adv: Reorganize sequence number handling

BATMAN and broadcast packets are tracked with a sequence number window of
currently 64 entries to measure and avoid duplicates. Packets which have a
sequence number smaller than the newest received packet minus 64 are not
within this sequence number window anymore and are called "old packets"
from now on.

When old packets are received, the routing code assumes that the host of the
originator has been restarted. This assumption however might be wrong as
packets can also be delayed by NIC drivers, e.g. because of long queues or
collision detection in dense WiFi? environments. This behaviour can be
reproduced by doing a broadcast ping flood in a dense node environment.

The effect is that the sequence number window is jumping forth and back,
accepting and forwarding any packet (because packets are assumed to be "new")
and causing loops.

To overcome this problem, the sequence number handling has been reorganized.
When an old packet is received, the window is reset back only once. Other old
packets are dropped for (currently) 30 seconds to "protect" the new sequence
number and avoid the hopping as described above.

The reorganization brings some code cleanups (at least i hope you feel the
same) and also fixes a bug in count_real_packets() which falsely updated
the last_real_seqno for slightly older packets within the seqno window
if they are no duplicates.

This second version of the patch also fixes a problem where for seq_diff==64
bit_shift() reads from outside of the seqno window, and removes the loop
for seq_diff == -64 which was present in the first patch.

The third iteration also adds a window for the next expected sequence numbers.
This minimizes sequence number flapping for packets with very big differences
(e.g. 3 packets with seqno 0, 25000 and 50000 might still cause problems
without this window).

Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: fix whitespace style issues
Sven Eckelmann [Fri, 7 May 2010 19:47:23 +0000 (21:47 +0200)]
Staging: batman-adv: fix whitespace style issues

This patch fixes unnecessary whitespaces before a quoted
newline that the remaining batman-adv files had.

Reported-by: Luis de Bethencourt <luisbg@ubuntu.com>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: move /proc interface handling to /sys
Marek Lindner [Fri, 7 May 2010 19:47:22 +0000 (21:47 +0200)]
Staging: batman-adv: move /proc interface handling to /sys

Instead of having a single /proc file "interfaces" in which you have
to echo the wanted interface batman-adv will create a subfolder in each
suitable /sys/class/net folder. This subfolder contains files for the
interface specific settings. For example, mesh_iface to add/remove an
interface from a virtual mesh network (at the moment only bat0 is
supported).

Example:
echo bat0 > /sys/class/net/eth0/batman-adv/mesh_iface

to deactivate:
echo none > /sys/class/net/eth0/batman-adv/mesh_iface

Interfaces which are not compatible with batman-adv won't contain the
batman-adv folder, therefore can't be activated. Not supported are:
loopback, non-ethernet, non-ARP and virtual mesh network interfaces

Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: remove redundant pointer to originator interface
Marek Lindner [Fri, 7 May 2010 19:47:21 +0000 (21:47 +0200)]
Staging: batman-adv: remove redundant pointer to originator interface

Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: move originator interval setting from /proc to /sys
Marek Lindner [Fri, 7 May 2010 19:47:20 +0000 (21:47 +0200)]
Staging: batman-adv: move originator interval setting from /proc to /sys

Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: convert more files from /proc to /sys
Marek Lindner [Fri, 7 May 2010 19:47:19 +0000 (21:47 +0200)]
Staging: batman-adv: convert more files from /proc to /sys

converted files:
vis_mode, vis_data

Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: convert multiple /proc files to use sysfs
Marek Lindner [Fri, 7 May 2010 19:47:18 +0000 (21:47 +0200)]
Staging: batman-adv: convert multiple /proc files to use sysfs

This is the first patch in a series of patches which aim to convert
all batman-adv /proc files to sysfs. To keep the changes in a
digestable size it has been split up into smaller chunks. During
the transition period batman-adv will use /proc as well as sysfs.

As a first step the following files have been converted:
aggregate_ogm, originators, transtable_global, transtable_local

Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: fix whitespace style issues
Luis de Bethencourt [Fri, 7 May 2010 19:47:17 +0000 (21:47 +0200)]
Staging: batman-adv: fix whitespace style issues

This patch fixes the 31 unnecessary whitespaces before a quoted
newline that the batman-adv files had.

Signed-off-by: Luis de Bethencourt <luisbg@ubuntu.com>
[sven.eckelmann@gmx.de: Redone to apply against current version]
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: cleanup: change test for end of array
Dan Carpenter [Fri, 7 May 2010 19:47:16 +0000 (21:47 +0200)]
Staging: batman-adv: cleanup: change test for end of array

The code here is testing to see if "i" is passed the end of the array.
The original code works probably, but it's not the cleanest way.

Andrew Lunn suggested that I also remove all the hard coded references
to 256 so I have done that as well.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Changing version to 0.2.2-beta
Simon Wunderlich [Fri, 7 May 2010 19:47:15 +0000 (21:47 +0200)]
Staging: batman-adv: Changing version to 0.2.2-beta

Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Update README about vis raw output
Linus Lüssing [Fri, 7 May 2010 19:47:14 +0000 (21:47 +0200)]
Staging: batman-adv: Update README about vis raw output

We are now having a newer, more neutral vis output so that we won't have
to change the kernelmodule for adding support of new vis output formats.
This patch adds an explanation about this in the README file of
batman-adv and removes the description about the dot/json format (they
will be added to the README of batctl).

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Add 0.2.1 changes to the CHANGELOG
Simon Wunderlich [Fri, 7 May 2010 19:47:13 +0000 (21:47 +0200)]
Staging: batman-adv: Add 0.2.1 changes to the CHANGELOG

Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Remove dead max addr and obsolete VIS_FORMAT strings
Linus Lüssing [Fri, 7 May 2010 19:47:12 +0000 (21:47 +0200)]
Staging: batman-adv: Remove dead max addr and obsolete VIS_FORMAT strings

Max address is not being used anywhere and just misleading, therefore
removing it. VIS_FORMAT string is now obsolete, so also remove it.

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: remove the beta from main.h for release
Simon Wunderlich [Fri, 7 May 2010 19:47:11 +0000 (21:47 +0200)]
Staging: batman-adv: remove the beta from main.h for release

Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Update copyright years
Simon Wunderlich [Fri, 7 May 2010 19:47:10 +0000 (21:47 +0200)]
Staging: batman-adv: Update copyright years

Signed-off-by: Simon Wunderlich <siwu@hrz.tu-chemnitz.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Fix aggregation direct-link bug
Linus Lüssing [Fri, 7 May 2010 19:47:09 +0000 (21:47 +0200)]
Staging: batman-adv: Fix aggregation direct-link bug

So far, neighbour's secondary interface OGMs can involuntarily
piggyback on primary interface OGMs that arrived on the same secondary
interface before. Secondary interface OGMs should NEVER leave their
direct neighbour broadcast domain! This patch ensures that secondary
interface OGMs can only be aggregated to other secondary interface OGMs.

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: fix aggregation timing bug
Marek Lindner [Fri, 7 May 2010 19:47:08 +0000 (21:47 +0200)]
Staging: batman-adv: fix aggregation timing bug

batman-adv aggregates routing packets to reduce the number of packets in
the air. Every outgoing packet is compared with other packets in the
buffer to determine whether it can be aggregated or not. Packets sent
at a lower interval can be held back longer to maximize the aggregation.
Due to insufficient checking batman-adv held back all packets for a
certain time depending on its own lowest interval rate which slowed
down all other nodes.

Reported-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: Clone shared bat packets before modifying them
Sven Eckelmann [Fri, 7 May 2010 19:47:07 +0000 (21:47 +0200)]
Staging: batman-adv: Clone shared bat packets before modifying them

"tcpdump" and "batctl td" will receive packets with a wrong sequence
number on systems with a different endianess than network byte order.
This happens due to the reordering of bytes in the function which
handles aggregated bat packets. The function which receives the bat
packets must ensure that these buffers aren't shared with anything else
before that function tries to write into it. Otherwise it has to copy
the buffers so it is save again to change them.

Reported-by: Kevin Steen <batman@kevinsteen.net>
Signed-off-by: Sven Eckelmann <sven.eckelmann@gmx.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: batman-adv: only modify hna-table on active module
Linus Lüssing [Fri, 7 May 2010 19:47:06 +0000 (21:47 +0200)]
Staging: batman-adv: only modify hna-table on active module

If we haven't set the module to MODULE_ACTIVE state before (in general,
no interface has yet been added to batman-adv) then the hna table is not
initialised yet. If the kernel changes the mac address of the bat0
interface at this moment then an hna_local_add() called by interface_set_mac_addr()
then resulted in a null pointer derefernce. With this patch we are now
explicitly checking before if the state is MODULE_ACTIVE right now so
that we can assume having an initialised hna table.

Signed-off-by: Linus Lüssing <linus.luessing@web.de>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rt2870: add device ID of MelCo.,Inc. WLI-UC-G301N
Nobuhiro KUSUNO [Wed, 5 May 2010 20:23:28 +0000 (05:23 +0900)]
Staging: rt2870: add device ID of MelCo.,Inc. WLI-UC-G301N

My wireless LAN module 'MelCo.,Inc. WLI-UC-G301N' works fine,
if the following line is added into 2870_main_dev.c.

Signed-off-by: Nobhiro KUSUNO <n-kusuno@fc4.so-net.ne.jp>
Cc: stable <stable@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: rar_register: depends on PCI
Randy Dunlap [Wed, 5 May 2010 22:45:22 +0000 (15:45 -0700)]
Staging: rar_register: depends on PCI

rar_register driver uses PCI interfaces and PCI devices, so it
should depend on PCI.

Also format the Kconfig help text as normally done.

drivers/staging/rar_register/rar_register.c:623: error: implicit declaration of function 'pci_dev_get'
drivers/staging/rar_register/rar_register.c:623: warning: assignment makes pointer from integer without a cast

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Acked-by: Alan Cox <alan@linux.intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: Fixed long line lengths in comedi.h
Mark Rankilor [Thu, 6 May 2010 10:07:44 +0000 (18:07 +0800)]
Staging: comedi: Fixed long line lengths in comedi.h

This patches fixes some of the long line lengths that checkpatch.pl was
complaining about in comedi.h

Signed-off-by: Mark Rankilor <reodge@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: Fixed long line length in comedidev.h
Mark Rankilor [Thu, 6 May 2010 09:49:37 +0000 (17:49 +0800)]
Staging: comedi: Fixed long line length in comedidev.h

This patch fixes a long line length in comedidev.h to make checkpatch.pl happy

Signed-off-by: Mark Rankilor <reodge@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: comedi: Fixed printk call lengths and log levels
Mark Rankilor [Thu, 6 May 2010 09:36:38 +0000 (17:36 +0800)]
Staging: comedi: Fixed printk call lengths and log levels

This is a patch to include log levels and fix some over length lines in
printk calls in drivers.c

Signed-off-by: Mark Rankilor <reodge@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: crystalhd: fix missing semicolon
Charles Clément [Wed, 5 May 2010 20:54:08 +0000 (13:54 -0700)]
Staging: crystalhd: fix missing semicolon

A semicolon is missing at the end of a statement, but it does compile
fine without it as the macro BCMLOG_ERR expands to a do {...} while (0);

Signed-off-by: Charles Clément <caratorn@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: netwave: delete the driver
Greg Kroah-Hartman [Thu, 6 May 2010 06:17:29 +0000 (23:17 -0700)]
Staging: netwave: delete the driver

It has sat in the staging directory since October of 2009, and no one
has stepped up to take it over, so odds are, no one cares about it
anymore.  So, it is now deleted as scheduled, and documented in the TODO
file.

Cc: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: wavelan: delete the driver
Greg Kroah-Hartman [Thu, 6 May 2010 06:16:09 +0000 (23:16 -0700)]
Staging: wavelan: delete the driver

It has sat in the staging directory since October of 2009, and no one
has stepped up to take it over, so odds are, no one cares about it
anymore.  So, it is now deleted as scheduled, and documented in the TODO
file.

Cc: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: strip: delete the driver
Greg Kroah-Hartman [Thu, 6 May 2010 06:13:37 +0000 (23:13 -0700)]
Staging: strip: delete the driver

It has sat in the staging directory since October of 2009, and no one
has stepped up to take it over, so odds are, no one cares about it
anymore.  So, it is now deleted as scheduled, and documented in the TODO
file.

Cc: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: arlan: delete the driver
Greg Kroah-Hartman [Thu, 6 May 2010 06:09:12 +0000 (23:09 -0700)]
Staging: arlan: delete the driver

It has sat in the staging directory since October of 2009, and no one
has stepped up to take it over, so odds are, no one cares about it
anymore.  So, it is now deleted as scheduled, and documented in the TODO
file.

Cc: John W. Linville <linville@tuxdriver.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename VersionInfo.h to version_info.h
Greg Kroah-Hartman [Thu, 6 May 2010 05:52:28 +0000 (22:52 -0700)]
Staging: hv: rename VersionInfo.h to version_info.h

The great renaming of the hv code is now complete.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename VmbusPacketFormat.h to vmbus_packet_format.h
Greg Kroah-Hartman [Thu, 6 May 2010 05:50:11 +0000 (22:50 -0700)]
Staging: hv: rename VmbusPacketFormat.h to vmbus_packet_format.h

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename VmbusChannelInterface.h to vmbus_channel_interface.h
Greg Kroah-Hartman [Thu, 6 May 2010 05:47:13 +0000 (22:47 -0700)]
Staging: hv: rename VmbusChannelInterface.h to vmbus_channel_interface.h

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename VmbusPrivate.h to vmbus_private.h
Greg Kroah-Hartman [Thu, 6 May 2010 05:45:25 +0000 (22:45 -0700)]
Staging: hv: rename VmbusPrivate.h to vmbus_private.h

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename VmbusApi.h to vmbus_api.h
Greg Kroah-Hartman [Thu, 6 May 2010 05:43:02 +0000 (22:43 -0700)]
Staging: hv: rename VmbusApi.h to vmbus_api.h

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename StorVscApi.h to storvsc_api.h
Greg Kroah-Hartman [Thu, 6 May 2010 05:40:43 +0000 (22:40 -0700)]
Staging: hv: rename StorVscApi.h to storvsc_api.h

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename NetVscApi.h to netvsc_api.h
Greg Kroah-Hartman [Thu, 6 May 2010 05:39:15 +0000 (22:39 -0700)]
Staging: hv: rename NetVscApi.h to netvsc_api.h

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename ChannelInterface.c and .h to channel_interface.c and .h
Greg Kroah-Hartman [Thu, 6 May 2010 05:36:31 +0000 (22:36 -0700)]
Staging: hv: rename ChannelInterface.c and .h to channel_interface.c and .h

All of the uppercase .c files are now gone.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename ChannelMgmt.c and .h to channel_mgmt.c and .h
Greg Kroah-Hartman [Thu, 6 May 2010 05:34:18 +0000 (22:34 -0700)]
Staging: hv: rename ChannelMgmt.c and .h to channel_mgmt.c and .h

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename RndisFilter.c and .h to rndis_filter.c and .h
Greg Kroah-Hartman [Thu, 6 May 2010 05:32:08 +0000 (22:32 -0700)]
Staging: hv: rename RndisFilter.c and .h to rndis_filter.c and .h

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename StorVsc.c to storvsc.c
Greg Kroah-Hartman [Thu, 6 May 2010 05:29:27 +0000 (22:29 -0700)]
Staging: hv: rename StorVsc.c to storvsc.c

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename NetVsc.c and .h to netvsc.c and .h
Greg Kroah-Hartman [Thu, 6 May 2010 05:27:31 +0000 (22:27 -0700)]
Staging: hv: rename NetVsc.c and .h to netvsc.c and .h

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename Vmbus.c to vmbus.c
Greg Kroah-Hartman [Thu, 6 May 2010 05:25:23 +0000 (22:25 -0700)]
Staging: hv: rename Vmbus.c to vmbus.c

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename BlkVsc.c to blkvsc.c
Greg Kroah-Hartman [Thu, 6 May 2010 05:24:25 +0000 (22:24 -0700)]
Staging: hv: rename BlkVsc.c to blkvsc.c

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename RingBuffer.c and .h to ring_buffer.c and .h
Greg Kroah-Hartman [Thu, 6 May 2010 05:22:35 +0000 (22:22 -0700)]
Staging: hv: rename RingBuffer.c and .h to ring_buffer.c and .h

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename Connection.c to connection.c
Greg Kroah-Hartman [Thu, 6 May 2010 05:19:40 +0000 (22:19 -0700)]
Staging: hv: rename Connection.c to connection.c

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename Channel.c and .h to channel.c and .h
Greg Kroah-Hartman [Thu, 6 May 2010 05:18:38 +0000 (22:18 -0700)]
Staging: hv: rename Channel.c and .h to channel.c and .h

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename Hv.h to hv.h
Greg Kroah-Hartman [Thu, 6 May 2010 05:16:10 +0000 (22:16 -0700)]
Staging: hv: rename Hv.h to hv.h

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename Hv.c to hv.c
Greg Kroah-Hartman [Thu, 6 May 2010 05:14:22 +0000 (22:14 -0700)]
Staging: hv: rename Hv.c to hv.c

No CamelCase in file names.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: rename hyperv_utils.c to hv_utils.c
Greg Kroah-Hartman [Thu, 6 May 2010 05:10:26 +0000 (22:10 -0700)]
Staging: hv: rename hyperv_utils.c to hv_utils.c

As the module only has one .c file in it, just name the file
the same as the desired module.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: util.h: fix up space mess again
Greg Kroah-Hartman [Thu, 6 May 2010 05:03:22 +0000 (22:03 -0700)]
Staging: hv: util.h: fix up space mess again

Again, use tabs, not spaces, it's not difficult to remember...

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: remove typedef that was just added.
Greg Kroah-Hartman [Thu, 6 May 2010 05:00:45 +0000 (22:00 -0700)]
Staging: hv: remove typedef that was just added.

It's a u64, so use a u64, it's not some special typedef.

Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: Add Time Sync feature to hv_utils module.
Haiyang Zhang [Wed, 5 May 2010 19:23:46 +0000 (19:23 +0000)]
Staging: hv: Add Time Sync feature to hv_utils module.

The Time Sync feature synchronizes guest time to host UTC time after reboot,
and restore from saved/paused state.

Signed-off-by: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: Channel.c: fix up compiler warning
Greg Kroah-Hartman [Thu, 6 May 2010 04:04:19 +0000 (21:04 -0700)]
Staging: hv: Channel.c: fix up compiler warning

In the series of ASSERT removals, somehow we ended up with a compiler
warning in Channel.c.  This patch fixes that up.

Cc: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: remove ASSERT in logging.h
Bill Pemberton [Wed, 5 May 2010 19:27:57 +0000 (15:27 -0400)]
staging: hv: remove ASSERT in logging.h

ASSERT is no longer used in hv, so remove the define

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: remove ASSERT() and return -EINVAL in NetVsc.c
Bill Pemberton [Wed, 5 May 2010 19:27:56 +0000 (15:27 -0400)]
staging: hv: remove ASSERT() and return -EINVAL in NetVsc.c

return -EINVAL instead of calling ASSERT()

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: replace ASSERT() with WARN_ON() in NetVsc.c
Bill Pemberton [Wed, 5 May 2010 19:27:55 +0000 (15:27 -0400)]
staging: hv: replace ASSERT() with WARN_ON() in NetVsc.c

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: remove ASSERT()s
Bill Pemberton [Wed, 5 May 2010 19:27:54 +0000 (15:27 -0400)]
staging: hv: remove ASSERT()s

These ASSERT()s serve no purpose other than for debugging.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: remove ASSERT()s in vmbus_drv.c
Bill Pemberton [Wed, 5 May 2010 19:27:51 +0000 (15:27 -0400)]
staging: hv: remove ASSERT()s in vmbus_drv.c

These ASSERT()s serve no purpose other than for debugging.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: remove ASSERT()s and return -EINVAL in RingBuffer.c
Bill Pemberton [Wed, 5 May 2010 19:27:50 +0000 (15:27 -0400)]
staging: hv: remove ASSERT()s and return -EINVAL in RingBuffer.c

return -EINVAL instead of calling ASSERT() for these conditionals.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: check return value of RingBufferInit()
Bill Pemberton [Wed, 5 May 2010 19:27:49 +0000 (15:27 -0400)]
staging: hv: check return value of RingBufferInit()

RingBufferInit() would always return sucess and instead relied on an
ASSERT() to test for an error condition.  Remove the ASSERT() and
return -EINVAL instead.  The return value of RingBufferInit() was also
never checked, so check it.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: remove ASSERT()s in RingBuffer.c
Bill Pemberton [Wed, 5 May 2010 19:27:48 +0000 (15:27 -0400)]
staging: hv: remove ASSERT()s in RingBuffer.c

These ASSERT()s serve no purpose other than for debugging.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: remove ASSERT()s in RndisFilter.c
Bill Pemberton [Wed, 5 May 2010 19:27:47 +0000 (15:27 -0400)]
staging: hv: remove ASSERT()s in RndisFilter.c

return -EINVAL instead of calling ASSERT() for these conditionals.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: remove ASSERT()s in RndisFilter.c
Bill Pemberton [Wed, 5 May 2010 19:27:46 +0000 (15:27 -0400)]
staging: hv: remove ASSERT()s in RndisFilter.c

These ASSERT()s serve no purpose other than for debugging.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: remove ASSERT()s in StorVsc.c
Bill Pemberton [Wed, 5 May 2010 19:27:45 +0000 (15:27 -0400)]
staging: hv: remove ASSERT()s in StorVsc.c

These ASSERT()s serve no purpose other than for debugging.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: remove ASSERT()s in blkvsc_drv.c
Bill Pemberton [Wed, 5 May 2010 19:27:44 +0000 (15:27 -0400)]
staging: hv: remove ASSERT()s in blkvsc_drv.c

These ASSERT()s serve no purpose other than for debugging.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: make the block driver depend on LBDAF
Bill Pemberton [Wed, 5 May 2010 19:27:43 +0000 (15:27 -0400)]
staging: hv: make the block driver depend on LBDAF

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: return error instead calling ASSERT in blkvsc_drv.c
Bill Pemberton [Wed, 5 May 2010 19:27:42 +0000 (15:27 -0400)]
staging: hv: return error instead calling ASSERT in blkvsc_drv.c

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: remove ASSERT()s in storvsc_drv.c
Bill Pemberton [Wed, 5 May 2010 19:27:41 +0000 (15:27 -0400)]
staging: hv: remove ASSERT()s in storvsc_drv.c

These ASSERT()s serve no purpose other than for debugging.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agostaging: hv: remove ASSERT()s in Channel.c
Bill Pemberton [Wed, 5 May 2010 19:27:40 +0000 (15:27 -0400)]
staging: hv: remove ASSERT()s in Channel.c

These ASSERT()s serve no purpose other than for debugging.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: return -EINVAL instead of calling ASSERT()
Bill Pemberton [Wed, 5 May 2010 19:27:39 +0000 (15:27 -0400)]
Staging: hv: return -EINVAL instead of calling ASSERT()

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: remove ASSERT() in Channel.c
Bill Pemberton [Wed, 5 May 2010 19:27:38 +0000 (15:27 -0400)]
Staging: hv: remove ASSERT() in Channel.c

VmbusChannelOpen() will now return -EINVAL if UserDataLen is too big.
Previously this was handled by an assert.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: test return value of VmbusChannelEstablishGpadl()
Bill Pemberton [Wed, 5 May 2010 19:27:37 +0000 (15:27 -0400)]
Staging: hv: test return value of VmbusChannelEstablishGpadl()

The return value of VmbusChannelEstablishGpadl() was not examined in
Channel.c

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: remove ASSERT() in Channel.c
Bill Pemberton [Wed, 5 May 2010 19:27:36 +0000 (15:27 -0400)]
Staging: hv: remove ASSERT() in Channel.c

return an error instead of calling ASSERT() if VmbusPostMessage()
fails.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: remove ASSERT() in Channel.c
Bill Pemberton [Wed, 5 May 2010 19:27:35 +0000 (15:27 -0400)]
Staging: hv: remove ASSERT() in Channel.c

check memory allocation in VmbusChannelCreateGpadlHeader() and
return -ENOMEM if it fails

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: remove ASSERT()s in Channel.c
Bill Pemberton [Wed, 5 May 2010 19:27:34 +0000 (15:27 -0400)]
Staging: hv: remove ASSERT()s in Channel.c

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: test return value of osd_WaitEventCreate()
Bill Pemberton [Wed, 5 May 2010 19:27:33 +0000 (15:27 -0400)]
Staging: hv: test return value of osd_WaitEventCreate()

The return value of osd_WaitEventCreate() was not examined in some
places.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: return correct error values in Connection.c
Bill Pemberton [Wed, 5 May 2010 19:27:32 +0000 (15:27 -0400)]
Staging: hv: return correct error values in Connection.c

Also check the kzalloc call return value.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: check return value of osd_PageAlloc()
Bill Pemberton [Wed, 5 May 2010 19:27:30 +0000 (15:27 -0400)]
Staging: hv: check return value of osd_PageAlloc()

The return value of osd_PageAlloc() was checked using an ASSERT().
Change that to more useful behaviour.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: remove ASSERT()s in ChannelMgt.c
Bill Pemberton [Wed, 5 May 2010 19:27:31 +0000 (15:27 -0400)]
Staging: hv: remove ASSERT()s in ChannelMgt.c

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: hv: Remove check for NULL before calling kfree()
Bill Pemberton [Wed, 5 May 2010 19:27:29 +0000 (15:27 -0400)]
Staging: hv: Remove check for NULL before calling kfree()

kfree() knows how to deal with NULL, so there's no reason to check for
NULL before passing something to it.

Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Cc: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dt3155v4l: fix some sparse warnings
Greg Kroah-Hartman [Wed, 5 May 2010 17:45:16 +0000 (10:45 -0700)]
Staging: dt3155v4l: fix some sparse warnings

Mostly some __iomem markings and some static functions as well.

Cc: Marin Mitov <mitov@issp.bas.bg
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: dt3155v4l: Adding the missing linux/delay.h
Marin Mitov [Wed, 5 May 2010 17:31:38 +0000 (20:31 +0300)]
Staging: dt3155v4l: Adding the missing linux/delay.h

The prototypes of udelay() and msleep() are in linux/delay.h,
so include it.

Reported-by: Randy Dunlap <randy.dunlap@oracle.com>
Signed-off-by: Marin Mitov <mitov@issp.bas.bg>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vt6656: code cleanup, resolved sparse finding
Andres More [Tue, 4 May 2010 23:40:11 +0000 (20:40 -0300)]
Staging: vt6656: code cleanup, resolved sparse finding

Cleared sparse warning 'Using plain integer as NULL pointer'

Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vt6656: code cleanup, removed OUT definition
Andres More [Tue, 4 May 2010 23:40:10 +0000 (20:40 -0300)]
Staging: vt6656: code cleanup, removed OUT definition

Remoted empty OUT define in ttype.h and its usage across the code.

Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: vt6656: removed SUCCESS define as it is not used
Andres More [Tue, 4 May 2010 23:40:09 +0000 (20:40 -0300)]
Staging: vt6656: removed SUCCESS define as it is not used

Signed-off-by: Andres More <more.andres@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
14 years agoStaging: arlan: fixed unnecessary whitespace style issue in arlan-main.c
Prashant P. Shah [Wed, 5 May 2010 14:16:28 +0000 (19:46 +0530)]
Staging: arlan: fixed unnecessary whitespace style issue in arlan-main.c

This is a patch to the arlan-main.c file that fixes the unnecessary whitespace
issues found by the checkpatch.pl tool.

Signed-off-by: Prashant P. Shah <pshah.mumbai@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>