Joe Perches [Thu, 25 Mar 2010 05:17:07 +0000 (22:17 -0700)]
Staging: wlags49_h2: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:06 +0000 (22:17 -0700)]
Staging: vt6656: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:05 +0000 (22:17 -0700)]
Staging: vt6655: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:04 +0000 (22:17 -0700)]
Staging: rtl8192u: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:03 +0000 (22:17 -0700)]
Staging: rtl8192su: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:02 +0000 (22:17 -0700)]
Staging: rtl8192e: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:01 +0000 (22:17 -0700)]
Staging: rtl8187se: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:17:00 +0000 (22:17 -0700)]
Staging: rt2870: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:16:59 +0000 (22:16 -0700)]
Staging: rt2860: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:16:58 +0000 (22:16 -0700)]
Staging: otus: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:16:57 +0000 (22:16 -0700)]
Staging: otus: 80211core: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Thu, 25 Mar 2010 05:16:55 +0000 (22:16 -0700)]
Staging: cx25821: Hoist assign from if
Signed-off-by: Joe Perches <joe@perches.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Roel Kluin [Mon, 22 Mar 2010 21:36:20 +0000 (22:36 +0100)]
Staging: vt6655: CGI/CSI confusion in device_ioctl()
The wrong messages were printed
Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Steven Harms [Thu, 18 Mar 2010 14:15:59 +0000 (10:15 -0400)]
Staging: vt6655: Convert C99 style comments, remove spaces between function definitions and parenthesis
Converted C99 style comments to kernel style guideline complianet
comments. Removed spaces between function definitions and parenthesis.
These were indicated as problems by checkpatch tool.
Fixed typo found by Gabor Stefanik
Signed-off-by: Steven Harms <sharms@ubuntu.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Peter Huewe [Mon, 26 Apr 2010 22:34:49 +0000 (00:34 +0200)]
Staging: otus: Add null check and fix coding style issue
This patch removes mixing of declarations and code and adds a null-test
after a kmalloc.
Signed-off-by: Peter Huewe <peterhuewe@gmx.de>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Vikram Dhillon [Sun, 4 Apr 2010 05:22:53 +0000 (01:22 -0400)]
Staging: Otus: Hal: hpani.c Fixed some style issues
Fixed some style issues in accordance with checkpatch.pl
Signed-by: Vikram Dhillon <opensolarisdev@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Sun, 28 Mar 2010 11:48:10 +0000 (14:48 +0300)]
Staging: otus: hpani: using the wrong variable
We're updating the "HpPriv->ani" array here so we should use that to
determine the end of the for loop. "HpPriv->ani" has 50 elements and
"wd->regulationTable.allowChannel" has 59 elements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Steven Harms [Sun, 14 Mar 2010 15:56:00 +0000 (11:56 -0400)]
Staging: otus: Remove mix of tabs and spaces with just tabs in ioctl.c
Previously defines had a mix of both tabs and spaces, causing an error
in the checkpatch tool. These tabs and spaces have been consolidated to
only tabs.
Signed-off-by: Steven Harms <sharms@ubuntu.com>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Neil Munro [Tue, 20 Apr 2010 00:06:33 +0000 (01:06 +0100)]
Staging: rt2860: rtmp.h: Fixed all bar one error.
All simple errors have been removed, including +80 line character limits
and various pointer syntax isues.
Signed-off-by: Neil Munro <neilmunro@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Trey Evans [Mon, 19 Apr 2010 20:15:37 +0000 (16:15 -0400)]
Staging: rt2860: fix usb_main_dev.c style errors
Correct several style errors related to pointers in usb_main_dev.c.
Signed-off-by: Trey Evans <lewis.r.evans@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Sat, 3 Apr 2010 08:29:13 +0000 (14:29 +0600)]
Staging: rt2860: fix coding style issue in mac_pci.h, mac_usb.h, rtmp_mac.h, rtmp_phy.h
This is a patch to the mac_pci.h, mac_usb.h, rtmp_mac.h, rtmp_phy.h files
that fixes up errors found by the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Fri, 19 Mar 2010 20:18:51 +0000 (01:18 +0500)]
Staging: rt2860: fix coding style issue in rt3070.c, rt3090.c, rt30xx.c
This is a patch to the rt3070.c, rt3090.c, rt30xx.c files that fixes up
errors found by the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Fri, 19 Mar 2010 18:22:41 +0000 (23:22 +0500)]
Staging: rt2860: fix coding style issue in rt_usb.c
This is a patch to the rt_usb.c file that fixes up errors found by the
checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Fri, 19 Mar 2010 18:10:32 +0000 (23:10 +0500)]
Staging: rt2860: fix coding style issue in rt_pci_rbus.c
This is a patch to the rt_pci_rbus.c file that fixes up errors found by
the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Fri, 19 Mar 2010 17:57:50 +0000 (22:57 +0500)]
Staging: rt2860: fix coding style issue in rt_main_dev.c
This is a patch to the rt_main_dev.c file that fixes up errors found by
the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Thu, 18 Mar 2010 09:56:47 +0000 (14:56 +0500)]
Staging: rt2860: fix coding style issue in rt_linux.c
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ben Hutchings [Mon, 29 Mar 2010 00:24:45 +0000 (01:24 +0100)]
Staging: rt28xx: Make PCI_{MAP,UNMAP}_SINGLE type-safe
To avoid recurrence of bugs such as <http://bugs.debian.org/575726>,
change the type of the first parameter to linux_pci_{map,unmap}_single()
from void * to struct rt_rtmp_adapter *. Also do not define the macros
PCI_{MAP,UNMAP}_SINGLE() when building the rt2870sta driver; they are
not used and if they were that would be a bug.
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>,
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 15:50:20 +0000 (17:50 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in inode.c
This is a patch to the inode.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 16:08:05 +0000 (18:08 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in netfs.h
This is a patch to the netfs.h file that fixed up a TAB and spaces
WARNING found by the checkpatch.pl tools, like
WARNING: please, no space before tabs
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 16:00:08 +0000 (18:00 +0200)]
Staging: pohmelfs: fix comments, spaces and TAB coding style issue in netfs.h
This is a patch to the netfs.h file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
and
ERROR: do not use C99 // comments
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 15:39:46 +0000 (17:39 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in dir.c
This is a patch to the dir.c file that fixed up a TAB and spaces Errors
found by the checkpatch.pl tools, like
ERROR: spaces required around that '=' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 15:11:03 +0000 (17:11 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in config.c
This is a patch to the config.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like:
ERROR: switch and case should be at the same indent
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 15:25:09 +0000 (17:25 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in crypto.c
This is a patch to the crypto.c file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
ERROR: switch and case should be at the same indent
and
spaces required around that '=' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Sun, 14 Mar 2010 15:03:04 +0000 (17:03 +0200)]
Staging: pohmelfs: fix spaces and TAB coding style issue in net.c
This is a patch to the net.c file that fixed up a TAB and spaces Errors found by the checkpatch.pl tools, like
ERROR: switch and case should be at the same indent
and
spaces required around that '=' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Wed, 28 Apr 2010 00:04:16 +0000 (17:04 -0700)]
Staging: dt3155: remove "inline" usage
It was wrong, and not doing what anyone would think it would do.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:53:59 +0000 (16:53 -0700)]
Staging: dt3155: rename dt3155_fbuffer_s
drop the "_s" as it's not needed.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:51:50 +0000 (16:51 -0700)]
Staging: dt3155: rename dt3155_config_s
Drop the "_s", as it's not needed.
Now, dt3155.h is checkpatch.pl clean.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:49:23 +0000 (16:49 -0700)]
Staging: dt3155: remove dt3155_read_t
The typedef is not needed.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:47:55 +0000 (16:47 -0700)]
Staging: dt3155: remove dt3155_status_t
The typedef is not needed.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:45:27 +0000 (16:45 -0700)]
Staging: dt3155: remove frame_info_t
The typedef is not needed.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:06:14 +0000 (16:06 -0700)]
Staging: dt3155: remove TRUE/FALSE
These aren't needed in the kernel, so remove them.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Greg Kroah-Hartman [Tue, 27 Apr 2010 23:04:13 +0000 (16:04 -0700)]
Staging: dt3155.h: remove #ifdef
We are in the kernel now, don't check to see if we are not.
Cc: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Joe Perches [Mon, 29 Mar 2010 07:34:29 +0000 (00:34 -0700)]
Staging: dt3155: allocator.c: sparse cleanups
Make prototypes match implementation
Use gfp_t flags not int prio
Still a couple of sparse warnings left
Signed-off-by: Joe Perches <joe@perches.com>
Cc: Simon Horman <horms@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Baldus [Sun, 28 Mar 2010 13:59:37 +0000 (09:59 -0400)]
Staging: dt3155: fix parentheses and bracket spacing style issues
This is a patch to the dt3155_drv.c file that removes spaces after open
parentheses and brackets and before close parentheses and brackets.
Signed-off-by: Jason Baldus <jason.baldus@gmail.com>
Reviewed-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Sat, 13 Mar 2010 19:35:17 +0000 (00:35 +0500)]
Staging: dt3155: fix coding style issue in dt3155_isr.c
This is a patch to the dt3155_isr.c file that fixes up a coding
style warning and errors found by the checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Acked-by: Simon Horman <horms@verge.net.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Huang Weiyi [Thu, 8 Apr 2010 11:49:36 +0000 (19:49 +0800)]
Staging: crystalhd: remove unused #include <linux/version.h>
Remove unused #include <linux/version.h>('s) in
drivers/staging/crystalhd/crystalhd_lnx.c
Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Huang Weiyi [Thu, 8 Apr 2010 11:49:45 +0000 (19:49 +0800)]
Staging: rtl8192u: remove unused #include <linux/version.h>
Remove unused #include <linux/version.h>('s) in
drivers/staging/rtl8192u/ieee80211/ieee80211_wx.c
Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Zachary Richey [Mon, 26 Apr 2010 11:49:37 +0000 (07:49 -0400)]
Staging: comedi: fixed coding style issues in drivers.c
This patch fixes coding style issues found by checkpatch.pl, and doesnt
line break string literals.
Signed-off-by: Zachary Richey <zr.public@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Stewart Robertson [Thu, 22 Apr 2010 19:33:48 +0000 (20:33 +0100)]
Staging: comedi: add missing KERN_INFO in ni_at_ao.c
This is a patch to the ni_at_ao.c file that adds the missing
KERN_INFO requested by the checkpatch.pl tool.
Signed-off-by: Stewart Robertson <stewart_r@aliencamel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Darren Armstrong [Sun, 25 Apr 2010 01:49:49 +0000 (02:49 +0100)]
Staging: comedi: ssc_dnp: Fixed coding style issues
Fixed coding style issues: 80-char width limit, KERN_ facility level
Signed-off-by: Darren Armstrong <darren.armstrong85@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gustavo Silva [Mon, 19 Apr 2010 06:21:10 +0000 (01:21 -0500)]
Staging: comedi: drivers: fix coding style issues in das08.c
This is a patch to the das08.c file that fixes up the following issues
found by the checkpatch.pl tool.
WARNING: line over 80 characters x 6
ERROR: code indent should use tabs where possible x 3
ERROR: spaces required around that '?' (ctx:VxV) x 4
ERROR: spaces required around that ':' (ctx:VxV) x 4
ERROR: that open brace { should be on the previous line x 1
WARNING: printk() should include KERN_ facility level x 9
WARNING: braces {} are not necessary for single statement blocks x 1
WARNING: EXPORT_SYMBOL(foo); should immediately follow its function/variable x 2
Signed-off-by: Gustavo Silva <silvagustavo@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gustavo Silva [Wed, 21 Apr 2010 05:34:35 +0000 (00:34 -0500)]
Staging: comedi: drivers: fix coding style issues in das16.c
This is a patch to the das16.c file that fixes up the following issues
found by the checkpatch.pl tool.
WARNING: line over 80 characters x 23
ERROR: spaces required around that '?' (ctx:VxV) x 2
ERROR: spaces required around that ':' (ctx:VxV) x 2
WARNING: printk() should include KERN_ facility level x 17
WARNING: braces {} are not necessary for single statement blocks x 8
Signed-off-by: Gustavo Silva <silvagustavo@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
David Fernández [Mon, 12 Apr 2010 19:19:23 +0000 (15:19 -0400)]
Staging: comedi: add new driver for Adlink PCI-7230 devices
Signed-off-by: Frank Mori Hess <fmhess@users.sourceforge.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Gorskin Ilya [Sat, 3 Apr 2010 06:18:25 +0000 (12:18 +0600)]
Staging: comedi: fix coding style issue in comedi.h
This is a patch to the comedi.h files that fixes up errors found by the
checkpatch.pl tool
Signed-off-by: Gorskin Ilya <revent82@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Sun, 28 Mar 2010 11:48:34 +0000 (14:48 +0300)]
Staging: comedi: dt2801.c: off by one issue
"dac_range_table" has 5 elements.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Stephen Palmateer [Wed, 24 Mar 2010 01:32:14 +0000 (21:32 -0400)]
Staging: comedi: comedi_parport: added KERN_ facility levels to printk messages.
This is a patch to the comedi_parport.c file that fixes the
KERN_ facility warnings found by the checkpatch.pl tool
Signed-off-by: Stephen Palmateer <stephen.palmateer@netsweeper.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
David Binderman [Fri, 19 Mar 2010 09:28:07 +0000 (09:28 +0000)]
Staging: comedi: das1800: fix kfree coding style issue
Signed-off-by: David Binderman <dcb314@hotmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Tue, 27 Apr 2010 20:23:48 +0000 (16:23 -0400)]
Staging: hv: declare NetVscOnChannelCallback() static
NetVscOnChannelCallback() was prototyped as static, but the actual
declartion of the function was not static.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Bill Pemberton [Tue, 27 Apr 2010 20:23:47 +0000 (16:23 -0400)]
Staging: hv: don't use dynamic sized array
NetVscOnChannelCallback() used a dynamic sized array that also made
the frame size over 2048. Replace it with a buffer allocated from
kzalloc.
Signed-off-by: Bill Pemberton <wfp5p@virginia.edu>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Ruslan Pisarev [Tue, 16 Mar 2010 15:24:47 +0000 (17:24 +0200)]
Staging: hv: fix spaces coding style issue in vstorage.h
This is a patch to the vstorage.h file that fixed up a TAB and spaces
Errors found by the checkpatch.pl tools, like
spaces required around that ':' (ctx:VxV)
Signed-off-by: Ruslan Pisarev <ruslan@rpisarev.org.ua>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Wong [Sat, 27 Mar 2010 01:48:43 +0000 (09:48 +0800)]
Staging: comedi: cb_pcidas64: fixed a coding style missed in the previous patch
Fixed a coding style issue.
Signed-off-by: Jason Wong <tsanghan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Wong [Sat, 27 Mar 2010 01:48:42 +0000 (09:48 +0800)]
Staging: comedi: cb_pcidas64: fixed multiple brace coding style issues
Fixed multiple coding style issues.
Signed-off-by: Jason Wong <tsanghan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Wong [Sat, 27 Mar 2010 01:48:41 +0000 (09:48 +0800)]
Staging: comedi: cb_das16_cs: fixed multiple brace coding style issues
Fixed multiple coding style issues
Signed-off-by: Jason Wong <tsanghan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Wong [Sat, 27 Mar 2010 01:48:39 +0000 (09:48 +0800)]
Staging: comedi: adv_pci1710: fixed multiple brace coding style issues
Fixed multiple coding style issues.
Signed-off-by: Jason Wong <tsanghan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Wong [Sat, 27 Mar 2010 01:48:40 +0000 (09:48 +0800)]
Staging: comedi: adv_pci_dio: fixed multiple brace coding style issues
Fixed multiple coding style issues.
Signed-off-by: Jason Wong <tsanghan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Wong [Sat, 27 Mar 2010 01:48:38 +0000 (09:48 +0800)]
Staging: comedi: adl_pci9118: fixed multiple brace coding style issues
Fixed multiple coding style issues
Signed-off-by: Jason Wong <tsanghan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Stefan Schick [Sat, 13 Mar 2010 12:47:09 +0000 (13:47 +0100)]
Staging: comedi: dt3000: fixed some coding style issues
Fixed some coding style issues
Signed-off-by: Stefan Schick <stinder21@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavel Machek [Sat, 13 Mar 2010 11:20:05 +0000 (12:20 +0100)]
Staging: windbond: camelCase should be fixed
(BTW, winbond/README alias winbond/TODO doesn't mention it, but another
(trivial) step is going to be to change variable names and function
names from CamelCase to lower_case spelling.)
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavel Machek [Sat, 13 Mar 2010 08:53:25 +0000 (09:53 +0100)]
Staging: dream: remove last bits of earlysuspend support
Remove last bits of earlysuspend support.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavel Machek [Sat, 13 Mar 2010 08:22:39 +0000 (09:22 +0100)]
Staging: dream: Kconfig fix for non-HTC hardware
> All of the Kconfig menu items under "config DREAM" should be listed
> indented under the 'DREAM' symbol, but they are not. (using xconfig)
> In menuconfig, the DREAM symbol isn't listed (since it depends on BROKEN),
> but the other (subordinate) symbols are still listed.
Ok, this should fix it ... or at least make it better an non-issue for
people with non-HTC hardware.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pavel Machek [Sat, 13 Mar 2010 11:17:59 +0000 (12:17 +0100)]
Staging: dream: fix gpio_input compilation
gpio_* drivers still need drivers in staging. Yes, that will need to
be fixed, but at least fix compilation for now.
Signed-off-by: Pavel Machek <pavel@ucw.cz>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Andre Silva [Fri, 12 Mar 2010 15:28:15 +0000 (15:28 +0000)]
Staging: arlan: fixed coding style issues in arlan-proc.c
This is a patch to the arlan-proc.c file that fixes up multiple coding
style errors and warnings found by the checkpatch.pl tool
Signed-off-by: Andre Silva <andre.beat@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
John Sheehan [Thu, 11 Mar 2010 17:32:33 +0000 (17:32 +0000)]
Staging: comedi: fix coding style in range.c
add missing space before closing brace
Signed-off-by: John Sheehan <john.d.sheehan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Robert Babilon [Thu, 11 Mar 2010 19:45:35 +0000 (13:45 -0600)]
Staging: comedi: fix export symbol warnings in ni_daq_700.c
This is a patch to the ni_daq_700.c file that fixes several EXPORT_SYMBOL
warnings found by the checkpatch.pl tool
Signed-off-by: Robert Babilon <robert.babilon@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Wouter Van Rooy [Thu, 11 Mar 2010 19:51:14 +0000 (20:51 +0100)]
Staging: cx25821 fixed C99 comments, white spaces and unnecessary braces
This patch fixes some C99 style comments, trailing white spaces and some
unnecessary 'if' braces found by checkpatch.pl
Signed-off-by: Wouter Van Rooy <wouter.vanrooy@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Thu, 11 Mar 2010 22:51:23 +0000 (23:51 +0100)]
Staging: hv: trivial whitespace fixes found by checkpatch.pl
Signed-off-by: Lars Lindley <lindley@coyote.org>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Wong [Fri, 12 Mar 2010 16:32:33 +0000 (00:32 +0800)]
Staging: comedi: amplc_pci230: fix brace coding style issue
Fixed multiple brace coding style issue.
Signed-off-by: Jason Wong <tsanghan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Arnd Bergmann [Tue, 27 Apr 2010 18:15:07 +0000 (20:15 +0200)]
Staging: push down BKL into ioctl functions
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
H Hartley Sweeten [Wed, 14 Apr 2010 03:01:31 +0000 (22:01 -0500)]
Staging: dt3155: fix wait_ibsyclr function
The wait_ibsyclr function is supposed to return the status of the I2C
cycle. Currently it will always return FALSE because the IIC_CSR2
register is not re-read in order to update the cached register value.
This results in the NEW_CYCLE bit still being 1.
The current code actually works correctly only because the return
value of {Read|Write}I2C is not checked in the driver.
Fix wait_ibsyclr by actually reading the IIC_CSR2 register to get the
updated status. While here, change the return type to be an actual
errno instead of the private TRUE/FALSE define and remove the now
obvious comments about the return value.
Also, remove the local variable 'writestat' in WriteI2C and just
return the result of wait_ibsyclr.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Scott Smedley <ss@aao.gov.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Huang Weiyi [Fri, 12 Mar 2010 13:05:26 +0000 (21:05 +0800)]
Staging: sep: remove duplicated #include
Remove duplicated #include('s) in
drivers/staging/sep/sep_driver.c
Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Huang Weiyi [Fri, 12 Mar 2010 14:13:43 +0000 (22:13 +0800)]
Staging: remove unused #include <linux/version.h>
Remove unused #include <linux/version.h>('s) in
drivers/staging/dt3155/allocator.c
drivers/staging/rtl8192u/ieee80211/ieee80211_tx.c
drivers/staging/vme/boards/vme_vmivme7805.c
Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Huang Weiyi [Fri, 12 Mar 2010 13:05:41 +0000 (21:05 +0800)]
Staging: wlan-ng: remove duplicated #include
Remove duplicated #include('s) in
drivers/staging/wlan-ng/p80211wext.c
Signed-off-by: Huang Weiyi <weiyi.huang@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Lars Lindley [Wed, 10 Mar 2010 23:21:20 +0000 (00:21 +0100)]
Staging: crystalhd: Whitespace fixes, indentation fixes and 3 changed #includes
These patches fixes some whitspace and indentation warnings from
checkpatch.pl
Also these changed #includes:
bc_dts_glob_lnx.h:43: WARNING: Use #include <linux/param.h> instead of <asm/param.h>
rystalhd_lnx.h:45: WARNING: Use #include <linux/io.h> instead of <asm/io.h>
crystalhd_lnx.h:49: WARNING: Use #include <linux/uaccess.h> instead of <asm/uaccess.h>
It all compiles fine, but I don't have the hardware to test with..
Signed-off-by: Lars Lindley <lindley@coyote.org>
Cc: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jani Nikula [Thu, 11 Mar 2010 16:22:51 +0000 (18:22 +0200)]
Staging: crystalhd: fix device_create() return value check
Use IS_ERR() instead of comparing to NULL.
Signed-off-by: Jani Nikula <ext-jani.1.nikula@nokia.com>
Cc: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Mike Sheldon [Wed, 10 Mar 2010 13:32:01 +0000 (13:32 +0000)]
Staging: winbond: Replace C99 comments with C89.
This patches mds.c to replace all the C99 style comments (//) with C89
style (/* ... */), as reported by checkpatch.pl.
Signed-off-by: Mike Sheldon <mike@mikeasoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Dan Carpenter [Wed, 10 Mar 2010 09:54:30 +0000 (12:54 +0300)]
Staging: rt2860: clean up & => &&
a4_exists is an integer used as a boolean type so the original code
works. But all the other conditions use && and this makes it
consistent.
Signed-off-by: Dan Carpenter <error27@gmail.com>
Cc: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Patrick Rooney [Wed, 10 Mar 2010 09:37:45 +0000 (09:37 +0000)]
Staging: sm7xx: Fixed space-before-tab coding style issues in smtcfb.c
Patch for smtcfb.c that removes spaces before tabs in the comments at
the beginning of the file.
Signed-off-by: Patrick Rooney <candyguitar@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Tomas Dabasinskas [Wed, 10 Mar 2010 09:51:01 +0000 (19:51 +1000)]
Staging: crystalhd: fixed white spaces and brace coding in crystalhd_hw.c
This is a patch to the crystalhd_hw.c file that fixes up a white space
and brace warnings found by the checkpatch.pl tool
Signed-off-by: Tomas Dabasinskas <tomas.it@gmail.com>
Acked-by: Jarod Wilson <jarod@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Michael Sprecher [Wed, 10 Mar 2010 12:15:35 +0000 (13:15 +0100)]
Staging: et131x: fix most coding style issues in et131x
This is a patch to the et131x driver that fixes up almost all coding
style issues
Signed-off-by: Michael Sprecher <sprecher.m@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Patrick Rooney [Wed, 10 Mar 2010 08:46:30 +0000 (08:46 +0000)]
Staging: wlan-ng: Fixed 80-character line coding style issues in p80211req.c
This is a patch for p80211req.c. An 'if' statement that spanned 80
characters has been split onto 2 lines and one of the tabs preceding
a comment has been removed.
Signed-off-by: Patrick Rooney <candyguitar@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Jason Wong [Wed, 10 Mar 2010 08:58:55 +0000 (16:58 +0800)]
Staging: comedi: amplc_pci224: fixed multiple brace coding style issue
Fixed multiple coding style issue.
Signed-off-by: Jason Wong <tsanghan@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Pieter De Praetere [Wed, 10 Mar 2010 08:47:44 +0000 (09:47 +0100)]
Staging: comedi: fix whitespace coding style issues in comedi_fops.c
Solves warnings found by the checkpatch.pl tool: spaces before tabs.
Signed-off-by: Pieter De Praetere <pieterc.depraetere@ugent.be>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Rich Folsom [Wed, 10 Mar 2010 05:36:45 +0000 (23:36 -0600)]
Staging: comedi: fix brace coding style issue in adl_pci9111.c
This is a patch to the adl_pci9111.c to fix up a brace warnging found by
the checkpatch.pl tool
Signed-off-by: Rich Folsom <rich.folsom@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Felipe de Oliveira Tanus [Wed, 10 Mar 2010 05:03:49 +0000 (02:03 -0300)]
Staging: comedi: cleanup dt2814.c
This patch cleans up the dt2814.c driver file from issues found by
checkpatch.pl tool.
Signed-off-by: Felipe de Oliveira Tanus <fotanus@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Julia Lawall [Tue, 9 Mar 2010 21:15:21 +0000 (22:15 +0100)]
Staging: drop redundant memset
The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2,e3,e4;
@@
- memset(e1,e2,e3);
memcpy(e1,e4,e3);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Henrik Hautakoski [Tue, 9 Mar 2010 20:51:24 +0000 (21:51 +0100)]
Staging: rt2860: fixed coding-style issues in pci_main_dev.c
fixed a bunch of coding-style issues generated from checkpatch.pl
Signed-off-by: Henrik Hautakoski <henrik.hautakoski@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Julia Lawall [Tue, 9 Mar 2010 21:14:58 +0000 (22:14 +0100)]
Staging: otus: drop redundant memset
The region set by the call to memset is immediately overwritten by the
subsequent call to memcpy.
The semantic patch that makes this change is as follows:
(http://coccinelle.lip6.fr/)
// <smpl>
@@
expression e1,e2,e3,e4;
@@
- memset(e1,e2,e3);
memcpy(e1,e4,e3);
// </smpl>
Signed-off-by: Julia Lawall <julia@diku.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Prashant P. Shah [Tue, 9 Mar 2010 14:46:44 +0000 (20:16 +0530)]
Staging: netwave: fixed trailing whitespace style issue in netwave_cs.c
This is a patch to the netwave_cs.c file that fixes up all the
trailing whitespace errors found by the checkpatch.pl tool.
Signed-off-by: Prashant P. Shah <pshah.mumbai@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Aseem Sethi [Tue, 9 Mar 2010 18:34:36 +0000 (00:04 +0530)]
Staging: comedi: fix missing KERN_facility level in ni_labpc.c
This is a patch to fix the "missing KERN_facility level" error found
when running the checkpatch.pl script
Signed-off-by: Aseem Sethi <aseemsethi@yahoo.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Stephen Hemminger [Wed, 10 Mar 2010 01:42:17 +0000 (17:42 -0800)]
Staging: hv: handle skb allocation failure
Some fixes to receive handling:
* Dieing with assertion failure when running out of memory is not ok
* Use newer alloc function to get aligned skb
* Dropped statistic is supposed to be incremented only by
driver it was responsible for the drop.
Compile tested only.
Signed-off-by: Stephen Hemminger <shemminger@vyatta.com>
Cc: Hank Janssen <hjanssen@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
git://ftp.safe.ca / safe / jmp / linux-2.6 / log