From: Herbert Xu <herbert@gondor.apana.org.au>
Date: Sun, 23 Oct 2005 06:11:39 +0000 (+1000)
Subject: [NEIGH] Print stack trace in neigh_add_timer
X-Git-Tag: v2.6.14~40^2~2
X-Git-Url: http://ftp.safe.ca/?p=safe%2Fjmp%2Flinux-2.6;a=commitdiff_plain;h=203755029e063066ecc4cf5eee1110ab946c2d88

[NEIGH] Print stack trace in neigh_add_timer

Stack traces are very helpful in determining the exact nature of a bug.
So let's print a stack trace when the timer is added twice.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

diff --git a/net/core/neighbour.c b/net/core/neighbour.c
index 4128fc7..766caa0 100644
--- a/net/core/neighbour.c
+++ b/net/core/neighbour.c
@@ -732,6 +732,7 @@ static inline void neigh_add_timer(struct neighbour *n, unsigned long when)
 	if (unlikely(mod_timer(&n->timer, when))) {
 		printk("NEIGH: BUG, double timer add, state is %x\n",
 		       n->nud_state);
+		dump_stack();
 	}
 }