[SCSI] be2iscsi: correct return value in mgmt_invalidate_icds()
authorDan Carpenter <error27@gmail.com>
Fri, 7 May 2010 08:53:45 +0000 (10:53 +0200)
committerJames Bottomley <James.Bottomley@suse.de>
Mon, 24 May 2010 16:11:03 +0000 (11:11 -0500)
This function should return 0 on error.  Returning -1 would cause a
crash.

Also there is an extra space before the newline character and a missing
space between the "for" and the "mgmt_invalidate_icds".  I put the string
on one line.  The current version of checkpatch.pl complains that the
line is too long, but it makes grepping easier.

Signed-off-by: Dan Carpenter <error27@gmail.com>
Reviewed-by: Mike Christie <michaelc@cs.wisc.edu>
Signed-off-by: James Bottomley <James.Bottomley@suse.de>
drivers/scsi/be2iscsi/be_mgmt.c

index e641922..350cbea 100644 (file)
@@ -167,10 +167,9 @@ unsigned char mgmt_invalidate_icds(struct beiscsi_hba *phba,
                                &nonemb_cmd.dma);
        if (nonemb_cmd.va == NULL) {
                SE_DEBUG(DBG_LVL_1,
-                        "Failed to allocate memory for"
-                        "mgmt_invalidate_icds \n");
+                        "Failed to allocate memory for mgmt_invalidate_icds\n");
                spin_unlock(&ctrl->mbox_lock);
-               return -1;
+               return 0;
        }
        nonemb_cmd.size = sizeof(struct invalidate_commands_params_in);
        req = nonemb_cmd.va;