drm/i915: avoid non-atomic sysrq execution
authorJesse Barnes <jbarnes@virtuousgeek.org>
Fri, 15 May 2009 21:11:48 +0000 (14:11 -0700)
committerEric Anholt <eric@anholt.net>
Fri, 5 Jun 2009 14:22:33 +0000 (14:22 +0000)
The sysrq functions are executed in hardirq context, so we shouldn't be
calling sleeping functions from them, like mutex_locks or memory
allocations.

Fix up the i915 sysrq handler to avoid this.

Signed-off-by: Jesse Barnes <jbarnes@virtuousgeek.org>
Signed-off-by: Eric Anholt <eric@anholt.net>
drivers/gpu/drm/i915/intel_fb.c

index e4652dc..7a66b91 100644 (file)
@@ -857,9 +857,15 @@ void intelfb_restore(void)
        drm_crtc_helper_set_config(&kernelfb_mode);
 }
 
+static void intelfb_restore_work_fn(struct work_struct *ignored)
+{
+       intelfb_restore();
+}
+static DECLARE_WORK(intelfb_restore_work, intelfb_restore_work_fn);
+
 static void intelfb_sysrq(int dummy1, struct tty_struct *dummy3)
 {
-        intelfb_restore();
+        schedule_work(&intelfb_restore_work);
 }
 
 static struct sysrq_key_op sysrq_intelfb_restore_op = {