nfsd: Drop reference in expkey_parse error cases

Drop reference to export key on error. Compile tested.

Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>

diff --git a/fs/nfsd/export.c b/fs/nfsd/export.c
index 9dc036f..7ce2c6e 100644 (file)
--- a/fs/nfsd/export.c
+++ b/fs/nfsd/export.c
@@ -151,8 +151,10 @@ static int expkey_parse(struct cache_detail *cd, char *mesg, int mlen)
 
        /* now we want a pathname, or empty meaning NEGATIVE  */
        err = -EINVAL;
-       if ((len=qword_get(&mesg, buf, PAGE_SIZE)) < 0)
+       if ((len=qword_get(&mesg, buf, PAGE_SIZE)) < 0) {
+               cache_put(&ek->h, &svc_expkey_cache);
                goto out;
+       }
        dprintk("Path seems to be <%s>\n", buf);
        err = 0;
        if (len == 0) {
@@ -164,8 +166,10 @@ static int expkey_parse(struct cache_detail *cd, char *mesg, int mlen)
        } else {
                struct nameidata nd;
                err = path_lookup(buf, 0, &nd);
-               if (err)
+               if (err) {
+                       cache_put(&ek->h, &svc_expkey_cache);
                        goto out;
+               }
 
                dprintk("Found the path %s\n", buf);
                key.ek_path = nd.path;