Staging: epl: do not use CLONE_SIGHAND with allow_signal()
authorOleg Nesterov <oleg@redhat.com>
Sun, 3 May 2009 22:15:31 +0000 (00:15 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Fri, 19 Jun 2009 18:00:52 +0000 (11:00 -0700)
Not sure this patch is really needed since kernel_thread() is deprecated
(and checkpatch.pl complains).

But we should not use kernel_thread(CLONE_SIGHAND) if we are going to play
with signals.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/staging/epl/EplSdoUdpu.c
drivers/staging/epl/ShbIpc-LinuxKernel.c

index b409c9b..c8e950f 100644 (file)
@@ -334,7 +334,8 @@ tEplKernel EplSdoUdpuConfig(unsigned long ulIpAddr_p, unsigned int uiPort_p)
        }
        // create Listen-Thread
        SdoUdpInstance_g.m_ThreadHandle =
-           kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g, CLONE_KERNEL);
+               kernel_thread(EplSdoUdpThread, &SdoUdpInstance_g,
+                               CLONE_FS | CLONE_FILES);
        if (SdoUdpInstance_g.m_ThreadHandle == 0) {
                Ret = kEplSdoUdpThreadError;
                goto Exit;
index 497938b..12d1ecc 100644 (file)
@@ -532,8 +532,8 @@ tShbError ShbIpcStartSignalingNewData(tShbInstance pShbInstance_p,
 
        //create thread for signalling new data
        pShbMemInst->m_tThreadNewDataId =
-           kernel_thread(ShbIpcThreadSignalNewData, pShbInstance_p,
-                         CLONE_KERNEL);
+               kernel_thread(ShbIpcThreadSignalNewData, pShbInstance_p,
+                               CLONE_FS | CLONE_FILES);
 
       Exit:
        return ShbError;
@@ -636,8 +636,8 @@ tShbError ShbIpcStartSignalingJobReady(tShbInstance pShbInstance_p,
        pShbMemHeader->m_fJobReady = FALSE;
        //create thread for signalling new data
        pShbMemInst->m_tThreadJobReadyId =
-           kernel_thread(ShbIpcThreadSignalJobReady, pShbInstance_p,
-                         CLONE_KERNEL);
+               kernel_thread(ShbIpcThreadSignalJobReady, pShbInstance_p,
+                               CLONE_FS | CLONE_FILES);
       Exit:
        return ShbError;
 }