sound: snd_ctl_elem_add: fix value count check
authorClemens Ladisch <clemens@ladisch.de>
Mon, 17 Aug 2009 10:25:52 +0000 (12:25 +0200)
committerTakashi Iwai <tiwai@suse.de>
Mon, 17 Aug 2009 10:48:00 +0000 (12:48 +0200)
Make sure that no user element that has no values can be added.

The check for count>1024 is not needed because the count is checked
later for the individual control types.

Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/control.c

index 17b8d47..66d6aaf 100644 (file)
@@ -951,7 +951,7 @@ static int snd_ctl_elem_add(struct snd_ctl_file *file,
        
        if (card->user_ctl_count >= MAX_USER_CONTROLS)
                return -ENOMEM;
-       if (info->count > 1024)
+       if (info->count < 1)
                return -EINVAL;
        access = info->access == 0 ? SNDRV_CTL_ELEM_ACCESS_READWRITE :
                (info->access & (SNDRV_CTL_ELEM_ACCESS_READWRITE|