KVM: VMX: Fix pending NMI-vs.-IRQ race for user space irqchip
authorJan Kiszka <jan.kiszka@siemens.com>
Mon, 24 Nov 2008 11:26:19 +0000 (12:26 +0100)
committerAvi Kivity <avi@redhat.com>
Wed, 31 Dec 2008 14:55:47 +0000 (16:55 +0200)
As with the kernel irqchip, don't allow an NMI to stomp over an already
injected IRQ; instead wait for the IRQ injection to be completed.

Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
arch/x86/kvm/vmx.c

index e446f23..487e1dc 100644 (file)
@@ -2486,7 +2486,9 @@ static void do_interrupt_requests(struct kvm_vcpu *vcpu,
        vmx_update_window_states(vcpu);
 
        if (vcpu->arch.nmi_pending && !vcpu->arch.nmi_injected) {
-               if (vcpu->arch.nmi_window_open) {
+               if (vcpu->arch.interrupt.pending) {
+                       enable_nmi_window(vcpu);
+               } else if (vcpu->arch.nmi_window_open) {
                        vcpu->arch.nmi_pending = false;
                        vcpu->arch.nmi_injected = true;
                } else {