powerpc/oprofile: fix potential buffer overrun in op_model_cell.c
authorDenis Kirjanov <dkirjanov@hera.kernel.org>
Tue, 1 Jun 2010 19:43:34 +0000 (15:43 -0400)
committerRobert Richter <robert.richter@amd.com>
Mon, 7 Jun 2010 09:18:56 +0000 (11:18 +0200)
Fix potential initial_lfsr buffer overrun.
Writing past the end of the buffer could happen when index == ENTRIES

Signed-off-by: Denis Kirjanov <dkirjanov@kernel.org>
Cc: stable@kernel.org
Signed-off-by: Robert Richter <robert.richter@amd.com>
arch/powerpc/oprofile/op_model_cell.c

index 2c9e522..7fd90d0 100644 (file)
@@ -1077,7 +1077,7 @@ static int calculate_lfsr(int n)
                index = ENTRIES-1;
 
        /* make sure index is valid */
                index = ENTRIES-1;
 
        /* make sure index is valid */
-       if ((index > ENTRIES) || (index < 0))
+       if ((index >= ENTRIES) || (index < 0))
                index = ENTRIES-1;
 
        return initial_lfsr[index];
                index = ENTRIES-1;
 
        return initial_lfsr[index];