nfs: nfs4xdr: encode_compound_hdr does not have to round up reserved bytes
authorBenny Halevy <bhalevy@panasas.com>
Fri, 14 Aug 2009 14:19:18 +0000 (17:19 +0300)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Fri, 14 Aug 2009 17:16:00 +0000 (13:16 -0400)
This is already done by xdr_reserve_space and since encode_compound_hdr
is adding a byte count to "12" which is already word aligned, the xdr
level rounding will work just as well.

Signed-off-by: Benny Halevy <bhalevy@panasas.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/nfs4xdr.c

index d460d81..7c2b162 100644 (file)
@@ -740,7 +740,7 @@ static void encode_compound_hdr(struct xdr_stream *xdr,
 
        dprintk("encode_compound: tag=%.*s\n", (int)hdr->taglen, hdr->tag);
        BUG_ON(hdr->taglen > NFS4_MAXTAGLEN);
-       RESERVE_SPACE(12+(XDR_QUADLEN(hdr->taglen)<<2));
+       RESERVE_SPACE(12 + hdr->taglen);
        *p++ = cpu_to_be32(hdr->taglen);
        p = xdr_encode_opaque_fixed(p, hdr->tag, hdr->taglen);
        *p++ = cpu_to_be32(hdr->minorversion);