x86: oprofile/op_model_amd.c set return values for op_amd_handle_ibs()
authorJaswinder Singh Rajput <jaswinder@kernel.org>
Thu, 18 Jun 2009 11:39:27 +0000 (17:09 +0530)
committerRobert Richter <robert.richter@amd.com>
Thu, 18 Jun 2009 14:44:38 +0000 (16:44 +0200)
op_amd_handle_ibs() should return 0 when IBS is not present or not defined.

Fix compilation warning:
 CC [M]  arch/x86/oprofile/op_model_amd.o
 arch/x86/oprofile/op_model_amd.c: In function ‘op_amd_handle_ibs’:
 arch/x86/oprofile/op_model_amd.c:217: warning: no return statement in function returning non-void

Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
Signed-off-by: Robert Richter <robert.richter@amd.com>
arch/x86/oprofile/op_model_amd.c

index cc93046..e95268e 100644 (file)
@@ -132,7 +132,7 @@ op_amd_handle_ibs(struct pt_regs * const regs,
        struct op_entry entry;
 
        if (!has_ibs)
-               return 1;
+               return 0;
 
        if (ibs_config.fetch_enabled) {
                rdmsrl(MSR_AMD64_IBSFETCHCTL, ctl);
@@ -214,7 +214,10 @@ static void op_amd_stop_ibs(void)
 #else
 
 static inline int op_amd_handle_ibs(struct pt_regs * const regs,
-                                   struct op_msrs const * const msrs) { }
+                                   struct op_msrs const * const msrs)
+{
+       return 0;
+}
 static inline void op_amd_start_ibs(void) { }
 static inline void op_amd_stop_ibs(void) { }