NOHZ: update idle state also when NOHZ is inactive
authorEero Nurkkala <ext-eero.nurkkala@nokia.com>
Wed, 7 Oct 2009 08:54:26 +0000 (11:54 +0300)
committerThomas Gleixner <tglx@linutronix.de>
Wed, 7 Oct 2009 11:05:05 +0000 (13:05 +0200)
commitfdc6f192e7e1ae80565af23cc33dc88e3dcdf184
tree431a47d5fe9b737cc5dd5fe40e178d06f7d579ed
parent0eca52a92735f43462165efe00a7e394345fb38e
NOHZ: update idle state also when NOHZ is inactive

Commit f2e21c9610991e95621a81407cdbab881226419b had unfortunate side
effects with cpufreq governors on some systems.

If the system did not switch into NOHZ mode ts->inidle is not set when
tick_nohz_stop_sched_tick() is called from the idle routine. Therefor
all subsequent calls from irq_exit() to tick_nohz_stop_sched_tick()
fail to call tick_nohz_start_idle(). This results in bogus idle
accounting information which is passed to cpufreq governors.

Set the inidle flag unconditionally of the NOHZ active state to keep
the idle time accounting correct in any case.

[ tglx: Added comment and tweaked the changelog ]

Reported-by: Steven Noonan <steven@uplinklabs.net>
Signed-off-by: Eero Nurkkala <ext-eero.nurkkala@nokia.com>
Cc: Rik van Riel <riel@redhat.com>
Cc: Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Cc: Greg KH <greg@kroah.com>
Cc: Steven Noonan <steven@uplinklabs.net>
Cc: stable@kernel.org
LKML-Reference: <1254907901.30157.93.camel@eenurkka-desktop>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
kernel/time/tick-sched.c