git://ftp.safe.ca / safe / jmp / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: bcd2ea1) | patch
nfs: Avoid overrun when copying client IP address string
authorBen Hutchings <ben@decadent.org.uk>
Tue, 6 Oct 2009 19:42:18 +0000 (15:42 -0400)
committerTrond Myklebust <Trond.Myklebust@netapp.com>
Tue, 6 Oct 2009 19:42:18 +0000 (15:42 -0400)
commitf4373bf9e67e4a653c8854acd7b02dac9714c98a
treed0371ed7638c0939550a2a43aef5b384d2e96b48tree | snapshot
parentbcd2ea17da6a329a7276cde7286d802f009af332commit | diff
nfs: Avoid overrun when copying client IP address string

As seen in <http://bugs.debian.org/549002>, nfs4_init_client() can
overrun the source string when copying the client IP address from
nfs_parsed_mount_data::client_address to nfs_client::cl_ipaddr.  Since
these are both treated as null-terminated strings elsewhere, the copy
should be done with strlcpy() not memcpy().

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
fs/nfs/client.c diff | blob | history
Full containers within linux kernel