hd: fix locking
authorTejun Heo <tj@kernel.org>
Tue, 28 Apr 2009 03:38:33 +0000 (12:38 +0900)
committerJens Axboe <jens.axboe@oracle.com>
Tue, 28 Apr 2009 05:36:56 +0000 (07:36 +0200)
commite93b9fb7d85da4fd9d5171649e5ddcac1dd572bf
tree72671e9cad1d1fa6acadd7e389515f3579f3ff26
parent7090a0a97f55cbf47547a140fcc5a349f32c598c
hd: fix locking

hd dance around local irq and HD_IRQ enable without achieving much.
It ends up transferring data from irq handler with both local irq and
HD_IRQ disabled.  The only place it actually does something is while
transferring the first block of a request which it does with HD_IRQ
disabled but local irq enabled.

Unfortunately, the dancing is horribly broken from locking POV.  IRQ
and timeout handlers access block queue without grabbing the queue
lock and running the driver in SMP configuration crashes the whole
machine pretty quickly.

Remove meaningless irq enable/disable dancing and add proper locking
in issue, irq and timeout paths.

Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/block/hd.c