git://ftp.safe.ca / safe / jmp / linux-2.6 / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: b356b7c) | patch
USB: skel_read really sucks royally
authorOliver Neukum <oliver@neukum.org>
Wed, 9 Sep 2009 15:06:53 +0000 (17:06 +0200)
committerGreg Kroah-Hartman <gregkh@suse.de>
Wed, 23 Sep 2009 13:46:40 +0000 (06:46 -0700)
commite7389cc9a7ff7c6e760e741c81a751c834f7d145
treec32bb55858fd792ac10b90a2a0539d163ad46136tree | snapshot
parentb356b7c7696b289dda99022d71e3979c6134af52commit | diff
USB: skel_read really sucks royally

The read code path of the skeleton driver really sucks

 - skel_read works only for devices which always send data
 - the timeout comes out of thin air
 - it blocks signals for the duration of the timeout
 - it disallows nonblocking IO by design

This patch fixes it by using a real urb, a completion and interruptible waits.

Signed-off-by: Oliver Neukum <oliver@neukum.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/usb/usb-skeleton.c diff | blob | history
Full containers within linux kernel