genirq: Run irq handlers with interrupts disabled
authorIngo Molnar <mingo@elte.hu>
Fri, 26 Mar 2010 00:06:51 +0000 (00:06 +0000)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 13 Apr 2010 14:36:40 +0000 (16:36 +0200)
commite58aa3d2d0cc01ad8d6f7f640a0670433f794922
tree6ed92d753a48e1fe9978f0958d1c09c8aae92fae
parentae731f8d0785ccd3380f511bae888933b6562e45
genirq: Run irq handlers with interrupts disabled

Running interrupt handlers with interrupts enabled can cause stack
overflows. That has been observed with multiqueue NICs delivering all
their interrupts to a single core. We might band aid that somehow by
checking the interrupt stacks, but the real safe fix is to run the irq
handlers with interrupts disabled.

Drivers for whacky hardware still can reenable them in the handler
itself, if the need arises. (They do already due to lockdep)

The risk of doing this is rather low:

 - lockdep already enforces this
 - CONFIG_NOHZ has shaken out the drivers which relied on jiffies updates
 - time keeping is not longer sensitive to the timer interrupt being delayed

Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andi Kleen <andi@firstfloor.org>
Cc: David Miller <davem@davemloft.net>
Cc: Greg Kroah-Hartman <gregkh@suse.de>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Linus Torvalds <torvalds@osdl.org>
LKML-Reference: <20100326000405.758579387@linutronix.de>
kernel/irq/handle.c