ecryptfs: initialize private persistent file before dereferencing pointer
authorErez Zadok <ezk@cs.sunysb.edu>
Thu, 3 Dec 2009 18:35:27 +0000 (13:35 -0500)
committerTyler Hicks <tyhicks@linux.vnet.ibm.com>
Wed, 20 Jan 2010 04:32:54 +0000 (22:32 -0600)
commite27759d7a333d1f25d628c4f7caf845c51be51c2
tree6181c5f5abe8b2e4b7bdc45f1231c769cc57a403
parent38e3eaeedcac75360af8a92e7b66956ec4f334e5
ecryptfs: initialize private persistent file before dereferencing pointer

Ecryptfs_open dereferences a pointer to the private lower file (the one
stored in the ecryptfs inode), without checking if the pointer is NULL.
Right afterward, it initializes that pointer if it is NULL.  Swap order of
statements to first initialize.  Bug discovered by Duckjin Kang.

Signed-off-by: Duckjin Kang <fromdj2k@gmail.com>
Signed-off-by: Erez Zadok <ezk@cs.sunysb.edu>
Cc: Dustin Kirkland <kirkland@canonical.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: <stable@kernel.org>
Signed-off-by: Tyler Hicks <tyhicks@linux.vnet.ibm.com>
fs/ecryptfs/file.c