KVM: fix handling of ACK from shared guest IRQ
authorMark McLoughlin <markmc@redhat.com>
Tue, 2 Dec 2008 12:16:33 +0000 (12:16 +0000)
committerAvi Kivity <avi@redhat.com>
Wed, 31 Dec 2008 14:55:47 +0000 (16:55 +0200)
commitdefaf1587c5d7dff828f6f11c8941e5bcef00f50
treefe4bcf162e203ee80916a5d168d838ef8aa62d25
parenteb64f1e8cd5c3cae912db30a77d062367f7a11a6
KVM: fix handling of ACK from shared guest IRQ

If an assigned device shares a guest irq with an emulated
device then we currently interpret an ack generated by the
emulated device as originating from the assigned device
leading to e.g. "Unbalanced enable for IRQ 4347" from the
enable_irq() in kvm_assigned_dev_ack_irq().

The fix is fairly simple - don't enable the physical device
irq unless it was previously disabled.

Of course, this can still lead to a situation where a
non-assigned device ACK can cause the physical device irq to
be reenabled before the device was serviced. However, being
level sensitive, the interrupt will merely be regenerated.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
Signed-off-by: Avi Kivity <avi@redhat.com>
include/linux/kvm_host.h
virt/kvm/kvm_main.c