ide/ide-cs: fix order of releasing resources
authorWolfram Sang <w.sang@pengutronix.de>
Fri, 15 Jan 2010 09:33:08 +0000 (01:33 -0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 15 Jan 2010 09:33:08 +0000 (01:33 -0800)
commitd4ae5415c6f2dd8f14e027c24f09d708f11a8d60
treea98f778fe54edfa81a3dbff6736e212e8a2b7005
parentc3be57b6f35ef96a980ce84e59d6a5a8ca6184ad
ide/ide-cs: fix order of releasing resources

ide_detach() called first ide_release() and then release_region(). This
produced the following warnings:

  Trying to free nonexistent resource <000000000000c10e-000000000000c10e>
  Trying to free nonexistent resource <000000000000c100-000000000000c107>

This is true, because the callchain inside ide_release() is:

  ide_release -> pcmcia_disable_device -> pcmcia_release_io

So, the whole io-block is already gone for release_region(). To fix
this, just swap the order of releasing (and remove the now obsolete
shadowing).

bzolnier:
- release resources in ide_release() to fix ordering of events
- remove stale FIXME note while at it

Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/ide/ide-cs.c